aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-02-24 00:26:08 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2022-04-06 20:38:06 +0200
commit7251a22f97f223ac16b9bd1567b9544d1910e63b (patch)
treeeef452a8527ce45b1b24fc99b0f82e76a71fecd9
parent54a0324ad96e74e82c33e72af7c6b360a7415863 (diff)
downloadffmpeg-7251a22f97f223ac16b9bd1567b9544d1910e63b.tar.gz
avformat/rmdec: Better duplicate tags check
Fixes: memleaks Fixes: 44810/clusterfuzz-testcase-minimized-ffmpeg_dem_IVR_fuzzer-5619494647627776 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 15a646e5018078a0954918f510f819a5599f0445) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/rmdec.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c
index 67a68bb2d0..b0aced5db9 100644
--- a/libavformat/rmdec.c
+++ b/libavformat/rmdec.c
@@ -128,10 +128,6 @@ static int rm_read_audio_stream_info(AVFormatContext *s, AVIOContext *pb,
uint32_t version;
int ret;
- // Duplicate tags
- if (st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO)
- return AVERROR_INVALIDDATA;
-
/* ra type header */
version = avio_rb16(pb); /* version */
if (version == 3) {
@@ -331,6 +327,11 @@ int ff_rm_read_mdpr_codecdata(AVFormatContext *s, AVIOContext *pb,
if (codec_data_size == 0)
return 0;
+ // Duplicate tags
+ if ( st->codecpar->codec_type != AVMEDIA_TYPE_UNKNOWN
+ && st->codecpar->codec_type != AVMEDIA_TYPE_DATA)
+ return AVERROR_INVALIDDATA;
+
avpriv_set_pts_info(st, 64, 1, 1000);
codec_pos = avio_tell(pb);
v = avio_rb32(pb);