aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-03-02 13:01:53 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2022-04-06 20:38:06 +0200
commit54a0324ad96e74e82c33e72af7c6b360a7415863 (patch)
treef9eafdd16342ff63a177b2c6ea62c93f07c0f076
parent69691dbb3aee0202ea3224f68c7f410db6c23da1 (diff)
downloadffmpeg-54a0324ad96e74e82c33e72af7c6b360a7415863.tar.gz
avformat/mov: Disallow empty sidx
It appears this is not allowed "Each Segment Index box documents how a (sub)segment is divided into one or more subsegments (which may themselves be further subdivided using Segment Index boxes)." Fixes: Null pointer dereference Fixes: Ticket9517 Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 4419433d77278cb742944c4514be5f72a04103c0) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/mov.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 6418e07c66..cc4a10f1bb 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -5104,6 +5104,8 @@ static int mov_read_sidx(MOVContext *c, AVIOContext *pb, MOVAtom atom)
avio_rb16(pb); // reserved
item_count = avio_rb16(pb);
+ if (item_count == 0)
+ return AVERROR_INVALIDDATA;
for (i = 0; i < item_count; i++) {
int index;