1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
|
#include "mkql_computation_pattern_cache.h"
#include <util/generic/intrlist.h>
namespace NKikimr::NMiniKQL {
class TComputationPatternLRUCache::TLRUPatternCacheImpl
{
public:
TLRUPatternCacheImpl(size_t maxPatternsSize,
size_t maxPatternsSizeBytes,
size_t maxCompiledPatternsSize,
size_t maxCompiledPatternsSizeBytes)
: MaxPatternsSize(maxPatternsSize)
, MaxPatternsSizeBytes(maxPatternsSizeBytes)
, MaxCompiledPatternsSize(maxCompiledPatternsSize)
, MaxCompiledPatternsSizeBytes(maxCompiledPatternsSizeBytes)
{}
size_t PatternsSize() const {
return SerializedProgramToPatternCacheHolder.size();
}
size_t PatternsSizeInBytes() const {
return CurrentPatternsSizeBytes;
}
size_t CompiledPatternsSize() const {
return CurrentCompiledPatternsSize;
}
size_t PatternsCompiledCodeSizeInBytes() const {
return CurrentPatternsCompiledCodeSizeInBytes;
}
std::shared_ptr<TPatternCacheEntry>* Find(const TString& serializedProgram) {
auto it = SerializedProgramToPatternCacheHolder.find(serializedProgram);
if (it == SerializedProgramToPatternCacheHolder.end()) {
return nullptr;
}
PromoteEntry(&it->second);
return &it->second.Entry;
}
void Insert(const TString& serializedProgram, std::shared_ptr<TPatternCacheEntry>& entry) {
auto [it, inserted] = SerializedProgramToPatternCacheHolder.emplace(std::piecewise_construct,
std::forward_as_tuple(serializedProgram),
std::forward_as_tuple(serializedProgram, entry));
if (!inserted) {
RemoveEntryFromLists(&it->second);
}
entry->UpdateSizeForCache();
/// New item is inserted, insert it in the back of both LRU lists and recalculate sizes
CurrentPatternsSizeBytes += entry->SizeForCache;
LRUPatternList.PushBack(&it->second);
if (entry->Pattern->IsCompiled()) {
++CurrentCompiledPatternsSize;
CurrentPatternsCompiledCodeSizeInBytes += entry->Pattern->CompiledCodeSize();
LRUCompiledPatternList.PushBack(&it->second);
}
entry->IsInCache.store(true);
ClearIfNeeded();
}
void NotifyPatternCompiled(const TString & serializedProgram) {
auto it = SerializedProgramToPatternCacheHolder.find(serializedProgram);
if (it == SerializedProgramToPatternCacheHolder.end()) {
return;
}
const auto& entry = it->second.Entry;
// TODO(ilezhankin): wait until migration of yql to arcadia is complete and merge the proper fix from here:
// https://github.com/ydb-platform/ydb/pull/11129
if (!entry->Pattern->IsCompiled()) {
return;
}
if (it->second.LinkedInCompiledPatternLRUList()) {
return;
}
PromoteEntry(&it->second);
++CurrentCompiledPatternsSize;
CurrentPatternsCompiledCodeSizeInBytes += entry->Pattern->CompiledCodeSize();
LRUCompiledPatternList.PushBack(&it->second);
ClearIfNeeded();
}
void Clear() {
CurrentPatternsSizeBytes = 0;
CurrentCompiledPatternsSize = 0;
CurrentPatternsCompiledCodeSizeInBytes = 0;
SerializedProgramToPatternCacheHolder.clear();
for (auto & holder : LRUPatternList) {
holder.Entry->IsInCache.store(false);
}
LRUPatternList.Clear();
LRUCompiledPatternList.Clear();
}
private:
struct TPatternLRUListTag {};
struct TCompiledPatternLRUListTag {};
/** Cache holder is used to store serialized program and pattern cache entry in intrusive LRU lists.
* Most recently accessed items are in back of the lists, least recently accessed items are in front of the lists.
*/
struct TPatternCacheHolder : public TIntrusiveListItem<TPatternCacheHolder, TPatternLRUListTag>, TIntrusiveListItem<TPatternCacheHolder, TCompiledPatternLRUListTag> {
TPatternCacheHolder(TString serializedProgram, std::shared_ptr<TPatternCacheEntry> entry)
: SerializedProgram(std::move(serializedProgram))
, Entry(std::move(entry))
{}
bool LinkedInPatternLRUList() const {
return !TIntrusiveListItem<TPatternCacheHolder, TPatternLRUListTag>::Empty();
}
bool LinkedInCompiledPatternLRUList() const {
return !TIntrusiveListItem<TPatternCacheHolder, TCompiledPatternLRUListTag>::Empty();
}
TString SerializedProgram;
std::shared_ptr<TPatternCacheEntry> Entry;
};
void PromoteEntry(TPatternCacheHolder* holder) {
Y_ASSERT(holder->LinkedInPatternLRUList());
LRUPatternList.Remove(holder);
LRUPatternList.PushBack(holder);
if (!holder->LinkedInCompiledPatternLRUList()) {
return;
}
LRUCompiledPatternList.Remove(holder);
LRUCompiledPatternList.PushBack(holder);
}
void RemoveEntryFromLists(TPatternCacheHolder* holder) {
Y_ASSERT(holder->LinkedInPatternLRUList());
LRUPatternList.Remove(holder);
Y_ASSERT(holder->Entry->SizeForCache <= CurrentPatternsSizeBytes);
CurrentPatternsSizeBytes -= holder->Entry->SizeForCache;
if (!holder->LinkedInCompiledPatternLRUList()) {
return;
}
Y_ASSERT(CurrentCompiledPatternsSize > 0);
--CurrentCompiledPatternsSize;
size_t patternCompiledCodeSize = holder->Entry->Pattern->CompiledCodeSize();
Y_ASSERT(patternCompiledCodeSize <= CurrentPatternsCompiledCodeSizeInBytes);
CurrentPatternsCompiledCodeSizeInBytes -= patternCompiledCodeSize;
LRUCompiledPatternList.Remove(holder);
holder->Entry->IsInCache.store(false);
}
void ClearIfNeeded() {
/// Remove from pattern LRU list and compiled pattern LRU list
while (SerializedProgramToPatternCacheHolder.size() > MaxPatternsSize || CurrentPatternsSizeBytes > MaxPatternsSizeBytes) {
TPatternCacheHolder* holder = LRUPatternList.Front();
RemoveEntryFromLists(holder);
SerializedProgramToPatternCacheHolder.erase(holder->SerializedProgram);
}
/// Only remove from compiled pattern LRU list
while (CurrentCompiledPatternsSize > MaxCompiledPatternsSize || CurrentPatternsCompiledCodeSizeInBytes > MaxCompiledPatternsSizeBytes) {
TPatternCacheHolder* holder = LRUCompiledPatternList.PopFront();
Y_ASSERT(CurrentCompiledPatternsSize > 0);
--CurrentCompiledPatternsSize;
auto & pattern = holder->Entry->Pattern;
size_t patternCompiledSize = pattern->CompiledCodeSize();
Y_ASSERT(patternCompiledSize <= CurrentPatternsCompiledCodeSizeInBytes);
CurrentPatternsCompiledCodeSizeInBytes -= patternCompiledSize;
pattern->RemoveCompiledCode();
holder->Entry->AccessTimes.store(0);
}
}
const size_t MaxPatternsSize;
const size_t MaxPatternsSizeBytes;
const size_t MaxCompiledPatternsSize;
const size_t MaxCompiledPatternsSizeBytes;
size_t CurrentPatternsSizeBytes = 0;
size_t CurrentCompiledPatternsSize = 0;
size_t CurrentPatternsCompiledCodeSizeInBytes = 0;
THashMap<TString, TPatternCacheHolder> SerializedProgramToPatternCacheHolder;
TIntrusiveList<TPatternCacheHolder, TPatternLRUListTag> LRUPatternList;
TIntrusiveList<TPatternCacheHolder, TCompiledPatternLRUListTag> LRUCompiledPatternList;
};
TComputationPatternLRUCache::TComputationPatternLRUCache(const TComputationPatternLRUCache::Config& configuration, NMonitoring::TDynamicCounterPtr counters)
: Cache(std::make_unique<TLRUPatternCacheImpl>(CacheMaxElementsSize, configuration.MaxSizeBytes, CacheMaxElementsSize, configuration.MaxCompiledSizeBytes))
, Configuration(configuration)
, Hits(counters->GetCounter("PatternCache/Hits", true))
, HitsCompiled(counters->GetCounter("PatternCache/HitsCompiled", true))
, Waits(counters->GetCounter("PatternCache/Waits", true))
, Misses(counters->GetCounter("PatternCache/Misses", true))
, NotSuitablePattern(counters->GetCounter("PatternCache/NotSuitablePattern", true))
, SizeItems(counters->GetCounter("PatternCache/SizeItems", false))
, SizeCompiledItems(counters->GetCounter("PatternCache/SizeCompiledItems", false))
, SizeBytes(counters->GetCounter("PatternCache/SizeBytes", false))
, SizeCompiledBytes(counters->GetCounter("PatternCache/SizeCompiledBytes", false))
, MaxSizeBytesCounter(counters->GetCounter("PatternCache/MaxSizeBytes", false))
, MaxCompiledSizeBytesCounter(counters->GetCounter("PatternCache/MaxCompiledSizeBytes", false))
{
*MaxSizeBytesCounter = Configuration.MaxSizeBytes;
*MaxCompiledSizeBytesCounter = Configuration.MaxCompiledSizeBytes;
}
TComputationPatternLRUCache::~TComputationPatternLRUCache() {
CleanCache();
}
std::shared_ptr<TPatternCacheEntry> TComputationPatternLRUCache::Find(const TString& serializedProgram) {
std::lock_guard<std::mutex> lock(Mutex);
if (auto it = Cache->Find(serializedProgram)) {
++*Hits;
if ((*it)->Pattern->IsCompiled())
++*HitsCompiled;
return *it;
}
++*Misses;
return {};
}
TComputationPatternLRUCache::TTicket TComputationPatternLRUCache::FindOrSubscribe(const TString& serializedProgram) {
std::lock_guard lock(Mutex);
if (auto it = Cache->Find(serializedProgram)) {
++*Hits;
AccessPattern(serializedProgram, *it);
return TTicket(serializedProgram, false, NThreading::MakeFuture<std::shared_ptr<TPatternCacheEntry>>(*it), nullptr);
}
auto [notifyIt, isNew] = Notify.emplace(serializedProgram, Nothing());
if (isNew) {
++*Misses;
return TTicket(serializedProgram, true, {}, this);
}
++*Waits;
auto promise = NThreading::NewPromise<std::shared_ptr<TPatternCacheEntry>>();
auto& subscribers = notifyIt->second;
if (!subscribers) {
subscribers.ConstructInPlace();
}
subscribers->push_back(promise);
return TTicket(serializedProgram, false, promise, nullptr);
}
void TComputationPatternLRUCache::EmplacePattern(const TString& serializedProgram, std::shared_ptr<TPatternCacheEntry> patternWithEnv) {
Y_DEBUG_ABORT_UNLESS(patternWithEnv && patternWithEnv->Pattern);
TMaybe<TVector<NThreading::TPromise<std::shared_ptr<TPatternCacheEntry>>>> subscribers;
{
std::lock_guard<std::mutex> lock(Mutex);
Cache->Insert(serializedProgram, patternWithEnv);
auto notifyIt = Notify.find(serializedProgram);
if (notifyIt != Notify.end()) {
subscribers.swap(notifyIt->second);
Notify.erase(notifyIt);
}
*SizeItems = Cache->PatternsSize();
*SizeBytes = Cache->PatternsSizeInBytes();
*SizeCompiledItems = Cache->CompiledPatternsSize();
*SizeCompiledBytes = Cache->PatternsCompiledCodeSizeInBytes();
}
if (subscribers) {
for (auto& subscriber : *subscribers) {
subscriber.SetValue(patternWithEnv);
}
}
}
void TComputationPatternLRUCache::NotifyPatternCompiled(const TString& serializedProgram) {
std::lock_guard lock(Mutex);
Cache->NotifyPatternCompiled(serializedProgram);
}
size_t TComputationPatternLRUCache::GetSize() const {
std::lock_guard lock(Mutex);
return Cache->PatternsSize();
}
void TComputationPatternLRUCache::CleanCache() {
*SizeItems = 0;
*SizeBytes = 0;
*MaxSizeBytesCounter = 0;
std::lock_guard lock(Mutex);
PatternsToCompile.clear();
Cache->Clear();
}
void TComputationPatternLRUCache::AccessPattern(const TString & serializedProgram, std::shared_ptr<TPatternCacheEntry> & entry) {
if (!Configuration.PatternAccessTimesBeforeTryToCompile || entry->Pattern->IsCompiled()) {
return;
}
size_t PatternAccessTimes = entry->AccessTimes.fetch_add(1) + 1;
if (PatternAccessTimes == *Configuration.PatternAccessTimesBeforeTryToCompile ||
(*Configuration.PatternAccessTimesBeforeTryToCompile == 0 && PatternAccessTimes == 1)) {
PatternsToCompile.emplace(serializedProgram, entry);
}
}
void TComputationPatternLRUCache::NotifyMissing(const TString& serialized) {
TMaybe<TVector<NThreading::TPromise<std::shared_ptr<TPatternCacheEntry>>>> subscribers;
{
std::lock_guard<std::mutex> lock(Mutex);
auto notifyIt = Notify.find(serialized);
if (notifyIt != Notify.end()) {
subscribers.swap(notifyIt->second);
Notify.erase(notifyIt);
}
}
if (subscribers) {
for (auto& subscriber : *subscribers) {
subscriber.SetValue(nullptr);
}
}
}
} // namespace NKikimr::NMiniKQL
|