1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
|
#include "shellcommand.h"
#include "compat.h"
#include "defaults.h"
#include "fs.h"
#include "sigset.h"
#include "spinlock.h"
#include <library/cpp/testing/unittest/env.h>
#include <library/cpp/testing/unittest/registar.h>
#include <util/folder/dirut.h>
#include <util/random/random.h>
#include <util/stream/file.h>
#include <util/stream/str.h>
#include <util/stream/mem.h>
#include <util/string/strip.h>
#include <util/folder/tempdir.h>
#if defined(_win_)
#define NL "\r\n"
const char catCommand[] = "sort"; // not really cat but ok
const size_t textSize = 1;
#else
#define NL "\n"
const char catCommand[] = "/bin/cat";
const size_t textSize = 20000;
#endif
class TGuardedStringStream: public IInputStream, public IOutputStream {
public:
TGuardedStringStream() {
Stream_.Reserve(100);
}
TString Str() const {
with_lock (Lock_) {
return Stream_.Str();
}
return TString(); // line for compiler
}
protected:
size_t DoRead(void* buf, size_t len) override {
with_lock (Lock_) {
return Stream_.Read(buf, len);
}
return 0; // line for compiler
}
void DoWrite(const void* buf, size_t len) override {
with_lock (Lock_) {
return Stream_.Write(buf, len);
}
}
private:
TAdaptiveLock Lock_;
TStringStream Stream_;
};
Y_UNIT_TEST_SUITE(TShellQuoteTest) {
Y_UNIT_TEST(TestQuoteArg) {
TString cmd;
ShellQuoteArg(cmd, "/pr f/krev/prev.exe");
ShellQuoteArgSp(cmd, "-DVal=\"W Quotes\"");
ShellQuoteArgSp(cmd, "-DVal=W Space");
ShellQuoteArgSp(cmd, "-DVal=Blah");
UNIT_ASSERT_STRINGS_EQUAL(cmd, "\"/pr f/krev/prev.exe\" \"-DVal=\\\"W Quotes\\\"\" \"-DVal=W Space\" \"-DVal=Blah\"");
}
}
Y_UNIT_TEST_SUITE(TShellCommandTest) {
Y_UNIT_TEST(TestNoQuotes) {
TShellCommandOptions options;
options.SetQuoteArguments(false);
TShellCommand cmd("echo hello");
cmd.Run();
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError(), "");
UNIT_ASSERT_VALUES_EQUAL(cmd.GetOutput(), "hello" NL);
UNIT_ASSERT(TShellCommand::SHELL_FINISHED == cmd.GetStatus());
UNIT_ASSERT(cmd.GetExitCode().Defined() && 0 == cmd.GetExitCode());
UNIT_ASSERT_VALUES_EQUAL(cmd.GetQuotedCommand(), "echo hello");
}
Y_UNIT_TEST(TestOnlyNecessaryQuotes) {
TShellCommandOptions options;
options.SetQuoteArguments(true);
TShellCommand cmd("echo");
cmd << "hey"
<< "hello&world";
cmd.Run();
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError(), "");
UNIT_ASSERT_VALUES_EQUAL(cmd.GetOutput(), "hey hello&world" NL);
UNIT_ASSERT(TShellCommand::SHELL_FINISHED == cmd.GetStatus());
UNIT_ASSERT(cmd.GetExitCode().Defined() && 0 == cmd.GetExitCode());
}
Y_UNIT_TEST(TestRun) {
TShellCommand cmd("echo");
cmd << "hello";
cmd.Run();
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError(), "");
#if defined(_win_)
UNIT_ASSERT_VALUES_EQUAL(cmd.GetOutput(), "\"hello\"\r\n");
#else
UNIT_ASSERT_VALUES_EQUAL(cmd.GetOutput(), "hello\n");
#endif
UNIT_ASSERT(TShellCommand::SHELL_FINISHED == cmd.GetStatus());
UNIT_ASSERT(cmd.GetExitCode().Defined() && 0 == cmd.GetExitCode());
}
// running with no shell is not implemented for win
// there should be no problem with it as long as SearchPath is on
Y_UNIT_TEST(TestNoShell) {
#if defined(_win_)
const char dir[] = "dir";
#else
const char dir[] = "ls";
#endif
TShellCommandOptions options;
options.SetQuoteArguments(false);
{
options.SetUseShell(false);
TShellCommand cmd(dir, options);
cmd << "|"
<< "sort";
cmd.Run();
UNIT_ASSERT(TShellCommand::SHELL_ERROR == cmd.GetStatus());
UNIT_ASSERT(cmd.GetExitCode().Defined() && 0 != cmd.GetExitCode());
}
{
options.SetUseShell(true);
TShellCommand cmd(dir, options);
cmd << "|"
<< "sort";
cmd.Run();
UNIT_ASSERT(TShellCommand::SHELL_FINISHED == cmd.GetStatus());
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError().size(), 0u);
UNIT_ASSERT(cmd.GetExitCode().Defined() && 0 == cmd.GetExitCode());
}
}
Y_UNIT_TEST(TestAsyncRun) {
TShellCommandOptions options;
options.SetAsync(true);
#if defined(_win_)
// fails with weird error "Input redirection is not supported"
// TShellCommand cmd("sleep", options);
// cmd << "3";
TShellCommand cmd("ping 1.1.1.1 -n 1 -w 2000", options);
#else
TShellCommand cmd("sleep", options);
cmd << "2";
#endif
UNIT_ASSERT(TShellCommand::SHELL_NONE == cmd.GetStatus());
cmd.Run();
sleep(1);
UNIT_ASSERT(TShellCommand::SHELL_RUNNING == cmd.GetStatus());
cmd.Wait();
UNIT_ASSERT(TShellCommand::SHELL_RUNNING != cmd.GetStatus());
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError(), "");
#if !defined(_win_)
UNIT_ASSERT(TShellCommand::SHELL_FINISHED == cmd.GetStatus());
UNIT_ASSERT_VALUES_EQUAL(cmd.GetOutput().size(), 0u);
UNIT_ASSERT(cmd.GetExitCode().Defined() && 0 == cmd.GetExitCode());
#endif
}
Y_UNIT_TEST(TestQuotes) {
TShellCommandOptions options;
TString input = TString("a\"a a");
TString output;
TStringOutput outputStream(output);
options.SetOutputStream(&outputStream);
TShellCommand cmd("echo", options);
cmd << input;
cmd.Run().Wait();
output = StripString(output);
#if defined(_win_)
UNIT_ASSERT_VALUES_EQUAL("\"a\\\"a a\"", output);
#else
UNIT_ASSERT_VALUES_EQUAL(input, output);
#endif
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError().size(), 0u);
}
Y_UNIT_TEST(TestRunNonexistent) {
TShellCommand cmd("iwerognweiofnewio"); // some nonexistent command name
cmd.Run().Wait();
UNIT_ASSERT(TShellCommand::SHELL_ERROR == cmd.GetStatus());
UNIT_ASSERT_VALUES_UNEQUAL(cmd.GetError().size(), 0u);
UNIT_ASSERT(cmd.GetExitCode().Defined() && 0 != cmd.GetExitCode());
}
Y_UNIT_TEST(TestExitCode) {
TShellCommand cmd("grep qwerty qwerty"); // some nonexistent file name
cmd.Run().Wait();
UNIT_ASSERT(TShellCommand::SHELL_ERROR == cmd.GetStatus());
UNIT_ASSERT_VALUES_UNEQUAL(cmd.GetError().size(), 0u);
UNIT_ASSERT(cmd.GetExitCode().Defined() && 2 == cmd.GetExitCode());
}
// 'type con' and 'copy con con' want real console, not stdin, use sort
Y_UNIT_TEST(TestInput) {
TShellCommandOptions options;
TString input = (TString("a") * 2000).append(NL) * textSize;
TStringInput inputStream(input);
options.SetInputStream(&inputStream);
TShellCommand cmd(catCommand, options);
cmd.Run().Wait();
UNIT_ASSERT_VALUES_EQUAL(input, cmd.GetOutput());
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError().size(), 0u);
}
Y_UNIT_TEST(TestOutput) {
TShellCommandOptions options;
TString input = (TString("a") * 2000).append(NL) * textSize;
TStringInput inputStream(input);
options.SetInputStream(&inputStream);
TString output;
TStringOutput outputStream(output);
options.SetOutputStream(&outputStream);
TShellCommand cmd(catCommand, options);
cmd.Run().Wait();
UNIT_ASSERT_VALUES_EQUAL(input, output);
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError().size(), 0u);
}
Y_UNIT_TEST(TestIO) {
// descriptive test: use all options
TShellCommandOptions options;
options.SetAsync(true);
options.SetQuoteArguments(false);
options.SetLatency(10);
options.SetClearSignalMask(true);
options.SetCloseAllFdsOnExec(true);
options.SetCloseInput(false);
TGuardedStringStream write;
options.SetInputStream(&write);
TGuardedStringStream read;
options.SetOutputStream(&read);
options.SetUseShell(true);
TShellCommand cmd("cat", options);
cmd.Run();
write << "alpha" << NL;
while (read.Str() != "alpha" NL) {
Sleep(TDuration::MilliSeconds(10));
}
write << "omega" << NL;
while (read.Str() != "alpha" NL "omega" NL) {
Sleep(TDuration::MilliSeconds(10));
}
write << "zeta" << NL;
cmd.CloseInput();
cmd.Wait();
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError(), "");
UNIT_ASSERT(TShellCommand::SHELL_FINISHED == cmd.GetStatus());
UNIT_ASSERT_VALUES_EQUAL(read.Str(), "alpha" NL "omega" NL "zeta" NL);
UNIT_ASSERT(cmd.GetExitCode().Defined() && 0 == cmd.GetExitCode());
}
Y_UNIT_TEST(TestStreamClose) {
struct TStream: public IOutputStream {
size_t NumCloses = 0;
void DoWrite(const void* buf, size_t len) override {
Y_UNUSED(buf);
Y_UNUSED(len);
}
void DoFinish() override {
++NumCloses;
}
} stream;
auto options1 = TShellCommandOptions().SetCloseStreams(false).SetOutputStream(&stream).SetErrorStream(&stream);
TShellCommand("echo hello", options1).Run().Wait();
UNIT_ASSERT_VALUES_EQUAL(stream.NumCloses, 0);
auto options = TShellCommandOptions().SetCloseStreams(true).SetOutputStream(&stream).SetErrorStream(&stream);
TShellCommand("echo hello", options).Run().Wait();
UNIT_ASSERT_VALUES_EQUAL(stream.NumCloses, 2);
}
Y_UNIT_TEST(TestInterruptSimple) {
TShellCommandOptions options;
options.SetAsync(true);
options.SetCloseInput(false);
TGuardedStringStream write;
options.SetInputStream(&write); // set input stream that will be waited by cat
TShellCommand cmd(catCommand, options);
cmd.Run();
sleep(1);
UNIT_ASSERT(TShellCommand::SHELL_RUNNING == cmd.GetStatus());
cmd.Terminate();
cmd.Wait();
UNIT_ASSERT(TShellCommand::SHELL_RUNNING != cmd.GetStatus());
}
#if !defined(_win_)
// this ut is unix-only, port to win using %TEMP%
Y_UNIT_TEST(TestInterrupt) {
TString tmpfile = TString("shellcommand_ut.interrupt.") + ToString(RandomNumber<ui32>());
TShellCommandOptions options;
options.SetAsync(true);
options.SetQuoteArguments(false);
{
TShellCommand cmd("/bin/sleep", options);
cmd << " 1300 & wait; /usr/bin/touch " << tmpfile;
cmd.Run();
sleep(1);
UNIT_ASSERT(TShellCommand::SHELL_RUNNING == cmd.GetStatus());
// Async mode requires Terminate() + Wait() to send kill to child proc!
cmd.Terminate();
cmd.Wait();
UNIT_ASSERT(TShellCommand::SHELL_ERROR == cmd.GetStatus());
UNIT_ASSERT(cmd.GetExitCode().Defined() && -15 == cmd.GetExitCode());
}
sleep(1);
UNIT_ASSERT(!NFs::Exists(tmpfile));
}
// this ut is unix-only (win has no signal mask)
Y_UNIT_TEST(TestSignalMask) {
// block SIGTERM
int rc;
sigset_t newmask, oldmask;
SigEmptySet(&newmask);
SigAddSet(&newmask, SIGTERM);
rc = SigProcMask(SIG_SETMASK, &newmask, &oldmask);
UNIT_ASSERT(rc == 0);
TString tmpfile = TString("shellcommand_ut.interrupt.") + ToString(RandomNumber<ui32>());
TShellCommandOptions options;
options.SetAsync(true);
options.SetQuoteArguments(false);
// child proc should not receive SIGTERM anymore
{
TShellCommand cmd("/bin/sleep", options);
// touch file only if sleep not interrupted by SIGTERM
cmd << " 10 & wait; [ $? == 0 ] || /usr/bin/touch " << tmpfile;
cmd.Run();
sleep(1);
UNIT_ASSERT(TShellCommand::SHELL_RUNNING == cmd.GetStatus());
cmd.Terminate();
cmd.Wait();
UNIT_ASSERT(TShellCommand::SHELL_ERROR == cmd.GetStatus() || TShellCommand::SHELL_FINISHED == cmd.GetStatus());
}
sleep(1);
UNIT_ASSERT(!NFs::Exists(tmpfile));
// child proc should receive SIGTERM
options.SetClearSignalMask(true);
{
TShellCommand cmd("/bin/sleep", options);
// touch file regardless -- it will be interrupted
cmd << " 10 & wait; /usr/bin/touch " << tmpfile;
cmd.Run();
sleep(1);
UNIT_ASSERT(TShellCommand::SHELL_RUNNING == cmd.GetStatus());
cmd.Terminate();
cmd.Wait();
UNIT_ASSERT(TShellCommand::SHELL_ERROR == cmd.GetStatus());
}
sleep(1);
UNIT_ASSERT(!NFs::Exists(tmpfile));
// restore signal mask
rc = SigProcMask(SIG_SETMASK, &oldmask, nullptr);
UNIT_ASSERT(rc == 0);
}
#else
// This ut is windows-only
Y_UNIT_TEST(TestStdinProperlyConstructed) {
TShellCommandOptions options;
options.SetErrorStream(&Cerr);
TShellCommand cmd(BinaryPath("util/system/ut/stdin_osfhandle/stdin_osfhandle"), options);
cmd.Run().Wait();
UNIT_ASSERT(TShellCommand::SHELL_FINISHED == cmd.GetStatus());
UNIT_ASSERT(cmd.GetExitCode().Defined() && 0 == cmd.GetExitCode());
}
#endif
Y_UNIT_TEST(TestInternalError) {
TString input = (TString("a") * 2000).append("\n");
TStringInput inputStream(input);
TMemoryOutput outputStream(nullptr, 0);
TShellCommandOptions options;
options.SetInputStream(&inputStream);
options.SetOutputStream(&outputStream);
TShellCommand cmd(catCommand, options);
cmd.Run().Wait();
UNIT_ASSERT(TShellCommand::SHELL_INTERNAL_ERROR == cmd.GetStatus());
UNIT_ASSERT_VALUES_UNEQUAL(cmd.GetInternalError().size(), 0u);
}
Y_UNIT_TEST(TestHugeOutput) {
TShellCommandOptions options;
TGuardedStringStream stream;
options.SetOutputStream(&stream);
options.SetUseShell(true);
TString input = TString(7000, 'a');
TString command = TStringBuilder{} << "echo " << input;
TShellCommand cmd(command, options);
cmd.Run().Wait();
UNIT_ASSERT_VALUES_EQUAL(stream.Str(), input + NL);
}
Y_UNIT_TEST(TestHugeError) {
TShellCommandOptions options;
TGuardedStringStream stream;
options.SetErrorStream(&stream);
options.SetUseShell(true);
TString input = TString(7000, 'a');
TString command = TStringBuilder{} << "echo " << input << ">&2";
TShellCommand cmd(command, options);
cmd.Run().Wait();
UNIT_ASSERT_VALUES_EQUAL(stream.Str(), input + NL);
}
Y_UNIT_TEST(TestPipeInput) {
TShellCommandOptions options;
options.SetAsync(true);
options.PipeInput();
TShellCommand cmd(catCommand, options);
cmd.Run();
{
TFile file(cmd.GetInputHandle().Release());
TUnbufferedFileOutput fo(file);
fo << "hello" << Endl;
}
cmd.Wait();
UNIT_ASSERT_VALUES_EQUAL(cmd.GetOutput(), "hello" NL);
UNIT_ASSERT_VALUES_EQUAL(cmd.GetError().size(), 0u);
}
Y_UNIT_TEST(TestPipeOutput) {
TShellCommandOptions options;
options.SetAsync(true);
options.PipeOutput();
constexpr TStringBuf firstMessage = "first message";
constexpr TStringBuf secondMessage = "second message";
const TString command = TStringBuilder() << "echo '" << firstMessage << "' && sleep 10 && echo '" << secondMessage << "'";
TShellCommand cmd(command, options);
cmd.Run();
TUnbufferedFileInput cmdOutput(TFile(cmd.GetOutputHandle().Release()));
TString firstLineOutput, secondLineOutput;
{
Sleep(TDuration::Seconds(5));
firstLineOutput = cmdOutput.ReadLine();
cmd.Wait();
secondLineOutput = cmdOutput.ReadLine();
}
UNIT_ASSERT_VALUES_EQUAL(firstLineOutput, firstMessage);
UNIT_ASSERT_VALUES_EQUAL(secondLineOutput, secondLineOutput);
}
Y_UNIT_TEST(TestOptionsConsistency) {
TShellCommandOptions options;
options.SetInheritOutput(false).SetInheritError(false);
options.SetOutputStream(nullptr).SetErrorStream(nullptr);
UNIT_ASSERT(options.OutputMode == TShellCommandOptions::HANDLE_STREAM);
UNIT_ASSERT(options.ErrorMode == TShellCommandOptions::HANDLE_STREAM);
}
Y_UNIT_TEST(TestForkCallback) {
TString tmpFile = TString("shellcommand_ut.test_for_callback.txt");
TFsPath cwd(::NFs::CurrentWorkingDirectory());
const TString tmpFilePath = cwd.Child(tmpFile);
const TString text = "test output";
auto afterForkCallback = [&tmpFilePath, &text]() -> void {
TFixedBufferFileOutput out(tmpFilePath);
out << text;
};
TShellCommandOptions options;
options.SetFuncAfterFork(afterForkCallback);
const TString command = "ls";
TShellCommand cmd(command, options);
cmd.Run();
UNIT_ASSERT(NFs::Exists(tmpFilePath));
TUnbufferedFileInput fileOutput(tmpFilePath);
TString firstLine = fileOutput.ReadLine();
UNIT_ASSERT_VALUES_EQUAL(firstLine, text);
}
}
|