1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
|
/**
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0.
*/
#include <aws/common/log_channel.h>
#include <aws/common/condition_variable.h>
#include <aws/common/log_writer.h>
#include <aws/common/mutex.h>
#include <aws/common/string.h>
#include <aws/common/thread.h>
#include <stdio.h>
/*
* Basic channel implementations - synchronized foreground, synchronized background
*/
struct aws_log_foreground_channel {
struct aws_mutex sync;
};
static int s_foreground_channel_send(struct aws_log_channel *channel, struct aws_string *log_line) {
struct aws_log_foreground_channel *impl = (struct aws_log_foreground_channel *)channel->impl;
AWS_ASSERT(channel->writer->vtable->write);
aws_mutex_lock(&impl->sync);
(channel->writer->vtable->write)(channel->writer, log_line);
aws_mutex_unlock(&impl->sync);
/*
* send is considered a transfer of ownership. write is not a transfer of ownership.
* So it's always the channel's responsibility to clean up all log lines that enter
* it as soon as they are no longer needed.
*/
aws_string_destroy(log_line);
return AWS_OP_SUCCESS;
}
static void s_foreground_channel_clean_up(struct aws_log_channel *channel) {
struct aws_log_foreground_channel *impl = (struct aws_log_foreground_channel *)channel->impl;
aws_mutex_clean_up(&impl->sync);
aws_mem_release(channel->allocator, impl);
}
static struct aws_log_channel_vtable s_foreground_channel_vtable = {
.send = s_foreground_channel_send,
.clean_up = s_foreground_channel_clean_up,
};
int aws_log_channel_init_foreground(
struct aws_log_channel *channel,
struct aws_allocator *allocator,
struct aws_log_writer *writer) {
struct aws_log_foreground_channel *impl = aws_mem_calloc(allocator, 1, sizeof(struct aws_log_foreground_channel));
if (impl == NULL) {
return AWS_OP_ERR;
}
if (aws_mutex_init(&impl->sync)) {
aws_mem_release(allocator, impl);
return AWS_OP_ERR;
}
channel->vtable = &s_foreground_channel_vtable;
channel->allocator = allocator;
channel->writer = writer;
channel->impl = impl;
return AWS_OP_SUCCESS;
}
struct aws_log_background_channel {
struct aws_mutex sync;
struct aws_thread background_thread;
struct aws_array_list pending_log_lines;
struct aws_condition_variable pending_line_signal;
bool finished;
};
static int s_background_channel_send(struct aws_log_channel *channel, struct aws_string *log_line) {
struct aws_log_background_channel *impl = (struct aws_log_background_channel *)channel->impl;
aws_mutex_lock(&impl->sync);
aws_array_list_push_back(&impl->pending_log_lines, &log_line);
aws_condition_variable_notify_one(&impl->pending_line_signal);
aws_mutex_unlock(&impl->sync);
return AWS_OP_SUCCESS;
}
static void s_background_channel_clean_up(struct aws_log_channel *channel) {
struct aws_log_background_channel *impl = (struct aws_log_background_channel *)channel->impl;
aws_mutex_lock(&impl->sync);
impl->finished = true;
aws_condition_variable_notify_one(&impl->pending_line_signal);
aws_mutex_unlock(&impl->sync);
aws_thread_join(&impl->background_thread);
aws_thread_clean_up(&impl->background_thread);
aws_condition_variable_clean_up(&impl->pending_line_signal);
aws_array_list_clean_up(&impl->pending_log_lines);
aws_mutex_clean_up(&impl->sync);
aws_mem_release(channel->allocator, impl);
}
static struct aws_log_channel_vtable s_background_channel_vtable = {
.send = s_background_channel_send,
.clean_up = s_background_channel_clean_up,
};
static bool s_background_wait(void *context) {
struct aws_log_background_channel *impl = (struct aws_log_background_channel *)context;
/*
* Condition variable predicates are checked under mutex protection
*/
return impl->finished || aws_array_list_length(&impl->pending_log_lines) > 0;
}
/**
* This is where the background thread spends 99.999% of its time.
* We broke this out into its own function so that the stacktrace clearly shows
* what this thread is doing. We've had a lot of cases where users think this
* thread is deadlocked because it's stuck here. We want it to be clear
* that it's doing nothing on purpose. It's waiting for log messages...
*/
AWS_NO_INLINE
static void aws_background_logger_listen_for_messages(struct aws_log_background_channel *impl) {
aws_condition_variable_wait_pred(&impl->pending_line_signal, &impl->sync, s_background_wait, impl);
}
static void aws_background_logger_thread(void *thread_data) {
(void)thread_data;
struct aws_log_channel *channel = (struct aws_log_channel *)thread_data;
AWS_ASSERT(channel->writer->vtable->write);
struct aws_log_background_channel *impl = (struct aws_log_background_channel *)channel->impl;
struct aws_array_list log_lines;
AWS_FATAL_ASSERT(aws_array_list_init_dynamic(&log_lines, channel->allocator, 10, sizeof(struct aws_string *)) == 0);
while (true) {
aws_mutex_lock(&impl->sync);
aws_background_logger_listen_for_messages(impl);
size_t line_count = aws_array_list_length(&impl->pending_log_lines);
bool finished = impl->finished;
if (line_count == 0) {
aws_mutex_unlock(&impl->sync);
if (finished) {
break;
}
continue;
}
aws_array_list_swap_contents(&impl->pending_log_lines, &log_lines);
aws_mutex_unlock(&impl->sync);
/*
* Consider copying these into a page-sized stack buffer (string) and then making the write calls
* against it rather than the individual strings. Might be a savings when > 1 lines (cut down on
* write calls).
*/
for (size_t i = 0; i < line_count; ++i) {
struct aws_string *log_line = NULL;
AWS_FATAL_ASSERT(aws_array_list_get_at(&log_lines, &log_line, i) == AWS_OP_SUCCESS);
(channel->writer->vtable->write)(channel->writer, log_line);
/*
* send is considered a transfer of ownership. write is not a transfer of ownership.
* So it's always the channel's responsibility to clean up all log lines that enter
* it as soon as they are no longer needed.
*/
aws_string_destroy(log_line);
}
aws_array_list_clear(&log_lines);
}
aws_array_list_clean_up(&log_lines);
}
int aws_log_channel_init_background(
struct aws_log_channel *channel,
struct aws_allocator *allocator,
struct aws_log_writer *writer) {
struct aws_log_background_channel *impl = aws_mem_calloc(allocator, 1, sizeof(struct aws_log_background_channel));
if (impl == NULL) {
return AWS_OP_ERR;
}
impl->finished = false;
if (aws_mutex_init(&impl->sync)) {
goto clean_up_sync_init_fail;
}
if (aws_array_list_init_dynamic(&impl->pending_log_lines, allocator, 10, sizeof(struct aws_string *))) {
goto clean_up_pending_log_lines_init_fail;
}
if (aws_condition_variable_init(&impl->pending_line_signal)) {
goto clean_up_pending_line_signal_init_fail;
}
if (aws_thread_init(&impl->background_thread, allocator)) {
goto clean_up_background_thread_init_fail;
}
channel->vtable = &s_background_channel_vtable;
channel->allocator = allocator;
channel->impl = impl;
channel->writer = writer;
/*
* Logging thread should need very little stack, but let's defer this to later
*/
struct aws_thread_options thread_options = *aws_default_thread_options();
thread_options.name = aws_byte_cursor_from_c_str("AwsLogger"); /* 15 characters is max for Linux */
if (aws_thread_launch(&impl->background_thread, aws_background_logger_thread, channel, &thread_options) ==
AWS_OP_SUCCESS) {
return AWS_OP_SUCCESS;
}
aws_thread_clean_up(&impl->background_thread);
clean_up_background_thread_init_fail:
aws_condition_variable_clean_up(&impl->pending_line_signal);
clean_up_pending_line_signal_init_fail:
aws_array_list_clean_up(&impl->pending_log_lines);
clean_up_pending_log_lines_init_fail:
aws_mutex_clean_up(&impl->sync);
clean_up_sync_init_fail:
aws_mem_release(allocator, impl);
return AWS_OP_ERR;
}
void aws_log_channel_clean_up(struct aws_log_channel *channel) {
AWS_ASSERT(channel->vtable->clean_up);
(channel->vtable->clean_up)(channel);
}
|