1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
|
--- a/src/core/lib/event_engine/forkable.cc (index)
+++ a/src/core/lib/event_engine/forkable.cc (working tree)
@@ -15,6 +15,7 @@
#include <grpc/support/port_platform.h>
#include "src/core/lib/event_engine/forkable.h"
+#include "src/core/lib/gprpp/fork.h"
#ifdef GRPC_POSIX_FORK_ALLOW_PTHREAD_ATFORK
@@ -35,6 +36,11 @@ bool g_registered Y_ABSL_GUARDED_BY(g_mu){false};
// This must be ordered because there are ordering dependencies between
// certain fork handlers.
grpc_core::NoDestruct<std::vector<Forkable*>> g_forkables Y_ABSL_GUARDED_BY(g_mu);
+
+bool IsForkEnabled() {
+ return grpc_core::Fork::Enabled();
+}
+
} // namespace
Forkable::Forkable() { ManageForkable(this); }
@@ -42,23 +48,31 @@ Forkable::Forkable() { ManageForkable(this); }
Forkable::~Forkable() { StopManagingForkable(this); }
void RegisterForkHandlers() {
- grpc_core::MutexLock lock(g_mu.get());
- if (!std::exchange(g_registered, true)) {
- pthread_atfork(PrepareFork, PostforkParent, PostforkChild);
+ if (IsForkEnabled()) {
+ grpc_core::MutexLock lock(g_mu.get());
+ if (!std::exchange(g_registered, true)) {
+#ifdef GRPC_POSIX_FORK_ALLOW_PTHREAD_ATFORK
+ pthread_atfork(PrepareFork, PostforkParent, PostforkChild);
+#endif
+ }
}
};
void PrepareFork() {
- grpc_core::MutexLock lock(g_mu.get());
- for (auto forkable_iter = g_forkables->rbegin();
- forkable_iter != g_forkables->rend(); ++forkable_iter) {
- (*forkable_iter)->PrepareFork();
+ if (IsForkEnabled()) {
+ grpc_core::MutexLock lock(g_mu.get());
+ for (auto forkable_iter = g_forkables->rbegin();
+ forkable_iter != g_forkables->rend(); ++forkable_iter) {
+ (*forkable_iter)->PrepareFork();
+ }
}
}
void PostforkParent() {
- grpc_core::MutexLock lock(g_mu.get());
- for (auto* forkable : *g_forkables) {
- forkable->PostforkParent();
+ if (IsForkEnabled()) {
+ grpc_core::MutexLock lock(g_mu.get());
+ for (auto* forkable : *g_forkables) {
+ forkable->PostforkParent();
+ }
}
}
@@ -69,30 +83,36 @@ void SetSkipPostForkChild() {
}
void PostforkChild() {
- y_absl::ResetDeadlockGraphMu();
- if (skip_postfork_child) {
- return;
- }
- grpc_core::MutexLock lock(g_mu.get());
- for (auto* forkable : *g_forkables) {
- forkable->PostforkChild();
+ if (IsForkEnabled()) {
+ y_absl::ResetDeadlockGraphMu();
+ if (skip_postfork_child) {
+ return;
+ }
+ grpc_core::MutexLock lock(g_mu.get());
+ for (auto* forkable : *g_forkables) {
+ forkable->PostforkChild();
+ }
}
}
void ManageForkable(Forkable* forkable) {
- grpc_core::MutexLock lock(g_mu.get());
- g_forkables->push_back(forkable);
+ if (IsForkEnabled()) {
+ grpc_core::MutexLock lock(g_mu.get());
+ g_forkables->push_back(forkable);
+ }
}
void StopManagingForkable(Forkable* forkable) {
- grpc_core::MutexLock lock(g_mu.get());
- auto iter = std::find(g_forkables->begin(), g_forkables->end(), forkable);
- // We've faced with the issue that destructor for TimerManager object is called
- // between PrepareFork and PostforkParent.
- // In result in PostforkParent we try to access not valid object via forkable ptr.
- // https://github.com/grpc/grpc/issues/33516
- if (iter != g_forkables->end()) {
- g_forkables->erase(iter);
+ if (IsForkEnabled()) {
+ grpc_core::MutexLock lock(g_mu.get());
+ auto iter = std::find(g_forkables->begin(), g_forkables->end(), forkable);
+ // We've faced with the issue that destructor for TimerManager object is called
+ // between PrepareFork and PostforkParent.
+ // In result in PostforkParent we try to access not valid object via forkable ptr.
+ // https://github.com/grpc/grpc/issues/33516
+ if (iter != g_forkables->end()) {
+ g_forkables->erase(iter);
+ }
}
}
|
