1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
|
//===--- SimplifySubscriptExprCheck.cpp - clang-tidy-----------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "SimplifySubscriptExprCheck.h"
#include "../utils/OptionsUtils.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
using namespace clang::ast_matchers;
namespace clang::tidy::readability {
static const char KDefaultTypes[] =
"::std::basic_string;::std::basic_string_view;::std::vector;::std::array";
SimplifySubscriptExprCheck::SimplifySubscriptExprCheck(
StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context), Types(utils::options::parseStringList(
Options.get("Types", KDefaultTypes))) {
}
void SimplifySubscriptExprCheck::registerMatchers(MatchFinder *Finder) {
const auto TypesMatcher = hasUnqualifiedDesugaredType(
recordType(hasDeclaration(cxxRecordDecl(hasAnyName(Types)))));
Finder->addMatcher(
arraySubscriptExpr(hasBase(
cxxMemberCallExpr(
has(memberExpr().bind("member")),
on(hasType(qualType(
unless(anyOf(substTemplateTypeParmType(),
hasDescendant(substTemplateTypeParmType()))),
anyOf(TypesMatcher, pointerType(pointee(TypesMatcher)))))),
callee(namedDecl(hasName("data"))))
.bind("call"))),
this);
}
void SimplifySubscriptExprCheck::check(const MatchFinder::MatchResult &Result) {
const auto *Call = Result.Nodes.getNodeAs<CXXMemberCallExpr>("call");
if (Result.Context->getSourceManager().isMacroBodyExpansion(
Call->getExprLoc()))
return;
const auto *Member = Result.Nodes.getNodeAs<MemberExpr>("member");
auto DiagBuilder =
diag(Member->getMemberLoc(),
"accessing an element of the container does not require a call to "
"'data()'; did you mean to use 'operator[]'?");
if (Member->isArrow())
DiagBuilder << FixItHint::CreateInsertion(Member->getBeginLoc(), "(*")
<< FixItHint::CreateInsertion(Member->getOperatorLoc(), ")");
DiagBuilder << FixItHint::CreateRemoval(
{Member->getOperatorLoc(), Call->getEndLoc()});
}
void SimplifySubscriptExprCheck::storeOptions(
ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "Types", utils::options::serializeStringList(Types));
}
} // namespace clang::tidy::readability
|
