1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
|
//===--- CopyConstructorInitCheck.cpp - clang-tidy-------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "CopyConstructorInitCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/Lex/Lexer.h"
using namespace clang::ast_matchers;
namespace clang::tidy::bugprone {
void CopyConstructorInitCheck::registerMatchers(MatchFinder *Finder) {
// In the future this might be extended to move constructors?
Finder->addMatcher(
cxxConstructorDecl(
isCopyConstructor(),
hasAnyConstructorInitializer(cxxCtorInitializer(
isBaseInitializer(),
withInitializer(cxxConstructExpr(hasDeclaration(
cxxConstructorDecl(isDefaultConstructor())))))),
unless(isInstantiated()))
.bind("ctor"),
this);
}
void CopyConstructorInitCheck::check(const MatchFinder::MatchResult &Result) {
const auto *Ctor = Result.Nodes.getNodeAs<CXXConstructorDecl>("ctor");
std::string ParamName = Ctor->getParamDecl(0)->getNameAsString();
// We want only one warning (and FixIt) for each ctor.
std::string FixItInitList;
bool HasRelevantBaseInit = false;
bool ShouldNotDoFixit = false;
bool HasWrittenInitializer = false;
SmallVector<FixItHint, 2> SafeFixIts;
for (const auto *Init : Ctor->inits()) {
bool CtorInitIsWritten = Init->isWritten();
HasWrittenInitializer = HasWrittenInitializer || CtorInitIsWritten;
if (!Init->isBaseInitializer())
continue;
const Type *BaseType = Init->getBaseClass();
// Do not do fixits if there is a type alias involved or one of the bases
// are explicitly initialized. In the latter case we not do fixits to avoid
// -Wreorder warnings.
if (const auto *TempSpecTy = dyn_cast<TemplateSpecializationType>(BaseType))
ShouldNotDoFixit = ShouldNotDoFixit || TempSpecTy->isTypeAlias();
ShouldNotDoFixit = ShouldNotDoFixit || isa<TypedefType>(BaseType);
ShouldNotDoFixit = ShouldNotDoFixit || CtorInitIsWritten;
const CXXRecordDecl *BaseClass =
BaseType->getAsCXXRecordDecl()->getDefinition();
if (BaseClass->field_empty() &&
BaseClass->forallBases(
[](const CXXRecordDecl *Class) { return Class->field_empty(); }))
continue;
bool NonCopyableBase = false;
for (const auto *Ctor : BaseClass->ctors()) {
if (Ctor->isCopyConstructor() &&
(Ctor->getAccess() == AS_private || Ctor->isDeleted())) {
NonCopyableBase = true;
break;
}
}
if (NonCopyableBase)
continue;
const auto *CExpr = dyn_cast<CXXConstructExpr>(Init->getInit());
if (!CExpr || !CExpr->getConstructor()->isDefaultConstructor())
continue;
HasRelevantBaseInit = true;
if (CtorInitIsWritten) {
if (!ParamName.empty())
SafeFixIts.push_back(
FixItHint::CreateInsertion(CExpr->getEndLoc(), ParamName));
} else {
if (Init->getSourceLocation().isMacroID() ||
Ctor->getLocation().isMacroID() || ShouldNotDoFixit)
break;
FixItInitList += BaseClass->getNameAsString();
FixItInitList += "(" + ParamName + "), ";
}
}
if (!HasRelevantBaseInit)
return;
auto Diag = diag(Ctor->getLocation(),
"calling a base constructor other than the copy constructor")
<< SafeFixIts;
if (FixItInitList.empty() || ParamName.empty() || ShouldNotDoFixit)
return;
std::string FixItMsg{FixItInitList.substr(0, FixItInitList.size() - 2)};
SourceLocation FixItLoc;
// There is no initialization list in this constructor.
if (!HasWrittenInitializer) {
FixItLoc = Ctor->getBody()->getBeginLoc();
FixItMsg = " : " + FixItMsg;
} else {
// We apply the missing ctors at the beginning of the initialization list.
FixItLoc = (*Ctor->init_begin())->getSourceLocation();
FixItMsg += ',';
}
FixItMsg += ' ';
Diag << FixItHint::CreateInsertion(FixItLoc, FixItMsg);
}
} // namespace clang::tidy::bugprone
|
