1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
|
//===--- AssertEquals.cpp - clang-tidy --------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "AssertEquals.h"
#include <map>
#include <string>
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace objc {
// Mapping from `XCTAssert*Equal` to `XCTAssert*EqualObjects` name.
static const std::map<std::string, std::string> &NameMap() {
static std::map<std::string, std::string> map{
{"XCTAssertEqual", "XCTAssertEqualObjects"},
{"XCTAssertNotEqual", "XCTAssertNotEqualObjects"},
};
return map;
}
void AssertEquals::registerMatchers(MatchFinder *finder) {
for (const auto &pair : NameMap()) {
finder->addMatcher(
binaryOperator(anyOf(hasOperatorName("!="), hasOperatorName("==")),
isExpandedFromMacro(pair.first),
anyOf(hasLHS(hasType(qualType(
hasCanonicalType(asString("NSString *"))))),
hasRHS(hasType(qualType(
hasCanonicalType(asString("NSString *"))))))
)
.bind(pair.first),
this);
}
}
void AssertEquals::check(const ast_matchers::MatchFinder::MatchResult &result) {
for (const auto &pair : NameMap()) {
if (const auto *root = result.Nodes.getNodeAs<BinaryOperator>(pair.first)) {
SourceManager *sm = result.SourceManager;
// The macros are nested two levels, so going up twice.
auto macro_callsite = sm->getImmediateMacroCallerLoc(
sm->getImmediateMacroCallerLoc(root->getBeginLoc()));
diag(macro_callsite, "use " + pair.second + " for comparing objects")
<< FixItHint::CreateReplacement(
clang::CharSourceRange::getCharRange(
macro_callsite,
macro_callsite.getLocWithOffset(pair.first.length())),
pair.second);
}
}
}
} // namespace objc
} // namespace tidy
} // namespace clang
|
