1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
|
//===--- BoolPointerImplicitConversionCheck.cpp - clang-tidy --------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "BoolPointerImplicitConversionCheck.h"
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace bugprone {
void BoolPointerImplicitConversionCheck::registerMatchers(MatchFinder *Finder) {
// Look for ifs that have an implicit bool* to bool conversion in the
// condition. Filter negations.
Finder->addMatcher(
traverse(
TK_AsIs,
ifStmt(
hasCondition(findAll(implicitCastExpr(
unless(hasParent(unaryOperator(hasOperatorName("!")))),
hasSourceExpression(expr(
hasType(pointerType(pointee(booleanType()))),
ignoringParenImpCasts(anyOf(declRefExpr().bind("expr"),
memberExpr().bind("expr"))))),
hasCastKind(CK_PointerToBoolean)))),
unless(isInTemplateInstantiation()))
.bind("if")),
this);
}
static void checkImpl(const MatchFinder::MatchResult &Result, const Expr *Ref,
const IfStmt *If,
const ast_matchers::internal::Matcher<Expr> &RefMatcher,
ClangTidyCheck &Check) {
// Ignore macros.
if (Ref->getBeginLoc().isMacroID())
return;
// Only allow variable accesses and member exprs for now, no function calls.
// Check that we don't dereference the variable anywhere within the if. This
// avoids false positives for checks of the pointer for nullptr before it is
// dereferenced. If there is a dereferencing operator on this variable don't
// emit a diagnostic. Also ignore array subscripts.
if (!match(findAll(unaryOperator(hasOperatorName("*"),
hasUnaryOperand(RefMatcher))),
*If, *Result.Context)
.empty() ||
!match(findAll(arraySubscriptExpr(hasBase(RefMatcher))), *If,
*Result.Context)
.empty() ||
// FIXME: We should still warn if the paremater is implicitly converted to
// bool.
!match(
findAll(callExpr(hasAnyArgument(ignoringParenImpCasts(RefMatcher)))),
*If, *Result.Context)
.empty() ||
!match(
findAll(cxxDeleteExpr(has(ignoringParenImpCasts(expr(RefMatcher))))),
*If, *Result.Context)
.empty())
return;
Check.diag(Ref->getBeginLoc(),
"dubious check of 'bool *' against 'nullptr', did "
"you mean to dereference it?")
<< FixItHint::CreateInsertion(Ref->getBeginLoc(), "*");
}
void BoolPointerImplicitConversionCheck::check(
const MatchFinder::MatchResult &Result) {
const auto *If = Result.Nodes.getNodeAs<IfStmt>("if");
if (const auto *E = Result.Nodes.getNodeAs<Expr>("expr")) {
const Decl *D = isa<DeclRefExpr>(E) ? cast<DeclRefExpr>(E)->getDecl()
: cast<MemberExpr>(E)->getMemberDecl();
const auto M =
ignoringParenImpCasts(anyOf(declRefExpr(to(equalsNode(D))),
memberExpr(hasDeclaration(equalsNode(D)))));
checkImpl(Result, E, If, M, *this);
}
}
} // namespace bugprone
} // namespace tidy
} // namespace clang
|
