1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
|
#include <Common/typeid_cast.h>
#include <Parsers/queryToString.h>
#include <Functions/FunctionsComparison.h>
#include <Functions/FunctionsLogical.h>
#include <IO/WriteHelpers.h>
#include <Interpreters/CrossToInnerJoinVisitor.h>
#include <Interpreters/DatabaseAndTableWithAlias.h>
#include <Interpreters/IdentifierSemantic.h>
#include <Interpreters/misc.h>
#include <Parsers/ASTExpressionList.h>
#include <Parsers/ASTFunction.h>
#include <Parsers/ASTIdentifier.h>
#include <Parsers/ASTLiteral.h>
#include <Parsers/ASTSelectQuery.h>
#include <Parsers/ASTSubquery.h>
#include <Parsers/ASTTablesInSelectQuery.h>
#include <Parsers/ExpressionListParsers.h>
#include <Parsers/ParserTablesInSelectQuery.h>
#include <Parsers/parseQuery.h>
#include <Common/logger_useful.h>
namespace DB
{
namespace ErrorCodes
{
extern const int INCORRECT_QUERY;
extern const int LOGICAL_ERROR;
extern const int NOT_IMPLEMENTED;
}
namespace
{
struct JoinedElement
{
explicit JoinedElement(const ASTTablesInSelectQueryElement & table_element)
: element(table_element)
{
if (element.table_join)
{
join = element.table_join->as<ASTTableJoin>();
original_kind = join->kind;
}
}
void checkTableName(const DatabaseAndTableWithAlias & table, const String & current_database) const
{
if (!element.table_expression)
throw Exception(ErrorCodes::LOGICAL_ERROR, "Not a table expression in JOIN (ARRAY JOIN?)");
ASTTableExpression * table_expression = element.table_expression->as<ASTTableExpression>();
if (!table_expression)
throw Exception(ErrorCodes::LOGICAL_ERROR, "Wrong table expression in JOIN");
if (!table.same(DatabaseAndTableWithAlias(*table_expression, current_database)))
throw Exception(ErrorCodes::LOGICAL_ERROR, "Inconsistent table names");
}
void rewriteCommaToCross()
{
if (join && join->kind == JoinKind::Comma)
join->kind = JoinKind::Cross;
}
JoinKind getOriginalKind() const { return original_kind; }
bool rewriteCrossToInner(ASTPtr on_expression)
{
if (join->kind != JoinKind::Cross)
return false;
join->kind = JoinKind::Inner;
join->strictness = JoinStrictness::All;
join->on_expression = on_expression;
join->children.push_back(join->on_expression);
return true;
}
ASTPtr arrayJoin() const { return element.array_join; }
const ASTTableJoin * tableJoin() const { return join; }
bool canAttachOnExpression() const { return join && !join->on_expression; }
bool hasUsing() const { return join && join->using_expression_list; }
private:
const ASTTablesInSelectQueryElement & element;
ASTTableJoin * join = nullptr;
JoinKind original_kind;
};
bool isAllowedToRewriteCrossJoin(const ASTPtr & node, const Aliases & aliases)
{
if (node->as<ASTFunction>())
{
auto idents = IdentifiersCollector::collect(node);
for (const auto * ident : idents)
{
if (ident->isShort() && aliases.contains(ident->shortName()))
return false;
}
return true;
}
return node->as<ASTIdentifier>() || node->as<ASTLiteral>();
}
/// Return mapping table_no -> expression with expression that can be moved into JOIN ON section
std::map<size_t, std::vector<ASTPtr>> moveExpressionToJoinOn(
const ASTPtr & ast,
const std::vector<JoinedElement> & joined_tables,
const std::vector<TableWithColumnNamesAndTypes> & tables,
const Aliases & aliases)
{
std::map<size_t, std::vector<ASTPtr>> asts_to_join_on;
for (const auto & node : splitConjunctionsAst(ast))
{
if (const auto * func = node->as<ASTFunction>(); func && func->name == NameEquals::name)
{
if (!func->arguments || func->arguments->children.size() != 2)
return {};
/// Check if the identifiers are from different joined tables.
/// If it's a self joint, tables should have aliases.
auto left_table_pos = IdentifierSemantic::getIdentsMembership(func->arguments->children[0], tables, aliases);
auto right_table_pos = IdentifierSemantic::getIdentsMembership(func->arguments->children[1], tables, aliases);
/// Identifiers from different table move to JOIN ON
if (left_table_pos && right_table_pos && *left_table_pos != *right_table_pos)
{
size_t table_pos = std::max(*left_table_pos, *right_table_pos);
if (joined_tables[table_pos].canAttachOnExpression())
asts_to_join_on[table_pos].push_back(node);
else
return {};
}
}
if (!isAllowedToRewriteCrossJoin(node, aliases))
return {};
}
return asts_to_join_on;
}
ASTPtr makeOnExpression(const std::vector<ASTPtr> & expressions)
{
if (expressions.size() == 1)
return expressions[0]->clone();
ASTs arguments;
arguments.reserve(expressions.size());
for (const auto & ast : expressions)
arguments.emplace_back(ast->clone());
return makeASTFunction(NameAnd::name, std::move(arguments));
}
std::vector<JoinedElement> getTables(const ASTSelectQuery & select)
{
if (!select.tables())
return {};
const auto * tables = select.tables()->as<ASTTablesInSelectQuery>();
if (!tables)
return {};
size_t num_tables = tables->children.size();
if (num_tables < 2)
return {};
std::vector<JoinedElement> joined_tables;
joined_tables.reserve(num_tables);
bool has_using = false;
for (const auto & child : tables->children)
{
const auto * table_element = child->as<ASTTablesInSelectQueryElement>();
if (!table_element)
throw Exception(ErrorCodes::LOGICAL_ERROR, "Logical error: TablesInSelectQueryElement expected");
JoinedElement & t = joined_tables.emplace_back(*table_element);
t.rewriteCommaToCross();
if (t.arrayJoin())
return {};
if (t.hasUsing())
{
if (has_using)
throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Multiple USING statements are not supported");
has_using = true;
}
if (const auto * join = t.tableJoin(); join && isCrossOrComma(join->kind))
{
if (!join->children.empty())
throw Exception(
ErrorCodes::LOGICAL_ERROR, "CROSS JOIN has {} expressions: [{}, ...]",
join->children.size(), queryToString(join->children[0]));
}
}
return joined_tables;
}
}
bool CrossToInnerJoinMatcher::needChildVisit(ASTPtr & node, const ASTPtr &)
{
return !node->as<ASTSubquery>();
}
void CrossToInnerJoinMatcher::visit(ASTPtr & ast, Data & data)
{
if (auto * t = ast->as<ASTSelectQuery>())
visit(*t, ast, data);
}
void CrossToInnerJoinMatcher::visit(ASTSelectQuery & select, ASTPtr &, Data & data)
{
std::vector<JoinedElement> joined_tables = getTables(select);
if (joined_tables.empty())
return;
/// Check if joined_tables are consistent with known tables_with_columns
{
if (joined_tables.size() != data.tables_with_columns.size())
throw Exception(ErrorCodes::LOGICAL_ERROR,
"Logical error: inconsistent number of tables: {} != {}",
joined_tables.size(), data.tables_with_columns.size());
for (size_t i = 0; i < joined_tables.size(); ++i)
joined_tables[i].checkTableName(data.tables_with_columns[i].table, data.current_database);
}
/// CROSS to INNER
if (data.cross_to_inner_join_rewrite && select.where())
{
auto asts_to_join_on = moveExpressionToJoinOn(select.where(), joined_tables, data.tables_with_columns, data.aliases);
for (size_t i = 1; i < joined_tables.size(); ++i)
{
auto & joined = joined_tables[i];
if (joined.tableJoin()->kind != JoinKind::Cross)
continue;
String query_before = queryToString(*joined.tableJoin());
bool rewritten = false;
const auto & expr_it = asts_to_join_on.find(i);
if (expr_it != asts_to_join_on.end())
{
ASTPtr on_expr = makeOnExpression(expr_it->second);
if (rewritten = joined.rewriteCrossToInner(on_expr); rewritten)
{
LOG_DEBUG(&Poco::Logger::get("CrossToInnerJoin"), "Rewritten '{}' to '{}'", query_before, queryToString(*joined.tableJoin()));
}
}
if (joined.getOriginalKind() == JoinKind::Comma &&
data.cross_to_inner_join_rewrite > 1 &&
!rewritten)
{
throw Exception(
ErrorCodes::INCORRECT_QUERY,
"Failed to rewrite comma join to INNER. "
"Please, try to simplify WHERE section "
"or set the setting `cross_to_inner_join_rewrite` to 1 to allow slow CROSS JOIN for this case "
"(cannot rewrite '{} WHERE {}' to INNER JOIN)",
query_before, queryToString(select.where()));
}
}
}
}
}
|