1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
|
#include <Access/LDAPAccessStorage.h>
#include <Access/AccessControl.h>
#include <Access/ExternalAuthenticators.h>
#include <Access/User.h>
#include <Access/Role.h>
#include <Access/Credentials.h>
#include <Access/LDAPClient.h>
#include <Common/Exception.h>
#include <Common/logger_useful.h>
#include <base/scope_guard.h>
#include <Poco/Util/AbstractConfiguration.h>
#include <Poco/JSON/JSON.h>
#include <Poco/JSON/Object.h>
#include <Poco/JSON/Stringifier.h>
#include <boost/container_hash/hash.hpp>
#include <boost/range/algorithm/copy.hpp>
#include <iterator>
#include <sstream>
#include <unordered_map>
namespace DB
{
namespace ErrorCodes
{
extern const int BAD_ARGUMENTS;
}
LDAPAccessStorage::LDAPAccessStorage(const String & storage_name_, AccessControl & access_control_, const Poco::Util::AbstractConfiguration & config, const String & prefix)
: IAccessStorage(storage_name_), access_control(access_control_), memory_storage(storage_name_, access_control.getChangesNotifier(), false)
{
setConfiguration(config, prefix);
}
String LDAPAccessStorage::getLDAPServerName() const
{
std::scoped_lock lock(mutex);
return ldap_server_name;
}
void LDAPAccessStorage::setConfiguration(const Poco::Util::AbstractConfiguration & config, const String & prefix)
{
std::scoped_lock lock(mutex);
// TODO: switch to passing config as a ConfigurationView and remove this extra prefix once a version of Poco with proper implementation is available.
const String prefix_str = (prefix.empty() ? "" : prefix + ".");
const bool has_server = config.has(prefix_str + "server");
const bool has_roles = config.has(prefix_str + "roles");
const bool has_role_mapping = config.has(prefix_str + "role_mapping");
if (!has_server)
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Missing 'server' field for LDAP user directory");
const auto ldap_server_name_cfg = config.getString(prefix_str + "server");
if (ldap_server_name_cfg.empty())
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Empty 'server' field for LDAP user directory");
std::set<String> common_roles_cfg;
if (has_roles)
{
Poco::Util::AbstractConfiguration::Keys role_names;
config.keys(prefix_str + "roles", role_names);
// Currently, we only extract names of roles from the section names and assign them directly and unconditionally.
common_roles_cfg.insert(role_names.begin(), role_names.end());
}
LDAPClient::RoleSearchParamsList role_search_params_cfg;
if (has_role_mapping)
{
Poco::Util::AbstractConfiguration::Keys all_keys;
config.keys(prefix, all_keys);
for (const auto & key : all_keys)
{
if (key == "role_mapping" || key.find("role_mapping[") == 0)
parseLDAPRoleSearchParams(role_search_params_cfg.emplace_back(), config, prefix_str + key);
}
}
ldap_server_name = ldap_server_name_cfg;
role_search_params.swap(role_search_params_cfg);
common_role_names.swap(common_roles_cfg);
external_role_hashes.clear();
users_per_roles.clear();
roles_per_users.clear();
granted_role_names.clear();
granted_role_ids.clear();
role_change_subscription = access_control.subscribeForChanges<Role>(
[this] (const UUID & id, const AccessEntityPtr & entity)
{
return this->processRoleChange(id, entity);
}
);
}
void LDAPAccessStorage::processRoleChange(const UUID & id, const AccessEntityPtr & entity)
{
std::scoped_lock lock(mutex);
const auto role = typeid_cast<std::shared_ptr<const Role>>(entity);
const auto it = granted_role_names.find(id);
if (role) // Added or renamed a role.
{
const auto & new_role_name = role->getName();
if (it != granted_role_names.end()) // Renamed a granted role.
{
const auto & old_role_name = it->second;
if (new_role_name != old_role_name)
{
// Revoke the old role first, then grant the new role.
applyRoleChangeNoLock(false /* revoke */, id, old_role_name);
applyRoleChangeNoLock(true /* grant */, id, new_role_name);
}
}
else // Added a role.
{
applyRoleChangeNoLock(true /* grant */, id, new_role_name);
}
}
else // Removed a role.
{
if (it != granted_role_names.end()) // Removed a granted role.
{
const auto & old_role_name = it->second;
applyRoleChangeNoLock(false /* revoke */, id, old_role_name);
}
}
}
void LDAPAccessStorage::applyRoleChangeNoLock(bool grant, const UUID & role_id, const String & role_name)
{
std::vector<UUID> user_ids;
// Build a list of ids of the relevant users.
if (common_role_names.contains(role_name))
{
user_ids = memory_storage.findAll<User>();
}
else
{
const auto it = users_per_roles.find(role_name);
if (it != users_per_roles.end())
{
const auto & user_names = it->second;
user_ids.reserve(user_names.size());
for (const auto & user_name : user_names)
{
if (const auto user_id = memory_storage.find<User>(user_name))
user_ids.emplace_back(*user_id);
}
}
}
// Update the granted roles of the relevant users.
if (!user_ids.empty())
{
auto update_func = [&role_id, &grant] (const AccessEntityPtr & entity_) -> AccessEntityPtr
{
if (auto user = typeid_cast<std::shared_ptr<const User>>(entity_))
{
auto changed_user = typeid_cast<std::shared_ptr<User>>(user->clone());
if (grant)
changed_user->granted_roles.grant(role_id);
else
changed_user->granted_roles.revoke(role_id);
return changed_user;
}
return entity_;
};
memory_storage.update(user_ids, update_func);
}
// Actualize granted_role_* mappings.
if (grant)
{
if (!user_ids.empty())
{
granted_role_names.insert_or_assign(role_id, role_name);
granted_role_ids.insert_or_assign(role_name, role_id);
}
}
else
{
granted_role_names.erase(role_id);
granted_role_ids.erase(role_name);
}
}
void LDAPAccessStorage::assignRolesNoLock(User & user, const LDAPClient::SearchResultsList & external_roles) const
{
const auto external_roles_hash = boost::hash<LDAPClient::SearchResultsList>{}(external_roles);
return assignRolesNoLock(user, external_roles, external_roles_hash);
}
void LDAPAccessStorage::assignRolesNoLock(User & user, const LDAPClient::SearchResultsList & external_roles, const std::size_t external_roles_hash) const
{
const auto & user_name = user.getName();
auto & granted_roles = user.granted_roles;
auto local_role_names = mapExternalRolesNoLock(external_roles);
auto grant_role = [this, &user_name, &granted_roles] (const String & role_name, const bool common)
{
auto it = granted_role_ids.find(role_name);
if (it == granted_role_ids.end())
{
if (const auto role_id = access_control.find<Role>(role_name))
{
granted_role_names.insert_or_assign(*role_id, role_name);
it = granted_role_ids.insert_or_assign(role_name, *role_id).first;
}
}
if (it != granted_role_ids.end())
{
const auto & role_id = it->second;
granted_roles.grant(role_id);
}
else
{
LOG_WARNING(getLogger(), "Unable to grant {} role '{}' to user '{}': role not found", (common ? "common" : "mapped"), role_name, user_name);
}
};
external_role_hashes.erase(user_name);
granted_roles = {};
const auto old_role_names = std::move(roles_per_users[user_name]);
// Grant the common roles first.
for (const auto & role_name : common_role_names)
{
grant_role(role_name, true /* common */);
}
// Grant the mapped external roles and actualize users_per_roles mapping.
// local_role_names allowed to overlap with common_role_names.
for (const auto & role_name : local_role_names)
{
grant_role(role_name, false /* mapped */);
users_per_roles[role_name].insert(user_name);
}
// Cleanup users_per_roles and granted_role_* mappings.
for (const auto & old_role_name : old_role_names)
{
if (local_role_names.contains(old_role_name))
continue;
const auto rit = users_per_roles.find(old_role_name);
if (rit == users_per_roles.end())
continue;
auto & user_names = rit->second;
user_names.erase(user_name);
if (!user_names.empty())
continue;
users_per_roles.erase(rit);
if (common_role_names.contains(old_role_name))
continue;
const auto iit = granted_role_ids.find(old_role_name);
if (iit == granted_role_ids.end())
continue;
const auto old_role_id = iit->second;
granted_role_names.erase(old_role_id);
granted_role_ids.erase(iit);
}
// Actualize roles_per_users mapping and external_role_hashes cache.
if (local_role_names.empty())
roles_per_users.erase(user_name);
else
roles_per_users[user_name] = std::move(local_role_names);
external_role_hashes[user_name] = external_roles_hash;
}
void LDAPAccessStorage::updateAssignedRolesNoLock(const UUID & id, const String & user_name, const LDAPClient::SearchResultsList & external_roles) const
{
// No need to include common_role_names in this hash each time, since they don't change.
const auto external_roles_hash = boost::hash<LDAPClient::SearchResultsList>{}(external_roles);
// Map and grant the roles from scratch only if the list of external role has changed.
const auto it = external_role_hashes.find(user_name);
if (it != external_role_hashes.end() && it->second == external_roles_hash)
return;
auto update_func = [this, &external_roles, external_roles_hash] (const AccessEntityPtr & entity_) -> AccessEntityPtr
{
if (auto user = typeid_cast<std::shared_ptr<const User>>(entity_))
{
auto changed_user = typeid_cast<std::shared_ptr<User>>(user->clone());
assignRolesNoLock(*changed_user, external_roles, external_roles_hash);
return changed_user;
}
return entity_;
};
memory_storage.update(id, update_func);
}
std::set<String> LDAPAccessStorage::mapExternalRolesNoLock(const LDAPClient::SearchResultsList & external_roles) const
{
std::set<String> role_names;
if (external_roles.size() != role_search_params.size())
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Unable to map external roles");
for (std::size_t i = 0; i < external_roles.size(); ++i)
{
const auto & external_role_set = external_roles[i];
const auto & prefix = role_search_params[i].prefix;
for (const auto & external_role : external_role_set)
{
if (
prefix.size() < external_role.size() &&
external_role.compare(0, prefix.size(), prefix) == 0
)
{
role_names.emplace(external_role, prefix.size());
}
}
}
return role_names;
}
bool LDAPAccessStorage::areLDAPCredentialsValidNoLock(const User & user, const Credentials & credentials,
const ExternalAuthenticators & external_authenticators, LDAPClient::SearchResultsList & role_search_results) const
{
if (!credentials.isReady())
return false;
if (credentials.getUserName() != user.getName())
return false;
if (typeid_cast<const AlwaysAllowCredentials *>(&credentials))
return true;
if (const auto * basic_credentials = dynamic_cast<const BasicCredentials *>(&credentials))
return external_authenticators.checkLDAPCredentials(ldap_server_name, *basic_credentials, &role_search_params, &role_search_results);
return false;
}
const char * LDAPAccessStorage::getStorageType() const
{
return STORAGE_TYPE;
}
String LDAPAccessStorage::getStorageParamsJSON() const
{
std::scoped_lock lock(mutex);
Poco::JSON::Object params_json;
params_json.set("server", ldap_server_name);
Poco::JSON::Array common_role_names_json;
for (const auto & role : common_role_names)
{
common_role_names_json.add(role);
}
params_json.set("roles", common_role_names_json);
Poco::JSON::Array role_mappings_json;
for (const auto & role_mapping : role_search_params)
{
Poco::JSON::Object role_mapping_json;
role_mapping_json.set("base_dn", role_mapping.base_dn);
role_mapping_json.set("search_filter", role_mapping.search_filter);
role_mapping_json.set("attribute", role_mapping.attribute);
role_mapping_json.set("prefix", role_mapping.prefix);
String scope;
switch (role_mapping.scope)
{
case LDAPClient::SearchParams::Scope::BASE: scope = "base"; break;
case LDAPClient::SearchParams::Scope::ONE_LEVEL: scope = "one_level"; break;
case LDAPClient::SearchParams::Scope::SUBTREE: scope = "subtree"; break;
case LDAPClient::SearchParams::Scope::CHILDREN: scope = "children"; break;
}
role_mapping_json.set("scope", scope);
role_mappings_json.add(role_mapping_json);
}
params_json.set("role_mappings", role_mappings_json);
std::ostringstream oss; // STYLE_CHECK_ALLOW_STD_STRING_STREAM
oss.exceptions(std::ios::failbit);
Poco::JSON::Stringifier::stringify(params_json, oss);
return oss.str();
}
std::optional<UUID> LDAPAccessStorage::findImpl(AccessEntityType type, const String & name) const
{
std::scoped_lock lock(mutex);
return memory_storage.find(type, name);
}
std::vector<UUID> LDAPAccessStorage::findAllImpl(AccessEntityType type) const
{
std::scoped_lock lock(mutex);
return memory_storage.findAll(type);
}
bool LDAPAccessStorage::exists(const UUID & id) const
{
std::scoped_lock lock(mutex);
return memory_storage.exists(id);
}
AccessEntityPtr LDAPAccessStorage::readImpl(const UUID & id, bool throw_if_not_exists) const
{
std::scoped_lock lock(mutex);
return memory_storage.read(id, throw_if_not_exists);
}
std::optional<std::pair<String, AccessEntityType>> LDAPAccessStorage::readNameWithTypeImpl(const UUID & id, bool throw_if_not_exists) const
{
std::scoped_lock lock(mutex);
return memory_storage.readNameWithType(id, throw_if_not_exists);
}
std::optional<UUID> LDAPAccessStorage::authenticateImpl(
const Credentials & credentials,
const Poco::Net::IPAddress & address,
const ExternalAuthenticators & external_authenticators,
bool throw_if_user_not_exists,
bool /* allow_no_password */,
bool /* allow_plaintext_password */) const
{
std::scoped_lock lock(mutex);
auto id = memory_storage.find<User>(credentials.getUserName());
UserPtr user = id ? memory_storage.read<User>(*id) : nullptr;
std::shared_ptr<User> new_user;
if (!user)
{
// User does not exist, so we create one, and will add it if authentication is successful.
new_user = std::make_shared<User>();
new_user->setName(credentials.getUserName());
new_user->auth_data = AuthenticationData(AuthenticationType::LDAP);
new_user->auth_data.setLDAPServerName(ldap_server_name);
user = new_user;
}
if (!isAddressAllowed(*user, address))
throwAddressNotAllowed(address);
LDAPClient::SearchResultsList external_roles;
if (!areLDAPCredentialsValidNoLock(*user, credentials, external_authenticators, external_roles))
{
// We don't know why the authentication has just failed:
// either there is no such user in LDAP or the password is not correct.
// We treat this situation as if there is no such user because we don't want to block
// other storages following this LDAPAccessStorage from trying to authenticate on their own.
if (throw_if_user_not_exists)
throwNotFound(AccessEntityType::USER, credentials.getUserName());
else
return {};
}
if (new_user)
{
// TODO: if these were AlwaysAllowCredentials, then mapped external roles are not available here,
// since without a password we can't authenticate and retrieve roles from the LDAP server.
assignRolesNoLock(*new_user, external_roles);
id = memory_storage.insert(new_user);
}
else
{
// Just in case external_roles are changed. This will be no-op if they are not.
updateAssignedRolesNoLock(*id, user->getName(), external_roles);
}
return id;
}
}
|