| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
commit_hash:f7485dac5115e73f75a5edccb3c65c0b657dd8e5
|
| |
|
|
| |
commit_hash:c180c2db4897962cb70063ffdc2ddcd21e5e3418
|
| |
|
|
| |
commit_hash:da491ee93c4f4d3c885c7908a22b4d5d66c80388
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch enables more Clang Tidy checks for the `yql/essentials` project.
I chosen the policy to enable all checks by default because
- It will keep us updated when new checks are become available in the DevTools
whitelist.
- You never know what check will be useful, even if it was not fired now.
Why some checks from the https://nda.ya.ru/t/8QnKCVIO7NWhBD were disabled?
- `arcadia-taxi-` checks are `userver`-specific.
- `bugprone-bool-pointer-implicit-conversion` is not applicable to our
codebase as we heavily used to it.
- `bugprone-branch-clone` triggered on a code that is not obviously
rewrittable and not so poor.
- `bugprone-dynamic-static-initializers` are heavily used in our codebase
especially in the translator. Static variables with dynamic initialization
are so common, so refactor them is too hard and requires huge code rewritting
to deliver some hardcoded configuration values via ctors, having them in a one
place.
- `bugprone-exception-escape` is useful check for programs where the care of
exception safety is taken, but we a lot of places where exception can be thrown
from the destructor or move-operator. I left a TODO in the `.clang-tidy` to
fix this. Maybe will create a ticket.
- `bugprone-lambda-function-name` appears when we throw an exception from the
lambda. I think, that this is okay and do not see any options to fix it.
- `bugprone-macro-parentheses` had false positives at `YQL_ENSURE` second argument
and also broke some code, by surrounding `A` at `template <class A>`.
- `bugprone-misplaced-widening-cast`,
`bugprone-narrowing-conversions`,
`bugprone-signed-char-misuse` are disabled because checking arithmetics
correctness is hard and non-trivial. I am not sure that it worth spending
a lot of time on it as everything seems to work well :o)
- `bugprone-reserved-identifier` was triggered on some harmless identifier in
computation, so I decided just to turn this off, rather than argue with someone.
- `bugprone-suspicious-enum-usage` happend on Arcadia HTTP client usage. Do not
think that it is worth to argue with Arcadia HTTP client code owners.
- `bugprone-suspicious-memory-comparison` happened in some compuration test.
I just decided to trust low-level code authors.
- `bugprone-too-small-loop-variable` seems not really a problem and lets you
safe some symbols on `static_cast`s.
- `bugprone-sizeof-expression` had so many false positives at computation.
- `bugprone-unchecked-optional-access` a good check, but optionals are dereferenced
everywhere in our codebase. Of course, in a perfect world near each of such
dereference should be an assertion with comment why it is a valid action, because
when static analysis can not infer that the value is non-null, then it is
not an obvious thing for a human also. But we a too far from such code quality now.
- `bugprone-undefined-memory-manipulation` is interesting. It argued on some `memcpy`
at computation. There was some `UnboxedValues` array and this objects have
some logic of memory marking and releasing under an `NDEBUG`. I added a TODO to check
this. Maybe will create a ticket.
- `bugprone-unhandled-self-assignment` has false positives on non-owning objects
such as iterators.
commit_hash:c0c0de6b157bf095eb681bdea55ada47845de814
|
| |
|
|
| |
commit_hash:a6b640bc576263b62884a0b4187ba79c893e13d9
|
| |
|
|
|
| |
init
commit_hash:f9684778bf1ea956965f2360b80b91edb7d4ffbe
|
| |
|
|
|
| |
Fix Unicode/ error line
commit_hash:aa5f17b1dd12a3b69869458c6f5aa92bb8514257
|
| |
|
|
| |
commit_hash:18e311c0ad94b55003cb5a6c0487a16830fac5cd
|
| |
|
|
| |
commit_hash:804e5d328ce4c658ecff2e5a0f259bce717f84f8
|
| |
|
|
| |
commit_hash:30371c936e006647e6aee38a0c95980d2d1af49e
|
| |
|
|
| |
commit_hash:5eac5390db34d1ca89f96441c1cfcff9c5853587
|
| |
|
|
|
|
|
| |
YQL-19535: Provide block operations
YQL-19535: Specify tests for blocked operations
commit_hash:032aa58fc3f44f0eba3d9b38def021178da949ce
|
| |
|
|
| |
commit_hash:a55c7dadcacd5aac18465edf6e6cee8fb77dfcc0
|
| |
|
|
| |
commit_hash:a686a16356826d703f351aacb2d03d24d3841838
|
| |
|
|
|
|
|
|
|
| |
simulate optimization failures
В обычном select 1 \|\| 2 теперь выдается ошибка в InitialTypeAnnotation stage
А ошибка на RepeatTypeAnnotation stage эскалируется до Severity=Fatal
commit_hash:fb09693b4baf9e14bfe7dae9a8a9cd4b9e0e0142
|
| |
|
|
|
|
|
|
|
|
|
| |
#11152 - Allow to choose normal or aggreation PG function
#11075 - Handle invalid base
#11068 - Allow more postgis functions
#10831 - Views: if exists / if not exists for DDL
commit_hash:0ebf35e45ac6de147c9000440ca25237db061d2e
|
| |
|
|
| |
commit_hash:b5826cf53cbe98e17103fcd8139fdfd091f5e037
|
| |
|
|
| |
commit_hash:1495166c0ac2e13c7e4f9be22ca76a5268e67d0d
|
| |
|
|
| |
commit_hash:b75c4510058a45b92316d448f6ac2dc21963b920
|
|
|
Except the following directories:
* clickhouse/client
* datetime
* knn
* roaring
commit_hash:c7da95636144d28db109d6b17ddc762e9bacb59f
|
