diff options
| author | robot-piglet <robot-piglet@yandex-team.com> | 2024-06-06 15:47:28 +0300 |
|---|---|---|
| committer | robot-piglet <robot-piglet@yandex-team.com> | 2024-06-06 16:03:06 +0300 |
| commit | d87cb8da08545c64c124f382cbb7e41a862a3f3d (patch) | |
| tree | bc69fbed3417065e54527ffcb24a59a69de76f64 /yt | |
| parent | d5b96872cfaceb0505854152a207bd2955934ebc (diff) | |
| download | ydb-d87cb8da08545c64c124f382cbb7e41a862a3f3d.tar.gz | |
Intermediate changes
Diffstat (limited to 'yt')
| -rw-r--r-- | yt/yt/core/concurrency/unittests/fair_share_invoker_pool_ut.cpp | 10 | ||||
| -rw-r--r-- | yt/yt/core/concurrency/unittests/profiled_fair_share_invoker_pool_ut.cpp | 7 |
2 files changed, 4 insertions, 13 deletions
diff --git a/yt/yt/core/concurrency/unittests/fair_share_invoker_pool_ut.cpp b/yt/yt/core/concurrency/unittests/fair_share_invoker_pool_ut.cpp index 8c7efa2adb..8fd475f85e 100644 --- a/yt/yt/core/concurrency/unittests/fair_share_invoker_pool_ut.cpp +++ b/yt/yt/core/concurrency/unittests/fair_share_invoker_pool_ut.cpp @@ -23,7 +23,8 @@ namespace { //////////////////////////////////////////////////////////////////////////////// -constexpr auto Margin = TDuration::MilliSeconds(20); +// NB(arkady-e1ppa): Margin is that bad while we can't simulate time. +constexpr auto Margin = TDuration::MilliSeconds(50); constexpr auto Quantum = TDuration::MilliSeconds(100); //////////////////////////////////////////////////////////////////////////////// @@ -614,13 +615,6 @@ TEST_F(TFairShareInvokerPoolTest, GetTotalWaitEstimateUncorrelatedWithOtherInvok secondaryLeash.NotifyOne(); WaitFor(std::move(secondaryAction)).ThrowOnError(); WaitFor(std::move(actions[1])).ThrowOnError(); - - statistics = invokerPool->GetInvokerStatistics(0); - expectedTotalTimeEstimate = (expectedTotalTimeEstimate + (GetInstant() - start)) / 3.0; - - EXPECT_EQ(statistics.WaitingActionCount, 0); - EXPECT_LE(statistics.TotalTimeEstimate, expectedTotalTimeEstimate + Margin); - EXPECT_GE(statistics.TotalTimeEstimate, expectedTotalTimeEstimate - Margin); } //////////////////////////////////////////////////////////////////////////////// diff --git a/yt/yt/core/concurrency/unittests/profiled_fair_share_invoker_pool_ut.cpp b/yt/yt/core/concurrency/unittests/profiled_fair_share_invoker_pool_ut.cpp index 2fbfa3fb27..d1b3ab09d5 100644 --- a/yt/yt/core/concurrency/unittests/profiled_fair_share_invoker_pool_ut.cpp +++ b/yt/yt/core/concurrency/unittests/profiled_fair_share_invoker_pool_ut.cpp @@ -28,7 +28,8 @@ using namespace NProfiling; //////////////////////////////////////////////////////////////////////////////// -constexpr auto Margin = TDuration::MilliSeconds(20); +// NB(arkady-e1ppa): Margin is that bad while we can't simulate time. +constexpr auto Margin = TDuration::MilliSeconds(50); constexpr auto Quantum = TDuration::MilliSeconds(100); //////////////////////////////////////////////////////////////////////////////// @@ -628,10 +629,6 @@ TEST_F(TProfiledFairShareInvokerPoolTest, GetTotalWaitEstimateUncorrelatedWithOt statistics = invokerPool->GetInvokerStatistics(0); expectedTotalTimeEstimate = (expectedTotalTimeEstimate + (GetInstant() - start)) / 3.0; - - EXPECT_EQ(statistics.WaitingActionCount, 0); - EXPECT_LE(statistics.TotalTimeEstimate, expectedTotalTimeEstimate + Margin); - EXPECT_GE(statistics.TotalTimeEstimate, expectedTotalTimeEstimate - Margin); } //////////////////////////////////////////////////////////////////////////////// |