Fix non-deterministic hash set traverse in YSON struct

* Changelog entry
Type: fix
Component: master

Non-deterministic order of YSON struct field loading leads leads to non-deterministic error in case of absence of two or more required fields. Since error message is a part of response for master mutation this could lead to "state hashes differ" alert on master.
commit_hash:140c56096212d5df8f9f1b1c2dbd63b3d2e61498

1 files changed, 5 insertions, 1 deletions

diff --git a/yt/yt/core/ytree/yson_struct_detail.cpp b/yt/yt/core/ytree/yson_struct_detail.cpp
index 3bcd69aa40..1665385717 100644
--- a/yt/yt/core/ytree/yson_struct_detail.cpp
+++ b/yt/yt/core/ytree/yson_struct_detail.cpp
@@ -273,7 +273,11 @@ void TYsonStructMeta::LoadStruct(
         pendingParameters.erase(parameter);
     });
 
-    for (const auto parameter : pendingParameters) {
+    auto sortedPendingParameters = std::vector(pendingParameters.begin(), pendingParameters.end());
+    Sort(sortedPendingParameters, [] (const auto* lhs, const auto* rhs) {
+        return lhs->GetKey() < rhs->GetKey();
+    });
+    for (const auto parameter : sortedPendingParameters) {
         parameter->Load(target, /*cursor*/ nullptr, createLoadOptions(parameter->GetKey()));
     }