diff options
| author | vitya-smirnov <[email protected]> | 2026-01-23 15:36:47 +0300 |
|---|---|---|
| committer | vitya-smirnov <[email protected]> | 2026-01-23 16:17:10 +0300 |
| commit | 5ec2ab12d84c8edd135d4a89d87e2fbd2b281f4e (patch) | |
| tree | 44cb327cb46af3c8b511fed6a8dd55f12bc04c0c /yql/essentials/udfs/common/python/bindings | |
| parent | 457271e202ef3564c1b5f32f9092068635d17681 (diff) | |
YQL-20095: Enable google-explicit-constructor
commit_hash:4d77ad10fd4db303459ec4e45e139967c7fc8196
Diffstat (limited to 'yql/essentials/udfs/common/python/bindings')
5 files changed, 6 insertions, 4 deletions
diff --git a/yql/essentials/udfs/common/python/bindings/py_callable.cpp b/yql/essentials/udfs/common/python/bindings/py_callable.cpp index cc254baef7b..8b1f7938849 100644 --- a/yql/essentials/udfs/common/python/bindings/py_callable.cpp +++ b/yql/essentials/udfs/common/python/bindings/py_callable.cpp @@ -252,7 +252,7 @@ struct TPySecureParam { PyObject_HEAD; TPyCastContext::TPtr CastCtx; - TPySecureParam(const TPyCastContext::TPtr& castCtx) + explicit TPySecureParam(const TPyCastContext::TPtr& castCtx) : CastCtx(castCtx) { } diff --git a/yql/essentials/udfs/common/python/bindings/py_lazy_mkql_dict.cpp b/yql/essentials/udfs/common/python/bindings/py_lazy_mkql_dict.cpp index eb7e3a64f32..e0f25941f54 100644 --- a/yql/essentials/udfs/common/python/bindings/py_lazy_mkql_dict.cpp +++ b/yql/essentials/udfs/common/python/bindings/py_lazy_mkql_dict.cpp @@ -522,7 +522,7 @@ class TLazySequenceAsDict: public NUdf::TBoxedValue { private: class TKeyIterator: public NUdf::TBoxedValue { public: - TKeyIterator(Py_ssize_t size) + explicit TKeyIterator(Py_ssize_t size) : Size_(size) , Index_(0) { diff --git a/yql/essentials/udfs/common/python/bindings/py_ptr.h b/yql/essentials/udfs/common/python/bindings/py_ptr.h index e17a290aaaf..a55b7daa0d9 100644 --- a/yql/essentials/udfs/common/python/bindings/py_ptr.h +++ b/yql/essentials/udfs/common/python/bindings/py_ptr.h @@ -33,6 +33,8 @@ public: { } + // Implicit ownership capturing is okay for smart pointers + // NOLINTNEXTLINE(google-explicit-constructor) inline TPyObjectPtr(PyObject* p) : TSelf(p, STEAL_REF) // do not increment refcounter by default { diff --git a/yql/essentials/udfs/common/python/bindings/py_stream_ut.cpp b/yql/essentials/udfs/common/python/bindings/py_stream_ut.cpp index 61c0fe5caf3..88711df09ad 100644 --- a/yql/essentials/udfs/common/python/bindings/py_stream_ut.cpp +++ b/yql/essentials/udfs/common/python/bindings/py_stream_ut.cpp @@ -29,7 +29,7 @@ void Ui32StreamValidator(const NUdf::TUnboxedValuePod& value) { } struct TTestStream final: NUdf::TBoxedValue { - TTestStream(ui32 maxValue, ui32 yieldOn = Max<ui32>()) + explicit TTestStream(ui32 maxValue, ui32 yieldOn = Max<ui32>()) : Current_(0) , YieldOn_(yieldOn) , MaxValue_(maxValue) diff --git a/yql/essentials/udfs/common/python/bindings/py_test_engine.h b/yql/essentials/udfs/common/python/bindings/py_test_engine.h index 5b482b8cd43..75ff4f4705f 100644 --- a/yql/essentials/udfs/common/python/bindings/py_test_engine.h +++ b/yql/essentials/udfs/common/python/bindings/py_test_engine.h @@ -45,7 +45,7 @@ public: , Alloc_(__LOCATION__) , Env_(Alloc_) , TypeInfoHelper_(new TTypeInfoHelper) - , FunctionInfoBuilder_(NYql::UnknownLangVersion, Env_, TypeInfoHelper_, "", nullptr, {}) + , FunctionInfoBuilder_(NYql::UnknownLangVersion, Env_, TypeInfoHelper_, "", nullptr, NYql::NUdf::TSourcePosition()) { HolderFactory_ = MakeHolder<THolderFactory>( Alloc_.Ref(), |