diff options
author | vitya-smirnov <[email protected]> | 2025-07-22 11:57:55 +0300 |
---|---|---|
committer | vitya-smirnov <[email protected]> | 2025-07-22 12:16:44 +0300 |
commit | cf94d8a9ef2bd554213054a9cb6352a20a134a10 (patch) | |
tree | 508577e572363c0a0b6ca1617af0179c0edbeaae /yql/essentials/sql/v1/complete/sql_complete.cpp | |
parent | 483d11bf5a8df9991fc6c614908d8f5a750dcca8 (diff) |
YQL-20221: Change binding replace range
Symbol `$` was excluded from the `BindingName`
candidate content as `Replxx` interprets `$` as
a word break. The problem is that Monaco Editor
accounts `$` as a word part and filters out bindings.
This patch makes `$` a word part and adds replace
range to handle this properly at `Replxx`.
commit_hash:ca3959635a6c0e6688bcbe7622a9c2aab6c683eb
Diffstat (limited to 'yql/essentials/sql/v1/complete/sql_complete.cpp')
-rw-r--r-- | yql/essentials/sql/v1/complete/sql_complete.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/yql/essentials/sql/v1/complete/sql_complete.cpp b/yql/essentials/sql/v1/complete/sql_complete.cpp index 253e4731835..dfafedd86ab 100644 --- a/yql/essentials/sql/v1/complete/sql_complete.cpp +++ b/yql/essentials/sql/v1/complete/sql_complete.cpp @@ -70,7 +70,7 @@ namespace NSQLComplete { TNameRequest request = NameRequestFrom(input, local, global); if (request.IsEmpty()) { return NThreading::MakeFuture<TCompletion>({ - .CompletedToken = GetCompletedToken(input, local.EditRange), + .CompletedToken = GetCompletedToken(input, local.ReplaceRange), .Candidates = {}, }); } @@ -109,7 +109,7 @@ namespace NSQLComplete { const TLocalSyntaxContext& local, const TGlobalContext& global) const { TNameRequest request = { - .Prefix = TString(GetCompletedToken(input, local.EditRange).Content), + .Prefix = TString(GetCompletedToken(input, local.FilterRange).Content), .Limit = Configuration_.Limit, }; @@ -177,7 +177,7 @@ namespace NSQLComplete { TCompletion ToCompletion(TCompletionInput input, TLocalSyntaxContext local, TNameResponse response) const { TCompletion completion = { - .CompletedToken = GetCompletedToken(input, local.EditRange), + .CompletedToken = GetCompletedToken(input, local.ReplaceRange), .Candidates = ToCandidate(std::move(response.RankedNames), std::move(local)), }; |