Remove read-only files and directories on Windows (to match behavior on unix)

Current behavior of RemoveDirWithContents does not allow removing
directories if any of files in this directory is read-only. This
behavior, however, does not allow, for example, to remove temporary
directory, in which git repository was created (on *nix systems,
however, this problem was not noticed). This PR overrides this behavior.

ref:1faf91e233008b4aece4f2b953884b52346ce2be

1 files changed, 4 insertions, 0 deletions

diff --git a/util/system/fs_win.cpp b/util/system/fs_win.cpp
index e9f4e5ac33..45d7454b2f 100644
--- a/util/system/fs_win.cpp
+++ b/util/system/fs_win.cpp
@@ -60,6 +60,10 @@ namespace NFsPrivate {
         }
         WIN32_FILE_ATTRIBUTE_DATA fad;
         if (::GetFileAttributesExW(wname, GetFileExInfoStandard, &fad)) {
+            if (fad.dwFileAttributes & FILE_ATTRIBUTE_READONLY) {
+                fad.dwFileAttributes = FILE_ATTRIBUTE_NORMAL;
+                ::SetFileAttributesW(wname, fad.dwFileAttributes);
+            }
             if (fad.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)
                 return ::RemoveDirectoryW(wname) != 0;
             return ::DeleteFileW(wname) != 0;