summaryrefslogtreecommitdiffstats
path: root/contrib/tools/python3/Modules/_json.c
diff options
context:
space:
mode:
authorshadchin <[email protected]>2026-06-24 07:09:14 +0300
committershadchin <[email protected]>2026-06-24 07:31:09 +0300
commit280914cd46f4411a2e01150bf9d9c53dff19fa66 (patch)
tree841d7b8330cb51e86f2ea6e915e4904563321aca /contrib/tools/python3/Modules/_json.c
parent1100ced6faf1d14f48cb041f885882d3b37491a2 (diff)
Update Python 3 to 3.13.14
commit_hash:9913a0288f56b5ddd0f99e5b2ff1569d491cbe5d
Diffstat (limited to 'contrib/tools/python3/Modules/_json.c')
-rw-r--r--contrib/tools/python3/Modules/_json.c32
1 files changed, 28 insertions, 4 deletions
diff --git a/contrib/tools/python3/Modules/_json.c b/contrib/tools/python3/Modules/_json.c
index afefc71bfbd..25cbd9b9bb8 100644
--- a/contrib/tools/python3/Modules/_json.c
+++ b/contrib/tools/python3/Modules/_json.c
@@ -1602,9 +1602,13 @@ encoder_listencode_dict(PyEncoderObject *s, _PyUnicodeWriter *writer,
for (Py_ssize_t i = 0; i < PyList_GET_SIZE(items); i++) {
PyObject *item = PyList_GET_ITEM(items, i);
+ // gh-142831: encoder_encode_key_value() can invoke user code
+ // that mutates the items list, invalidating this borrowed ref.
+ Py_INCREF(item);
if (!PyTuple_Check(item) || PyTuple_GET_SIZE(item) != 2) {
PyErr_SetString(PyExc_ValueError, "items must return 2-tuples");
+ Py_DECREF(item);
goto bail;
}
@@ -1612,18 +1616,30 @@ encoder_listencode_dict(PyEncoderObject *s, _PyUnicodeWriter *writer,
value = PyTuple_GET_ITEM(item, 1);
if (encoder_encode_key_value(s, writer, &first, key, value,
new_newline_indent,
- current_item_separator) < 0)
+ current_item_separator) < 0) {
+ Py_DECREF(item);
goto bail;
+ }
+ Py_DECREF(item);
}
Py_CLEAR(items);
} else {
Py_ssize_t pos = 0;
while (PyDict_Next(dct, &pos, &key, &value)) {
+ // gh-142831: encoder_encode_key_value() can invoke user code
+ // that mutates the dict, invalidating these borrowed refs.
+ Py_INCREF(key);
+ Py_INCREF(value);
if (encoder_encode_key_value(s, writer, &first, key, value,
new_newline_indent,
- current_item_separator) < 0)
+ current_item_separator) < 0) {
+ Py_DECREF(key);
+ Py_DECREF(value);
goto bail;
+ }
+ Py_DECREF(key);
+ Py_DECREF(value);
}
}
@@ -1712,12 +1728,20 @@ encoder_listencode_list(PyEncoderObject *s, _PyUnicodeWriter *writer,
}
for (i = 0; i < PySequence_Fast_GET_SIZE(s_fast); i++) {
PyObject *obj = PySequence_Fast_GET_ITEM(s_fast, i);
+ // gh-142831: encoder_listencode_obj() can invoke user code
+ // that mutates the sequence, invalidating this borrowed ref.
+ Py_INCREF(obj);
if (i) {
- if (_PyUnicodeWriter_WriteStr(writer, separator) < 0)
+ if (_PyUnicodeWriter_WriteStr(writer, separator) < 0) {
+ Py_DECREF(obj);
goto bail;
+ }
}
- if (encoder_listencode_obj(s, writer, obj, new_newline_indent))
+ if (encoder_listencode_obj(s, writer, obj, new_newline_indent)) {
+ Py_DECREF(obj);
goto bail;
+ }
+ Py_DECREF(obj);
}
if (ident != NULL) {
if (PyDict_DelItem(s->markers, ident))