Intermediate changes

commit_hash:9e9eb9789dc376bac164b089669f6c8adeefdc63

3 files changed, 16 insertions, 11 deletions

diff --git a/contrib/python/traitlets/py3/tests/test_traitlets.py b/contrib/python/traitlets/py3/tests/test_traitlets.py
index f9f623b4ae6..665422cd9d2 100644
--- a/contrib/python/traitlets/py3/tests/test_traitlets.py
+++ b/contrib/python/traitlets/py3/tests/test_traitlets.py
@@ -7,6 +7,7 @@
 # also under the terms of the Modified BSD License.
 from __future__ import annotations
 
+import decimal
 import pickle
 import re
 import typing as t
@@ -1391,7 +1392,7 @@ class TestLong(TraitTestBase):
     obj = LongTrait()
 
     _default_value = 99
-    _good_values = [10, -10]
+    _good_values = [10, -10, 10.0, decimal.Decimal("10.0")]
     _bad_values = [
         "ten",
         [10],
@@ -1401,6 +1402,7 @@ class TestLong(TraitTestBase):
         1j,
         10.1,
         -10.1,
+        decimal.Decimal("10.1"),
         "10",
         "-10",
         "10L",
diff --git a/contrib/python/traitlets/py3/tests/test_typing.py b/contrib/python/traitlets/py3/tests/test_typing.py
index 8329feb8375..940447478dc 100644
--- a/contrib/python/traitlets/py3/tests/test_typing.py
+++ b/contrib/python/traitlets/py3/tests/test_typing.py
@@ -407,27 +407,27 @@ def mypy_tcp_typing() -> None:
         otcp = TCPAddress(None, allow_none=True)
 
     t = T()
-    reveal_type(t.tcp)  # R: Tuple[builtins.str, builtins.int]
+    reveal_type(t.tcp)  # R: tuple[builtins.str, builtins.int]
     reveal_type(
-        T.tcp  # R: traitlets.traitlets.TCPAddress[Tuple[builtins.str, builtins.int], Tuple[builtins.str, builtins.int]]
+        T.tcp  # R: traitlets.traitlets.TCPAddress[tuple[builtins.str, builtins.int], tuple[builtins.str, builtins.int]]
     )
     reveal_type(
-        T.tcp.tag(  # R:traitlets.traitlets.TCPAddress[Tuple[builtins.str, builtins.int], Tuple[builtins.str, builtins.int]]
+        T.tcp.tag(  # R:traitlets.traitlets.TCPAddress[tuple[builtins.str, builtins.int], tuple[builtins.str, builtins.int]]
             sync=True
         )
     )
-    reveal_type(t.otcp)  # R: Union[Tuple[builtins.str, builtins.int], None]
+    reveal_type(t.otcp)  # R: Union[tuple[builtins.str, builtins.int], None]
     reveal_type(
-        T.otcp  # R: traitlets.traitlets.TCPAddress[Union[Tuple[builtins.str, builtins.int], None], Union[Tuple[builtins.str, builtins.int], None]]
+        T.otcp  # R: traitlets.traitlets.TCPAddress[Union[tuple[builtins.str, builtins.int], None], Union[tuple[builtins.str, builtins.int], None]]
     )
     reveal_type(
-        T.otcp.tag(  # R: traitlets.traitlets.TCPAddress[Union[Tuple[builtins.str, builtins.int], None], Union[Tuple[builtins.str, builtins.int], None]]
+        T.otcp.tag(  # R: traitlets.traitlets.TCPAddress[Union[tuple[builtins.str, builtins.int], None], Union[tuple[builtins.str, builtins.int], None]]
             sync=True
         )
     )
-    t.tcp = "foo"  # E: Incompatible types in assignment (expression has type "str", variable has type "Tuple[str, int]")  [assignment]
-    t.otcp = "foo"  # E: Incompatible types in assignment (expression has type "str", variable has type "Optional[Tuple[str, int]]")  [assignment]
-    t.tcp = None  # E: Incompatible types in assignment (expression has type "None", variable has type "Tuple[str, int]")  [assignment]
+    t.tcp = "foo"  # E: Incompatible types in assignment (expression has type "str", variable has type "tuple[str, int]")  [assignment]
+    t.otcp = "foo"  # E: Incompatible types in assignment (expression has type "str", variable has type "Optional[tuple[str, int]]")  [assignment]
+    t.tcp = None  # E: Incompatible types in assignment (expression has type "None", variable has type "tuple[str, int]")  [assignment]
 
 
 @pytest.mark.mypy_testing
diff --git a/contrib/python/traitlets/py3/tests/utils/test_bunch.py b/contrib/python/traitlets/py3/tests/utils/test_bunch.py
index 90efe982739..98bf262016a 100644
--- a/contrib/python/traitlets/py3/tests/utils/test_bunch.py
+++ b/contrib/python/traitlets/py3/tests/utils/test_bunch.py
@@ -14,5 +14,8 @@ def test_bunch():
 
 def test_bunch_dir():
     b = Bunch(x=5, y=10)
-    assert "x" in dir(b)
     assert "keys" in dir(b)
+    assert "x" in dir(b)
+    assert "z" not in dir(b)
+    b.z = 15
+    assert "z" in dir(b)