diff options
| author | yuryalekseev <yuryalekseev@yandex-team.com> | 2024-04-22 22:43:02 +0300 |
|---|---|---|
| committer | yuryalekseev <yuryalekseev@yandex-team.com> | 2024-04-22 22:50:44 +0300 |
| commit | fd41af07c937014fe317735d72e86df25604812c (patch) | |
| tree | 812c16a364838b04cc2afd34e3e076e82d17fc77 | |
| parent | 6efae713ebe1d2edc0cd67dfa5499ee63adb37b1 (diff) | |
| download | ydb-fd41af07c937014fe317735d72e86df25604812c.tar.gz | |
YT-20113: Address review comments.
38fc0bceba87529d2732c38a0904c0ba39c0381a
| -rw-r--r-- | yt/yt/client/table_client/comparator.cpp | 4 | ||||
| -rw-r--r-- | yt/yt/client/table_client/comparator.h | 2 | ||||
| -rw-r--r-- | yt/yt/client/table_client/schema.cpp | 4 | ||||
| -rw-r--r-- | yt/yt/client/table_client/schema.h | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/yt/yt/client/table_client/comparator.cpp b/yt/yt/client/table_client/comparator.cpp index f49bec0fba..34aefde9db 100644 --- a/yt/yt/client/table_client/comparator.cpp +++ b/yt/yt/client/table_client/comparator.cpp @@ -19,9 +19,9 @@ static const TLogger Logger("TableClientComparator"); //////////////////////////////////////////////////////////////////////////////// -TComparator::TComparator(std::vector<ESortOrder> sortOrders, TCallback<TUUComparerSignature> CGComparator) +TComparator::TComparator(std::vector<ESortOrder> sortOrders, TCallback<TUUComparerSignature> cgComparator) : SortOrders_(std::move(sortOrders)) - , CGComparator_(CGComparator) + , CGComparator_(std::move(cgComparator)) { } void TComparator::Persist(const TPersistenceContext& context) diff --git a/yt/yt/client/table_client/comparator.h b/yt/yt/client/table_client/comparator.h index b228356555..b272c6569e 100644 --- a/yt/yt/client/table_client/comparator.h +++ b/yt/yt/client/table_client/comparator.h @@ -28,7 +28,7 @@ public: public: TComparator() = default; - TComparator(std::vector<ESortOrder> sortOrders, TCallback<TUUComparerSignature> CGComparator = {}); + explicit TComparator(std::vector<ESortOrder> sortOrders, TCallback<TUUComparerSignature> cgComparator = {}); void Persist(const TPersistenceContext& context); diff --git a/yt/yt/client/table_client/schema.cpp b/yt/yt/client/table_client/schema.cpp index 241c8019f2..29ac95929d 100644 --- a/yt/yt/client/table_client/schema.cpp +++ b/yt/yt/client/table_client/schema.cpp @@ -1305,7 +1305,7 @@ TTableSchemaPtr TTableSchema::ToModifiedSchema(ETableSchemaModification schemaMo } } -TComparator TTableSchema::ToComparator(TCallback<TUUComparerSignature> CGComparator) const +TComparator TTableSchema::ToComparator(TCallback<TUUComparerSignature> cgComparator) const { std::vector<ESortOrder> sortOrders; if (ColumnInfo_) { @@ -1317,7 +1317,7 @@ TComparator TTableSchema::ToComparator(TCallback<TUUComparerSignature> CGCompara } } - return TComparator(std::move(sortOrders), std::move(CGComparator)); + return TComparator(std::move(sortOrders), std::move(cgComparator)); } void TTableSchema::Save(TStreamSaveContext& context) const diff --git a/yt/yt/client/table_client/schema.h b/yt/yt/client/table_client/schema.h index 8ece5019e9..9c6e794072 100644 --- a/yt/yt/client/table_client/schema.h +++ b/yt/yt/client/table_client/schema.h @@ -381,7 +381,7 @@ public: TTableSchemaPtr ToModifiedSchema(ETableSchemaModification schemaModification) const; - TComparator ToComparator(TCallback<TUUComparerSignature> CGComparator = {}) const; + TComparator ToComparator(TCallback<TUUComparerSignature> cgComparator = {}) const; TKeyColumnTypes GetKeyColumnTypes() const; |