diff options
author | babenko <babenko@yandex-team.com> | 2024-12-06 18:53:45 +0300 |
---|---|---|
committer | babenko <babenko@yandex-team.com> | 2024-12-06 19:30:16 +0300 |
commit | f8e7e242532d48494b5483c81d364c9c8fa593cd (patch) | |
tree | 7e635c557647111e7a7abc03ccd66cd82bccf28d | |
parent | 39819d97313d7d00c8a5b22fca17b3568c522af8 (diff) | |
download | ydb-f8e7e242532d48494b5483c81d364c9c8fa593cd.tar.gz |
YT-23731: Temporarily drop spin wait slow path logger configuration
commit_hash:3ac7eb9f36369d2d4a446df10a92e82ee5d6b68f
-rw-r--r-- | yt/yt/core/threading/spin_wait_slow_path_logger.cpp | 2 | ||||
-rw-r--r-- | yt/yt/library/program/config.cpp | 4 | ||||
-rw-r--r-- | yt/yt/library/program/config.h | 2 | ||||
-rw-r--r-- | yt/yt/library/program/helpers.cpp | 6 |
4 files changed, 1 insertions, 13 deletions
diff --git a/yt/yt/core/threading/spin_wait_slow_path_logger.cpp b/yt/yt/core/threading/spin_wait_slow_path_logger.cpp index 492a6f4f5c..74c3b9c23b 100644 --- a/yt/yt/core/threading/spin_wait_slow_path_logger.cpp +++ b/yt/yt/core/threading/spin_wait_slow_path_logger.cpp @@ -22,7 +22,7 @@ void SpinWaitSlowPathLoggingHook( Y_UNUSED(cpuDelay); Y_UNUSED(location); Y_UNUSED(activityKind); - // XXX(babenko): currently broken + // XXX(babenko): YT-23731: currently broken // if (cpuDelay >= SpinWaitSlowPathLoggingThreshold) { // const auto& Logger = ThreadingLogger; // YT_LOG_DEBUG("Spin wait took too long (SourceLocation: %, ActivityKind: %v, Delay: %v)", diff --git a/yt/yt/library/program/config.cpp b/yt/yt/library/program/config.cpp index 960463a978..6d1f2f45fd 100644 --- a/yt/yt/library/program/config.cpp +++ b/yt/yt/library/program/config.cpp @@ -20,8 +20,6 @@ void THeapProfilerConfig::Register(TRegistrar registrar) void TSingletonsConfig::Register(TRegistrar registrar) { - registrar.Parameter("spin_wait_slow_path_logging_threshold", &TThis::SpinWaitSlowPathLoggingThreshold) - .Default(TDuration::MicroSeconds(100)); registrar.Parameter("fiber_manager", &TThis::FiberManager) .DefaultNew(); registrar.Parameter("address_resolver", &TThis::AddressResolver) @@ -61,8 +59,6 @@ void TSingletonsConfig::Register(TRegistrar registrar) void TSingletonsDynamicConfig::Register(TRegistrar registrar) { - registrar.Parameter("spin_lock_slow_path_logging_threshold", &TThis::SpinWaitSlowPathLoggingThreshold) - .Optional(); registrar.Parameter("fiber_manager", &TThis::FiberManager) .DefaultNew(); registrar.Parameter("tcp_dispatcher", &TThis::TcpDispatcher) diff --git a/yt/yt/library/program/config.h b/yt/yt/library/program/config.h index ae69194b9f..fa92d6923e 100644 --- a/yt/yt/library/program/config.h +++ b/yt/yt/library/program/config.h @@ -61,7 +61,6 @@ class TSingletonsConfig : public virtual NYTree::TYsonStruct { public: - TDuration SpinWaitSlowPathLoggingThreshold; NConcurrency::TFiberManagerConfigPtr FiberManager; NNet::TAddressResolverConfigPtr AddressResolver; NBus::TTcpDispatcherConfigPtr TcpDispatcher; @@ -92,7 +91,6 @@ class TSingletonsDynamicConfig : public virtual NYTree::TYsonStruct { public: - std::optional<TDuration> SpinWaitSlowPathLoggingThreshold; NConcurrency::TFiberManagerDynamicConfigPtr FiberManager; NBus::TTcpDispatcherDynamicConfigPtr TcpDispatcher; NPipes::TIODispatcherConfigPtr IODispatcher; diff --git a/yt/yt/library/program/helpers.cpp b/yt/yt/library/program/helpers.cpp index 7b65c81dbf..6a1e8df9fd 100644 --- a/yt/yt/library/program/helpers.cpp +++ b/yt/yt/library/program/helpers.cpp @@ -33,8 +33,6 @@ #include <yt/yt/core/service_discovery/yp/service_discovery.h> -#include <yt/yt/core/threading/spin_wait_slow_path_logger.h> - #include <library/cpp/yt/memory/atomic_intrusive_ptr.h> #include <util/string/split.h> @@ -53,8 +51,6 @@ using namespace NTCMalloc; void ConfigureSingletons(const TSingletonsConfigPtr& config) { - SetSpinWaitSlowPathLoggingThreshold(config->SpinWaitSlowPathLoggingThreshold); - TFiberManager::Configure(config->FiberManager); NLogging::TLogManager::Get()->EnableReopenOnSighup(); @@ -101,8 +97,6 @@ void ConfigureSingletons(const TSingletonsConfigPtr& config) void ReconfigureSingletons(const TSingletonsConfigPtr& config, const TSingletonsDynamicConfigPtr& dynamicConfig) { - SetSpinWaitSlowPathLoggingThreshold(dynamicConfig->SpinWaitSlowPathLoggingThreshold.value_or(config->SpinWaitSlowPathLoggingThreshold)); - TFiberManager::Configure(config->FiberManager->ApplyDynamic(dynamicConfig->FiberManager)); if (!NLogging::TLogManager::Get()->IsConfiguredFromEnv()) { |