diff options
| author | vitya-smirnov <[email protected]> | 2026-05-15 18:17:47 +0300 |
|---|---|---|
| committer | vitya-smirnov <[email protected]> | 2026-05-15 18:40:45 +0300 |
| commit | e6065108aafec57742cfcbd8dab2011eab7b9499 (patch) | |
| tree | 7a8203b54c69667f99e82943d1904e3c83983434 | |
| parent | a666fd3e1cbef934f3b4cc8cb39b09876b497948 (diff) | |
YQL-20095: Enable readability-static-definition-in-anonymous-namespace
commit_hash:f7485dac5115e73f75a5edccb3c65c0b657dd8e5
28 files changed, 111 insertions, 110 deletions
diff --git a/yql/essentials/.clang-tidy b/yql/essentials/.clang-tidy index b74460347b8..3d21813af90 100644 --- a/yql/essentials/.clang-tidy +++ b/yql/essentials/.clang-tidy @@ -407,7 +407,7 @@ Checks: > readability-simplify-boolean-expr, readability-simplify-subscript-expr, -readability-static-accessed-through-instance, - -readability-static-definition-in-anonymous-namespace, + readability-static-definition-in-anonymous-namespace, -readability-string-compare, -readability-suspicious-call-argument, -readability-uniqueptr-delete-release, diff --git a/yql/essentials/core/sql_types/simple_types.cpp b/yql/essentials/core/sql_types/simple_types.cpp index 3b158f28a8c..c6cd40e37aa 100644 --- a/yql/essentials/core/sql_types/simple_types.cpp +++ b/yql/essentials/core/sql_types/simple_types.cpp @@ -18,7 +18,7 @@ struct TSimpleType { // NOLINTBEGIN(modernize-use-designated-initializers) -static const std::unordered_map<std::string_view, TSimpleType> SimpleTypes = { +const std::unordered_map<std::string_view, TSimpleType> SimpleTypes = { {"void", {"Void", "Void", "Void"}}, {"unit", {"Unit", "Unit", "Unit"}}, {"generic", {"Generic", "Generic", "Generic"}}, @@ -78,7 +78,7 @@ static const std::unordered_map<std::string_view, TSimpleType> SimpleTypes = { {"tztimestamp64", {"TzTimestamp64", "TzTimestamp64", "Data"}}}; // new types (or aliases) should be added here -static const std::unordered_map<std::string_view, TSimpleType> NewSimpleTypes = { +const std::unordered_map<std::string_view, TSimpleType> NewSimpleTypes = { {"text", {"", "Utf8", ""}}, {"bytes", {"", "String", ""}}}; } // namespace diff --git a/yql/essentials/core/yql_expr_csee.cpp b/yql/essentials/core/yql_expr_csee.cpp index 23dcc76c2dd..8effaf01bff 100644 --- a/yql/essentials/core/yql_expr_csee.cpp +++ b/yql/essentials/core/yql_expr_csee.cpp @@ -11,7 +11,7 @@ namespace NYql { namespace { - static constexpr bool UseDeterminsticHash = false; + constexpr bool UseDeterminsticHash = false; struct TLambdaFrame { TLambdaFrame(const TExprNode* lambda, const TLambdaFrame* prev) diff --git a/yql/essentials/core/yql_expr_type_annotation.cpp b/yql/essentials/core/yql_expr_type_annotation.cpp index 53faf0cc735..fc33831004a 100644 --- a/yql/essentials/core/yql_expr_type_annotation.cpp +++ b/yql/essentials/core/yql_expr_type_annotation.cpp @@ -6221,7 +6221,7 @@ void PrintTupleDiff(TStringBuilder& res, size_t level, const TIndentPrinter& ind } } -static void PrintTypeDiff(TStringBuilder& res, size_t level, const TIndentPrinter& indent, const TTypeAnnotationNode& left, const TTypeAnnotationNode& right) { +void PrintTypeDiff(TStringBuilder& res, size_t level, const TIndentPrinter& indent, const TTypeAnnotationNode& left, const TTypeAnnotationNode& right) { if (&left == &right) { res << "no diff"; return; diff --git a/yql/essentials/minikql/computation/mkql_validate.cpp b/yql/essentials/minikql/computation/mkql_validate.cpp index b7fe7a27a64..aff030b09c9 100644 --- a/yql/essentials/minikql/computation/mkql_validate.cpp +++ b/yql/essentials/minikql/computation/mkql_validate.cpp @@ -11,7 +11,7 @@ namespace NKikimr::NMiniKQL { namespace { -static const TString VERIFY_DELIMITER = "\n - "; +const TString VERIFY_DELIMITER = "\n - "; using namespace NUdf; diff --git a/yql/essentials/minikql/computation/mkql_validate_ut.cpp b/yql/essentials/minikql/computation/mkql_validate_ut.cpp index bb670073adf..0446f26dd12 100644 --- a/yql/essentials/minikql/computation/mkql_validate_ut.cpp +++ b/yql/essentials/minikql/computation/mkql_validate_ut.cpp @@ -25,8 +25,8 @@ namespace NYql { namespace { using namespace NKikimr::NMiniKQL; -static const ui32 RAW_INDEX_NO_HOLE = -1; -static const ui32 RAW_BROKEN_INDEX_LIST_TO_DICT = 1; +const ui32 RAW_INDEX_NO_HOLE = -1; +const ui32 RAW_BROKEN_INDEX_LIST_TO_DICT = 1; template <class T> NUdf::TUnboxedValue ToUnboxedValue(const T& val) { @@ -489,7 +489,7 @@ SIMPLE_UDF_RUN(TSeqListWithHole, NUdf::TListType<ui32>(ui32, ui32), NUdf::TOptio return NUdf::TUnboxedValuePod(std::move(boxed)); } -static const auto TUPLE = std::make_tuple(ui8(33), TString("world"), ui64(0xFEEDB00B2A115E), TString("funny bunny")); +const auto TUPLE = std::make_tuple(ui8(33), TString("world"), ui64(0xFEEDB00B2A115E), TString("funny bunny")); using NUdfTuple = NUdf::TTuple<ui8, char*, ui64, char*>; @@ -500,7 +500,7 @@ SIMPLE_UDF(TTuple, NUdfTuple(ui32)) { return NUdf::TUnboxedValuePod(std::move(boxed)); } -static const std::vector<std::pair<ui32, ui64>> DICT_DIGIT2DIGIT = { +const std::vector<std::pair<ui32, ui64>> DICT_DIGIT2DIGIT = { {1, 100500}, {42, 0xDEADBEAF}, {911, 1234567890}, @@ -528,13 +528,13 @@ SIMPLE_UDF(TDictDigDigHoleAsOpt, NUdfDictDigDig(ui32, ui32)) { return NUdf::TUnboxedValuePod(std::move(boxed)); } -static const NUdf::TPersonStruct STRUCT_PERSON_JONNIE = {.FirstName = "Johnnie Walker", .LastName = "Blue Label", .Age = 25}; -static const NUdf::TPersonStruct STRUCT_PERSON_HITHCOCK = {.FirstName = "Alfred", .LastName = "Hithcock", .Age = 81}; -static const NUdf::TPersonStruct STRUCT_PERSON_LOVECRAFT = {.FirstName = "Howard", .LastName = "Lovecraft", .Age = 25}; -static const NUdf::TPersonStruct STRUCT_PERSON_KING = {.FirstName = "Stephen", .LastName = "King", .Age = 25}; -static const NUdf::TPersonStructWithOptList STRUCT_PERSON_HITHCOCK_LIST = {.FirstName = "Alfred", .LastName = "Hithcock", .Age = 81, .Tags = {}}; -static const NUdf::TPersonStructWithOptList STRUCT_PERSON_LOVECRAFT_LIST = {.FirstName = "Howard", .LastName = "Lovecraft", .Age = 25, .Tags = {3, 2, 99}}; -static const NUdf::TPersonStructWithOptList STRUCT_PERSON_KING_LIST = {.FirstName = "Stephen", .LastName = "King", .Age = 25, .Tags = {}}; +const NUdf::TPersonStruct STRUCT_PERSON_JONNIE = {.FirstName = "Johnnie Walker", .LastName = "Blue Label", .Age = 25}; +const NUdf::TPersonStruct STRUCT_PERSON_HITHCOCK = {.FirstName = "Alfred", .LastName = "Hithcock", .Age = 81}; +const NUdf::TPersonStruct STRUCT_PERSON_LOVECRAFT = {.FirstName = "Howard", .LastName = "Lovecraft", .Age = 25}; +const NUdf::TPersonStruct STRUCT_PERSON_KING = {.FirstName = "Stephen", .LastName = "King", .Age = 25}; +const NUdf::TPersonStructWithOptList STRUCT_PERSON_HITHCOCK_LIST = {.FirstName = "Alfred", .LastName = "Hithcock", .Age = 81, .Tags = {}}; +const NUdf::TPersonStructWithOptList STRUCT_PERSON_LOVECRAFT_LIST = {.FirstName = "Howard", .LastName = "Lovecraft", .Age = 25, .Tags = {3, 2, 99}}; +const NUdf::TPersonStructWithOptList STRUCT_PERSON_KING_LIST = {.FirstName = "Stephen", .LastName = "King", .Age = 25, .Tags = {}}; SIMPLE_UDF_RUN(TPersonStruct, NUdf::TPersonStruct(ui32), NUdf::TOptional<void>) { Y_UNUSED(valueBuilder); @@ -544,16 +544,16 @@ SIMPLE_UDF_RUN(TPersonStruct, NUdf::TPersonStruct(ui32), NUdf::TOptional<void>) } using NUdfPersonTuple = NUdf::TTuple<NUdf::TPersonStructWithOptList, NUdf::TPersonStruct, NUdf::TPersonStructWithOptList, NUdf::TPersonStruct>; -static const auto TUPLE_OF_PERSON = std::make_tuple( +const auto TUPLE_OF_PERSON = std::make_tuple( STRUCT_PERSON_HITHCOCK_LIST, STRUCT_PERSON_JONNIE, STRUCT_PERSON_LOVECRAFT_LIST, STRUCT_PERSON_KING); -static const auto TUPLE_OF_PERSON_NO_LIST = std::make_tuple(STRUCT_PERSON_HITHCOCK_LIST, - STRUCT_PERSON_JONNIE, - STRUCT_PERSON_KING_LIST, - STRUCT_PERSON_KING); +const auto TUPLE_OF_PERSON_NO_LIST = std::make_tuple(STRUCT_PERSON_HITHCOCK_LIST, + STRUCT_PERSON_JONNIE, + STRUCT_PERSON_KING_LIST, + STRUCT_PERSON_KING); SIMPLE_UDF(TTupleOfPersonStruct, NUdfPersonTuple(ui32)) { Y_UNUSED(valueBuilder); @@ -569,7 +569,7 @@ SIMPLE_UDF(TTupleOfPersonStructNoList, NUdfPersonTuple(ui32)) { return NUdf::TUnboxedValuePod(std::move(boxed)); } -static const std::vector<NUdf::TPersonStructWithOptList> LIST_OF_STRUCT_PERSON = { +const std::vector<NUdf::TPersonStructWithOptList> LIST_OF_STRUCT_PERSON = { STRUCT_PERSON_HITHCOCK_LIST, STRUCT_PERSON_LOVECRAFT_LIST, STRUCT_PERSON_KING_LIST}; @@ -597,7 +597,7 @@ SIMPLE_UDF(TListOfPersonStructWithBrokenIndexToDict, NUdf::TListType<NUdf::TPers return NUdf::TUnboxedValuePod(std::move(boxed)); } -static std::array<const NUdf::TPersonStruct*, 3> DICT_DIGIT2PERSON_BROKEN_CONTENT_BY_INDEX = { +std::array<const NUdf::TPersonStruct*, 3> DICT_DIGIT2PERSON_BROKEN_CONTENT_BY_INDEX = { &STRUCT_PERSON_HITHCOCK, &STRUCT_PERSON_JONNIE, &STRUCT_PERSON_LOVECRAFT}; const ui32 DICT_DIGIT2PERSON_BROKEN_PERSON_INDEX = 1; const ui32 DICT_DIGIT2PERSON_BROKEN_STRUCT_INDEX = 2; diff --git a/yql/essentials/minikql/mkql_mem_info.cpp b/yql/essentials/minikql/mkql_mem_info.cpp index 8385d5801fc..e9640430fca 100644 --- a/yql/essentials/minikql/mkql_mem_info.cpp +++ b/yql/essentials/minikql/mkql_mem_info.cpp @@ -9,7 +9,7 @@ namespace NKikimr::NMiniKQL { namespace { #if !defined(NDEBUG) -static constexpr char COLLECT_STACK_TRACE_KEY[] = "YQL_MKQL_COLLECT_STACKTRACES_FOR_ALLOCATIONS"; +constexpr char COLLECT_STACK_TRACE_KEY[] = "YQL_MKQL_COLLECT_STACKTRACES_FOR_ALLOCATIONS"; bool ShouldCollectStackTracesForAllocations() { static bool Result = []() { diff --git a/yql/essentials/minikql/mkql_node_serialization.cpp b/yql/essentials/minikql/mkql_node_serialization.cpp index 7cbf673c55d..58512915b9a 100644 --- a/yql/essentials/minikql/mkql_node_serialization.cpp +++ b/yql/essentials/minikql/mkql_node_serialization.cpp @@ -16,18 +16,18 @@ namespace NKikimr::NMiniKQL { using namespace NDetail; namespace { -static const char KindMask = 0x0f; -static const char TypeMask = 0x7f; +const char KindMask = 0x0f; +const char TypeMask = 0x7f; static_assert(KindMask == char(TType::EKind::ReservedKind), "Kind should be encoded in 4 bit"); -static const char UserMarker1 = 0x10; -static const char UserMarker2 = 0x20; -static const char UserMarker3 = 0x40; -static const char TypeMarker = '\x80'; -static const char SystemMask = KindMask; -static const char CommandMask = '\xf0'; -static const ui32 NameRefMark = 0x01; -static const ui32 RequiresNextPass = 0x80000000U; -static const ui32 AllPassesDone = 0xFFFFFFFFU; +const char UserMarker1 = 0x10; +const char UserMarker2 = 0x20; +const char UserMarker3 = 0x40; +const char TypeMarker = '\x80'; +const char SystemMask = KindMask; +const char CommandMask = '\xf0'; +const ui32 NameRefMark = 0x01; +const ui32 RequiresNextPass = 0x80000000U; +const ui32 AllPassesDone = 0xFFFFFFFFU; enum class ESystemCommand { Begin = 0x10, diff --git a/yql/essentials/minikql/mkql_program_builder.cpp b/yql/essentials/minikql/mkql_program_builder.cpp index 2bd88d7a91c..4d9ff9f7248 100644 --- a/yql/essentials/minikql/mkql_program_builder.cpp +++ b/yql/essentials/minikql/mkql_program_builder.cpp @@ -240,7 +240,7 @@ bool ReduceOptionalElements(const TType* type, const TArrayRef<const ui32>& test return multiOptional; } -static std::vector<TType*> ValidateBlockItems(const TArrayRef<TType* const>& wideComponents, bool unwrap) { +std::vector<TType*> ValidateBlockItems(const TArrayRef<TType* const>& wideComponents, bool unwrap) { MKQL_ENSURE(!wideComponents.empty(), "Expected at least one column"); std::vector<TType*> items; items.reserve(wideComponents.size()); diff --git a/yql/essentials/minikql/mkql_type_builder.cpp b/yql/essentials/minikql/mkql_type_builder.cpp index ca47c9b83b8..a3530103714 100644 --- a/yql/essentials/minikql/mkql_type_builder.cpp +++ b/yql/essentials/minikql/mkql_type_builder.cpp @@ -26,7 +26,7 @@ namespace NKikimr { namespace { -static const TString UdfName("UDF"); +const TString UdfName("UDF"); class TPrefixLogger: public NUdf::ILogger { public: diff --git a/yql/essentials/minikql/protobuf_udf/value_builder.cpp b/yql/essentials/minikql/protobuf_udf/value_builder.cpp index 43e2cc9b478..321d33b7e8d 100644 --- a/yql/essentials/minikql/protobuf_udf/value_builder.cpp +++ b/yql/essentials/minikql/protobuf_udf/value_builder.cpp @@ -74,7 +74,7 @@ TUnboxedValue TProtobufSerialize::Run( namespace { -static TUnboxedValuePod CreateEnumValue( +TUnboxedValuePod CreateEnumValue( const IValueBuilder* valueBuilder, const NProtoBuf::EnumValueDescriptor* desc, const EEnumFormat format, @@ -97,7 +97,7 @@ static TUnboxedValuePod CreateEnumValue( Y_ENSURE(false, "Unreachable"); } -static TUnboxedValuePod CreateSingleField( +TUnboxedValuePod CreateSingleField( const IValueBuilder* valueBuilder, const Message& proto, const FieldDescriptor* fd, @@ -144,7 +144,7 @@ static TUnboxedValuePod CreateSingleField( return TUnboxedValuePod(); } -static TUnboxedValuePod CreateDefaultValue( +TUnboxedValuePod CreateDefaultValue( const IValueBuilder* valueBuilder, const FieldDescriptor* fd, const TProtoInfo& info, @@ -179,7 +179,7 @@ static TUnboxedValuePod CreateDefaultValue( #undef DEFAULT_TO_VALUE } -static TUnboxedValuePod CreateRepeatedField( +TUnboxedValuePod CreateRepeatedField( const IValueBuilder* valueBuilder, const Message& proto, const FieldDescriptor* fd, @@ -239,7 +239,7 @@ static TUnboxedValuePod CreateRepeatedField( return list.Release(); } -static TUnboxedValuePod CreateMapField( +TUnboxedValuePod CreateMapField( const IValueBuilder* valueBuilder, const Message& proto, const FieldDescriptor* fd, diff --git a/yql/essentials/public/udf/udf_data_type.cpp b/yql/essentials/public/udf/udf_data_type.cpp index e20a829802f..db96a88e7ac 100644 --- a/yql/essentials/public/udf/udf_data_type.cpp +++ b/yql/essentials/public/udf/udf_data_type.cpp @@ -32,7 +32,7 @@ ui8 GetDecimalWidth(EDataTypeFeatures features) { #define NO {ECastOptions::Impossible} #define UN {ECastOptions::Impossible | ECastOptions::Undefined} -static const std::array<std::array<std::optional<TCastResultOptions>, DataSlotCount>, DataSlotCount> CastResultsTable = {{ +const std::array<std::array<std::optional<TCastResultOptions>, DataSlotCount>, DataSlotCount> CastResultsTable = {{ // Bool, Int8 ----integrals---- Uint64 Floats, Strings, YJsons, Uuid, DateTimes, Interval, TzDateTimes, Decimal, DyNumber, JsonDocument {{OK, OK, OK, OK, OK, OK, OK, OK, OK, OK, OK, OK, OK, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO, NO}}, // Bool diff --git a/yql/essentials/sql/v1/sql_query.cpp b/yql/essentials/sql/v1/sql_query.cpp index 75f09d2a3b2..3f1e89091e1 100644 --- a/yql/essentials/sql/v1/sql_query.cpp +++ b/yql/essentials/sql/v1/sql_query.cpp @@ -4587,7 +4587,7 @@ TNodePtr TSqlQuery::Build(const std::vector<::NSQLv1Generated::TRule_sql_stmt_co } namespace { -static bool BuildColumnFeatures(std::map<TString, TDeferredAtom>& result, const TRule_column_schema& columnSchema, const NYql::TPosition& pos, TSqlTranslation& translation) { +bool BuildColumnFeatures(std::map<TString, TDeferredAtom>& result, const TRule_column_schema& columnSchema, const NYql::TPosition& pos, TSqlTranslation& translation) { const TString columnName(Id(columnSchema.GetRule_an_id_schema1(), translation)); TString columnType; diff --git a/yql/essentials/sql/v1/sql_translation.cpp b/yql/essentials/sql/v1/sql_translation.cpp index ed1508d0fa3..73e178bf7ff 100644 --- a/yql/essentials/sql/v1/sql_translation.cpp +++ b/yql/essentials/sql/v1/sql_translation.cpp @@ -5864,7 +5864,7 @@ bool TSqlTranslation::ParseViewQuery( namespace { -static TString GetLambdaText(TTranslation& ctx, TContext& Ctx, const TRule_lambda_or_parameter& lambdaOrParameter) { +TString GetLambdaText(TTranslation& ctx, TContext& Ctx, const TRule_lambda_or_parameter& lambdaOrParameter) { static const TString StatementSeparator = ";\n"; TVector<TString> statements; diff --git a/yql/essentials/types/binary_json/ut_benchmark/write.cpp b/yql/essentials/types/binary_json/ut_benchmark/write.cpp index 51efaee89c3..1a9712ae9f4 100644 --- a/yql/essentials/types/binary_json/ut_benchmark/write.cpp +++ b/yql/essentials/types/binary_json/ut_benchmark/write.cpp @@ -16,7 +16,7 @@ using namespace NKikimr::NBinaryJson; namespace { -static ui64 seed = 0; +ui64 seed = 0; NJson::TJsonValue GetTestJson(ui64 depth = 10, ui64 nChildren = 2) { NJson::TJsonValue value; @@ -35,7 +35,7 @@ TString GetTestJsonString() { return NJson::WriteJson(GetTestJson(3, 50)); } -static void BenchWriteSimdJson(benchmark::State& state) { +void BenchWriteSimdJson(benchmark::State& state) { TString value = GetTestJsonString(); TStringBuf buf(value); for (auto _ : state) { diff --git a/yql/essentials/udfs/common/datetime2/datetime_udf.cpp b/yql/essentials/udfs/common/datetime2/datetime_udf.cpp index 1bfae7df517..f3373697d7a 100644 --- a/yql/essentials/udfs/common/datetime2/datetime_udf.cpp +++ b/yql/essentials/udfs/common/datetime2/datetime_udf.cpp @@ -139,15 +139,15 @@ TString BuildBoundaryPolyArgs(ESecondPolyArg secondArg = ESecondPolyArg::None) { } template <typename Type> -static void PrintTypeAlternatives(NUdf::IFunctionTypeInfoBuilder& builder, - ITypeInfoHelper::TPtr typeInfoHelper, TStringBuilder& strBuilder) +void PrintTypeAlternatives(NUdf::IFunctionTypeInfoBuilder& builder, + ITypeInfoHelper::TPtr typeInfoHelper, TStringBuilder& strBuilder) { TTypePrinter(*typeInfoHelper, builder.SimpleType<Type>()).Out(strBuilder.Out); } template <typename Type, typename Head, typename... Tail> -static void PrintTypeAlternatives(NUdf::IFunctionTypeInfoBuilder& builder, - ITypeInfoHelper::TPtr typeInfoHelper, TStringBuilder& strBuilder) +void PrintTypeAlternatives(NUdf::IFunctionTypeInfoBuilder& builder, + ITypeInfoHelper::TPtr typeInfoHelper, TStringBuilder& strBuilder) { PrintTypeAlternatives<Type>(builder, typeInfoHelper, strBuilder); strBuilder << " or "; @@ -155,8 +155,8 @@ static void PrintTypeAlternatives(NUdf::IFunctionTypeInfoBuilder& builder, } template <typename... Types> -static void SetInvalidTypeError(NUdf::IFunctionTypeInfoBuilder& builder, - ITypeInfoHelper::TPtr typeInfoHelper, const TType* argType) +void SetInvalidTypeError(NUdf::IFunctionTypeInfoBuilder& builder, + ITypeInfoHelper::TPtr typeInfoHelper, const TType* argType) { ::TStringBuilder sb; sb << "Invalid argument type: got "; @@ -167,34 +167,34 @@ static void SetInvalidTypeError(NUdf::IFunctionTypeInfoBuilder& builder, builder.SetError(sb); } -static void SetResourceExpectedError(NUdf::IFunctionTypeInfoBuilder& builder, - ITypeInfoHelper::TPtr typeInfoHelper, const TType* argType) +void SetResourceExpectedError(NUdf::IFunctionTypeInfoBuilder& builder, + ITypeInfoHelper::TPtr typeInfoHelper, const TType* argType) { SetInvalidTypeError< TResource<TMResourceName>, TResource<TM64ResourceName>>(builder, typeInfoHelper, argType); } -static void SetIntervalExpectedError(NUdf::IFunctionTypeInfoBuilder& builder, - ITypeInfoHelper::TPtr typeInfoHelper, const TType* argType) +void SetIntervalExpectedError(NUdf::IFunctionTypeInfoBuilder& builder, + ITypeInfoHelper::TPtr typeInfoHelper, const TType* argType) { SetInvalidTypeError<TInterval, TInterval64>(builder, typeInfoHelper, argType); } template <const char* TResourceName> -static void PrintTagAlternatives(TStringBuilder& strBuilder) { +void PrintTagAlternatives(TStringBuilder& strBuilder) { strBuilder << "'" << TResourceName << "'"; } template <const char* TResourceName, const char* Head, const char*... Tail> -static void PrintTagAlternatives(TStringBuilder& strBuilder) { +void PrintTagAlternatives(TStringBuilder& strBuilder) { PrintTagAlternatives<TResourceName>(strBuilder); strBuilder << " or "; PrintTagAlternatives<Head, Tail...>(strBuilder); } -static void SetUnexpectedTagError(NUdf::IFunctionTypeInfoBuilder& builder, - TStringRef tag) +void SetUnexpectedTagError(NUdf::IFunctionTypeInfoBuilder& builder, + TStringRef tag) { ::TStringBuilder sb; sb << "Unexpected Resource tag: got '" << tag << "', but "; @@ -2873,11 +2873,11 @@ struct PrintNDigits { // Format -static constexpr size_t OSize = sizeof("+0000") - 1; -static constexpr size_t CSize = sizeof("+00:00") - 1; +constexpr size_t OSize = sizeof("+0000") - 1; +constexpr size_t CSize = sizeof("+00:00") - 1; template <bool WriteOffsetWithColon> -static size_t PrintUTCOffset(char* out) { +size_t PrintUTCOffset(char* out) { if constexpr (WriteOffsetWithColon) { std::memcpy(out, "+00:00", CSize); return CSize; @@ -2888,7 +2888,7 @@ static size_t PrintUTCOffset(char* out) { } template <bool WriteOffsetWithColon> -static size_t PrintTzOffset(char* out, i32 offset) { +size_t PrintTzOffset(char* out, i32 offset) { Y_ENSURE(offset != 0); *out++ = offset > 0 ? '+' : '-'; offset = std::abs(offset); diff --git a/yql/essentials/udfs/common/file/file_udf.cpp b/yql/essentials/udfs/common/file/file_udf.cpp index bbf5381e99a..c1d2c964671 100644 --- a/yql/essentials/udfs/common/file/file_udf.cpp +++ b/yql/essentials/udfs/common/file/file_udf.cpp @@ -169,7 +169,7 @@ struct TypeToTypeName<TJson> { } // namespace NHelper -static const ui64 TAKE_UNLIM = -1; +const ui64 TAKE_UNLIM = -1; bool SkipElements(IBoxedValue& iter, ui64 skip) { for (; skip > 0; --skip) { diff --git a/yql/essentials/udfs/common/python/bindings/py_lazy_mkql_list.cpp b/yql/essentials/udfs/common/python/bindings/py_lazy_mkql_list.cpp index d93861812d4..2061c3cd518 100644 --- a/yql/essentials/udfs/common/python/bindings/py_lazy_mkql_list.cpp +++ b/yql/essentials/udfs/common/python/bindings/py_lazy_mkql_list.cpp @@ -18,7 +18,7 @@ using namespace NKikimr; namespace NPython { namespace { -static ui64 CalculateIteratorLength(PyObject* iter, const TPyCastContext::TPtr& castCtx) +ui64 CalculateIteratorLength(PyObject* iter, const TPyCastContext::TPtr& castCtx) { PyObject* item; @@ -35,7 +35,7 @@ static ui64 CalculateIteratorLength(PyObject* iter, const TPyCastContext::TPtr& return length; } -static bool IsIteratorHasItems(PyObject* iter, const TPyCastContext::TPtr& castCtx) +bool IsIteratorHasItems(PyObject* iter, const TPyCastContext::TPtr& castCtx) { if (const TPyObjectPtr item = PyIter_Next(iter)) { return true; diff --git a/yql/essentials/udfs/common/python/bindings/py_void.cpp b/yql/essentials/udfs/common/python/bindings/py_void.cpp index 697c2f593f4..a9f0fcc725b 100644 --- a/yql/essentials/udfs/common/python/bindings/py_void.cpp +++ b/yql/essentials/udfs/common/python/bindings/py_void.cpp @@ -9,11 +9,11 @@ using namespace NKikimr; namespace NPython { namespace { -static PyObject* VoidRepr(PyObject*) { +PyObject* VoidRepr(PyObject*) { return PyRepr("yql.Void").Release(); } -static void VoidDealloc(PyObject*) { +void VoidDealloc(PyObject*) { Py_FatalError("Deallocating yql.Void"); } diff --git a/yql/essentials/udfs/common/reservoir_sampling/reservoir_udf.cpp b/yql/essentials/udfs/common/reservoir_sampling/reservoir_udf.cpp index d113d09658b..91d43de0dbd 100644 --- a/yql/essentials/udfs/common/reservoir_sampling/reservoir_udf.cpp +++ b/yql/essentials/udfs/common/reservoir_sampling/reservoir_udf.cpp @@ -15,14 +15,14 @@ using namespace NUdf; namespace { -static const auto CreateName = TStringRef::Of("Create"); -static const auto AddName = TStringRef::Of("Add"); -static const auto SerializeName = TStringRef::Of("Serialize"); -static const auto DeserializeName = TStringRef::Of("Deserialize"); -static const auto MergeName = TStringRef::Of("Merge"); -static const auto GetResultValueName = TStringRef::Of("GetResultValue"); -static const auto GetResultListName = TStringRef::Of("GetResultList"); -static const auto ResourcePrefix = TStringRef::Of("ReservoirSampling_"); +const auto CreateName = TStringRef::Of("Create"); +const auto AddName = TStringRef::Of("Add"); +const auto SerializeName = TStringRef::Of("Serialize"); +const auto DeserializeName = TStringRef::Of("Deserialize"); +const auto MergeName = TStringRef::Of("Merge"); +const auto GetResultValueName = TStringRef::Of("GetResultValue"); +const auto GetResultListName = TStringRef::Of("GetResultList"); +const auto ResourcePrefix = TStringRef::Of("ReservoirSampling_"); using namespace NReservoirSampling; diff --git a/yql/essentials/udfs/common/set/set_udf.cpp b/yql/essentials/udfs/common/set/set_udf.cpp index 5eaae14cfa8..74a109abeb2 100644 --- a/yql/essentials/udfs/common/set/set_udf.cpp +++ b/yql/essentials/udfs/common/set/set_udf.cpp @@ -363,13 +363,13 @@ UDF_TYPE_ID_MAP(MAKE_RESOURCE) setType = builder.Resource(SetResourceName##slot); \ break; -static const auto CreateName = TStringRef::Of("Create"); -static const auto AddValueName = TStringRef::Of("AddValue"); -static const auto WasChangedName = TStringRef::Of("WasChanged"); // must be used right after AddValue -static const auto SerializeName = TStringRef::Of("Serialize"); -static const auto DeserializeName = TStringRef::Of("Deserialize"); -static const auto MergeName = TStringRef::Of("Merge"); -static const auto GetResultName = TStringRef::Of("GetResult"); +const auto CreateName = TStringRef::Of("Create"); +const auto AddValueName = TStringRef::Of("AddValue"); +const auto WasChangedName = TStringRef::Of("WasChanged"); // must be used right after AddValue +const auto SerializeName = TStringRef::Of("Serialize"); +const auto DeserializeName = TStringRef::Of("Deserialize"); +const auto MergeName = TStringRef::Of("Merge"); +const auto GetResultName = TStringRef::Of("GetResult"); class TSetModule: public IUdfModule { public: diff --git a/yql/essentials/udfs/common/string/string_udf.cpp b/yql/essentials/udfs/common/string/string_udf.cpp index 603d249d0d0..08781ce98ee 100644 --- a/yql/essentials/udfs/common/string/string_udf.cpp +++ b/yql/essentials/udfs/common/string/string_udf.cpp @@ -521,7 +521,7 @@ struct TContainsKernelExec: public TBinaryKernelExec<TContainsKernelExec> { END_SIMPLE_ARROW_UDF(TContains, TContainsKernelExec::Do); -static bool IgnoreCaseComparator(char a, char b) { +bool IgnoreCaseComparator(char a, char b) { return AsciiToUpper(a) == AsciiToUpper(b); } @@ -810,7 +810,7 @@ SIMPLE_STRICT_UDF_WITH_OPTIONAL_ARGS(TSubstring, char*(TAutoMap<char*>, TOptiona using TTmpVector = TSmallVec<TUnboxedValue, TUnboxedValue::TAllocator>; template <typename TIt> -static void SplitToListImpl( +void SplitToListImpl( const IValueBuilder* valueBuilder, const TUnboxedValue& input, const std::string_view::const_iterator from, @@ -821,7 +821,7 @@ static void SplitToListImpl( } } template <typename TIt> -static void SplitToListImpl( +void SplitToListImpl( const IValueBuilder* valueBuilder, const TUnboxedValue& input, const std::string_view::const_iterator from, @@ -1038,7 +1038,7 @@ STRING_TWO_ARGS_UDF_MAP_DEPRECATED_2025_02(STRING_TWO_ARGS_UDF_DEPRECATED_2025_0 STRING_ASCII_CMP_IGNORE_CASE_UDF_MAP(STRING_ASCII_CMP_IGNORE_CASE_UDF) IS_ASCII_UDF_MAP(IS_ASCII_UDF) -static constexpr ui64 padLim = 1000000; +constexpr ui64 padLim = 1000000; STRING_STREAM_PAD_FORMATTER_UDF_MAP(STRING_STREAM_PAD_FORMATTER_UDF) STRING_STREAM_NUM_FORMATTER_UDF_MAP(STRING_STREAM_NUM_FORMATTER_UDF) STRING_STREAM_TEXT_FORMATTER_UDF_MAP(STRING_STREAM_TEXT_FORMATTER_UDF) diff --git a/yql/essentials/udfs/common/top/top_udf.cpp b/yql/essentials/udfs/common/top/top_udf.cpp index 35371058225..806deeac9f8 100644 --- a/yql/essentials/udfs/common/top/top_udf.cpp +++ b/yql/essentials/udfs/common/top/top_udf.cpp @@ -752,12 +752,12 @@ RESOURCE_GENERIC(true, true) } \ } -static const auto CreateName = TStringRef::Of("Create"); -static const auto AddValueName = TStringRef::Of("AddValue"); -static const auto SerializeName = TStringRef::Of("Serialize"); -static const auto DeserializeName = TStringRef::Of("Deserialize"); -static const auto MergeName = TStringRef::Of("Merge"); -static const auto GetResultName = TStringRef::Of("GetResult"); +const auto CreateName = TStringRef::Of("Create"); +const auto AddValueName = TStringRef::Of("AddValue"); +const auto SerializeName = TStringRef::Of("Serialize"); +const auto DeserializeName = TStringRef::Of("Deserialize"); +const auto MergeName = TStringRef::Of("Merge"); +const auto GetResultName = TStringRef::Of("GetResult"); class TTopModule: public IUdfModule { public: diff --git a/yql/essentials/udfs/common/topfreq/static/topfreq_udf.h b/yql/essentials/udfs/common/topfreq/static/topfreq_udf.h index a5fc9ed5f5c..bfeabebbff5 100644 --- a/yql/essentials/udfs/common/topfreq/static/topfreq_udf.h +++ b/yql/essentials/udfs/common/topfreq/static/topfreq_udf.h @@ -204,12 +204,12 @@ UDF_TYPE_ID_MAP(MAKE_RESOURCE) topFreqType = builder.Resource(TopFreqResourceName##slot); \ break; -static const auto CreateName = TStringRef::Of("TopFreq_Create"); -static const auto AddValueName = TStringRef::Of("TopFreq_AddValue"); -static const auto SerializeName = TStringRef::Of("TopFreq_Serialize"); -static const auto DeserializeName = TStringRef::Of("TopFreq_Deserialize"); -static const auto MergeName = TStringRef::Of("TopFreq_Merge"); -static const auto GetName = TStringRef::Of("TopFreq_Get"); +const auto CreateName = TStringRef::Of("TopFreq_Create"); +const auto AddValueName = TStringRef::Of("TopFreq_AddValue"); +const auto SerializeName = TStringRef::Of("TopFreq_Serialize"); +const auto DeserializeName = TStringRef::Of("TopFreq_Deserialize"); +const auto MergeName = TStringRef::Of("TopFreq_Merge"); +const auto GetName = TStringRef::Of("TopFreq_Get"); class TTopFreqModule: public IUdfModule { public: diff --git a/yql/essentials/udfs/common/unicode_base/lib/unicode_base_udf.h b/yql/essentials/udfs/common/unicode_base/lib/unicode_base_udf.h index f1ac3c7919a..38de0533524 100644 --- a/yql/essentials/udfs/common/unicode_base/lib/unicode_base_udf.h +++ b/yql/essentials/udfs/common/unicode_base/lib/unicode_base_udf.h @@ -646,7 +646,7 @@ DEFINE_UTF8_OPERATION_BIN_STRICT(TryToUint64, TToUint64Converter</*strict=*/true using TTmpVector = TSmallVec<TUnboxedValue, TUnboxedValue::TAllocator>; template <typename TIt> -static void SplitToListImpl( +void SplitToListImpl( const IValueBuilder* valueBuilder, const TUnboxedValue& input, const std::string_view::const_iterator from, @@ -658,7 +658,7 @@ static void SplitToListImpl( } template <typename TIt> -static void SplitToListImpl( +void SplitToListImpl( const IValueBuilder* valueBuilder, const TUnboxedValue& input, const TUtf32String::const_iterator start, @@ -682,7 +682,7 @@ static void SplitToListImpl( } template <typename TIt, typename TStrIt> -static void SplitToListImpl( +void SplitToListImpl( const IValueBuilder* valueBuilder, const TUnboxedValue& input, const TStrIt from, diff --git a/yql/essentials/udfs/common/vector/vector_udf.cpp b/yql/essentials/udfs/common/vector/vector_udf.cpp index 6b95ca0088c..0fba3cdf23e 100644 --- a/yql/essentials/udfs/common/vector/vector_udf.cpp +++ b/yql/essentials/udfs/common/vector/vector_udf.cpp @@ -94,10 +94,10 @@ private: } }; -static const auto CreateName = TStringRef::Of("Create"); -static const auto EmplaceName = TStringRef::Of("Emplace"); -static const auto SwapName = TStringRef::Of("Swap"); -static const auto GetResultName = TStringRef::Of("GetResult"); +const auto CreateName = TStringRef::Of("Create"); +const auto EmplaceName = TStringRef::Of("Emplace"); +const auto SwapName = TStringRef::Of("Swap"); +const auto GetResultName = TStringRef::Of("GetResult"); class TVectorModule: public IUdfModule { public: diff --git a/yql/essentials/utils/log/tls_backend.cpp b/yql/essentials/utils/log/tls_backend.cpp index d25ee88170a..8071fefc032 100644 --- a/yql/essentials/utils/log/tls_backend.cpp +++ b/yql/essentials/utils/log/tls_backend.cpp @@ -5,6 +5,7 @@ namespace NYql::NLog { namespace { +// NOLINTNEXTLINE(readability-static-definition-in-anonymous-namespace) Y_POD_STATIC_THREAD(TLogBackend*) CurrentBackend; } // namespace diff --git a/yql/essentials/utils/utf8.cpp b/yql/essentials/utils/utf8.cpp index 0caa5252882..e1db600f68c 100644 --- a/yql/essentials/utils/utf8.cpp +++ b/yql/essentials/utils/utf8.cpp @@ -44,7 +44,7 @@ struct TUtf8Ranges { // see https://lemire.me/blog/2018/05/09/how-quickly-can-you-check-that-a-string-is-valid-unicode-utf-8 // NOLINTBEGIN(modernize-use-designated-initializers) // clang-format off -inline static const std::vector<TUtf8Ranges> Utf8Ranges = { +inline const std::vector<TUtf8Ranges> Utf8Ranges = { { 1, { {0x00, 0x7f}, {0x00, 0x00}, {0x00, 0x00}, {0x00, 0x00}, } }, { 2, { {0xc2, 0xdf}, {0x80, 0xbf}, {0x00, 0x00}, {0x00, 0x00}, } }, { 3, { {0xe0, 0xe0}, {0xa0, 0xbf}, {0x80, 0xbf}, {0x00, 0x00}, } }, |
