aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorgvit <gvit@ydb.tech>2023-02-14 13:56:07 +0300
committergvit <gvit@ydb.tech>2023-02-14 13:56:07 +0300
commite0b2154fab00a08c07439524ad258e459b7bc4d3 (patch)
tree42c95f6b03c38041e2fda34058ef1d6eec94add0
parent06041b424615b3174b87232ea82ef4fc1dfbdb26 (diff)
downloadydb-e0b2154fab00a08c07439524ad258e459b7bc4d3.tar.gz
remove set enable mvcc in kqp tests
-rw-r--r--ydb/core/kqp/ut/effects/kqp_immediate_effects_ut.cpp38
-rw-r--r--ydb/core/kqp/ut/indexes/kqp_indexes_multishard_ut.cpp47
-rw-r--r--ydb/core/kqp/ut/indexes/kqp_indexes_ut.cpp66
-rw-r--r--ydb/core/kqp/ut/query/kqp_limits_ut.cpp36
-rw-r--r--ydb/core/kqp/ut/query/kqp_query_ut.cpp6
-rw-r--r--ydb/core/kqp/ut/tx/kqp_mvcc_ut.cpp12
-rw-r--r--ydb/core/kqp/ut/tx/kqp_tx_ut.cpp20
7 files changed, 23 insertions, 202 deletions
diff --git a/ydb/core/kqp/ut/effects/kqp_immediate_effects_ut.cpp b/ydb/core/kqp/ut/effects/kqp_immediate_effects_ut.cpp
index 9fa4704b1d..86c40267f4 100644
--- a/ydb/core/kqp/ut/effects/kqp_immediate_effects_ut.cpp
+++ b/ydb/core/kqp/ut/effects/kqp_immediate_effects_ut.cpp
@@ -32,8 +32,6 @@ namespace {
Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(Upsert) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -90,8 +88,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(UpsertDuplicates) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -125,8 +121,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(UpsertExistingKey) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -173,8 +167,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(Replace) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -231,8 +223,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(ReplaceDuplicates) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -266,8 +256,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(ReplaceExistingKey) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -314,8 +302,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(Insert) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -372,8 +358,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(InsertDuplicates) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -401,8 +385,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(InsertExistingKey) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -429,8 +411,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(UpdateOn) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -483,8 +463,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(Delete) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -533,8 +511,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(UpdateAfterUpsert) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -564,8 +540,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(DeleteAfterUpsert) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -604,8 +578,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(UpdateAfterInsert) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -635,8 +607,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(DeleteAfterInsert) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -676,8 +646,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(UpsertAfterInsert) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -703,8 +671,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(UpsertAfterInsertWithIndex) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -780,8 +746,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(DeleteOnAfterInsertWithIndex) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -843,8 +807,6 @@ Y_UNIT_TEST_SUITE(KqpImmediateEffects) {
Y_UNIT_TEST(MultipleEffectsWithIndex) {
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetEnableKqpImmediateEffects(true);
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
diff --git a/ydb/core/kqp/ut/indexes/kqp_indexes_multishard_ut.cpp b/ydb/core/kqp/ut/indexes/kqp_indexes_multishard_ut.cpp
index 0b0164ce03..1b2ea03c11 100644
--- a/ydb/core/kqp/ut/indexes/kqp_indexes_multishard_ut.cpp
+++ b/ydb/core/kqp/ut/indexes/kqp_indexes_multishard_ut.cpp
@@ -382,15 +382,13 @@ Y_UNIT_TEST_SUITE(KqpMultishardIndex) {
}
- Y_UNIT_TEST_TWIN(DataColumnUpsertMixedSemantic, WithMvcc) {
+ Y_UNIT_TEST_TWIN(DataColumnUpsertMixedSemantic, StreamLookup) {
NKikimrConfig::TAppConfig appConfig;
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(WithMvcc);
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(WithMvcc);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(StreamLookup);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(StreamLookup);
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(WithMvcc)
- .SetEnableMvccSnapshotReads(WithMvcc)
.SetAppConfig(appConfig)
.SetKqpSettings({setting});
@@ -433,15 +431,13 @@ Y_UNIT_TEST_SUITE(KqpMultishardIndex) {
}
}
- Y_UNIT_TEST_TWIN(DataColumnWriteNull, WithMvcc) {
+ Y_UNIT_TEST_TWIN(DataColumnWriteNull, StreamLookup) {
NKikimrConfig::TAppConfig appConfig;
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(WithMvcc);
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(WithMvcc);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(StreamLookup);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(StreamLookup);
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(WithMvcc)
- .SetEnableMvccSnapshotReads(WithMvcc)
.SetAppConfig(appConfig)
.SetKqpSettings({setting});
@@ -518,15 +514,13 @@ Y_UNIT_TEST_SUITE(KqpMultishardIndex) {
}
}
- Y_UNIT_TEST_TWIN(DataColumnWrite, WithMvcc) {
+ Y_UNIT_TEST_TWIN(DataColumnWrite, StreamLookup) {
NKikimrConfig::TAppConfig appConfig;
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(WithMvcc);
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(WithMvcc);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(StreamLookup);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(StreamLookup);
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(WithMvcc)
- .SetEnableMvccSnapshotReads(WithMvcc)
.SetAppConfig(appConfig)
.SetKqpSettings({setting});
@@ -921,15 +915,13 @@ Y_UNIT_TEST_SUITE(KqpMultishardIndex) {
}
}
- Y_UNIT_TEST_TWIN(DataColumnSelect, WithMvcc) {
+ Y_UNIT_TEST_TWIN(DataColumnSelect, StreamLookup) {
NKikimrConfig::TAppConfig appConfig;
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(WithMvcc);
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(WithMvcc);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(StreamLookup);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(StreamLookup);
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(WithMvcc)
- .SetEnableMvccSnapshotReads(WithMvcc)
.SetAppConfig(appConfig)
.SetKqpSettings({setting});
@@ -1021,15 +1013,13 @@ Y_UNIT_TEST_SUITE(KqpMultishardIndex) {
}
}
- Y_UNIT_TEST_TWIN(DuplicateUpsert, WithMvcc) {
+ Y_UNIT_TEST_TWIN(DuplicateUpsert, StreamLookup) {
NKikimrConfig::TAppConfig appConfig;
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(WithMvcc);
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(WithMvcc);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(StreamLookup);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(StreamLookup);
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(WithMvcc)
- .SetEnableMvccSnapshotReads(WithMvcc)
.SetAppConfig(appConfig)
.SetKqpSettings({setting});
@@ -1060,13 +1050,12 @@ Y_UNIT_TEST_SUITE(KqpMultishardIndex) {
}
}
- Y_UNIT_TEST_TWIN(SortByPk, WithMvcc) {
+ Y_UNIT_TEST_TWIN(SortByPk, StreamLookup) {
NKikimrConfig::TAppConfig appConfig;
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(WithMvcc);
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(WithMvcc);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(StreamLookup);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(StreamLookup);
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(WithMvcc)
.SetAppConfig(appConfig);
TKikimrRunner kikimr(serverSettings);
diff --git a/ydb/core/kqp/ut/indexes/kqp_indexes_ut.cpp b/ydb/core/kqp/ut/indexes/kqp_indexes_ut.cpp
index d89306dcbd..ccba0a35eb 100644
--- a/ydb/core/kqp/ut/indexes/kqp_indexes_ut.cpp
+++ b/ydb/core/kqp/ut/indexes/kqp_indexes_ut.cpp
@@ -109,8 +109,6 @@ Y_UNIT_TEST_SUITE(KqpIndexMetadata) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
@@ -163,8 +161,6 @@ Y_UNIT_TEST_SUITE(KqpIndexMetadata) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
@@ -335,8 +331,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(SelectConcurentTX) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -416,8 +410,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(SelectConcurentTX2) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -497,8 +489,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(UpsertWithoutExtraNullDelete) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -708,8 +698,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(UpsertWithNullKeysSimple) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({ setting });
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -804,8 +792,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(UpsertWithNullKeysComplex) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -942,8 +928,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(SecondaryIndexUpsert1DeleteUpdate) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -1130,8 +1114,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(SecondaryIndexUpsert2Update) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -1221,8 +1203,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(SecondaryIndexUpdateOnUsingIndex) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -1288,8 +1268,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(SecondaryIndexSelectUsingScripting) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -1329,8 +1307,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(SecondaryIndexOrderBy) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -1627,8 +1603,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(SecondaryIndexOrderBy2) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -1787,8 +1761,6 @@ Y_UNIT_TEST_SUITE(KqpIndexes) {
Y_UNIT_TEST(SecondaryIndexReplace) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -1866,8 +1838,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(SecondaryIndexInsert1) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -1912,8 +1882,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(MultipleSecondaryIndex) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -1977,8 +1945,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(MultipleSecondaryIndexWithSameComulns) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -2315,8 +2281,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(SecondaryIndexWithPrimaryKeySameComulns) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -2589,8 +2553,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(SecondaryIndexUsingInJoin) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -2773,8 +2735,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(SecondaryIndexUsingInJoin2) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -2908,8 +2868,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(ForbidViewModification) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -2996,8 +2954,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(ForbidDirectIndexTableCreation) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -3047,8 +3003,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(DuplicateUpsertInterleave) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -3085,8 +3039,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(DuplicateUpsertInterleaveParams) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -3173,8 +3125,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(MultipleModifications) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -3224,8 +3174,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
kqpSetting.SetValue("1");
auto settings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({kqpSetting});
TKikimrRunner kikimr(settings);
auto db = kikimr.GetTableClient();
@@ -3308,8 +3256,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
kqpSetting.SetValue("1");
auto settings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({kqpSetting});
TKikimrRunner kikimr(settings);
auto db = kikimr.GetTableClient();
@@ -3366,8 +3312,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
setting.SetName("_KqpYqlSyntaxVersion");
setting.SetValue("1");
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -3450,8 +3394,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
setting.SetName("_KqpYqlSyntaxVersion");
setting.SetValue("1");
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
auto db = kikimr.GetTableClient();
@@ -3626,8 +3568,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(DeleteByIndex) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
@@ -3717,8 +3657,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(UpdateDeletePlan) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
@@ -3775,8 +3713,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(UpsertNoIndexColumns) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
@@ -3827,8 +3763,6 @@ R"([[#;#;["Primary1"];[41u]];[["Secondary2"];[2u];["Primary2"];[42u]];[["Seconda
Y_UNIT_TEST(UpdateIndexSubsetPk) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings);
diff --git a/ydb/core/kqp/ut/query/kqp_limits_ut.cpp b/ydb/core/kqp/ut/query/kqp_limits_ut.cpp
index 20ec0cc0b6..89f9d7323f 100644
--- a/ydb/core/kqp/ut/query/kqp_limits_ut.cpp
+++ b/ydb/core/kqp/ut/query/kqp_limits_ut.cpp
@@ -359,42 +359,6 @@ Y_UNIT_TEST_SUITE(KqpLimits) {
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS, result.GetIssues().ToString());
}
- Y_UNIT_TEST(TotalReadSizeLimit) {
- NKikimrConfig::TAppConfig appConfig;
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(false);
-
- auto& queryLimits = *appConfig.MutableTableServiceConfig()->MutableQueryLimits();
- queryLimits.MutablePhaseLimits()->SetTotalReadSizeLimitBytes(100'000'000);
-
- auto serverSettings = TKikimrSettings()
- .SetAppConfig(appConfig)
- .SetEnableMvccSnapshotReads(false);
-
- TKikimrRunner kikimr(serverSettings);
- CreateLargeTable(kikimr, 20, 10, 1'000'000, 1);
-
- auto db = kikimr.GetTableClient();
- auto session = db.CreateSession().GetValueSync().GetSession();
-
- auto result = session.ExecuteDataQuery(Q_(R"(
- SELECT Key, KeyText, SUBSTRING(DataText, 0, 10) AS DataText
- FROM `/Root/LargeTable`;
- )"), TTxControl::BeginTx().CommitTx()).ExtractValueSync();
- result.GetIssues().PrintTo(Cerr);
- UNIT_ASSERT_VALUES_EQUAL(result.GetStatus(), EStatus::PRECONDITION_FAILED);
- UNIT_ASSERT(HasIssue(result.GetIssues(), NYql::TIssuesIds::KIKIMR_PRECONDITION_FAILED,
- [] (const NYql::TIssue& issue) {
- return issue.GetMessage().Contains("Transaction total read size");
- }));
-
- result = session.ExecuteDataQuery(Q_(R"(
- SELECT Key, KeyText, SUBSTRING(DataText, 0, 10) AS DataText
- FROM `/Root/LargeTable`
- WHERE Key < 4000000;
- )"), TTxControl::BeginTx().CommitTx()).ExtractValueSync();
- UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS, result.GetIssues().ToString());
- }
-
Y_UNIT_TEST(ComputeNodeMemoryLimit) {
NKikimrConfig::TAppConfig appConfig;
appConfig.MutableTableServiceConfig()->MutableResourceManager()->SetMkqlLightProgramMemoryLimit(1'000'000);
diff --git a/ydb/core/kqp/ut/query/kqp_query_ut.cpp b/ydb/core/kqp/ut/query/kqp_query_ut.cpp
index b91d2ec163..434b0d3ac2 100644
--- a/ydb/core/kqp/ut/query/kqp_query_ut.cpp
+++ b/ydb/core/kqp/ut/query/kqp_query_ut.cpp
@@ -306,13 +306,11 @@ Y_UNIT_TEST_SUITE(KqpQuery) {
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus() == EStatus::SUCCESS || result.GetStatus() == EStatus::SESSION_BUSY, true, result.GetIssues().ToString());
}
- Y_UNIT_TEST_TWIN(QueryClientTimeout, WithMvcc) {
+ Y_UNIT_TEST_TWIN(QueryClientTimeout, EnableImmediateEffects) {
NKikimrConfig::TAppConfig app;
app.MutableTableServiceConfig()->SetEnableKqpDataQuerySourceRead(false);
auto serverSettings = TKikimrSettings()
- .SetEnableMvcc(WithMvcc)
- .SetEnableMvccSnapshotReads(WithMvcc)
- .SetEnableKqpImmediateEffects(WithMvcc)
+ .SetEnableKqpImmediateEffects(EnableImmediateEffects)
.SetAppConfig(app);
TKikimrRunner kikimr(serverSettings);
diff --git a/ydb/core/kqp/ut/tx/kqp_mvcc_ut.cpp b/ydb/core/kqp/ut/tx/kqp_mvcc_ut.cpp
index 8bd4ee2f75..a484eb9b64 100644
--- a/ydb/core/kqp/ut/tx/kqp_mvcc_ut.cpp
+++ b/ydb/core/kqp/ut/tx/kqp_mvcc_ut.cpp
@@ -11,8 +11,6 @@ using namespace NYdb::NTable;
Y_UNIT_TEST_SUITE(KqpSnapshotRead) {
Y_UNIT_TEST(TestSnapshotExpiration) {
auto settings = TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetKeepSnapshotTimeout(TDuration::Seconds(1));
TKikimrRunner kikimr(settings);
@@ -79,8 +77,6 @@ Y_UNIT_TEST_SUITE(KqpSnapshotRead) {
appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(true);
TKikimrRunner kikimr(TKikimrSettings()
.SetAppConfig(appConfig)
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
);
// kikimr.GetTestServer().GetRuntime()->SetLogPriority(NKikimrServices::KQP_COMPUTE, NActors::NLog::PRI_DEBUG);
@@ -139,7 +135,7 @@ Y_UNIT_TEST_SUITE(KqpSnapshotRead) {
}
Y_UNIT_TEST(ReadOnlyTxWithIndexCommitsOnConcurrentWrite) {
- TKikimrRunner kikimr(TKikimrSettings().SetEnableMvcc(true).SetEnableMvccSnapshotReads(true));
+ TKikimrRunner kikimr;
// kikimr.GetTestServer().GetRuntime()->SetLogPriority(NKikimrServices::KQP_COMPUTE, NActors::NLog::PRI_DEBUG);
// kikimr.GetTestServer().GetRuntime()->SetLogPriority(NKikimrServices::KQP_BLOBS_STORAGE, NActors::NLog::PRI_DEBUG);
@@ -200,7 +196,7 @@ Y_UNIT_TEST_SUITE(KqpSnapshotRead) {
}
Y_UNIT_TEST(ReadWriteTxFailsOnConcurrentWrite1) {
- TKikimrRunner kikimr(TKikimrSettings().SetEnableMvcc(true).SetEnableMvccSnapshotReads(true));
+ TKikimrRunner kikimr;
// kikimr.GetTestServer().GetRuntime()->SetLogPriority(NKikimrServices::KQP_COMPUTE, NActors::NLog::PRI_DEBUG);
// kikimr.GetTestServer().GetRuntime()->SetLogPriority(NKikimrServices::KQP_BLOBS_STORAGE, NActors::NLog::PRI_DEBUG);
@@ -237,7 +233,7 @@ Y_UNIT_TEST_SUITE(KqpSnapshotRead) {
}
Y_UNIT_TEST(ReadWriteTxFailsOnConcurrentWrite2) {
- TKikimrRunner kikimr(TKikimrSettings().SetEnableMvcc(true).SetEnableMvccSnapshotReads(true));
+ TKikimrRunner kikimr;
// kikimr.GetTestServer().GetRuntime()->SetLogPriority(NKikimrServices::KQP_COMPUTE, NActors::NLog::PRI_DEBUG);
// kikimr.GetTestServer().GetRuntime()->SetLogPriority(NKikimrServices::KQP_BLOBS_STORAGE, NActors::NLog::PRI_DEBUG);
@@ -284,8 +280,6 @@ Y_UNIT_TEST_SUITE(KqpSnapshotRead) {
appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(true);
TKikimrRunner kikimr(
TKikimrSettings()
- .SetEnableMvcc(true)
- .SetEnableMvccSnapshotReads(true)
.SetAppConfig(appConfig)
);
diff --git a/ydb/core/kqp/ut/tx/kqp_tx_ut.cpp b/ydb/core/kqp/ut/tx/kqp_tx_ut.cpp
index 44dcd90084..1efd0d9116 100644
--- a/ydb/core/kqp/ut/tx/kqp_tx_ut.cpp
+++ b/ydb/core/kqp/ut/tx/kqp_tx_ut.cpp
@@ -664,26 +664,6 @@ Y_UNIT_TEST_SUITE(KqpTx) {
auto commitResult = tx.Commit().ExtractValueSync();
UNIT_ASSERT_VALUES_EQUAL_C(commitResult.GetStatus(), EStatus::SUCCESS, commitResult.GetIssues().ToString());
}
-
- Y_UNIT_TEST(SnapshotRONoMvccReads) {
- TKikimrRunner kikimr(TKikimrSettings()
- .SetEnableMvccSnapshotReads(false));
-
- auto db = kikimr.GetTableClient();
- auto session = db.CreateSession().GetValueSync().GetSession();
-
- // Query
- auto result = session.ExecuteDataQuery(Q1_(R"(
- SELECT * FROM EightShard WHERE Key = 102;
- )"), TTxControl::BeginTx(TTxSettings::SnapshotRO()).CommitTx()).ExtractValueSync();
- result.GetIssues().PrintTo(Cerr);
- UNIT_ASSERT_VALUES_EQUAL(result.GetStatus(), EStatus::BAD_REQUEST);
-
- // Begin
- auto beginResult = session.BeginTransaction(TTxSettings::SnapshotRO()).ExtractValueSync();
- beginResult.GetIssues().PrintTo(Cerr);
- UNIT_ASSERT_VALUES_EQUAL(beginResult.GetStatus(), EStatus::BAD_REQUEST);
- }
}
} // namespace NKqp