diff options
author | niksaveliev <[email protected]> | 2024-09-09 16:46:52 +0500 |
---|---|---|
committer | GitHub <[email protected]> | 2024-09-09 11:46:52 +0000 |
commit | d7a78d09729b8659fe78d649beba13e723e8c86f (patch) | |
tree | 93e4bff427b90c0b9c9c0341ed6b08c92bcf858c | |
parent | ec1d5881da8b1a1105129b7b26be6737cf87f6f0 (diff) |
Fix CLI max partitions default (#8944)
-rw-r--r-- | ydb/public/lib/ydb_cli/commands/ydb_service_topic.cpp | 9 | ||||
-rw-r--r-- | ydb/public/lib/ydb_cli/commands/ydb_service_topic.h | 3 |
2 files changed, 7 insertions, 5 deletions
diff --git a/ydb/public/lib/ydb_cli/commands/ydb_service_topic.cpp b/ydb/public/lib/ydb_cli/commands/ydb_service_topic.cpp index a491332cd98..508d0121646 100644 --- a/ydb/public/lib/ydb_cli/commands/ydb_service_topic.cpp +++ b/ydb/public/lib/ydb_cli/commands/ydb_service_topic.cpp @@ -304,8 +304,7 @@ namespace { config.Opts->AddLongOption("auto-partitioning-max-partitions-count", "Maximum number of partitions for topic") .Optional() - .StoreResult(&MaxActivePartitions_) - .DefaultValue(1); + .StoreResult(&MaxActivePartitions_); AddAutoPartitioning(config, false); } @@ -329,7 +328,11 @@ namespace { GetAutoPartitioningUpUtilizationPercent() ? *GetAutoPartitioningUpUtilizationPercent() : 0, GetAutoPartitioninDownUtilizationPercent() ? *GetAutoPartitioninDownUtilizationPercent() : 0); - settings.PartitioningSettings(MinActivePartitions_, MaxActivePartitions_, autoscaleSettings); + ui32 finalMaxActivePartitions = MaxActivePartitions_.Defined() ? *MaxActivePartitions_ + : autoscaleSettings.GetStrategy() != NTopic::EAutoPartitioningStrategy::Disabled ? MinActivePartitions_ + 50 + : MinActivePartitions_; + + settings.PartitioningSettings(MinActivePartitions_, finalMaxActivePartitions, autoscaleSettings); settings.PartitionWriteBurstBytes(PartitionWriteSpeedKbps_ * 1_KB); settings.PartitionWriteSpeedBytesPerSecond(PartitionWriteSpeedKbps_ * 1_KB); diff --git a/ydb/public/lib/ydb_cli/commands/ydb_service_topic.h b/ydb/public/lib/ydb_cli/commands/ydb_service_topic.h index 2b16a3ea2d4..3680064f13d 100644 --- a/ydb/public/lib/ydb_cli/commands/ydb_service_topic.h +++ b/ydb/public/lib/ydb_cli/commands/ydb_service_topic.h @@ -71,8 +71,7 @@ namespace NYdb::NConsoleClient { ui64 RetentionPeriodHours_; ui64 RetentionStorageMb_; ui32 MinActivePartitions_; - ui32 MaxActivePartitions_; - + TMaybe<ui32> MaxActivePartitions_; ui32 PartitionWriteSpeedKbps_; }; |