summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrobot-piglet <[email protected]>2024-02-11 21:46:48 +0300
committerDaniil Cherednik <[email protected]>2024-02-14 14:25:57 +0000
commitd695a5c67a24c0cd93d925109c461a6bcec73c8b (patch)
tree076ba37802b3dd3d63f7072754a4ffbd6c352536
parent13541f11ba4a095d131c08643b0332968e8bbada (diff)
Intermediate changes
-rw-r--r--yt/yt/core/actions/future.cpp2
-rw-r--r--yt/yt/core/bus/tcp/connection.cpp4
-rw-r--r--yt/yt/core/concurrency/fair_share_invoker_pool.cpp4
-rw-r--r--yt/yt/core/concurrency/fair_throttler.cpp2
-rw-r--r--yt/yt/core/concurrency/moody_camel_concurrent_queue.h2
-rw-r--r--yt/yt/core/concurrency/throughput_throttler.cpp2
-rw-r--r--yt/yt/core/concurrency/unittests/invoker_pool_ut.cpp8
-rw-r--r--yt/yt/core/concurrency/unittests/scheduler_ut.cpp2
-rw-r--r--yt/yt/core/json/json_writer.cpp2
-rw-r--r--yt/yt/core/misc/arithmetic_formula.cpp2
-rw-r--r--yt/yt/core/misc/arithmetic_formula.h2
-rw-r--r--yt/yt/core/misc/async_expiring_cache-inl.h4
-rw-r--r--yt/yt/core/misc/error.cpp2
-rw-r--r--yt/yt/core/misc/proc.cpp26
-rw-r--r--yt/yt/core/misc/unittests/async_expiring_cache_ut.cpp6
-rw-r--r--yt/yt/core/misc/unittests/async_slru_cache_ut.cpp12
-rw-r--r--yt/yt/core/misc/unittests/digest_ut.cpp6
-rw-r--r--yt/yt/core/net/helpers.cpp4
-rw-r--r--yt/yt/core/yson/pull_parser-inl.h2
-rw-r--r--yt/yt/core/yson/pull_parser.cpp28
-rw-r--r--yt/yt/core/yson/unittests/yson_token_writer_ut.cpp2
-rw-r--r--yt/yt/core/ytree/fluent.h2
-rw-r--r--yt/yt/core/ytree/serialize-inl.h2
-rw-r--r--yt/yt/core/ytree/service_combiner.cpp2
-rw-r--r--yt/yt/core/ytree/ypath_client.cpp14
-rw-r--r--yt/yt/core/ytree/ypath_service.cpp4
-rw-r--r--yt/yt/core/ytree/yson_serializable-inl.h10
-rw-r--r--yt/yt/core/ytree/yson_serializable.cpp4
-rw-r--r--yt/yt/core/ytree/yson_struct_detail-inl.h4
-rw-r--r--yt/yt/core/ytree/yson_struct_detail.cpp2
30 files changed, 84 insertions, 84 deletions
diff --git a/yt/yt/core/actions/future.cpp b/yt/yt/core/actions/future.cpp
index 547492d4386..1dc54ca780d 100644
--- a/yt/yt/core/actions/future.cpp
+++ b/yt/yt/core/actions/future.cpp
@@ -61,7 +61,7 @@ bool TFutureState<void>::Cancel(const TError& error) noexcept
return false;
}
// The reference is acquired above.
- TIntrusivePtr<TFutureState<void>> this_(this, /* addReference */ false);
+ TIntrusivePtr<TFutureState<void>> this_(this, /*addReference*/ false);
{
auto guard = Guard(SpinLock_);
diff --git a/yt/yt/core/bus/tcp/connection.cpp b/yt/yt/core/bus/tcp/connection.cpp
index c602964133b..84e0f050e79 100644
--- a/yt/yt/core/bus/tcp/connection.cpp
+++ b/yt/yt/core/bus/tcp/connection.cpp
@@ -74,7 +74,7 @@ bool TTcpConnection::TPacket::MarkEncoded()
return State.compare_exchange_strong(expected, EPacketState::Encoded);
}
-void TTcpConnection::TPacket::OnCancel(const TError& /* error */)
+void TTcpConnection::TPacket::OnCancel(const TError& /*error*/)
{
auto expected = EPacketState::Queued;
if (!State.compare_exchange_strong(expected, EPacketState::Canceled)) {
@@ -2021,7 +2021,7 @@ void TTcpConnection::TryEstablishSslSession()
}
// Enable verification of the peer's certificate with the CA.
- SSL_set_verify(Ssl_.get(), SSL_VERIFY_PEER, /* callback */ nullptr);
+ SSL_set_verify(Ssl_.get(), SSL_VERIFY_PEER, /*callback*/ nullptr);
break;
}
case EVerificationMode::None:
diff --git a/yt/yt/core/concurrency/fair_share_invoker_pool.cpp b/yt/yt/core/concurrency/fair_share_invoker_pool.cpp
index a12e7d8f299..99f231ebbd2 100644
--- a/yt/yt/core/concurrency/fair_share_invoker_pool.cpp
+++ b/yt/yt/core/concurrency/fair_share_invoker_pool.cpp
@@ -283,8 +283,8 @@ private:
: Index_(index)
, Queue_(queue)
, ContextSwitchGuard_(
- /* out */ [this] { Account(); },
- /* in */ [] { })
+ /*out*/ [this] { Account(); },
+ /*in*/ [] { })
{ }
void Account()
diff --git a/yt/yt/core/concurrency/fair_throttler.cpp b/yt/yt/core/concurrency/fair_throttler.cpp
index 692c0877d58..aca2725c06d 100644
--- a/yt/yt/core/concurrency/fair_throttler.cpp
+++ b/yt/yt/core/concurrency/fair_throttler.cpp
@@ -621,7 +621,7 @@ TFairThrottler::TFairThrottler(
SharedBucket_->Limit.Value = std::shared_ptr<std::atomic<i64>>(
&IPC_->State()->Value,
- [ipc=IPC_] (auto /* ptr */) { }
+ [ipc=IPC_] (auto /*ptr*/) { }
);
Profiler_.AddFuncGauge("/leader", MakeStrong(this), [this] {
diff --git a/yt/yt/core/concurrency/moody_camel_concurrent_queue.h b/yt/yt/core/concurrency/moody_camel_concurrent_queue.h
index 3b43aaad78b..939122ae8a0 100644
--- a/yt/yt/core/concurrency/moody_camel_concurrent_queue.h
+++ b/yt/yt/core/concurrency/moody_camel_concurrent_queue.h
@@ -3217,7 +3217,7 @@ private:
for (auto ptr = producerListTail.load(std::memory_order::acquire); ptr != nullptr; ptr = ptr->next_prod()) {
if (ptr->inactive.load(std::memory_order::relaxed) && ptr->isExplicit == isExplicit) {
bool expected = true;
- if (ptr->inactive.compare_exchange_strong(expected, /* desired */ false, std::memory_order::acquire, std::memory_order::relaxed)) {
+ if (ptr->inactive.compare_exchange_strong(expected, /*desired*/ false, std::memory_order::acquire, std::memory_order::relaxed)) {
// We caught one! It's been marked as activated, the caller can have it
recycled = true;
return ptr;
diff --git a/yt/yt/core/concurrency/throughput_throttler.cpp b/yt/yt/core/concurrency/throughput_throttler.cpp
index bdfe1d17241..c7a06ef199b 100644
--- a/yt/yt/core/concurrency/throughput_throttler.cpp
+++ b/yt/yt/core/concurrency/throughput_throttler.cpp
@@ -612,7 +612,7 @@ public:
asyncResults.push_back(throttler->Throttle(amount));
}
- return AllSucceeded(asyncResults).Apply(BIND([weakThis = MakeWeak(this), amount] (const TError& /* error */ ) {
+ return AllSucceeded(asyncResults).Apply(BIND([weakThis = MakeWeak(this), amount] (const TError& /*error*/ ) {
if (auto this_ = weakThis.Lock()) {
this_->SelfQueueSize_ -= amount;
}
diff --git a/yt/yt/core/concurrency/unittests/invoker_pool_ut.cpp b/yt/yt/core/concurrency/unittests/invoker_pool_ut.cpp
index 793d5bd673a..3a565aac3d5 100644
--- a/yt/yt/core/concurrency/unittests/invoker_pool_ut.cpp
+++ b/yt/yt/core/concurrency/unittests/invoker_pool_ut.cpp
@@ -172,7 +172,7 @@ TEST_F(TTransformInvokerPoolTest, OutputPoolOutlivesInputPool)
TEST_F(TTransformInvokerPoolTest, InstantiateForWellKnownTypes)
{
const auto testOne = [this] (auto invokerFunctor) {
- auto inputInvokerPool = CreateDummyInvokerPool(Queue_->GetInvoker(), /* invokerCount */ 10);
+ auto inputInvokerPool = CreateDummyInvokerPool(Queue_->GetInvoker(), /*invokerCount*/ 10);
return TransformInvokerPool(std::move(inputInvokerPool), invokerFunctor);
};
@@ -182,7 +182,7 @@ TEST_F(TTransformInvokerPoolTest, InstantiateForWellKnownTypes)
IInvokerPoolPtr w = testOne(CreateIdenticalInvokerByConstReference);
const auto testPair = [this] (auto firstInvokerFunctor, auto secondInvokerFunctor) {
- auto inputInvokerPool = CreateDummyInvokerPool(Queue_->GetInvoker(), /* invokerCount */ 10);
+ auto inputInvokerPool = CreateDummyInvokerPool(Queue_->GetInvoker(), /*invokerCount*/ 10);
auto intermediateInvokerPool = TransformInvokerPool(std::move(inputInvokerPool), firstInvokerFunctor);
auto outputInvokerPool = TransformInvokerPool(std::move(intermediateInvokerPool), secondInvokerFunctor);
};
@@ -228,7 +228,7 @@ TEST_F(TTransformInvokerPoolTest, Chaining)
TEST_F(TTransformInvokerPoolTest, ReturnTypeConvertability)
{
- auto invokerPool = CreateDummyInvokerPool(Queue_->GetInvoker(), /* invokerCount */ 10);
+ auto invokerPool = CreateDummyInvokerPool(Queue_->GetInvoker(), /*invokerCount*/ 10);
auto suspendableInvokerPool = TransformInvokerPool(invokerPool, CreateSuspendableInvoker);
auto prioritizedInvokerPool = TransformInvokerPool(suspendableInvokerPool, CreatePrioritizedInvokerTest);
@@ -257,7 +257,7 @@ TEST(TInvokerPoolTest, IndexByEnum)
{
auto queue = New<TActionQueue>();
- auto invokerPool = CreateDummyInvokerPool(queue->GetInvoker(), /* invokerCount */ 3);
+ auto invokerPool = CreateDummyInvokerPool(queue->GetInvoker(), /*invokerCount*/ 3);
EXPECT_EQ(invokerPool->GetInvoker(0).Get(), invokerPool->GetInvoker(EInvokerIndex::ZeroInvoker).Get());
EXPECT_EQ(invokerPool->GetInvoker(1).Get(), invokerPool->GetInvoker(EInvokerIndex::FirstInvoker).Get());
diff --git a/yt/yt/core/concurrency/unittests/scheduler_ut.cpp b/yt/yt/core/concurrency/unittests/scheduler_ut.cpp
index 3e032a82d75..80bf31e5971 100644
--- a/yt/yt/core/concurrency/unittests/scheduler_ut.cpp
+++ b/yt/yt/core/concurrency/unittests/scheduler_ut.cpp
@@ -769,7 +769,7 @@ TEST_F(TSchedulerTest, CancelInApplyUnique)
BIND([=] () {
auto promise = NewPromise<int>();
- auto f2 = promise.ToFuture().ApplyUnique(BIND([] (TErrorOr<int>&& /* error */) {
+ auto f2 = promise.ToFuture().ApplyUnique(BIND([] (TErrorOr<int>&& /*error*/) {
auto canceler = NYT::NConcurrency::GetCurrentFiberCanceler();
canceler(TError("kek"));
diff --git a/yt/yt/core/json/json_writer.cpp b/yt/yt/core/json/json_writer.cpp
index 20adbb47868..3d5c2b46926 100644
--- a/yt/yt/core/json/json_writer.cpp
+++ b/yt/yt/core/json/json_writer.cpp
@@ -660,7 +660,7 @@ std::unique_ptr<IJsonConsumer> CreateJsonConsumer(
{
auto jsonWriter = CreateJsonWriter(
output,
- /* pretty */ config->Format == EJsonFormat::Pretty);
+ /*pretty*/ config->Format == EJsonFormat::Pretty);
return std::make_unique<TJsonConsumer>(std::move(jsonWriter), type, std::move(config));
}
diff --git a/yt/yt/core/misc/arithmetic_formula.cpp b/yt/yt/core/misc/arithmetic_formula.cpp
index 283befb37aa..b8a4f733926 100644
--- a/yt/yt/core/misc/arithmetic_formula.cpp
+++ b/yt/yt/core/misc/arithmetic_formula.cpp
@@ -907,7 +907,7 @@ TString ToString(const TBooleanFormulaTags& tags)
return ToStringViaBuilder(tags);
}
-void FormatValue(TStringBuilderBase* builder, const TBooleanFormulaTags& tags, TStringBuf /* format */)
+void FormatValue(TStringBuilderBase* builder, const TBooleanFormulaTags& tags, TStringBuf /*format*/)
{
builder->AppendFormat("%v", tags.GetSourceTags());
}
diff --git a/yt/yt/core/misc/arithmetic_formula.h b/yt/yt/core/misc/arithmetic_formula.h
index c2eb3cd2e0b..e83065cd697 100644
--- a/yt/yt/core/misc/arithmetic_formula.h
+++ b/yt/yt/core/misc/arithmetic_formula.h
@@ -98,7 +98,7 @@ void Serialize(const TBooleanFormulaTags& tags, NYson::IYsonConsumer* consumer);
void Deserialize(TBooleanFormulaTags& tags, NYTree::INodePtr node);
TString ToString(const TBooleanFormulaTags& tags);
-void FormatValue(TStringBuilderBase* builder, const TBooleanFormulaTags& tags, TStringBuf /* format */);
+void FormatValue(TStringBuilderBase* builder, const TBooleanFormulaTags& tags, TStringBuf /*format*/);
////////////////////////////////////////////////////////////////////////////////
diff --git a/yt/yt/core/misc/async_expiring_cache-inl.h b/yt/yt/core/misc/async_expiring_cache-inl.h
index 96039eee960..618825adf7b 100644
--- a/yt/yt/core/misc/async_expiring_cache-inl.h
+++ b/yt/yt/core/misc/async_expiring_cache-inl.h
@@ -215,7 +215,7 @@ TFuture<std::vector<TErrorOr<TValue>>> TAsyncExpiringCache<TKey, TValue>::GetMan
if (!keysToPopulate.empty()) {
YT_LOG_DEBUG("Populating cache entries (Keys: %v)",
keysToPopulate);
- InvokeGetMany(entriesToPopulate, keysToPopulate, /* periodicRefreshTime */ std::nullopt);
+ InvokeGetMany(entriesToPopulate, keysToPopulate, /*periodicRefreshTime*/ std::nullopt);
}
}
@@ -529,7 +529,7 @@ void TAsyncExpiringCache<TKey, TValue>::InvokeGet(
template <class TKey, class TValue>
TFuture<TValue> TAsyncExpiringCache<TKey, TValue>::DoGet(
const TKey& key,
- const TErrorOr<TValue>* /* oldValue */,
+ const TErrorOr<TValue>* /*oldValue*/,
EUpdateReason reason) noexcept
{
return DoGet(key, reason != EUpdateReason::InitialFetch);
diff --git a/yt/yt/core/misc/error.cpp b/yt/yt/core/misc/error.cpp
index 2c3b79db5c1..cdb09da2afb 100644
--- a/yt/yt/core/misc/error.cpp
+++ b/yt/yt/core/misc/error.cpp
@@ -1135,7 +1135,7 @@ void SerializeInnerErrors(TFluentMap fluent, const TError& error, int depth)
auto visit = [&] (auto fluent, const TError& error, int depth) {
fluent
.Item().Do([&] (auto fluent) {
- Serialize(error, fluent.GetConsumer(), /* valueProduce */ nullptr, depth);
+ Serialize(error, fluent.GetConsumer(), /*valueProduce*/ nullptr, depth);
});
};
diff --git a/yt/yt/core/misc/proc.cpp b/yt/yt/core/misc/proc.cpp
index 22882e45366..76730659988 100644
--- a/yt/yt/core/misc/proc.cpp
+++ b/yt/yt/core/misc/proc.cpp
@@ -991,17 +991,17 @@ bool TryClose(TFileDescriptor fd, bool ignoreBadFD)
return false;
}
-bool TryDup2(TFileDescriptor /* oldFD */, TFileDescriptor /* newFD */)
+bool TryDup2(TFileDescriptor /*oldFD*/, TFileDescriptor /*newFD*/)
{
YT_UNIMPLEMENTED();
}
-void SafeDup2(TFileDescriptor /* oldFD */, TFileDescriptor /* newFD */)
+void SafeDup2(TFileDescriptor /*oldFD*/, TFileDescriptor /*newFD*/)
{
YT_UNIMPLEMENTED();
}
-void SafeSetCloexec(TFileDescriptor /* fd */)
+void SafeSetCloexec(TFileDescriptor /*fd*/)
{
YT_UNIMPLEMENTED();
}
@@ -1011,7 +1011,7 @@ bool TryExecve(const char /* *path */, const char* /* argv[] */, const char* /*
YT_UNIMPLEMENTED();
}
-TError StatusToError(int /* status */)
+TError StatusToError(int /*status*/)
{
YT_UNIMPLEMENTED();
}
@@ -1021,47 +1021,47 @@ void CloseAllDescriptors()
YT_UNIMPLEMENTED();
}
-void SafePipe(TFileDescriptor /* fd */ [2])
+void SafePipe(TFileDescriptor /*fd*/ [2])
{
YT_UNIMPLEMENTED();
}
-TFileDescriptor SafeDup(TFileDescriptor /* fd */)
+TFileDescriptor SafeDup(TFileDescriptor /*fd*/)
{
YT_UNIMPLEMENTED();
}
-void SafeOpenPty(TFileDescriptor* /* masterFD */, TFileDescriptor* /* slaveFD */, int /* height */, int /* width */)
+void SafeOpenPty(TFileDescriptor* /*masterFD*/, TFileDescriptor* /*slaveFD*/, int /*height*/, int /*width*/)
{
YT_UNIMPLEMENTED();
}
-void SafeLoginTty(TFileDescriptor /* slaveFD */)
+void SafeLoginTty(TFileDescriptor /*slaveFD*/)
{
YT_UNIMPLEMENTED();
}
-void SafeSetTtyWindowSize(TFileDescriptor /* slaveFD */, int /* height */, int /* width */)
+void SafeSetTtyWindowSize(TFileDescriptor /*slaveFD*/, int /*height*/, int /*width*/)
{
YT_UNIMPLEMENTED();
}
-bool TryMakeNonblocking(TFileDescriptor /* fd */)
+bool TryMakeNonblocking(TFileDescriptor /*fd*/)
{
YT_UNIMPLEMENTED();
}
-void SafeMakeNonblocking(TFileDescriptor /* fd */)
+void SafeMakeNonblocking(TFileDescriptor /*fd*/)
{
YT_UNIMPLEMENTED();
}
-void SafeSetUid(int /* uid */)
+void SafeSetUid(int /*uid*/)
{
YT_UNIMPLEMENTED();
}
-TString SafeGetUsernameByUid(int /* uid */)
+TString SafeGetUsernameByUid(int /*uid*/)
{
YT_UNIMPLEMENTED();
}
diff --git a/yt/yt/core/misc/unittests/async_expiring_cache_ut.cpp b/yt/yt/core/misc/unittests/async_expiring_cache_ut.cpp
index add613a5083..6fec652cd15 100644
--- a/yt/yt/core/misc/unittests/async_expiring_cache_ut.cpp
+++ b/yt/yt/core/misc/unittests/async_expiring_cache_ut.cpp
@@ -320,14 +320,14 @@ public:
private:
virtual TFuture<int> DoGet(
- const int& /* key */,
- bool /* isPeriodicUpdate */) noexcept
+ const int& /*key*/,
+ bool /*isPeriodicUpdate*/) noexcept
{
YT_UNIMPLEMENTED();
}
virtual TFuture<int> DoGet(
- const int& /* key */,
+ const int& /*key*/,
const TErrorOr<int>* oldValue,
EUpdateReason reason) noexcept
{
diff --git a/yt/yt/core/misc/unittests/async_slru_cache_ut.cpp b/yt/yt/core/misc/unittests/async_slru_cache_ut.cpp
index 7e2393f30a2..3049df240c2 100644
--- a/yt/yt/core/misc/unittests/async_slru_cache_ut.cpp
+++ b/yt/yt/core/misc/unittests/async_slru_cache_ut.cpp
@@ -422,9 +422,9 @@ TEST(TAsyncSlruCacheTest, AddThenImmediatelyRemove)
auto cache = New<TCountingSlruCache>(std::move(config));
auto persistentValue = New<TSimpleCachedValue>(
- /* key */ 0,
- /* value */ 42,
- /* weight */ 100);
+ /*key*/ 0,
+ /*value*/ 42,
+ /*weight*/ 100);
{
auto cookie = cache->BeginInsert(0);
@@ -437,9 +437,9 @@ TEST(TAsyncSlruCacheTest, AddThenImmediatelyRemove)
{
auto cookie = cache->BeginInsert(1);
auto temporaryValue = New<TSimpleCachedValue>(
- /* key */ 1,
- /* value */ 43,
- /* weight */ 100);
+ /*key*/ 1,
+ /*value*/ 43,
+ /*weight*/ 100);
cookie.EndInsert(temporaryValue);
temporaryValue.Reset();
EXPECT_EQ(cache->GetItemCount(), 0);
diff --git a/yt/yt/core/misc/unittests/digest_ut.cpp b/yt/yt/core/misc/unittests/digest_ut.cpp
index ad57883e36c..4704d25804b 100644
--- a/yt/yt/core/misc/unittests/digest_ut.cpp
+++ b/yt/yt/core/misc/unittests/digest_ut.cpp
@@ -77,7 +77,7 @@ TEST_F(TLogDigestTest, TestNormalDistributionFixture)
{
CreateStandardLogDigest();
- std::mt19937 generator(42 /* seed */);
+ std::mt19937 generator(42 /*seed*/);
std::normal_distribution<double> distribution(0.77, 0.05);
for (int i = 0; i < SampleCount; ++i) {
@@ -93,7 +93,7 @@ TEST_F(TLogDigestTest, TestUniformRandomFixture)
{
CreateStandardLogDigest();
- std::mt19937 generator(42 /* seed */);
+ std::mt19937 generator(42 /*seed*/);
std::uniform_real_distribution<double> distribution(0.25, 1.25);
for (int i = 0; i < SampleCount; ++i) {
@@ -115,7 +115,7 @@ TEST_F(TLogDigestTest, TestCoincidingBounds)
config->RelativePrecision = Epsilon;
LogDigest_ = CreateLogDigest(config);
- std::mt19937 generator(42 /* seed */);
+ std::mt19937 generator(42 /*seed*/);
std::uniform_real_distribution<double> distribution(0.5, 1.5);
for (int i = 0; i < SampleCount; ++i) {
diff --git a/yt/yt/core/net/helpers.cpp b/yt/yt/core/net/helpers.cpp
index 3a1abf69063..f4071c3fac3 100644
--- a/yt/yt/core/net/helpers.cpp
+++ b/yt/yt/core/net/helpers.cpp
@@ -40,12 +40,12 @@ std::vector<int> AllocateFreePorts(
YT_LOG_DEBUG("Making a preliminary port bind (Port: %v, Socket: %v)", port, socket);
BindSocket(socket, TNetworkAddress::CreateIPv6Any(port));
} catch (const std::exception& ex) {
- SafeClose(socket, false /* ignoreBadFD */);
+ SafeClose(socket, false /*ignoreBadFD*/);
YT_LOG_DEBUG(ex, "Error while trying making a preliminary port bind, skipping it (Port: %v, Socket: %v)", port, socket);
continue;
}
- SafeClose(socket, false /* ignoreBadFD */);
+ SafeClose(socket, false /*ignoreBadFD*/);
YT_LOG_DEBUG("Socket used in preliminary bind is closed (Port: %v, Socket: %v)", port, socket);
allocatedPorts.push_back(port);
diff --git a/yt/yt/core/yson/pull_parser-inl.h b/yt/yt/core/yson/pull_parser-inl.h
index 3d111074553..2e8d7bf72fa 100644
--- a/yt/yt/core/yson/pull_parser-inl.h
+++ b/yt/yt/core/yson/pull_parser-inl.h
@@ -252,7 +252,7 @@ auto TYsonPullParser::ParseItem() -> std::conditional_t<IsOptional, bool, void>
}
}
- ThrowUnexpectedTokenException("item", *this, item, ItemType, /* isOptional */ true);
+ ThrowUnexpectedTokenException("item", *this, item, ItemType, /*isOptional*/ true);
};
auto result = parse();
diff --git a/yt/yt/core/yson/pull_parser.cpp b/yt/yt/core/yson/pull_parser.cpp
index 55261056f6b..f79b81b2e65 100644
--- a/yt/yt/core/yson/pull_parser.cpp
+++ b/yt/yt/core/yson/pull_parser.cpp
@@ -148,19 +148,19 @@ public:
void OnEndList()
{ }
- void OnString(TStringBuf /* value */)
+ void OnString(TStringBuf /*value*/)
{ }
- void OnInt64(i64 /* value */)
+ void OnInt64(i64 /*value*/)
{ }
- void OnUint64(ui64 /* value */)
+ void OnUint64(ui64 /*value*/)
{ }
- void OnDouble(double /* value */)
+ void OnDouble(double /*value*/)
{ }
- void OnBoolean(bool /* value */)
+ void OnBoolean(bool /*value*/)
{ }
void OnEntity()
@@ -465,19 +465,19 @@ EYsonType TYsonPullParser::GetYsonType() const
void TYsonPullParser::SkipComplexValue()
{
auto visitor = NDetail::TNullVisitor();
- TraverseComplexValueOrAttributes(&visitor, /* stopAfterAttributes */ false);
+ TraverseComplexValueOrAttributes(&visitor, /*stopAfterAttributes*/ false);
}
void TYsonPullParser::TransferComplexValue(TCheckedInDebugYsonTokenWriter* writer)
{
auto visitor = NDetail::TYsonTokenWritingVisitor(writer);
- TraverseComplexValueOrAttributes(&visitor, /* stopAfterAttributes */ false);
+ TraverseComplexValueOrAttributes(&visitor, /*stopAfterAttributes*/ false);
}
void TYsonPullParser::SkipComplexValue(const TYsonItem& previousItem)
{
auto visitor = NDetail::TNullVisitor();
- TraverseComplexValueOrAttributes(&visitor, previousItem, /* stopAfterAttributes */ false);
+ TraverseComplexValueOrAttributes(&visitor, previousItem, /*stopAfterAttributes*/ false);
}
void TYsonPullParser::TransferComplexValue(TCheckedInDebugYsonTokenWriter* writer, const TYsonItem& previousItem)
@@ -486,7 +486,7 @@ void TYsonPullParser::TransferComplexValue(TCheckedInDebugYsonTokenWriter* write
TraverseComplexValueOrAttributes(
&visitor,
previousItem,
- /* stopAfterAttributes */ false);
+ /*stopAfterAttributes*/ false);
}
void TYsonPullParser::TransferComplexValue(IYsonConsumer* consumer, const TYsonItem& previousItem)
@@ -495,7 +495,7 @@ void TYsonPullParser::TransferComplexValue(IYsonConsumer* consumer, const TYsonI
TraverseComplexValueOrAttributes(
&visitor,
previousItem,
- /* stopAfterAttributes */ false);
+ /*stopAfterAttributes*/ false);
}
@@ -503,13 +503,13 @@ void TYsonPullParser::SkipAttributes(const TYsonItem& previousItem)
{
EnsureYsonToken("attributes", *this, previousItem, EYsonItemType::BeginAttributes);
auto visitor = NDetail::TNullVisitor();
- TraverseComplexValueOrAttributes(&visitor, previousItem, /* stopAfterAttributes */ true);
+ TraverseComplexValueOrAttributes(&visitor, previousItem, /*stopAfterAttributes*/ true);
}
void TYsonPullParser::SkipComplexValueOrAttributes(const TYsonItem& previousItem)
{
auto visitor = NDetail::TNullVisitor();
- TraverseComplexValueOrAttributes(&visitor, previousItem, /* stopAfterAttributes */ true);
+ TraverseComplexValueOrAttributes(&visitor, previousItem, /*stopAfterAttributes*/ true);
}
void TYsonPullParser::TransferAttributes(TCheckedInDebugYsonTokenWriter* writer, const TYsonItem& previousItem)
@@ -519,7 +519,7 @@ void TYsonPullParser::TransferAttributes(TCheckedInDebugYsonTokenWriter* writer,
TraverseComplexValueOrAttributes(
&visitor,
previousItem,
- /* stopAfterAttributes */ true);
+ /*stopAfterAttributes*/ true);
}
void TYsonPullParser::TransferAttributes(IYsonConsumer* consumer, const TYsonItem& previousItem)
@@ -529,7 +529,7 @@ void TYsonPullParser::TransferAttributes(IYsonConsumer* consumer, const TYsonIte
TraverseComplexValueOrAttributes(
&visitor,
previousItem,
- /* stopAfterAttributes */ true);
+ /*stopAfterAttributes*/ true);
}
std::vector<TErrorAttribute> TYsonPullParser::GetErrorAttributes() const
diff --git a/yt/yt/core/yson/unittests/yson_token_writer_ut.cpp b/yt/yt/core/yson/unittests/yson_token_writer_ut.cpp
index 0ae16ed98d3..609c3cd888d 100644
--- a/yt/yt/core/yson/unittests/yson_token_writer_ut.cpp
+++ b/yt/yt/core/yson/unittests/yson_token_writer_ut.cpp
@@ -191,7 +191,7 @@ TEST(TYsonTokenWriterTest, WriteRawNodeUnchecked)
{
TString out;
- TFixedGrowthStringOutput outStream(&out, /* bufferSize */ 20);
+ TFixedGrowthStringOutput outStream(&out, /*bufferSize*/ 20);
TCheckedYsonTokenWriter writer(&outStream);
writer.WriteBeginMap();
diff --git a/yt/yt/core/ytree/fluent.h b/yt/yt/core/ytree/fluent.h
index 6ef40dfc109..ec0c51fd7ed 100644
--- a/yt/yt/core/ytree/fluent.h
+++ b/yt/yt/core/ytree/fluent.h
@@ -646,7 +646,7 @@ public:
using TValue = NYson::TYsonString;
TFluentYsonWriterState(NYson::EYsonFormat format, NYson::EYsonType type)
- : Writer(&Output, format, type, true /* enableRaw */)
+ : Writer(&Output, format, type, true /*enableRaw*/)
, Type(type)
{ }
diff --git a/yt/yt/core/ytree/serialize-inl.h b/yt/yt/core/ytree/serialize-inl.h
index dac0bce7473..bdf29749d3e 100644
--- a/yt/yt/core/ytree/serialize-inl.h
+++ b/yt/yt/core/ytree/serialize-inl.h
@@ -280,7 +280,7 @@ void WriteYson(
NYson::EYsonFormat format,
int indent)
{
- NYson::TYsonWriter writer(output, format, type, /* enableRaw */ false, indent);
+ NYson::TYsonWriter writer(output, format, type, /*enableRaw*/ false, indent);
Serialize(value, &writer);
}
diff --git a/yt/yt/core/ytree/service_combiner.cpp b/yt/yt/core/ytree/service_combiner.cpp
index ef51b0b3803..91d5b8ca7d3 100644
--- a/yt/yt/core/ytree/service_combiner.cpp
+++ b/yt/yt/core/ytree/service_combiner.cpp
@@ -289,7 +289,7 @@ private:
{
std::vector<TFuture<std::vector<TString>>> serviceListFutures;
for (const auto& service : Services_) {
- auto asyncList = AsyncYPathList(service, TYPath() /* path */, std::numeric_limits<i64>::max() /* limit */);
+ auto asyncList = AsyncYPathList(service, TYPath() /*path*/, std::numeric_limits<i64>::max() /*limit*/);
serviceListFutures.push_back(asyncList);
}
auto asyncResult = AllSucceeded(serviceListFutures);
diff --git a/yt/yt/core/ytree/ypath_client.cpp b/yt/yt/core/ytree/ypath_client.cpp
index 2a40321189a..4b36f0264e9 100644
--- a/yt/yt/core/ytree/ypath_client.cpp
+++ b/yt/yt/core/ytree/ypath_client.cpp
@@ -909,29 +909,29 @@ TNodeWalkOptions GetNodeByYPathOptions {
};
TNodeWalkOptions FindNodeByYPathOptions {
- .MissingAttributeHandler = [] (const TString& /* key */) {
+ .MissingAttributeHandler = [] (const TString& /*key*/) {
return nullptr;
},
- .MissingChildKeyHandler = [] (const IMapNodePtr& /* node */, const TString& /* key */) {
+ .MissingChildKeyHandler = [] (const IMapNodePtr& /*node*/, const TString& /*key*/) {
return nullptr;
},
- .MissingChildIndexHandler = [] (const IListNodePtr& /* node */, int /* index */) {
+ .MissingChildIndexHandler = [] (const IListNodePtr& /*node*/, int /*index*/) {
return nullptr;
},
.NodeCannotHaveChildrenHandler = GetNodeByYPathOptions.NodeCannotHaveChildrenHandler
};
TNodeWalkOptions FindNodeByYPathNoThrowOptions {
- .MissingAttributeHandler = [] (const TString& /* key */) {
+ .MissingAttributeHandler = [] (const TString& /*key*/) {
return nullptr;
},
- .MissingChildKeyHandler = [] (const IMapNodePtr& /* node */, const TString& /* key */) {
+ .MissingChildKeyHandler = [] (const IMapNodePtr& /*node*/, const TString& /*key*/) {
return nullptr;
},
- .MissingChildIndexHandler = [] (const IListNodePtr& /* node */, int /* index */) {
+ .MissingChildIndexHandler = [] (const IListNodePtr& /*node*/, int /*index*/) {
return nullptr;
},
- .NodeCannotHaveChildrenHandler = [] (const INodePtr& /* node */) {
+ .NodeCannotHaveChildrenHandler = [] (const INodePtr& /*node*/) {
return nullptr;
},
};
diff --git a/yt/yt/core/ytree/ypath_service.cpp b/yt/yt/core/ytree/ypath_service.cpp
index 7272de852ef..8683b61e3a6 100644
--- a/yt/yt/core/ytree/ypath_service.cpp
+++ b/yt/yt/core/ytree/ypath_service.cpp
@@ -866,7 +866,7 @@ bool TCachedYPathService::DoInvoke(const IYPathServiceContextPtr& context)
void TCachedYPathService::RebuildCache()
{
try {
- auto asyncYson = AsyncYPathGet(UnderlyingService_, /* path */ TYPath(), TAttributeFilter());
+ auto asyncYson = AsyncYPathGet(UnderlyingService_, /*path*/ TYPath(), TAttributeFilter());
auto yson = WaitFor(asyncYson)
.ValueOrThrow();
@@ -928,7 +928,7 @@ private:
TCachingPermissionValidator PermissionValidator_;
void ValidatePermission(
- EPermissionCheckScope /* scope */,
+ EPermissionCheckScope /*scope*/,
EPermission permission,
const TString& user) override
{
diff --git a/yt/yt/core/ytree/yson_serializable-inl.h b/yt/yt/core/ytree/yson_serializable-inl.h
index 6445f1a04b9..a53c6aa26a8 100644
--- a/yt/yt/core/ytree/yson_serializable-inl.h
+++ b/yt/yt/core/ytree/yson_serializable-inl.h
@@ -531,9 +531,9 @@ struct TGetUnrecognizedRecursively<TIntrusivePtr<T>>
// all
template <class F>
void InvokeForComposites(
- const void* /* parameter */,
- const NYPath::TYPath& /* path */,
- const F& /* func */)
+ const void* /*parameter*/,
+ const NYPath::TYPath& /*path*/,
+ const F& /*func*/)
{ }
// TYsonSerializable or TYsonStruct
@@ -581,8 +581,8 @@ inline void InvokeForComposites(
// all
template <class F>
void InvokeForComposites(
- const void* /* parameter */,
- const F& /* func */)
+ const void* /*parameter*/,
+ const F& /*func*/)
{ }
// TYsonStruct or TYsonSerializable
diff --git a/yt/yt/core/ytree/yson_serializable.cpp b/yt/yt/core/ytree/yson_serializable.cpp
index cc7ccee83ef..f9557e19888 100644
--- a/yt/yt/core/ytree/yson_serializable.cpp
+++ b/yt/yt/core/ytree/yson_serializable.cpp
@@ -208,7 +208,7 @@ void TYsonSerializableLite::Load(
for (auto parameter : pendingParameters) {
auto childPath = path + "/" + parameter->GetKey();
- parameter->Load(/* cursor */ nullptr, childPath);
+ parameter->Load(/*cursor*/ nullptr, childPath);
}
if (postprocess) {
@@ -299,7 +299,7 @@ void TYsonSerializableLite::LoadParameter(const TString& key, const NYTree::INod
<< ex;
}
};
- parameter->SafeLoad(node, /* path */ "", validate, mergeStrategy);
+ parameter->SafeLoad(node, /*path*/ "", validate, mergeStrategy);
}
void TYsonSerializableLite::ResetParameter(const TString& key) const
diff --git a/yt/yt/core/ytree/yson_struct_detail-inl.h b/yt/yt/core/ytree/yson_struct_detail-inl.h
index 650d45ab423..34d87a44120 100644
--- a/yt/yt/core/ytree/yson_struct_detail-inl.h
+++ b/yt/yt/core/ytree/yson_struct_detail-inl.h
@@ -541,8 +541,8 @@ inline void InvokeForComposites(
// all
template <class F>
void InvokeForComposites(
- const void* /* parameter */,
- const F& /* func */)
+ const void* /*parameter*/,
+ const F& /*func*/)
{ }
// TYsonStruct or TYsonSerializable
diff --git a/yt/yt/core/ytree/yson_struct_detail.cpp b/yt/yt/core/ytree/yson_struct_detail.cpp
index c340756deaf..48919a5d22e 100644
--- a/yt/yt/core/ytree/yson_struct_detail.cpp
+++ b/yt/yt/core/ytree/yson_struct_detail.cpp
@@ -275,7 +275,7 @@ void TYsonStructMeta::LoadStruct(
});
for (const auto parameter : pendingParameters) {
- parameter->Load(target, /* cursor */ nullptr, createLoadOptions(parameter->GetKey()));
+ parameter->Load(target, /*cursor*/ nullptr, createLoadOptions(parameter->GetKey()));
}
if (postprocess) {