aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVitaly Stoyan <vvvv@ydb.tech>2024-01-29 17:42:11 +0300
committerGitHub <noreply@github.com>2024-01-29 17:42:11 +0300
commitccbe144622ee7d70e398162c16aa5558887435c1 (patch)
tree2e2bd9f6343a3b7572c4f137b45874edd77a43af
parent5959806076373da77e0f7b040b917c87bdab7ff8 (diff)
downloadydb-ccbe144622ee7d70e398162c16aa5558887435c1.tar.gz
init (#1375)
-rw-r--r--ydb/library/yql/minikql/codegen/codegen.cpp9
-rw-r--r--ydb/library/yql/minikql/codegen/codegen_ut.cpp2
-rw-r--r--ydb/library/yql/minikql/codegen/ut/ya.make.inc2
-rw-r--r--ydb/library/yql/minikql/codegen/ya.make.inc2
-rw-r--r--ydb/library/yql/minikql/comp_nodes/llvm/ut/ya.make4
-rw-r--r--ydb/library/yql/minikql/comp_nodes/llvm/ya.make2
-rw-r--r--ydb/library/yql/minikql/comp_nodes/llvm14/ut/ya.make4
-rw-r--r--ydb/library/yql/minikql/comp_nodes/llvm14/ya.make2
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_block_agg.cpp3
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_block_compress.cpp3
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_block_top.cpp1
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_blocks.cpp4
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_chopper.cpp2
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_combine.cpp3
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_decimal_mod.cpp1
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_discard.cpp1
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_ensure.cpp1
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_extend.cpp6
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_flow.cpp2
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_fromstring.cpp3
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp6
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_join.cpp3
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_logical.cpp1
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp2
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_size.cpp1
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_squeeze_to_list.cpp1
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_switch.cpp13
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_todict.cpp4
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_tostring.cpp3
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_wide_chopper.cpp1
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp4
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_wide_filter.cpp3
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_wide_map.cpp2
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_wide_top_sort.cpp5
-rw-r--r--ydb/library/yql/minikql/comp_nodes/mkql_withcontext.cpp1
-rw-r--r--ydb/library/yql/minikql/computation/llvm/ut/ya.make4
-rw-r--r--ydb/library/yql/minikql/computation/llvm/ya.make4
-rw-r--r--ydb/library/yql/minikql/computation/llvm14/ut/ya.make4
-rw-r--r--ydb/library/yql/minikql/computation/llvm14/ya.make2
-rw-r--r--ydb/library/yql/minikql/computation/mkql_computation_node_codegen.cpp5
-rw-r--r--ydb/library/yql/minikql/computation/mkql_computation_node_pack_ut.cpp3
-rw-r--r--ydb/library/yql/minikql/invoke_builtins/llvm/ya.make4
-rw-r--r--ydb/library/yql/minikql/invoke_builtins/llvm14/ya.make2
-rw-r--r--ydb/library/yql/parser/pg_catalog/catalog.cpp2
44 files changed, 37 insertions, 100 deletions
diff --git a/ydb/library/yql/minikql/codegen/codegen.cpp b/ydb/library/yql/minikql/codegen/codegen.cpp
index c84f6622ca..6039330335 100644
--- a/ydb/library/yql/minikql/codegen/codegen.cpp
+++ b/ydb/library/yql/minikql/codegen/codegen.cpp
@@ -1,5 +1,8 @@
#include "codegen.h"
+Y_PRAGMA_DIAGNOSTIC_PUSH
+Y_PRAGMA("GCC diagnostic ignored \"-Wbitwise-instead-of-logical\"")
#include "codegen_llvm_deps.h" // Y_IGNORE
+Y_PRAGMA_DIAGNOSTIC_POP
#include <contrib/libs/re2/re2/re2.h>
#include <util/generic/maybe.h>
@@ -567,9 +570,7 @@ public:
std::unique_ptr<void, void(*)(void*)> delDis(dis, LLVMDisasmDispose);
LLVMSetDisasmOptions(dis, LLVMDisassembler_Option_AsmPrinterVariant);
char outline[1024];
- int pos;
-
- pos = 0;
+ size_t pos = 0;
while (pos < size) {
size_t l = LLVMDisasmInstruction(dis, (uint8_t*)buf + pos, size - pos, 0, outline, sizeof(outline));
if (!l) {
@@ -719,7 +720,9 @@ private:
std::string Diagnostic_;
std::string Triple_;
llvm::Module* Module_;
+#ifdef __linux__
llvm::JITEventListener* PerfListener_ = nullptr;
+#endif
std::unique_ptr<llvm::ExecutionEngine> Engine_;
std::vector<std::pair<llvm::object::SectionRef, ui64>> CodeSections_;
ui64 TotalObjectSize = 0;
diff --git a/ydb/library/yql/minikql/codegen/codegen_ut.cpp b/ydb/library/yql/minikql/codegen/codegen_ut.cpp
index 980ece9d62..42d46384b2 100644
--- a/ydb/library/yql/minikql/codegen/codegen_ut.cpp
+++ b/ydb/library/yql/minikql/codegen/codegen_ut.cpp
@@ -265,6 +265,7 @@ Y_UNIT_TEST_SUITE(TCodegenTests) {
Y_UNIT_TEST(BadFib) {
auto codegen = ICodegen::Make(ETarget::Native);
auto func = CreateBadFibFunction(codegen->GetModule(), codegen->GetContext());
+ Y_UNUSED(func);
UNIT_ASSERT_EXCEPTION(codegen->Verify(), yexception);
}
@@ -298,6 +299,7 @@ Y_UNIT_TEST_SUITE(TCodegenTests) {
Y_UNIT_TEST(LinkWithGeneratedFunction) {
auto codegen = ICodegen::Make(ETarget::Native);
auto mulFunc = CreateMulFunction(codegen->GetModule(), codegen->GetContext());
+ Y_UNUSED(mulFunc);
auto bitcode = NResource::Find("/llvm_bc/Funcs");
codegen->LoadBitCode(bitcode, "Funcs");
auto func = codegen->GetModule().getFunction("sum_sqr");
diff --git a/ydb/library/yql/minikql/codegen/ut/ya.make.inc b/ydb/library/yql/minikql/codegen/ut/ya.make.inc
index 876e6a06e5..2966e584d5 100644
--- a/ydb/library/yql/minikql/codegen/ut/ya.make.inc
+++ b/ydb/library/yql/minikql/codegen/ut/ya.make.inc
@@ -1,7 +1,5 @@
OWNER(g:yql)
-NO_COMPILER_WARNINGS()
-
ADDINCL(
${ARCADIA_BUILD_ROOT}/${MODDIR}
)
diff --git a/ydb/library/yql/minikql/codegen/ya.make.inc b/ydb/library/yql/minikql/codegen/ya.make.inc
index 65b7b788d0..3806c2d4a7 100644
--- a/ydb/library/yql/minikql/codegen/ya.make.inc
+++ b/ydb/library/yql/minikql/codegen/ya.make.inc
@@ -47,8 +47,6 @@ COPY_FILE(
codegen_llvm_deps.h
)
-NO_COMPILER_WARNINGS()
-
IF (NOT WINDOWS)
PEERDIR(
contrib/libs/cxxsupp/builtins
diff --git a/ydb/library/yql/minikql/comp_nodes/llvm/ut/ya.make b/ydb/library/yql/minikql/comp_nodes/llvm/ut/ya.make
index 956d4f4a73..2c2299814b 100644
--- a/ydb/library/yql/minikql/comp_nodes/llvm/ut/ya.make
+++ b/ydb/library/yql/minikql/comp_nodes/llvm/ut/ya.make
@@ -1,7 +1,5 @@
UNITTEST()
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm
ydb/library/yql/minikql/comp_nodes/llvm
@@ -16,4 +14,4 @@ PEERDIR(
INCLUDE(../../ut/ya.make.inc)
-END() \ No newline at end of file
+END()
diff --git a/ydb/library/yql/minikql/comp_nodes/llvm/ya.make b/ydb/library/yql/minikql/comp_nodes/llvm/ya.make
index 1b6561071e..3b55997074 100644
--- a/ydb/library/yql/minikql/comp_nodes/llvm/ya.make
+++ b/ydb/library/yql/minikql/comp_nodes/llvm/ya.make
@@ -5,8 +5,6 @@ OWNER(
g:yql_ydb_core
)
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm
ydb/library/yql/minikql/invoke_builtins/llvm
diff --git a/ydb/library/yql/minikql/comp_nodes/llvm14/ut/ya.make b/ydb/library/yql/minikql/comp_nodes/llvm14/ut/ya.make
index 0126919c93..9c5ddc9e9c 100644
--- a/ydb/library/yql/minikql/comp_nodes/llvm14/ut/ya.make
+++ b/ydb/library/yql/minikql/comp_nodes/llvm14/ut/ya.make
@@ -1,7 +1,5 @@
UNITTEST()
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm14
ydb/library/yql/minikql/comp_nodes/llvm14
@@ -16,4 +14,4 @@ PEERDIR(
INCLUDE(../../ut/ya.make.inc)
-END() \ No newline at end of file
+END()
diff --git a/ydb/library/yql/minikql/comp_nodes/llvm14/ya.make b/ydb/library/yql/minikql/comp_nodes/llvm14/ya.make
index 77eb4fbd8f..25c4a3b55e 100644
--- a/ydb/library/yql/minikql/comp_nodes/llvm14/ya.make
+++ b/ydb/library/yql/minikql/comp_nodes/llvm14/ya.make
@@ -5,8 +5,6 @@ OWNER(
g:yql_ydb_core
)
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm14
ydb/library/yql/minikql/invoke_builtins/llvm14
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_block_agg.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_block_agg.cpp
index ca91d66c45..b74ceec4e7 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_block_agg.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_block_agg.cpp
@@ -509,7 +509,6 @@ public:
auto& context = ctx.Codegen.GetContext();
const auto valueType = Type::getInt128Ty(context);
- const auto ptrValueType = PointerType::getUnqual(valueType);
const auto statusType = Type::getInt32Ty(context);
const auto indexType = Type::getInt64Ty(context);
const auto flagType = Type::getInt1Ty(context);
@@ -609,6 +608,7 @@ public:
ICodegeneratorInlineWideNode::TGettersList getters(AggsParams_.size());
for (size_t idx = 0U; idx < getters.size(); ++idx) {
getters[idx] = [idx, getType, getPtr, indexType, statePtrType, stateOnStack](const TCodegenContext& ctx, BasicBlock*& block) {
+ Y_UNUSED(ctx);
const auto stateArg = new LoadInst(statePtrType, stateOnStack, "state", block);
return CallInst::Create(getType, getPtr, {stateArg, ConstantInt::get(indexType, idx)}, "get", block);
};
@@ -921,7 +921,6 @@ public:
auto& context = ctx.Codegen.GetContext();
const auto valueType = Type::getInt128Ty(context);
- const auto ptrValueType = PointerType::getUnqual(valueType);
const auto statusType = Type::getInt32Ty(context);
const auto indexType = Type::getInt64Ty(context);
const auto flagType = Type::getInt1Ty(context);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_block_compress.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_block_compress.cpp
index b90c759406..ab644753f9 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_block_compress.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_block_compress.cpp
@@ -308,7 +308,6 @@ public:
const auto width = Types_.size() + 1U;
const auto valueType = Type::getInt128Ty(context);
- const auto ptrValueType = PointerType::getUnqual(valueType);
const auto statusType = Type::getInt32Ty(context);
const auto indexType = Type::getInt64Ty(context);
const auto arrayType = ArrayType::get(valueType, width);
@@ -479,7 +478,7 @@ public:
ICodegeneratorInlineWideNode::TGettersList getters(width);
for (size_t idx = 0U; idx < getters.size(); ++idx) {
- getters[idx] = [idx, width, getType, getPtr, heightPtr, indexType, valueType, statePtrType, stateOnStack, getter = getres.second[idx < BitmapIndex_ ? idx : idx + 1U]](const TCodegenContext& ctx, BasicBlock*& block) {
+ getters[idx] = [idx, getType, getPtr, heightPtr, indexType, valueType, statePtrType, stateOnStack, getter = getres.second[idx < BitmapIndex_ ? idx : idx + 1U]](const TCodegenContext& ctx, BasicBlock*& block) {
auto& context = ctx.Codegen.GetContext();
const auto pass = BasicBlock::Create(context, "pass", ctx.Func);
const auto call = BasicBlock::Create(context, "call", ctx.Func);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_block_top.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_block_top.cpp
index be3309b044..c26294a0fa 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_block_top.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_block_top.cpp
@@ -83,7 +83,6 @@ public:
const auto width = Columns_.size() + 1U;
const auto valueType = Type::getInt128Ty(context);
- const auto ptrValueType = PointerType::getUnqual(valueType);
const auto statusType = Type::getInt32Ty(context);
const auto indexType = Type::getInt64Ty(context);
const auto flagType = Type::getInt1Ty(context);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_blocks.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_blocks.cpp
index a719c116f9..3949919faa 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_blocks.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_blocks.cpp
@@ -114,7 +114,6 @@ public:
auto& context = ctx.Codegen.GetContext();
const auto valueType = Type::getInt128Ty(context);
- const auto ptrValueType = PointerType::getUnqual(valueType);
const auto statusType = Type::getInt32Ty(context);
const auto indexType = Type::getInt64Ty(context);
@@ -629,7 +628,7 @@ public:
ICodegeneratorInlineWideNode::TGettersList getters(width);
for (size_t idx = 0U; idx < getters.size(); ++idx) {
- getters[idx] = [idx, width, getType, getPtr, valueType, indexType, arrayType, ptrValuesType, stateType, statePtrType, stateOnStack, getBlocks = getres.second](const TCodegenContext& ctx, BasicBlock*& block) {
+ getters[idx] = [idx, width, getType, getPtr, indexType, arrayType, ptrValuesType, stateType, statePtrType, stateOnStack, getBlocks = getres.second](const TCodegenContext& ctx, BasicBlock*& block) {
auto& context = ctx.Codegen.GetContext();
const auto init = BasicBlock::Create(context, "init", ctx.Func);
const auto call = BasicBlock::Create(context, "call", ctx.Func);
@@ -979,7 +978,6 @@ public:
auto& context = ctx.Codegen.GetContext();
const auto valueType = Type::getInt128Ty(context);
- const auto ptrValueType = PointerType::getUnqual(valueType);
const auto statusType = Type::getInt32Ty(context);
const auto indexType = Type::getInt64Ty(context);
const auto arrayType = ArrayType::get(valueType, Width_);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_chopper.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_chopper.cpp
index ef8c5ffdc6..ee5fe2bc31 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_chopper.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_chopper.cpp
@@ -133,8 +133,6 @@ private:
ctx.Ctx = &*ctx.Func->arg_begin();
ctx.Ctx->addAttr(Attribute::NonNull);
- const auto indexType = Type::getInt32Ty(context);
-
auto block = main;
const auto load = BasicBlock::Create(context, "load", ctx.Func);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_combine.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_combine.cpp
index 575c0aa553..b85d7062d1 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_combine.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_combine.cpp
@@ -256,8 +256,6 @@ public:
const auto valueType = Type::getInt128Ty(context);
const auto ptrValueType = PointerType::getUnqual(valueType);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
- const auto contextType = GetCompContextType(context);
const auto statusType = Type::getInt32Ty(context);
TLLVMFieldsStructureState fieldsStruct(context);
@@ -724,7 +722,6 @@ private:
const auto valueType = Type::getInt128Ty(context);
const auto ptrValueType = PointerType::getUnqual(valueType);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
const auto containerType = codegen.GetEffectiveTarget() == NYql::NCodegen::ETarget::Windows ? static_cast<Type*>(ptrValueType) : static_cast<Type*>(valueType);
const auto contextType = GetCompContextType(context);
const auto statusType = Type::getInt32Ty(context);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_decimal_mod.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_decimal_mod.cpp
index 0f3d35349a..00de4c461d 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_decimal_mod.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_decimal_mod.cpp
@@ -52,7 +52,6 @@ public:
BinaryOperator::CreateAnd(left, right, "test", block):
IsLeftOptional ? left : right;
- const auto check = CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, test, zero, "check", block);
result->addIncoming(zero, block);
BranchInst::Create(done, good, IsEmpty(test, block), block);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_discard.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_discard.cpp
index 0569360d99..71d4d6a697 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_discard.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_discard.cpp
@@ -179,7 +179,6 @@ private:
ctx.Ctx = &*args;
const auto containerArg = &*++args;
- const auto valuePtr = &*++args;
const auto main = BasicBlock::Create(context, "main", ctx.Func);
auto block = main;
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_ensure.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_ensure.cpp
index 74166050dc..2a0fe8b1f4 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_ensure.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_ensure.cpp
@@ -35,7 +35,6 @@ public:
#ifndef MKQL_DISABLE_CODEGEN
Value* DoGenerateGetValue(const TCodegenContext& ctx, BasicBlock*& block) const {
auto& context = ctx.Codegen.GetContext();
- const auto valueType = Type::getInt128Ty(context);
const auto predicate = GetNodeValue(Predicate, ctx, block);
const auto pass = CastInst::Create(Instruction::Trunc, predicate, Type::getInt1Ty(context), "bool", block);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_extend.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_extend.cpp
index 7975d22e74..68ed4cddfe 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_extend.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_extend.cpp
@@ -190,6 +190,7 @@ public:
ICodegeneratorInlineWideNode::TGettersList getters(Width_);
for (size_t idx = 0U; idx < getters.size(); ++idx) {
getters[idx] = [idx, valueType, arrayType, arrayPtr, indexType](const TCodegenContext& ctx, BasicBlock*& block) {
+ Y_UNUSED(ctx);
const auto valuePtr = GetElementPtrInst::CreateInBounds(arrayType, arrayPtr, { ConstantInt::get(indexType, 0), ConstantInt::get(indexType, idx)}, "value_ptr", block);
return new LoadInst(valueType, valuePtr, "value", block);
};
@@ -373,10 +374,6 @@ public:
TLLVMFieldsStructureState stateFields(context);
- const auto stateType = StructType::get(context, stateFields.GetFieldsArray());
- const auto statePtrType = PointerType::getUnqual(stateType);
- const auto funcType = FunctionType::get(Type::getVoidTy(context), {statePtrType}, false);
-
const auto main = BasicBlock::Create(context, "main", ctx.Func);
const auto next = BasicBlock::Create(context, "next", ctx.Func);
const auto done = BasicBlock::Create(context, "done", ctx.Func);
@@ -436,6 +433,7 @@ public:
ICodegeneratorInlineWideNode::TGettersList getters(Width_);
for (size_t idx = 0U; idx < getters.size(); ++idx) {
getters[idx] = [idx, valueType, arrayType, arrayPtr, indexType](const TCodegenContext& ctx, BasicBlock*& block) {
+ Y_UNUSED(ctx);
const auto valuePtr = GetElementPtrInst::CreateInBounds(arrayType, arrayPtr, { ConstantInt::get(indexType, 0), ConstantInt::get(indexType, idx)}, "value_ptr", block);
return new LoadInst(valueType, valuePtr, "value", block);
};
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_flow.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_flow.cpp
index c4744d760b..03c38d72d2 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_flow.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_flow.cpp
@@ -348,7 +348,7 @@ public:
TGettersList getters(Width);
for (auto i = 0U; i < getters.size(); ++i) {
- getters[i] = [idx = TempStateIndex + i, values, valueType, indexType](const TCodegenContext& ctx, BasicBlock*& block) {
+ getters[i] = [idx = TempStateIndex + i, valueType, indexType](const TCodegenContext& ctx, BasicBlock*& block) {
const auto valuePtr = GetElementPtrInst::CreateInBounds(valueType, ctx.GetMutables(), {ConstantInt::get(indexType, idx)}, (TString("ptr_") += ToString(idx)).c_str(), block);
return new LoadInst(valueType, valuePtr, (TString("val_") += ToString(idx)).c_str(), block);
};
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_fromstring.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_fromstring.cpp
index 44a3d8cf7b..c05fbf7741 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_fromstring.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_fromstring.cpp
@@ -9,6 +9,8 @@
#include <ydb/library/yql/public/udf/udf_terminator.h>
#ifndef MKQL_DISABLE_CODEGEN
+Y_PRAGMA_DIAGNOSTIC_PUSH
+Y_PRAGMA("GCC diagnostic ignored \"-Wreturn-type-c-linkage\"")
extern "C" NKikimr::NUdf::TUnboxedValuePod DataFromString(const NKikimr::NUdf::TUnboxedValuePod data, NKikimr::NUdf::EDataSlot slot) {
return NKikimr::NMiniKQL::ValueFromString(slot, data.AsStringRef());
}
@@ -16,6 +18,7 @@ extern "C" NKikimr::NUdf::TUnboxedValuePod DataFromString(const NKikimr::NUdf::T
extern "C" NYql::NDecimal::TInt128 DecimalFromString(const NKikimr::NUdf::TUnboxedValuePod decimal, ui8 precision, ui8 scale) {
return NYql::NDecimal::FromStringEx(decimal.AsStringRef(), precision, scale);
}
+Y_PRAGMA_DIAGNOSTIC_POP
#endif
namespace NKikimr {
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp
index 42df38f9ed..af2b832e77 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp
@@ -637,11 +637,6 @@ class TGraceJoinWrapper : public TStatefulWideFlowCodegeneratorNode<TGraceJoinWr
const auto valueType = Type::getInt128Ty(context);
const auto indexType = Type::getInt32Ty(context);
- const auto ptrValueType = PointerType::getUnqual(valueType);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
- const auto contextType = GetCompContextType(context);
- const auto statusType = Type::getInt32Ty(context);
-
const auto arrayType = ArrayType::get(valueType, OutputRepresentations.size());
const auto fieldsType = ArrayType::get(PointerType::getUnqual(valueType), OutputRepresentations.size());
@@ -663,6 +658,7 @@ class TGraceJoinWrapper : public TStatefulWideFlowCodegeneratorNode<TGraceJoinWr
initF = InsertValueInst::Create(initF, pointers.back(), {i}, (TString("insert_") += ToString(i)).c_str(), atTop);
getters[i] = [i, values, indexType, arrayType, valueType](const TCodegenContext& ctx, BasicBlock*& block) {
+ Y_UNUSED(ctx);
const auto pointer = GetElementPtrInst::CreateInBounds(arrayType, values, {ConstantInt::get(indexType, 0), ConstantInt::get(indexType, i)}, (TString("ptr_") += ToString(i)).c_str(), block);
return new LoadInst(valueType, pointer, (TString("load_") += ToString(i)).c_str(), block);
};
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_join.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_join.cpp
index 1020a706f7..2dcd1161f4 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_join.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_join.cpp
@@ -1162,7 +1162,6 @@ public:
const auto valueType = Type::getInt128Ty(context);
const auto indexType = Type::getInt32Ty(context);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
const auto size = LeftOutputColumns.size() + RightOutputColumns.size();
const auto arrayType = ArrayType::get(valueType, size);
@@ -1185,6 +1184,7 @@ public:
initF = InsertValueInst::Create(initF, pointers.back(), {i}, (TString("insert_") += ToString(i)).c_str(), atTop);
getters[i] = [i, values, valueType, indexType, arrayType](const TCodegenContext& ctx, BasicBlock*& block) {
+ Y_UNUSED(ctx);
const auto pointer = GetElementPtrInst::CreateInBounds(arrayType, values, {ConstantInt::get(indexType, 0), ConstantInt::get(indexType, i)}, (TString("ptr_") += ToString(i)).c_str(), block);
return new LoadInst(valueType, pointer, (TString("load_") += ToString(i)).c_str(), block);
};
@@ -1306,7 +1306,6 @@ private:
const auto contextType = GetCompContextType(context);
const auto resultType = Type::getInt32Ty(context);
const auto funcType = FunctionType::get(resultType, {PointerType::getUnqual(contextType), PointerType::getUnqual(arrayType)}, false);
- const auto indexType = Type::getInt32Ty(context);
TCodegenContext ctx(codegen);
ctx.Func = cast<Function>(module.getOrInsertFunction(name.c_str(), funcType).getCallee());
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_logical.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_logical.cpp
index ed84bd4c5a..f144b99cb6 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_logical.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_logical.cpp
@@ -262,6 +262,7 @@ public:
#ifndef MKQL_DISABLE_CODEGEN
Value* DoGenerateGetValue(const TCodegenContext& ctx, Value* arg, BasicBlock*& block) const {
+ Y_UNUSED(ctx);
const auto xorr = BinaryOperator::CreateXor(arg, ConstantInt::get(arg->getType(), 1), "xor", block);
const auto result = IsOptional ? SelectInst::Create(IsExists(arg, block), xorr, arg, "sel", block) : static_cast<Value*>(xorr);
return result;
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp
index 803652d2cd..64e0431dcf 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp
@@ -1543,7 +1543,6 @@ private:
const auto keysType = IsTuple ? ArrayType::get(valueType, this->LeftKeyColumns.size()) : nullptr;
const auto containerType = codegen.GetEffectiveTarget() == NYql::NCodegen::ETarget::Windows ? static_cast<Type*>(PointerType::getUnqual(valueType)) : static_cast<Type*>(valueType);
const auto contextType = GetCompContextType(context);
- const auto idxType = Type::getInt32Ty(context);
const auto statusType = Type::getInt32Ty(context);
const auto funcType = FunctionType::get(statusType, {PointerType::getUnqual(contextType), containerType, containerType, PointerType::getUnqual(valueType)}, false);
@@ -1699,7 +1698,6 @@ private:
const auto keysType = IsTuple ? ArrayType::get(valueType, this->LeftKeyColumns.size()) : nullptr;
const auto containerType = codegen.GetEffectiveTarget() == NYql::NCodegen::ETarget::Windows ? static_cast<Type*>(PointerType::getUnqual(valueType)) : static_cast<Type*>(valueType);
const auto contextType = GetCompContextType(context);
- const auto idxType = Type::getInt32Ty(context);
const auto statusType = Type::getInt32Ty(context);
const auto funcType = FunctionType::get(statusType, {PointerType::getUnqual(contextType), containerType, containerType, PointerType::getUnqual(valueType), PointerType::getUnqual(valueType), PointerType::getUnqual(valueType)}, false);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_size.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_size.cpp
index a1ef8e6eed..4def910971 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_size.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_size.cpp
@@ -26,6 +26,7 @@ public:
#ifndef MKQL_DISABLE_CODEGEN
Value* DoGenerateGetValue(const TCodegenContext& ctx, Value* value, BasicBlock*& block) const {
+ Y_UNUSED(ctx);
const uint64_t init[] = {Size, 0x100000000000000ULL};
const auto size = ConstantInt::get(value->getType(), APInt(128, 2, init));
return SelectInst::Create(IsEmpty(value, block), value, size, "size", block);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_squeeze_to_list.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_squeeze_to_list.cpp
index 550edda117..a7a450c46d 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_squeeze_to_list.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_squeeze_to_list.cpp
@@ -87,7 +87,6 @@ public:
auto& context = ctx.Codegen.GetContext();
const auto valueType = Type::getInt128Ty(context);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
TLLVMFieldsStructureForState fieldsStruct(context);
const auto stateType = StructType::get(context, fieldsStruct.GetFieldsArray());
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_switch.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_switch.cpp
index 643018d4c5..bcb37a5837 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_switch.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_switch.cpp
@@ -295,10 +295,6 @@ private:
ctx.Ctx = &*ctx.Func->arg_begin();
ctx.Ctx->addAttr(Attribute::NonNull);
- const auto ptrValueType = PointerType::getUnqual(valueType);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
- const auto contextType = GetCompContextType(context);
- const auto statusType = Type::getInt32Ty(context);
const auto indexType = Type::getInt32Ty(context);
TLLVMFieldsStructureForFlowState fieldsStruct(context);
const auto stateType = StructType::get(context, fieldsStruct.GetFieldsArray());
@@ -362,8 +358,6 @@ private:
const auto choise = SwitchInst::Create(unpack.first, loop, handler.InputIndices.size(), block);
for (ui32 idx = 0U; idx < handler.InputIndices.size(); ++idx) {
- const auto index = ConstantInt::get(indexType, idx);
-
const auto var = BasicBlock::Create(context, (TString("var_") += ToString(idx)).c_str(), ctx.Func);
choise->addCase(ConstantInt::get(indexType, handler.InputIndices[idx]), var);
@@ -384,9 +378,6 @@ public:
auto& context = ctx.Codegen.GetContext();
const auto valueType = Type::getInt128Ty(context);
- const auto ptrValueType = PointerType::getUnqual(valueType);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
- const auto contextType = GetCompContextType(context);
const auto statusType = Type::getInt32Ty(context);
const auto indexType = Type::getInt32Ty(context);
TLLVMFieldsStructureForFlowState fieldsStruct(context);
@@ -819,7 +810,6 @@ private:
const auto valueType = Type::getInt128Ty(context);
const auto ptrValueType = PointerType::getUnqual(valueType);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
const auto containerType = codegen.GetEffectiveTarget() == NYql::NCodegen::ETarget::Windows ? static_cast<Type*>(ptrValueType) : static_cast<Type*>(valueType);
const auto contextType = GetCompContextType(context);
const auto statusType = Type::getInt32Ty(context);
@@ -942,9 +932,6 @@ private:
block = good;
- const auto factory = ctx.GetFactory();
- const auto func = ConstantInt::get(Type::getInt64Ty(context), GetMethodPtr(&THolderFactory::CreateVariantHolder));
-
const auto choise = SwitchInst::Create(index, stub, Handlers.size(), block);
for (ui32 i = 0U; i < Handlers.size(); ++i) {
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_todict.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_todict.cpp
index 220fc19ebd..558fa8fd2e 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_todict.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_todict.cpp
@@ -949,7 +949,6 @@ public:
MKQL_ENSURE(codegenItemArg, "Item must be codegenerator node.");
const auto valueType = Type::getInt128Ty(context);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
TLLVMFieldsStructureStateWithAccum<TLLVMFieldsStructure<TComputationValue<TState>>> fieldsStruct(context);
const auto stateType = StructType::get(context, fieldsStruct.GetFieldsArray());
@@ -1139,7 +1138,6 @@ public:
auto& context = ctx.Codegen.GetContext();
const auto valueType = Type::getInt128Ty(context);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
TLLVMFieldsStructureStateWithAccum<TLLVMFieldsStructure<TComputationValue<TState>>> fieldsStruct(context);
const auto stateType = StructType::get(context, fieldsStruct.GetFieldsArray());
@@ -1460,7 +1458,6 @@ public:
MKQL_ENSURE(codegenItemArg, "Item must be codegenerator node.");
const auto valueType = Type::getInt128Ty(context);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
TLLVMFieldsStructureStateWithAccum<TLLVMFieldsStructure<TComputationValue<TState>>> fieldsStruct(context);
const auto stateType = StructType::get(context, fieldsStruct.GetFieldsArray());
@@ -1658,7 +1655,6 @@ public:
auto& context = ctx.Codegen.GetContext();
const auto valueType = Type::getInt128Ty(context);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
TLLVMFieldsStructureStateWithAccum<TLLVMFieldsStructure<TComputationValue<TState>>> fieldsStruct(context);
const auto stateType = StructType::get(context, fieldsStruct.GetFieldsArray());
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_tostring.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_tostring.cpp
index b60f141261..407803912c 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_tostring.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_tostring.cpp
@@ -11,6 +11,8 @@
#include <ydb/library/yql/public/udf/udf_terminator.h>
#ifndef MKQL_DISABLE_CODEGEN
+Y_PRAGMA_DIAGNOSTIC_PUSH
+Y_PRAGMA("GCC diagnostic ignored \"-Wreturn-type-c-linkage\"")
extern "C" NYql::NUdf::TUnboxedValuePod DataToString(NYql::NUdf::TUnboxedValuePod data, NYql::NUdf::EDataSlot slot) {
return NKikimr::NMiniKQL::ValueToString(slot, data);
}
@@ -21,6 +23,7 @@ extern "C" NYql::NUdf::TUnboxedValuePod DecimalToString(NYql::NDecimal::TInt128
}
return NYql::NUdf::TUnboxedValuePod();
}
+Y_PRAGMA_DIAGNOSTIC_POP
#endif
namespace NKikimr {
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_wide_chopper.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_wide_chopper.cpp
index 8a32efc421..7810b0efc7 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_wide_chopper.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_wide_chopper.cpp
@@ -292,7 +292,6 @@ public:
for (ui32 i = 0U; i < Keys.size(); ++i) {
if (KeyArgs[i]->GetDependencesCount() > 0U) {
- const auto map = KeysOnItems[i];
const auto key = GetNodeValue(Keys[i], ctx, block);
EnsureDynamicCast<ICodegeneratorExternalNode*>(KeyArgs[i])->CreateSetValue(ctx, block, key);
}
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp
index 7a3f0f3d09..418a141b8e 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp
@@ -430,8 +430,6 @@ public:
const auto statePtrType = PointerType::getUnqual(stateType);
- const auto keys = new AllocaInst(ArrayType::get(valueType, Nodes.KeyResultNodes.size()), 0U, "keys", &ctx.Func->getEntryBlock().back());
-
const auto make = BasicBlock::Create(context, "make", ctx.Func);
const auto main = BasicBlock::Create(context, "main", ctx.Func);
const auto more = BasicBlock::Create(context, "more", ctx.Func);
@@ -829,8 +827,6 @@ public:
const auto stateType = StructType::get(context, stateFields.GetFieldsArray());
const auto statePtrType = PointerType::getUnqual(stateType);
- const auto keys = new AllocaInst(ArrayType::get(valueType, Nodes.KeyResultNodes.size()), 0U, "keys", &ctx.Func->getEntryBlock().back());
-
const auto make = BasicBlock::Create(context, "make", ctx.Func);
const auto main = BasicBlock::Create(context, "main", ctx.Func);
const auto more = BasicBlock::Create(context, "more", ctx.Func);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_wide_filter.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_wide_filter.cpp
index ef9e5ef89a..e54effbe2e 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_wide_filter.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_wide_filter.cpp
@@ -284,9 +284,6 @@ public:
const auto result = PHINode::Create(resultType, 4U, "result", done);
result->addIncoming(ConstantInt::get(resultType, static_cast<i32>(EFetchResult::Finish)), block);
- const auto state = new LoadInst(Type::getInt128Ty(context), statePtr, "state", block);
- const auto finished = CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, state, GetTrue(context), "finished", block);
-
BranchInst::Create(done, work, IsValid(statePtr, block), block);
block = work;
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_wide_map.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_wide_map.cpp
index 5e37dd99bf..e6b467dcb4 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_wide_map.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_wide_map.cpp
@@ -125,8 +125,6 @@ public:
TGenerateResult DoGenGetValues(const TCodegenContext& ctx, BasicBlock*& block) const {
auto& context = ctx.Codegen.GetContext();
- const auto valueType = Type::getInt128Ty(context);
-
const auto result = GetNodeValues(Flow, ctx, block);
const auto good = CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_SGT, result.first, ConstantInt::get(result.first->getType(), 0), "good", block);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_wide_top_sort.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_wide_top_sort.cpp
index 0a873284bf..3715f4bc4f 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_wide_top_sort.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_wide_top_sort.cpp
@@ -327,8 +327,6 @@ public:
const auto valueType = Type::getInt128Ty(context);
const auto ptrValueType = PointerType::getUnqual(valueType);
- const auto structPtrType = PointerType::getUnqual(StructType::get(context));
- const auto contextType = GetCompContextType(context);
const auto statusType = Type::getInt32Ty(context);
const auto indexType = Type::getInt32Ty(ctx.Codegen.GetContext());
@@ -345,6 +343,7 @@ public:
for (auto i = 0U; i < getters.size(); ++i) {
getters[Indexes[i]] = [i, outs, indexType, valueType, outputPtrType, outputType](const TCodegenContext& ctx, BasicBlock*& block) {
+ Y_UNUSED(ctx);
const auto values = new LoadInst(outputPtrType, outs, "values", block);
const auto pointer = GetElementPtrInst::CreateInBounds(outputType, values, {ConstantInt::get(indexType, 0), ConstantInt::get(indexType, i)}, (TString("ptr_") += ToString(i)).c_str(), block);
return new LoadInst(valueType, pointer, (TString("load_") += ToString(i)).c_str(), block);
@@ -438,7 +437,7 @@ public:
}
if constexpr (!HasCount) {
- for (auto i = 0; i < Representations.size(); ++i) {
+ for (auto i = 0U; i < Representations.size(); ++i) {
const auto item = getres.second[Indexes[i]](ctx, block);
ValueAddRef(Representations[i], item, ctx, block);
new StoreInst(item, placeholders[i], block);
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_withcontext.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_withcontext.cpp
index 9358f9adf7..0e23cdc011 100644
--- a/ydb/library/yql/minikql/comp_nodes/mkql_withcontext.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/mkql_withcontext.cpp
@@ -250,6 +250,7 @@ public:
for (auto idx = 0U; idx < getres.second.size(); ++idx) {
getres.second[idx] = [idx, arrayPtr, arrayType, indexType, valueType] (const TCodegenContext& ctx, BasicBlock*& block) {
+ Y_UNUSED(ctx);
const auto itemPtr = GetElementPtrInst::CreateInBounds(arrayType, arrayPtr, {ConstantInt::get(indexType, 0), ConstantInt::get(indexType, idx)}, (TString("ptr_") += ToString(idx)).c_str(), block);
return new LoadInst(valueType, itemPtr, (TString("item_") += ToString(idx)).c_str(), block);
};
diff --git a/ydb/library/yql/minikql/computation/llvm/ut/ya.make b/ydb/library/yql/minikql/computation/llvm/ut/ya.make
index c071a36450..650ac0271f 100644
--- a/ydb/library/yql/minikql/computation/llvm/ut/ya.make
+++ b/ydb/library/yql/minikql/computation/llvm/ut/ya.make
@@ -1,7 +1,5 @@
UNITTEST()
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm
ydb/library/yql/minikql/computation/llvm
@@ -16,4 +14,4 @@ PEERDIR(
INCLUDE(../../ut/ya.make.inc)
-END() \ No newline at end of file
+END()
diff --git a/ydb/library/yql/minikql/computation/llvm/ya.make b/ydb/library/yql/minikql/computation/llvm/ya.make
index a70fa31127..5c14353315 100644
--- a/ydb/library/yql/minikql/computation/llvm/ya.make
+++ b/ydb/library/yql/minikql/computation/llvm/ya.make
@@ -1,7 +1,5 @@
LIBRARY()
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm
contrib/libs/llvm12/lib/IR
@@ -18,4 +16,4 @@ END()
RECURSE_FOR_TESTS(
ut
-) \ No newline at end of file
+)
diff --git a/ydb/library/yql/minikql/computation/llvm14/ut/ya.make b/ydb/library/yql/minikql/computation/llvm14/ut/ya.make
index 93e6274423..8d3868de11 100644
--- a/ydb/library/yql/minikql/computation/llvm14/ut/ya.make
+++ b/ydb/library/yql/minikql/computation/llvm14/ut/ya.make
@@ -1,7 +1,5 @@
UNITTEST()
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm14
ydb/library/yql/minikql/computation/llvm14
@@ -16,4 +14,4 @@ PEERDIR(
INCLUDE(../../ut/ya.make.inc)
-END() \ No newline at end of file
+END()
diff --git a/ydb/library/yql/minikql/computation/llvm14/ya.make b/ydb/library/yql/minikql/computation/llvm14/ya.make
index 222a8b1bed..45349c7db7 100644
--- a/ydb/library/yql/minikql/computation/llvm14/ya.make
+++ b/ydb/library/yql/minikql/computation/llvm14/ya.make
@@ -1,7 +1,5 @@
LIBRARY()
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm14
contrib/libs/llvm14/lib/IR
diff --git a/ydb/library/yql/minikql/computation/mkql_computation_node_codegen.cpp b/ydb/library/yql/minikql/computation/mkql_computation_node_codegen.cpp
index 06e62e7101..8d9f9bedcf 100644
--- a/ydb/library/yql/minikql/computation/mkql_computation_node_codegen.cpp
+++ b/ydb/library/yql/minikql/computation/mkql_computation_node_codegen.cpp
@@ -976,7 +976,7 @@ void GenInvalidate(const TCodegenContext& ctx, const std::vector<std::pair<ui32,
const auto valueType = Type::getInt128Ty(context);
const auto values = ctx.GetMutables();
- for (const auto index : invalidationSet) {
+ for (const auto& index : invalidationSet) {
const auto invPtr = GetElementPtrInst::CreateInBounds(valueType, values, {ConstantInt::get(indexType, index.first)}, "inv_ptr", block);
ValueUnRef(index.second, invPtr, ctx, block);
new StoreInst(GetInvalid(context), invPtr, block);
@@ -1726,7 +1726,7 @@ void SafeUnRefUnboxed(Value* pointer, const TCodegenContext& ctx, BasicBlock*& b
if (const auto itemType = pointer->getType()->getPointerElementType(); itemType->isArrayTy()) {
const auto indexType = Type::getInt64Ty(ctx.Codegen.GetContext());
Value* zeros = UndefValue::get(itemType);
- for (size_t idx = 0U; idx < itemType->getArrayNumElements(); ++idx) {
+ for (ui32 idx = 0U; idx < itemType->getArrayNumElements(); ++idx) {
const auto item = GetElementPtrInst::CreateInBounds(itemType, pointer, { ConstantInt::get(indexType, 0), ConstantInt::get(indexType, idx) }, (TString("item_") += ToString(idx)).c_str(), block);
UnRefUnboxed(item, ctx, block);
zeros = InsertValueInst::Create(zeros, ConstantInt::get(itemType->getArrayElementType(), 0), {idx}, (TString("zero_") += ToString(idx)).c_str(), block);
@@ -2004,7 +2004,6 @@ Value* CheckAdjustedMemLimit(ui64 limit, Value* init, const TCodegenContext& ctx
BranchInst::Create(call, skip, now, block);
block = call;
- const auto fact = ctx.Ctx;
const auto func = ConstantInt::get(Type::getInt64Ty(context), GetMethodPtr(&TComputationContext::UpdateUsageAdjustor));
const auto funType = FunctionType::get(Type::getVoidTy(context), {ctx.Ctx->getType(), Type::getInt64Ty(context)}, false);
const auto funcPtr = CastInst::Create(Instruction::IntToPtr, func, PointerType::getUnqual(funType), "update", block);
diff --git a/ydb/library/yql/minikql/computation/mkql_computation_node_pack_ut.cpp b/ydb/library/yql/minikql/computation/mkql_computation_node_pack_ut.cpp
index fd46cf1986..0a9ea5595b 100644
--- a/ydb/library/yql/minikql/computation/mkql_computation_node_pack_ut.cpp
+++ b/ydb/library/yql/minikql/computation/mkql_computation_node_pack_ut.cpp
@@ -611,9 +611,8 @@ protected:
auto listObj = listPacker.Unpack(TRope(serialized), HolderFactory);
UNIT_ASSERT_VALUES_EQUAL(listObj.GetListLength(), count);
- ui32 i = 0;
const auto iter = listObj.GetListIterator();
- for (NUdf::TUnboxedValue uVal; iter.Next(uVal); ++i) {
+ for (NUdf::TUnboxedValue uVal; iter.Next(uVal);) {
UNIT_ASSERT(uVal);
UNIT_ASSERT_VALUES_EQUAL(std::string_view(uVal.AsStringRef()), str);
}
diff --git a/ydb/library/yql/minikql/invoke_builtins/llvm/ya.make b/ydb/library/yql/minikql/invoke_builtins/llvm/ya.make
index 582e335163..cb6318a407 100644
--- a/ydb/library/yql/minikql/invoke_builtins/llvm/ya.make
+++ b/ydb/library/yql/minikql/invoke_builtins/llvm/ya.make
@@ -1,7 +1,5 @@
LIBRARY()
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm
ydb/library/yql/minikql/computation/llvm
@@ -21,4 +19,4 @@ END()
RECURSE_FOR_TESTS(
ut
-) \ No newline at end of file
+)
diff --git a/ydb/library/yql/minikql/invoke_builtins/llvm14/ya.make b/ydb/library/yql/minikql/invoke_builtins/llvm14/ya.make
index dc02aeea21..6123d1a848 100644
--- a/ydb/library/yql/minikql/invoke_builtins/llvm14/ya.make
+++ b/ydb/library/yql/minikql/invoke_builtins/llvm14/ya.make
@@ -5,8 +5,6 @@ OWNER(
g:yql_ydb_core
)
-NO_COMPILER_WARNINGS()
-
PEERDIR(
ydb/library/yql/minikql/codegen/llvm14
ydb/library/yql/minikql/computation/llvm14
diff --git a/ydb/library/yql/parser/pg_catalog/catalog.cpp b/ydb/library/yql/parser/pg_catalog/catalog.cpp
index 5cd7c26fb4..2a301546eb 100644
--- a/ydb/library/yql/parser/pg_catalog/catalog.cpp
+++ b/ydb/library/yql/parser/pg_catalog/catalog.cpp
@@ -1503,7 +1503,7 @@ struct TCatalog {
}
for (const auto& c: AllStaticColumns) {
- auto tablePtr = StaticColumns.FindPtr(TTableInfo(c.Schema, c.TableName));
+ auto tablePtr = StaticColumns.FindPtr(TTableInfo{c.Schema, c.TableName});
Y_ENSURE(tablePtr);
tablePtr->push_back(c);
}