aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsabdenovch <sabdenovch@yandex-team.com>2025-03-02 02:57:13 +0300
committersabdenovch <sabdenovch@yandex-team.com>2025-03-02 03:12:26 +0300
commitcc146d6998417dbfbfcdce7c65f522e276b44af0 (patch)
treec0a466893a4642ef55d62da8bc221289ce4f551b
parent5a9dddd79ace81bab6ef8d50390c5ce268d350e9 (diff)
downloadydb-cc146d6998417dbfbfcdce7c65f522e276b44af0.tar.gz
Cosmetics in QL test
commit_hash:5963f3bfc09538d500fa3733677bff3be8d3dccd
-rw-r--r--yt/yt/client/table_client/helpers.cpp17
-rw-r--r--yt/yt/client/table_client/helpers.h15
2 files changed, 15 insertions, 17 deletions
diff --git a/yt/yt/client/table_client/helpers.cpp b/yt/yt/client/table_client/helpers.cpp
index 680f5f995b..857893c458 100644
--- a/yt/yt/client/table_client/helpers.cpp
+++ b/yt/yt/client/table_client/helpers.cpp
@@ -164,7 +164,7 @@ void YTreeNodeToUnversionedValue(
} // namespace
TUnversionedOwningRow YsonToSchemafulRow(
- const TString& yson,
+ TStringBuf yson,
const TTableSchema& tableSchema,
bool treatMissingAsNull,
NYson::EYsonType ysonType,
@@ -172,8 +172,7 @@ TUnversionedOwningRow YsonToSchemafulRow(
{
auto nameTable = TNameTable::FromSchema(tableSchema);
- auto rowParts = ConvertTo<THashMap<TString, INodePtr>>(
- TYsonString(yson, ysonType));
+ auto rowParts = ConvertTo<THashMap<TString, INodePtr>>(TYsonString(yson, ysonType));
TUnversionedOwningRowBuilder rowBuilder;
auto validateAndAddValue = [&rowBuilder, &validateValues] (const TUnversionedValue& value, const TColumnSchema& column) {
@@ -266,7 +265,7 @@ TUnversionedOwningRow YsonToSchemafulRow(
return rowBuilder.FinishRow();
}
-TUnversionedOwningRow YsonToSchemalessRow(const TString& valueYson)
+TUnversionedOwningRow YsonToSchemalessRow(TStringBuf valueYson)
{
TUnversionedOwningRowBuilder builder;
@@ -285,8 +284,8 @@ TUnversionedOwningRow YsonToSchemalessRow(const TString& valueYson)
TVersionedRow YsonToVersionedRow(
const TRowBufferPtr& rowBuffer,
- const TString& keyYson,
- const TString& valueYson,
+ TStringBuf keyYson,
+ TStringBuf valueYson,
const std::vector<TTimestamp>& deleteTimestamps,
const std::vector<TTimestamp>& extraWriteTimestamps)
{
@@ -349,8 +348,8 @@ TVersionedRow YsonToVersionedRow(
}
TVersionedOwningRow YsonToVersionedRow(
- const TString& keyYson,
- const TString& valueYson,
+ TStringBuf keyYson,
+ TStringBuf valueYson,
const std::vector<TTimestamp>& deleteTimestamps,
const std::vector<TTimestamp>& extraWriteTimestamps)
{
@@ -360,7 +359,7 @@ TVersionedOwningRow YsonToVersionedRow(
return TVersionedOwningRow(row);
}
-TUnversionedOwningRow YsonToKey(const TString& yson)
+TUnversionedOwningRow YsonToKey(TStringBuf yson)
{
TUnversionedOwningRowBuilder keyBuilder;
auto keyParts = ConvertTo<std::vector<INodePtr>>(
diff --git a/yt/yt/client/table_client/helpers.h b/yt/yt/client/table_client/helpers.h
index d1c5d17325..36bbff3498 100644
--- a/yt/yt/client/table_client/helpers.h
+++ b/yt/yt/client/table_client/helpers.h
@@ -34,25 +34,24 @@ NChunkClient::EChunkFormat DefaultFormatFromOptimizeFor(
// Mostly used in unittests and for debugging purposes.
// Quite inefficient.
TUnversionedOwningRow YsonToSchemafulRow(
- const TString& yson,
+ TStringBuf yson,
const TTableSchema& tableSchema,
bool treatMissingAsNull,
NYson::EYsonType ysonType = NYson::EYsonType::MapFragment,
bool validateValues = false);
-TUnversionedOwningRow YsonToSchemalessRow(
- const TString& yson);
+TUnversionedOwningRow YsonToSchemalessRow(TStringBuf yson);
TVersionedRow YsonToVersionedRow(
const TRowBufferPtr& rowBuffer,
- const TString& keyYson,
- const TString& valueYson,
+ TStringBuf keyYson,
+ TStringBuf valueYson,
const std::vector<TTimestamp>& deleteTimestamps = {},
const std::vector<TTimestamp>& extraWriteTimestamps = {});
TVersionedOwningRow YsonToVersionedRow(
- const TString& keyYson,
- const TString& valueYson,
+ TStringBuf keyYson,
+ TStringBuf valueYson,
const std::vector<TTimestamp>& deleteTimestamps = {},
const std::vector<TTimestamp>& extraWriteTimestamps = {});
-TUnversionedOwningRow YsonToKey(const TString& yson);
+TUnversionedOwningRow YsonToKey(TStringBuf yson);
TString KeyToYson(TUnversionedRow row);
////////////////////////////////////////////////////////////////////////////////