aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorhor911 <hor911@ydb.tech>2023-03-22 18:28:59 +0300
committerhor911 <hor911@ydb.tech>2023-03-22 18:28:59 +0300
commitca8d36afbd5dc9dd2ed0f3e11a695f12c5488d54 (patch)
tree4bc11213540a186658fc99b6b22b68ff96b83346
parent5e0b4427e78b2c36babe490cd2b6dce5f1cc9b99 (diff)
downloadydb-ca8d36afbd5dc9dd2ed0f3e11a695f12c5488d54.tar.gz
Allow (ignore) issues in SUCCESS, do not fail query if StatusCode is not set
-rw-r--r--ydb/core/fq/libs/actors/run_actor.cpp14
1 files changed, 5 insertions, 9 deletions
diff --git a/ydb/core/fq/libs/actors/run_actor.cpp b/ydb/core/fq/libs/actors/run_actor.cpp
index 586bfb99764..dc44f752c82 100644
--- a/ydb/core/fq/libs/actors/run_actor.cpp
+++ b/ydb/core/fq/libs/actors/run_actor.cpp
@@ -1143,20 +1143,16 @@ private:
SaveQueryResponse(ev);
- const bool failure = Issues.Size() > 0;
- {
- auto statusCode = ev->Get()->Record.GetStatusCode();
- if (statusCode == NYql::NDqProto::StatusIds::UNSPECIFIED
- || (failure != (ev->Get()->Record.GetStatusCode() != NYql::NDqProto::StatusIds::SUCCESS))
- ) {
- QueryCounters.Counters->GetCounter(NYql::NDqProto::StatusIds_StatusCode_Name(statusCode), false)->Inc();
- }
+ auto statusCode = ev->Get()->Record.GetStatusCode();
+ if (statusCode == NYql::NDqProto::StatusIds::UNSPECIFIED) {
+ LOG_E("StatusCode == NYql::NDqProto::StatusIds::UNSPECIFIED, it is not expected, the query will be failed.");
}
+ const bool failure = statusCode != NYql::NDqProto::StatusIds::SUCCESS;
const bool finalize = failure || DqGraphIndex + 1 >= static_cast<i32>(DqGraphParams.size());
if (finalize) {
if (failure) {
- ResignQuery(ev->Get()->Record.GetStatusCode());
+ ResignQuery(statusCode);
return;
}