diff options
author | babenko <babenko@yandex-team.com> | 2024-06-11 07:49:25 +0300 |
---|---|---|
committer | babenko <babenko@yandex-team.com> | 2024-06-11 07:57:48 +0300 |
commit | ca4183836a7f147ab01cf4c617b09f2f0ebd9155 (patch) | |
tree | 532b6a3cdb4997b844ae2a9ec221a031485c5fd4 | |
parent | b7c3a9599b8242d20ee8249d6c394a5ace6866d0 (diff) | |
download | ydb-ca4183836a7f147ab01cf4c617b09f2f0ebd9155.tar.gz |
Fix style of commented argument names
23312d4c81ec46ab94f4050a8b465222e9757beb
-rw-r--r-- | yt/yt/client/chunk_client/read_limit.cpp | 6 | ||||
-rw-r--r-- | yt/yt/client/table_client/unversioned_row.cpp | 2 | ||||
-rw-r--r-- | yt/yt/client/unittests/key_ut.cpp | 2 | ||||
-rw-r--r-- | yt/yt/client/unittests/read_limit_ut.cpp | 14 | ||||
-rw-r--r-- | yt/yt/core/concurrency/fiber.cpp | 2 | ||||
-rw-r--r-- | yt/yt/core/concurrency/fiber_scheduler_thread.cpp | 2 | ||||
-rw-r--r-- | yt/yt/core/misc/unittests/consistent_hashing_ut.cpp | 4 | ||||
-rw-r--r-- | yt/yt/core/misc/unittests/error_ut.cpp | 2 | ||||
-rw-r--r-- | yt/yt/core/ytree/ypath_detail.cpp | 2 | ||||
-rw-r--r-- | yt/yt/library/formats/skiff_yson_converter.cpp | 2 |
10 files changed, 19 insertions, 19 deletions
diff --git a/yt/yt/client/chunk_client/read_limit.cpp b/yt/yt/client/chunk_client/read_limit.cpp index e862c18a54..3218442a28 100644 --- a/yt/yt/client/chunk_client/read_limit.cpp +++ b/yt/yt/client/chunk_client/read_limit.cpp @@ -875,10 +875,10 @@ TReadRange::TReadRange( int keyLength) { if (range.has_lower_limit()) { - LowerLimit_ = TReadLimit(range.lower_limit(), /* isUpper */false, keyLength); + LowerLimit_ = TReadLimit(range.lower_limit(), /* isUpper */ false, keyLength); } if (range.has_upper_limit()) { - UpperLimit_ = TReadLimit(range.upper_limit(), /* isUpper */true, keyLength); + UpperLimit_ = TReadLimit(range.upper_limit(), /* isUpper */ true, keyLength); } } @@ -940,7 +940,7 @@ void Serialize(const TReadRange& readLimit, NYson::IYsonConsumer* consumer) //////////////////////////////////////////////////////////////////////////////// -REGISTER_INTERMEDIATE_PROTO_INTEROP_BYTES_FIELD_REPRESENTATION(NProto::TReadLimit, /*key*/4, TUnversionedOwningRow) +REGISTER_INTERMEDIATE_PROTO_INTEROP_BYTES_FIELD_REPRESENTATION(NProto::TReadLimit, /*key*/ 4, TUnversionedOwningRow) //////////////////////////////////////////////////////////////////////////////// diff --git a/yt/yt/client/table_client/unversioned_row.cpp b/yt/yt/client/table_client/unversioned_row.cpp index 69fba276ae..5828593b3a 100644 --- a/yt/yt/client/table_client/unversioned_row.cpp +++ b/yt/yt/client/table_client/unversioned_row.cpp @@ -787,7 +787,7 @@ void ValidateClientRow( } const auto& column = schema.Columns()[mappedId]; - ValidateValueType(value, schema, mappedId, /*typeAnyAcceptsAllValues*/false); + ValidateValueType(value, schema, mappedId, /*typeAnyAcceptsAllValues*/ false); if (Any(value.Flags & EValueFlags::Aggregate) && !column.Aggregate()) { THROW_ERROR_EXCEPTION( diff --git a/yt/yt/client/unittests/key_ut.cpp b/yt/yt/client/unittests/key_ut.cpp index 0d35528f7b..25fccea3df 100644 --- a/yt/yt/client/unittests/key_ut.cpp +++ b/yt/yt/client/unittests/key_ut.cpp @@ -31,7 +31,7 @@ TEST(TKeyTest, Simple) } { TUnversionedOwningRow shortenedRow(row.FirstNElements(2)); - auto key = TKey::FromRow(row, /*length*/2); + auto key = TKey::FromRow(row, /*length*/ 2); EXPECT_EQ(shortenedRow, key.AsOwningRow()); EXPECT_EQ(row.Begin(), key.Begin()); EXPECT_EQ(2, key.GetLength()); diff --git a/yt/yt/client/unittests/read_limit_ut.cpp b/yt/yt/client/unittests/read_limit_ut.cpp index 1f08d4c945..83a20aa040 100644 --- a/yt/yt/client/unittests/read_limit_ut.cpp +++ b/yt/yt/client/unittests/read_limit_ut.cpp @@ -61,7 +61,7 @@ TEST(TLegacyReadRangeTest, Simple2) TEST(TReadLimitTest, ProtobufConversion) { TReadLimit readLimit; - auto keyBound = TOwningKeyBound::FromRow(/* prefix */MakeRow({1, 42}), /* isUpper */true, /* isInclusive */true); + auto keyBound = TOwningKeyBound::FromRow(/* prefix */ MakeRow({1, 42}), /* isUpper */ true, /* isInclusive */ true); readLimit.KeyBound() = keyBound; readLimit.SetRowIndex(1); readLimit.SetOffset(2); @@ -71,7 +71,7 @@ TEST(TReadLimitTest, ProtobufConversion) NProto::TReadLimit protoReadLimit; ToProto(&protoReadLimit, readLimit); - TReadLimit newReadLimit(protoReadLimit, /* isUpper */true); + TReadLimit newReadLimit(protoReadLimit, /* isUpper */ true); EXPECT_EQ(newReadLimit.KeyBound(), keyBound); EXPECT_EQ(newReadLimit.GetRowIndex(), 1); @@ -83,7 +83,7 @@ TEST(TReadLimitTest, ProtobufConversion) TEST(TReadLimitTest, LegacyKey) { TReadLimit readLimit; - auto keyBound = TOwningKeyBound::FromRow(/* prefix */MakeRow({1, 42}), /* isInclusive */true, /* isUpper */true); + auto keyBound = TOwningKeyBound::FromRow(/* prefix */ MakeRow({1, 42}), /* isInclusive */ true, /* isUpper */ true); readLimit.KeyBound() = keyBound; readLimit.SetRowIndex(1); readLimit.SetOffset(2); @@ -96,7 +96,7 @@ TEST(TReadLimitTest, LegacyKey) protoReadLimit.clear_key_bound_prefix(); protoReadLimit.clear_key_bound_is_inclusive(); - TReadLimit newReadLimit(protoReadLimit, /* isUpper */true, /* keyLength */2); + TReadLimit newReadLimit(protoReadLimit, /* isUpper */ true, /* keyLength */ 2); EXPECT_EQ(newReadLimit.KeyBound(), keyBound); EXPECT_EQ(newReadLimit.GetRowIndex(), 1); @@ -149,17 +149,17 @@ TEST(TReadLimitTest, Trivial) NProto::TReadLimit protoReadLimit; ToProto(&protoReadLimit, readLimit); - TReadLimit newReadLimit(protoReadLimit, /* isUpper */true); + TReadLimit newReadLimit(protoReadLimit, /* isUpper */ true); EXPECT_TRUE(newReadLimit.IsTrivial()); } TEST(TReadRangeTest, ProtobufConversion) { TReadRange readRange; - auto lowerKeyBound = TOwningKeyBound::FromRow(/* prefix */MakeRow({1, 42}), /* isInclusive */true, /* isUpper */false); + auto lowerKeyBound = TOwningKeyBound::FromRow(/* prefix */ MakeRow({1, 42}), /* isInclusive */ true, /* isUpper */ false); readRange.LowerLimit().KeyBound() = lowerKeyBound; readRange.LowerLimit().SetRowIndex(1); - auto upperKeyBound = TOwningKeyBound::FromRow(/* prefix */MakeRow({12, 13}), /* isInclusive */true, /* isUpper */true); + auto upperKeyBound = TOwningKeyBound::FromRow(/* prefix */ MakeRow({12, 13}), /* isInclusive */ true, /* isUpper */ true); readRange.UpperLimit().KeyBound() = upperKeyBound; readRange.UpperLimit().SetRowIndex(2); diff --git a/yt/yt/core/concurrency/fiber.cpp b/yt/yt/core/concurrency/fiber.cpp index 032bc53fa7..b9bc55c9c3 100644 --- a/yt/yt/core/concurrency/fiber.cpp +++ b/yt/yt/core/concurrency/fiber.cpp @@ -151,7 +151,7 @@ private: auto guard = Guard(Lock_); while(GuardedProcessQueues()); }), - /*priority*/std::numeric_limits<int>::min()); + /*priority*/ std::numeric_limits<int>::min()); } #endif diff --git a/yt/yt/core/concurrency/fiber_scheduler_thread.cpp b/yt/yt/core/concurrency/fiber_scheduler_thread.cpp index 39efb9f1c3..550f4b84ea 100644 --- a/yt/yt/core/concurrency/fiber_scheduler_thread.cpp +++ b/yt/yt/core/concurrency/fiber_scheduler_thread.cpp @@ -403,7 +403,7 @@ private: const TShutdownCookie ShutdownCookie_ = RegisterShutdownCallback( "IdleFiberPool", BIND_NO_PROPAGATE(&TIdleFiberPool::Shutdown, this), - /*priority*/std::numeric_limits<int>::min() + 1); + /*priority*/ std::numeric_limits<int>::min() + 1); void Shutdown() { diff --git a/yt/yt/core/misc/unittests/consistent_hashing_ut.cpp b/yt/yt/core/misc/unittests/consistent_hashing_ut.cpp index f61c1d1ed1..e870aeed1a 100644 --- a/yt/yt/core/misc/unittests/consistent_hashing_ut.cpp +++ b/yt/yt/core/misc/unittests/consistent_hashing_ut.cpp @@ -475,7 +475,7 @@ TEST(TConsistentHashingRing, ServerAdditionBarrierStress) /*fileGenerator*/ GenerateItem, /*fileCount*/ 1000, /*serverCount*/ 1000, - /*queryCount=*/ 2000, + /*queryCount*/ 2000, /*queryGenerator*/ generateQuery, /*candidateCount*/ 3); EXPECT_LE(result, 0.05); @@ -598,7 +598,7 @@ TEST(TConsistentHashingRing, SmallTokenCount) /*serverCount*/ 1000, /*queryCount*/ 600, /*queryGenerator*/ GenerateQuery<10, 40, 250>, - /*candidateCount=*/ 1, + /*candidateCount*/ 1, /*batchSize*/ 200) / testCases; manyReplicasSmallResult += GetPercentageInconsistentFiles( diff --git a/yt/yt/core/misc/unittests/error_ut.cpp b/yt/yt/core/misc/unittests/error_ut.cpp index 13c347be5c..9ab7ee2b54 100644 --- a/yt/yt/core/misc/unittests/error_ut.cpp +++ b/yt/yt/core/misc/unittests/error_ut.cpp @@ -280,7 +280,7 @@ TEST(TErrorTest, BitshiftOverloadsImplicitLeftOperand) }; IterateTestOverEveryRightOperand< decltype(adlResolutionTester), - /*LeftOperandHasUserDefinedOverload=*/ true>(adlResolutionTester); + /*LeftOperandHasUserDefinedOverload*/ true>(adlResolutionTester); // Make sure no ambiguous calls. auto genericErrorOrTester = [] (auto&& arg) { diff --git a/yt/yt/core/ytree/ypath_detail.cpp b/yt/yt/core/ytree/ypath_detail.cpp index 55c8bc8022..679f0f6fea 100644 --- a/yt/yt/core/ytree/ypath_detail.cpp +++ b/yt/yt/core/ytree/ypath_detail.cpp @@ -482,7 +482,7 @@ TFuture<TYsonString> TSupportsAttributes::DoGetAttribute( writer.OnBeginMap(); if (attributeFilter) { - WriteAttributesFragment(&writer, attributeFilter, /*stable*/false); + WriteAttributesFragment(&writer, attributeFilter, /*stable*/ false); } else { if (builtinAttributeProvider) { std::vector<ISystemAttributeProvider::TAttributeDescriptor> builtinDescriptors; diff --git a/yt/yt/library/formats/skiff_yson_converter.cpp b/yt/yt/library/formats/skiff_yson_converter.cpp index f191c19c0e..3e375d03ec 100644 --- a/yt/yt/library/formats/skiff_yson_converter.cpp +++ b/yt/yt/library/formats/skiff_yson_converter.cpp @@ -1640,7 +1640,7 @@ TSkiffToYsonConverter CreateStructSkiffToYsonConverter( writer->WriteEntity(); }; - auto structMatch = MatchStructTypes(descriptor, skiffSchema, /*allowUnknownSkiffFields*/false); + auto structMatch = MatchStructTypes(descriptor, skiffSchema, /*allowUnknownSkiffFields*/ false); std::vector<TSkiffToYsonConverter> converterList; for (const auto& match : structMatch) { const auto& [fieldDescriptor, fieldSkiffSchema] = *match; |