aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorspuchin <spuchin@ydb.tech>2025-03-05 20:38:04 +0300
committerGitHub <noreply@github.com>2025-03-05 20:38:04 +0300
commitc0c27d9a2454652d0d6ce89bccab17e5334338d6 (patch)
tree7a8648bbb26b50248383487b38df8d6225bc2b48
parent8212ee0f68ccc70751c5d9c9b7dce8c75eb065f3 (diff)
downloadydb-c0c27d9a2454652d0d6ce89bccab17e5334338d6.tar.gz
Revert "additional deadline checkers and info" (#15374)
Because broken olap perf tests
-rw-r--r--ydb/core/tx/columnshard/engines/reader/actor/actor.cpp16
-rw-r--r--ydb/core/tx/columnshard/engines/reader/actor/actor.h5
2 files changed, 4 insertions, 17 deletions
diff --git a/ydb/core/tx/columnshard/engines/reader/actor/actor.cpp b/ydb/core/tx/columnshard/engines/reader/actor/actor.cpp
index dad620ee36..cc4b07d626 100644
--- a/ydb/core/tx/columnshard/engines/reader/actor/actor.cpp
+++ b/ydb/core/tx/columnshard/engines/reader/actor/actor.cpp
@@ -153,10 +153,8 @@ void TColumnShardScan::HandleScan(TEvents::TEvWakeup::TPtr& /*ev*/) {
<< " txId: " << TxId << " scanId: " << ScanId << " gen: " << ScanGen << " tablet: " << TabletId);
if (TMonotonic::Now() >= GetDeadline()) {
- CheckHanging(true);
- LastResultInstant = TMonotonic::Now();
- // SendScanError("ColumnShard scanner timeout: HAS_ACK=" + ::ToString(!!AckReceivedInstant));
- // Finish(NColumnShard::TScanCounters::EStatusFinish::Deadline);
+ SendScanError("ColumnShard scanner timeout: HAS_ACK=" + ::ToString(!!AckReceivedInstant));
+ Finish(NColumnShard::TScanCounters::EStatusFinish::Deadline);
} else {
ScheduleWakeup(GetDeadline());
}
@@ -286,16 +284,6 @@ void TColumnShardScan::ContinueProcessing() {
}
}
}
- CheckHanging();
-}
-
-void TColumnShardScan::CheckHanging(const bool logging) const {
- if (logging) {
- AFL_WARN(NKikimrServices::TX_COLUMNSHARD)("HAS_ACK", AckReceivedInstant)("fi", FinishInstant)("si", !!ScanIterator)(
- "has_more", ChunksLimiter.HasMore())("in_waiting", ScanCountersPool.InWaiting())("counters_waiting", ScanCountersPool.DebugString())(
- "scan_actor_id", ScanActorId)("tx_id", TxId)("scan_id", ScanId)("gen", ScanGen)("tablet", TabletId)(
- "debug", ScanIterator ? ScanIterator->DebugString() : Default<TString>())("last", LastResultInstant);
- }
AFL_VERIFY(!!FinishInstant || !ScanIterator || !ChunksLimiter.HasMore() || ScanCountersPool.InWaiting())("scan_actor_id", ScanActorId)("tx_id", TxId)("scan_id", ScanId)(
"gen", ScanGen)("tablet", TabletId)("debug", ScanIterator->DebugString())(
"counters", ScanCountersPool.DebugString());
diff --git a/ydb/core/tx/columnshard/engines/reader/actor/actor.h b/ydb/core/tx/columnshard/engines/reader/actor/actor.h
index 929987806d..caaa5524b0 100644
--- a/ydb/core/tx/columnshard/engines/reader/actor/actor.h
+++ b/ydb/core/tx/columnshard/engines/reader/actor/actor.h
@@ -47,8 +47,8 @@ public:
private:
STATEFN(StateScan) {
auto g = Stats->MakeGuard("processing");
- TLogContextGuard gLogging(NActors::TLogContextBuilder::Build(NKikimrServices::TX_COLUMNSHARD_SCAN) ("SelfId", SelfId())("TabletId",
- TabletId)("ScanId", ScanId)("TxId", TxId)("ScanGen", ScanGen)("task_identifier", ReadMetadataRange->GetScanIdentifier()));
+ TLogContextGuard gLogging(NActors::TLogContextBuilder::Build(NKikimrServices::TX_COLUMNSHARD_SCAN) ("SelfId", SelfId())(
+ "TabletId", TabletId)("ScanId", ScanId)("TxId", TxId)("ScanGen", ScanGen)("task_identifier", ReadMetadataRange->GetScanIdentifier()));
switch (ev->GetTypeRewrite()) {
hFunc(NKqp::TEvKqpCompute::TEvScanDataAck, HandleScan);
hFunc(NKqp::TEvKqp::TEvAbortExecution, HandleScan);
@@ -78,7 +78,6 @@ private:
void HandleScan(TEvents::TEvWakeup::TPtr& /*ev*/);
private:
- void CheckHanging(const bool logging = false) const;
void MakeResult(size_t reserveRows = 0);
void AddRow(const TConstArrayRef<TCell>& row) override;