diff options
| author | antervis <antervis@yandex-team.ru> | 2022-02-10 16:49:48 +0300 |
|---|---|---|
| committer | Daniil Cherednik <dcherednik@yandex-team.ru> | 2022-02-10 16:49:48 +0300 |
| commit | b3eef5b52437f05851a3e8fb489a68db0132657b (patch) | |
| tree | 5d5cb817648f650d76cf1076100726fd9b8448e8 | |
| parent | 0942f9eeaefcfc84db83fa240d8ed52b99345e7d (diff) | |
| download | ydb-b3eef5b52437f05851a3e8fb489a68db0132657b.tar.gz | |
Restoring authorship annotation for <antervis@yandex-team.ru>. Commit 2 of 2.
169 files changed, 726 insertions, 726 deletions
diff --git a/library/cpp/actors/core/scheduler_basic.h b/library/cpp/actors/core/scheduler_basic.h index 81869f41ab..2ccde39235 100644 --- a/library/cpp/actors/core/scheduler_basic.h +++ b/library/cpp/actors/core/scheduler_basic.h @@ -41,13 +41,13 @@ namespace NActors { TBasicSchedulerThread(const TSchedulerConfig& config = TSchedulerConfig()); ~TBasicSchedulerThread(); - void Prepare(TActorSystem* actorSystem, volatile ui64* currentTimestamp, volatile ui64* currentMonotonic) override; + void Prepare(TActorSystem* actorSystem, volatile ui64* currentTimestamp, volatile ui64* currentMonotonic) override; void PrepareSchedules(NSchedulerQueue::TReader** readers, ui32 scheduleReadersCount) override; void PrepareStart() override; - void Start() override; - void PrepareStop() override; - void Stop() override; + void Start() override; + void PrepareStop() override; + void Stop() override; }; class TMockSchedulerThread: public ISchedulerThread { diff --git a/library/cpp/coroutine/engine/trampoline.h b/library/cpp/coroutine/engine/trampoline.h index ed52614631..37b61cf015 100644 --- a/library/cpp/coroutine/engine/trampoline.h +++ b/library/cpp/coroutine/engine/trampoline.h @@ -44,7 +44,7 @@ namespace NCoro { Ctx_.SwitchTo(ctx); } - void DoRun() override; + void DoRun() override; void DoRunNaked() override; diff --git a/library/cpp/grpc/server/grpc_request.h b/library/cpp/grpc/server/grpc_request.h index 43243d7b18..5bd8d3902b 100644 --- a/library/cpp/grpc/server/grpc_request.h +++ b/library/cpp/grpc/server/grpc_request.h @@ -203,7 +203,7 @@ public: NextReplyCb_ = cb; } - void AddTrailingMetadata(const TString& key, const TString& value) override { + void AddTrailingMetadata(const TString& key, const TString& value) override { this->Context.AddTrailingMetadata(key, value); } diff --git a/library/cpp/histogram/adaptive/adaptive_histogram.h b/library/cpp/histogram/adaptive/adaptive_histogram.h index 1f3993a49e..fa8f48433f 100644 --- a/library/cpp/histogram/adaptive/adaptive_histogram.h +++ b/library/cpp/histogram/adaptive/adaptive_histogram.h @@ -59,7 +59,7 @@ namespace NKiwiAggr { TQualityFunction GetQualityFunc(); - void Clear() override; + void Clear() override; void Add(double value, double weight) override; void Add(const THistoRec& histoRec) override; diff --git a/library/cpp/http/fetch/httpparser.h b/library/cpp/http/fetch/httpparser.h index cc88cbd31d..769828e4ae 100644 --- a/library/cpp/http/fetch/httpparser.h +++ b/library/cpp/http/fetch/httpparser.h @@ -51,7 +51,7 @@ public: protected: int CheckHeaders() { - if (Header->http_status < HTTP_OK || Header->http_status == HTTP_NO_CONTENT || Header->http_status == HTTP_NOT_MODIFIED) { + if (Header->http_status < HTTP_OK || Header->http_status == HTTP_NO_CONTENT || Header->http_status == HTTP_NOT_MODIFIED) { Header->content_length = 0; Header->transfer_chunked = 0; } @@ -65,7 +65,7 @@ protected: Header->error = HTTP_BAD_CONTENT_LENGTH; return 1; } - if (Header->http_status == HTTP_OK) { + if (Header->http_status == HTTP_OK) { if (Header->compression_method != HTTP_COMPRESSION_UNSET && Header->compression_method != HTTP_COMPRESSION_IDENTITY && Header->compression_method != HTTP_COMPRESSION_GZIP && @@ -290,12 +290,12 @@ public: using TBaseT::ParseGeneric; using TBaseT::State; - int Init(THttpHeader* H, int parsHeader, int assumeConnectionClosed = 0, bool headRequest = false) { + int Init(THttpHeader* H, int parsHeader, int assumeConnectionClosed = 0, bool headRequest = false) { Header = H; Eoferr = 1; Size = 0; AssumeConnectionClosed = assumeConnectionClosed; - HeadRequest = headRequest; + HeadRequest = headRequest; return parsHeader ? ParseHeader() : SkipHeader(); } diff --git a/library/cpp/http/fetch/httpzreader.h b/library/cpp/http/fetch/httpzreader.h index c510935ae1..68eb00853d 100644 --- a/library/cpp/http/fetch/httpzreader.h +++ b/library/cpp/http/fetch/httpzreader.h @@ -25,9 +25,9 @@ public: using TBase::ParseGeneric; using TBase::State; - static constexpr size_t DefaultBufSize = 64 << 10; - static constexpr unsigned int DefaultWinSize = 15; - + static constexpr size_t DefaultBufSize = 64 << 10; + static constexpr unsigned int DefaultWinSize = 15; + TCompressedHttpReader() : CompressedInput(false) , BufSize(0) @@ -58,19 +58,19 @@ public: IgnoreTrailingGarbage = ignore; } - int Init( - THttpHeader* H, - int parsHeader, - const size_t maxContSize = Max<size_t>(), - const size_t bufSize = DefaultBufSize, - const unsigned int winSize = DefaultWinSize, - bool headRequest = false) - { + int Init( + THttpHeader* H, + int parsHeader, + const size_t maxContSize = Max<size_t>(), + const size_t bufSize = DefaultBufSize, + const unsigned int winSize = DefaultWinSize, + bool headRequest = false) + { ZErr = 0; CurContSize = 0; MaxContSize = maxContSize; - int ret = TBase::Init(H, parsHeader, ConnectionClosed, headRequest); + int ret = TBase::Init(H, parsHeader, ConnectionClosed, headRequest); if (ret) return ret; @@ -256,15 +256,15 @@ public: { } - int Init( - THttpHeader* H, - int parsHeader, - const size_t maxContSize = Max<size_t>(), - const size_t bufSize = TBase::DefaultBufSize, - const unsigned int winSize = TBase::DefaultWinSize, - bool headRequest = false) - { - int ret = TBase::Init(H, parsHeader, maxContSize, bufSize, winSize, headRequest); + int Init( + THttpHeader* H, + int parsHeader, + const size_t maxContSize = Max<size_t>(), + const size_t bufSize = TBase::DefaultBufSize, + const unsigned int winSize = TBase::DefaultWinSize, + bool headRequest = false) + { + int ret = TBase::Init(H, parsHeader, maxContSize, bufSize, winSize, headRequest); return (int)HandleRetValue((long)ret); } diff --git a/library/cpp/ipv6_address/ipv6_address.cpp b/library/cpp/ipv6_address/ipv6_address.cpp index a3d0e0a859..be8fcbae13 100644 --- a/library/cpp/ipv6_address/ipv6_address.cpp +++ b/library/cpp/ipv6_address/ipv6_address.cpp @@ -23,16 +23,16 @@ namespace { *(reinterpret_cast<const ui64*>(memPtr) + 1) }; } - - // zero-terminated copy of address string - template <size_t N> - inline auto AddrBuf(TStringBuf str) noexcept { - std::array<char, N+1> res; - auto len = Min(str.size(), N); - CopyN(str.begin(), len, res.begin()); - res[len] = '\0'; - return res; - } + + // zero-terminated copy of address string + template <size_t N> + inline auto AddrBuf(TStringBuf str) noexcept { + std::array<char, N+1> res; + auto len = Min(str.size(), N); + CopyN(str.begin(), len, res.begin()); + res[len] = '\0'; + return res; + } } void TIpv6Address::InitFrom(const in6_addr& addr) { @@ -78,35 +78,35 @@ TIpv6Address::TIpv6Address(const in_addr& addr) { InitFrom(addr); } -TIpv6Address TIpv6Address::FromString(TStringBuf str, bool& ok) noexcept { - const TIpType ipType = FigureOutType(str); +TIpv6Address TIpv6Address::FromString(TStringBuf str, bool& ok) noexcept { + const TIpType ipType = FigureOutType(str); if (ipType == Ipv6) { - ui32 scopeId = 0; - if (size_t pos = str.find('%'); pos != TStringBuf::npos) { - ::TryFromString(str.substr(pos + 1), scopeId); - str.Trunc(pos); + ui32 scopeId = 0; + if (size_t pos = str.find('%'); pos != TStringBuf::npos) { + ::TryFromString(str.substr(pos + 1), scopeId); + str.Trunc(pos); } - const auto buf = AddrBuf<INET6_ADDRSTRLEN>(str); + const auto buf = AddrBuf<INET6_ADDRSTRLEN>(str); in6_addr addr; - if (inet_pton(AF_INET6, buf.data(), &addr) != 1) { + if (inet_pton(AF_INET6, buf.data(), &addr) != 1) { ok = false; return TIpv6Address(); } - + ok = true; - return TIpv6Address(addr, scopeId); + return TIpv6Address(addr, scopeId); } else { // if (ipType == Ipv4) { - const auto buf = AddrBuf<INET_ADDRSTRLEN>(str); + const auto buf = AddrBuf<INET_ADDRSTRLEN>(str); in_addr addr; - if (inet_pton(AF_INET, buf.data(), &addr) != 1) { + if (inet_pton(AF_INET, buf.data(), &addr) != 1) { ok = false; return TIpv6Address(); } - + ok = true; - return TIpv6Address(addr); + return TIpv6Address(addr); } } @@ -192,12 +192,12 @@ void TIpv6Address::ToIn6Addr(in6_addr& Addr6) const { } void TIpv6Address::Save(IOutputStream* out) const { - ::Save(out, Ip); + ::Save(out, Ip); ::Save(out, static_cast<ui8>(Type_)); ::Save(out, ScopeId_); } void TIpv6Address::Load(IInputStream* in) { - ::Load(in, Ip); + ::Load(in, Ip); ui8 num; ::Load(in, num); Type_ = static_cast<TIpType>(num); @@ -242,14 +242,14 @@ TIpv6Address TIpv6Address::Normalized() const noexcept { } IOutputStream& operator<<(IOutputStream& Out, const TIpv6Address::TIpType Type) noexcept { - switch (Type) { - case TIpv6Address::Ipv4: - Out << "Ipv4"; - return Out; - case TIpv6Address::Ipv6: - Out << "Ipv6"; - return Out; - default: + switch (Type) { + case TIpv6Address::Ipv4: + Out << "Ipv4"; + return Out; + case TIpv6Address::Ipv6: + Out << "Ipv6"; + return Out; + default: Out << "UnknownType"; return Out; } @@ -317,16 +317,16 @@ std::tuple<THostAddressAndPort, TString, TIpPort> ParseHostAndMayBePortFromStrin const size_t BracketColPos = RawStr.find("]:"); if (BracketColPos != TString::npos) { // [ipv6]:port - if (!RawStr.StartsWith('[')) { + if (!RawStr.StartsWith('[')) { Ok = false; return {}; } - const TStringBuf StrIpv6(RawStr.begin() + 1, RawStr.begin() + BracketColPos); - const TStringBuf StrPort(RawStr.begin() + BracketColPos + 2, RawStr.end()); + const TStringBuf StrIpv6(RawStr.begin() + 1, RawStr.begin() + BracketColPos); + const TStringBuf StrPort(RawStr.begin() + BracketColPos + 2, RawStr.end()); bool IpConverted; const TIpv6Address Ip = TIpv6Address::FromString(StrIpv6, IpConverted); - if (!IpConverted) { + if (!IpConverted) { Ok = false; return {}; } @@ -334,8 +334,8 @@ std::tuple<THostAddressAndPort, TString, TIpPort> ParseHostAndMayBePortFromStrin Ok = false; return {}; } - TIpPort Port {}; - if (!::TryFromString(StrPort, Port)) { + TIpPort Port {}; + if (!::TryFromString(StrPort, Port)) { Ok = false; return {}; } @@ -349,15 +349,15 @@ std::tuple<THostAddressAndPort, TString, TIpPort> ParseHostAndMayBePortFromStrin if (RawStr.StartsWith('[')) { // [ipv6] - if (!RawStr.EndsWith(']')) { + if (!RawStr.EndsWith(']')) { Ok = false; return {}; } - const TStringBuf StrIpv6(RawStr.begin() + 1, RawStr.end() - 1); + const TStringBuf StrIpv6(RawStr.begin() + 1, RawStr.end() - 1); bool IpConverted; const TIpv6Address Ip = TIpv6Address::FromString(StrIpv6, IpConverted); - if (!IpConverted || Ip.Type() != TIpv6Address::Ipv6) { + if (!IpConverted || Ip.Type() != TIpv6Address::Ipv6) { Ok = false; return {}; } @@ -386,14 +386,14 @@ std::tuple<THostAddressAndPort, TString, TIpPort> ParseHostAndMayBePortFromStrin } } - const TStringBuf StrPort(RawStr.begin() + ColPos + 1, RawStr.end()); - TIpPort Port {}; - if (!::TryFromString(StrPort, Port)) { + const TStringBuf StrPort(RawStr.begin() + ColPos + 1, RawStr.end()); + TIpPort Port {}; + if (!::TryFromString(StrPort, Port)) { Ok = false; return {}; } - const TStringBuf StrIpv4OrHost(RawStr.begin(), RawStr.begin() + ColPos); + const TStringBuf StrIpv4OrHost(RawStr.begin(), RawStr.begin() + ColPos); { bool IpConverted; const TIpv6Address Ipv4 = TIpv6Address::FromString(StrIpv4OrHost, IpConverted); @@ -408,7 +408,7 @@ std::tuple<THostAddressAndPort, TString, TIpPort> ParseHostAndMayBePortFromStrin { // host:port Ok = true; - TRes Res{THostAddressAndPort{}, TString(StrIpv4OrHost), Port}; + TRes Res{THostAddressAndPort{}, TString(StrIpv4OrHost), Port}; return Res; } } @@ -431,7 +431,7 @@ std::tuple<THostAddressAndPort, TString, TIpPort> ParseHostAndMayBePortFromStrin { // host Ok = true; - TRes Res{THostAddressAndPort{}, TString(RawStr), DefaultPort}; + TRes Res{THostAddressAndPort{}, TString(RawStr), DefaultPort}; return Res; } } diff --git a/library/cpp/ipv6_address/ipv6_address.h b/library/cpp/ipv6_address/ipv6_address.h index 3c9db90d15..1d7eb0b65f 100644 --- a/library/cpp/ipv6_address/ipv6_address.h +++ b/library/cpp/ipv6_address/ipv6_address.h @@ -32,26 +32,26 @@ public: Ipv4, LAST }; - constexpr TIpv6Address() noexcept = default; - constexpr TIpv6Address(const TIpv6Address&) noexcept = default; - constexpr TIpv6Address& operator=(const TIpv6Address&) noexcept = default; - - constexpr TIpv6Address(const ui128& ip, TIpType Type) noexcept - : Ip(ip), Type_(Type) - {} - - constexpr TIpv6Address(ui8 a, ui8 b, ui8 c, ui8 d) noexcept - : Ip((ui32(a) << 24) | (ui32(b) << 16) | (ui32(c) << 8) | ui32(d)) - , Type_(TIpv6Address::Ipv4) - {} - - constexpr TIpv6Address(ui16 a, ui16 b, ui16 c, ui16 d, ui16 e, ui16 f, ui16 g, ui16 h, ui32 scope = 0) noexcept - : Type_(TIpv6Address::Ipv6) - , ScopeId_(scope) - { - auto hi = (ui64(a) << 48) | (ui64(b) << 32) | (ui64(c) << 16) | ui64(d); - auto lo = (ui64(e) << 48) | (ui64(f) << 32) | (ui64(g) << 16) | ui64(h); - Ip = {hi, lo}; + constexpr TIpv6Address() noexcept = default; + constexpr TIpv6Address(const TIpv6Address&) noexcept = default; + constexpr TIpv6Address& operator=(const TIpv6Address&) noexcept = default; + + constexpr TIpv6Address(const ui128& ip, TIpType Type) noexcept + : Ip(ip), Type_(Type) + {} + + constexpr TIpv6Address(ui8 a, ui8 b, ui8 c, ui8 d) noexcept + : Ip((ui32(a) << 24) | (ui32(b) << 16) | (ui32(c) << 8) | ui32(d)) + , Type_(TIpv6Address::Ipv4) + {} + + constexpr TIpv6Address(ui16 a, ui16 b, ui16 c, ui16 d, ui16 e, ui16 f, ui16 g, ui16 h, ui32 scope = 0) noexcept + : Type_(TIpv6Address::Ipv6) + , ScopeId_(scope) + { + auto hi = (ui64(a) << 48) | (ui64(b) << 32) | (ui64(c) << 16) | ui64(d); + auto lo = (ui64(e) << 48) | (ui64(f) << 32) | (ui64(g) << 16) | ui64(h); + Ip = {hi, lo}; } explicit TIpv6Address(const NAddr::IRemoteAddr& addr); @@ -60,24 +60,24 @@ public: explicit TIpv6Address(const in6_addr& addr, ui32 Scope); explicit TIpv6Address(const in_addr& addr); - static TIpv6Address FromString(TStringBuf srcStr, bool& ok) noexcept; + static TIpv6Address FromString(TStringBuf srcStr, bool& ok) noexcept; - constexpr bool IsNull() const noexcept { + constexpr bool IsNull() const noexcept { return Ip == 0; } - constexpr bool IsValid() const noexcept { - return Ip != 0 && (Type_ == Ipv6 || Type_ == Ipv4); - } + constexpr bool IsValid() const noexcept { + return Ip != 0 && (Type_ == Ipv6 || Type_ == Ipv4); + } - explicit constexpr operator bool() const noexcept { - return IsValid(); + explicit constexpr operator bool() const noexcept { + return IsValid(); + } + + constexpr bool operator ! () const noexcept { + return !IsValid(); } - constexpr bool operator ! () const noexcept { - return !IsValid(); - } - bool Isv4MappedTov6() const noexcept; TIpv6Address TryToExtractIpv4From6() const noexcept; TIpv6Address Normalized() const noexcept; @@ -95,45 +95,45 @@ public: void ToIn6Addr(in6_addr& Addr6) const; // int SocketFamily() const; - constexpr bool operator<(const TIpv6Address& other) const noexcept { + constexpr bool operator<(const TIpv6Address& other) const noexcept { if (Type_ != other.Type_) return Type_ > other.Type_; else return Ip < other.Ip; } - constexpr bool operator>(const TIpv6Address& other) const noexcept { + constexpr bool operator>(const TIpv6Address& other) const noexcept { if (Type_ != other.Type_) return Type_ < other.Type_; else return Ip > other.Ip; } - constexpr bool operator==(const TIpv6Address& other) const noexcept { + constexpr bool operator==(const TIpv6Address& other) const noexcept { return Type_ == other.Type_ && Ip == other.Ip; } - constexpr bool operator!=(const TIpv6Address& other) const noexcept { + constexpr bool operator!=(const TIpv6Address& other) const noexcept { return Type_ != other.Type_ || Ip != other.Ip; } - constexpr bool operator<=(const TIpv6Address& other) const noexcept { + constexpr bool operator<=(const TIpv6Address& other) const noexcept { return !(*this > other); } - constexpr bool operator>=(const TIpv6Address& other) const noexcept { + constexpr bool operator>=(const TIpv6Address& other) const noexcept { return !(*this < other); } - constexpr operator ui128() const noexcept { + constexpr operator ui128() const noexcept { return Ip; } - constexpr TIpType Type() const noexcept { + constexpr TIpType Type() const noexcept { return Type_; } - void SetScopeId(ui32 New) noexcept { + void SetScopeId(ui32 New) noexcept { ScopeId_ = New; } - constexpr ui32 ScopeId() const noexcept { + constexpr ui32 ScopeId() const noexcept { return ScopeId_; } @@ -154,35 +154,35 @@ private: IOutputStream& operator<<(IOutputStream& Out, const TIpv6Address::TIpType Type) noexcept; IOutputStream& operator<<(IOutputStream& Out, const TIpv6Address& ipv6Address) noexcept; -constexpr TIpv6Address Get127001() noexcept { - return {127, 0, 0, 1}; +constexpr TIpv6Address Get127001() noexcept { + return {127, 0, 0, 1}; } - -constexpr TIpv6Address Get1() noexcept { - return {1, TIpv6Address::Ipv6}; + +constexpr TIpv6Address Get1() noexcept { + return {1, TIpv6Address::Ipv6}; } struct THostAddressAndPort { - constexpr THostAddressAndPort() noexcept = default; - constexpr THostAddressAndPort(const TIpv6Address& i, TIpPort p) noexcept { + constexpr THostAddressAndPort() noexcept = default; + constexpr THostAddressAndPort(const TIpv6Address& i, TIpPort p) noexcept { Ip = i; Port = p; } - constexpr bool operator==(const THostAddressAndPort& Other) const noexcept { + constexpr bool operator==(const THostAddressAndPort& Other) const noexcept { return Ip == Other.Ip && Port == Other.Port; } - constexpr bool operator!=(const THostAddressAndPort& Other) const noexcept { + constexpr bool operator!=(const THostAddressAndPort& Other) const noexcept { return !(*this == Other); } - constexpr bool IsValid() const noexcept { + constexpr bool IsValid() const noexcept { return Ip.IsValid() && Port != 0; } TString ToString() const noexcept; - TIpv6Address Ip {}; - TIpPort Port {0}; + TIpv6Address Ip {}; + TIpPort Port {0}; }; IOutputStream& operator<<(IOutputStream& Out, const THostAddressAndPort& HostAddressAndPort) noexcept; diff --git a/library/cpp/ipv6_address/ipv6_address_p.h b/library/cpp/ipv6_address/ipv6_address_p.h index 29405af946..44bec74579 100644 --- a/library/cpp/ipv6_address/ipv6_address_p.h +++ b/library/cpp/ipv6_address/ipv6_address_p.h @@ -2,6 +2,6 @@ #include "ipv6_address.h" -inline TIpv6Address::TIpType FigureOutType(TStringBuf srcStr) noexcept { - return srcStr.Contains(':') ? TIpv6Address::Ipv6 : TIpv6Address::Ipv4; +inline TIpv6Address::TIpType FigureOutType(TStringBuf srcStr) noexcept { + return srcStr.Contains(':') ? TIpv6Address::Ipv6 : TIpv6Address::Ipv4; } diff --git a/library/cpp/ipv6_address/ut/ipv6_address_ut.cpp b/library/cpp/ipv6_address/ut/ipv6_address_ut.cpp index 4a97ff4eab..73bb7cffdd 100644 --- a/library/cpp/ipv6_address/ut/ipv6_address_ut.cpp +++ b/library/cpp/ipv6_address/ut/ipv6_address_ut.cpp @@ -5,12 +5,12 @@ class TIpv6AddressTest: public TTestBase { UNIT_TEST_SUITE(TIpv6AddressTest); UNIT_TEST(ParseHostAndMayBePortFromString_data); - UNIT_TEST(CheckAddressValidity) + UNIT_TEST(CheckAddressValidity) UNIT_TEST_SUITE_END(); private: void ParseHostAndMayBePortFromString_data(); - void CheckAddressValidity(); + void CheckAddressValidity(); void HashCompileTest(); }; @@ -79,33 +79,33 @@ void TIpv6AddressTest::ParseHostAndMayBePortFromString_data() { CheckIpDefPortAgainstIpPortDefPort("ya.ru", 123, HostRes("ya.ru", 123), true); } -void TIpv6AddressTest::CheckAddressValidity() { - bool Ok; - - constexpr TIpv6Address partsV4 {12, 34, 56, 78}; - static_assert(partsV4.Type() == TIpv6Address::Ipv4); - - constexpr TIpv6Address intV4 {0x0C22384E, TIpv6Address::Ipv4}; - static_assert(partsV4 == intV4); - - const auto parsedV4 = TIpv6Address::FromString("12.34.56.78", Ok); +void TIpv6AddressTest::CheckAddressValidity() { + bool Ok; + + constexpr TIpv6Address partsV4 {12, 34, 56, 78}; + static_assert(partsV4.Type() == TIpv6Address::Ipv4); + + constexpr TIpv6Address intV4 {0x0C22384E, TIpv6Address::Ipv4}; + static_assert(partsV4 == intV4); + + const auto parsedV4 = TIpv6Address::FromString("12.34.56.78", Ok); UNIT_ASSERT(Ok); UNIT_ASSERT_EQUAL(parsedV4, partsV4); - - constexpr TIpv6Address partsV6 {0xFB, 0x1634, 0x19, 0xABED, 0, 0x8001, 0x1670, 0x742}; - static_assert(partsV6.Type() == TIpv6Address::Ipv6); - - constexpr TIpv6Address intV6 {{0x00FB16340019ABED, 0x0000800116700742}, TIpv6Address::Ipv6}; - static_assert(partsV6 == intV6); - - const auto parsedV6 = TIpv6Address::FromString("FB:1634:19:ABED:0:8001:1670:742", Ok); + + constexpr TIpv6Address partsV6 {0xFB, 0x1634, 0x19, 0xABED, 0, 0x8001, 0x1670, 0x742}; + static_assert(partsV6.Type() == TIpv6Address::Ipv6); + + constexpr TIpv6Address intV6 {{0x00FB16340019ABED, 0x0000800116700742}, TIpv6Address::Ipv6}; + static_assert(partsV6 == intV6); + + const auto parsedV6 = TIpv6Address::FromString("FB:1634:19:ABED:0:8001:1670:742", Ok); UNIT_ASSERT(Ok); UNIT_ASSERT_EQUAL(parsedV6, partsV6); - - static_assert(Get127001() == TIpv6Address(0x7F000001, TIpv6Address::Ipv4)); - static_assert(Get1() == TIpv6Address(0, 0, 0, 0, 0, 0, 0, 1)); -} - + + static_assert(Get127001() == TIpv6Address(0x7F000001, TIpv6Address::Ipv4)); + static_assert(Get1() == TIpv6Address(0, 0, 0, 0, 0, 0, 0, 1)); +} + void TIpv6AddressTest::HashCompileTest() { std::unordered_set<TIpv6Address> test; Y_UNUSED(test); diff --git a/library/cpp/messagebus/messqueue.cpp b/library/cpp/messagebus/messqueue.cpp index c956d4a473..3474d62705 100644 --- a/library/cpp/messagebus/messqueue.cpp +++ b/library/cpp/messagebus/messqueue.cpp @@ -131,34 +131,34 @@ TBusClientSessionPtr TBusMessageQueue::CreateSource(TBusProtocol* proto, IBusCli } TBusServerSessionPtr TBusMessageQueue::CreateDestination(TBusProtocol* proto, IBusServerHandler* handler, const TBusClientSessionConfig& config, const TString& name) { - TRemoteServerSessionPtr session(new TRemoteServerSession(this, proto, handler, config, name)); - try { - int port = config.ListenPort; - if (port == 0) { - port = Locator->GetLocalPort(proto->GetService()); - } - if (port == 0) { - port = proto->GetPort(); - } - - session->Listen(port, this); - - Add(session.Get()); - return session.Release(); - } catch (...) { - Y_FAIL("create destination failure: %s", CurrentExceptionMessage().c_str()); - } + TRemoteServerSessionPtr session(new TRemoteServerSession(this, proto, handler, config, name)); + try { + int port = config.ListenPort; + if (port == 0) { + port = Locator->GetLocalPort(proto->GetService()); + } + if (port == 0) { + port = proto->GetPort(); + } + + session->Listen(port, this); + + Add(session.Get()); + return session.Release(); + } catch (...) { + Y_FAIL("create destination failure: %s", CurrentExceptionMessage().c_str()); + } } TBusServerSessionPtr TBusMessageQueue::CreateDestination(TBusProtocol* proto, IBusServerHandler* handler, const TBusServerSessionConfig& config, const TVector<TBindResult>& bindTo, const TString& name) { - TRemoteServerSessionPtr session(new TRemoteServerSession(this, proto, handler, config, name)); - try { - session->Listen(bindTo, this); - Add(session.Get()); - return session.Release(); - } catch (...) { - Y_FAIL("create destination failure: %s", CurrentExceptionMessage().c_str()); - } + TRemoteServerSessionPtr session(new TRemoteServerSession(this, proto, handler, config, name)); + try { + session->Listen(bindTo, this); + Add(session.Get()); + return session.Release(); + } catch (...) { + Y_FAIL("create destination failure: %s", CurrentExceptionMessage().c_str()); + } } void TBusMessageQueue::Add(TIntrusivePtr<TBusSessionImpl> session) { diff --git a/library/cpp/monlib/metrics/summary_collector.h b/library/cpp/monlib/metrics/summary_collector.h index a7372e2a10..acba0fddf9 100644 --- a/library/cpp/monlib/metrics/summary_collector.h +++ b/library/cpp/monlib/metrics/summary_collector.h @@ -41,7 +41,7 @@ namespace NMonitoring { Count_.fetch_add(1ul, std::memory_order_relaxed); } - ISummaryDoubleSnapshotPtr Snapshot() const override { + ISummaryDoubleSnapshotPtr Snapshot() const override { return new TSummaryDoubleSnapshot( Sum_.load(std::memory_order_relaxed), Min_.load(std::memory_order_relaxed), diff --git a/library/cpp/testing/gmock_in_unittest/example_ut/example_ut.cpp b/library/cpp/testing/gmock_in_unittest/example_ut/example_ut.cpp index 788b252e5e..97f19050e4 100644 --- a/library/cpp/testing/gmock_in_unittest/example_ut/example_ut.cpp +++ b/library/cpp/testing/gmock_in_unittest/example_ut/example_ut.cpp @@ -21,8 +21,8 @@ public: class TTestMock: public ITestIface { public: - MOCK_METHOD(void, Func1, (), (override)); - MOCK_METHOD(int, Func2, (const TString&), (const, override)); + MOCK_METHOD(void, Func1, (), (override)); + MOCK_METHOD(int, Func2, (const TString&), (const, override)); }; using namespace testing; diff --git a/library/cpp/threading/future/core/future.h b/library/cpp/threading/future/core/future.h index d65c4895e2..2e82bb953e 100644 --- a/library/cpp/threading/future/core/future.h +++ b/library/cpp/threading/future/core/future.h @@ -78,11 +78,11 @@ namespace NThreading { TFuture() noexcept = default; TFuture(const TFuture<T>& other) noexcept = default; - TFuture(TFuture<T>&& other) noexcept = default; + TFuture(TFuture<T>&& other) noexcept = default; TFuture(const TIntrusivePtr<TFutureState>& state) noexcept; TFuture<T>& operator=(const TFuture<T>& other) noexcept = default; - TFuture<T>& operator=(TFuture<T>&& other) noexcept = default; + TFuture<T>& operator=(TFuture<T>&& other) noexcept = default; void Swap(TFuture<T>& other); bool Initialized() const; @@ -135,11 +135,11 @@ namespace NThreading { TFuture() noexcept = default; TFuture(const TFuture<void>& other) noexcept = default; - TFuture(TFuture<void>&& other) noexcept = default; + TFuture(TFuture<void>&& other) noexcept = default; TFuture(const TIntrusivePtr<TFutureState>& state) noexcept; TFuture<void>& operator=(const TFuture<void>& other) noexcept = default; - TFuture<void>& operator=(TFuture<void>&& other) noexcept = default; + TFuture<void>& operator=(TFuture<void>&& other) noexcept = default; void Swap(TFuture<void>& other); bool Initialized() const; @@ -193,11 +193,11 @@ namespace NThreading { public: TPromise() noexcept = default; TPromise(const TPromise<T>& other) noexcept = default; - TPromise(TPromise<T>&& other) noexcept = default; + TPromise(TPromise<T>&& other) noexcept = default; TPromise(const TIntrusivePtr<TFutureState>& state) noexcept; TPromise<T>& operator=(const TPromise<T>& other) noexcept = default; - TPromise<T>& operator=(TPromise<T>&& other) noexcept = default; + TPromise<T>& operator=(TPromise<T>&& other) noexcept = default; void Swap(TPromise<T>& other); bool Initialized() const; @@ -237,11 +237,11 @@ namespace NThreading { public: TPromise() noexcept = default; TPromise(const TPromise<void>& other) noexcept = default; - TPromise(TPromise<void>&& other) noexcept = default; + TPromise(TPromise<void>&& other) noexcept = default; TPromise(const TIntrusivePtr<TFutureState>& state) noexcept; TPromise<void>& operator=(const TPromise<void>& other) noexcept = default; - TPromise<void>& operator=(TPromise<void>&& other) noexcept = default; + TPromise<void>& operator=(TPromise<void>&& other) noexcept = default; void Swap(TPromise<void>& other); bool Initialized() const; diff --git a/library/cpp/yt/small_containers/unittests/compact_vector_ut.cpp b/library/cpp/yt/small_containers/unittests/compact_vector_ut.cpp index 678e02c1b6..770d62b9fd 100644 --- a/library/cpp/yt/small_containers/unittests/compact_vector_ut.cpp +++ b/library/cpp/yt/small_containers/unittests/compact_vector_ut.cpp @@ -156,7 +156,7 @@ private: class CompactVectorTestBase : public testing::Test { protected: - void SetUp() override { + void SetUp() override { Constructable::reset(); } diff --git a/util/generic/ptr_ut.cpp b/util/generic/ptr_ut.cpp index fbcc968cdc..c2dcff23f6 100644 --- a/util/generic/ptr_ut.cpp +++ b/util/generic/ptr_ut.cpp @@ -42,7 +42,7 @@ private: }; struct TLocalThread: public ISimpleThread { - void* ThreadProc() override { + void* ThreadProc() override { TSimpleIntrusivePtr<S> ptr; return nullptr; } diff --git a/ydb/core/actorlib_impl/http_request_protocol.h b/ydb/core/actorlib_impl/http_request_protocol.h index de1a7a786c..d5a5b4a0bc 100644 --- a/ydb/core/actorlib_impl/http_request_protocol.h +++ b/ydb/core/actorlib_impl/http_request_protocol.h @@ -190,7 +190,7 @@ public: CatchHTTPRequestError(std::move(error)); } - void CatchReadDataError(TString error) noexcept override + void CatchReadDataError(TString error) noexcept override { CatchHTTPRequestError(std::move(error)); } diff --git a/ydb/core/actorlib_impl/test_protocols_ut.cpp b/ydb/core/actorlib_impl/test_protocols_ut.cpp index a5a6df02ff..2e622406a0 100644 --- a/ydb/core/actorlib_impl/test_protocols_ut.cpp +++ b/ydb/core/actorlib_impl/test_protocols_ut.cpp @@ -315,7 +315,7 @@ Y_UNIT_TEST_SUITE(TestProtocols) { Send(Edge, new TEvents::TEvWakeup); } - void CatchReadDataError(TString error) noexcept override + void CatchReadDataError(TString error) noexcept override { Error = std::move(error); Send(Edge, new TEvents::TEvWakeup); diff --git a/ydb/core/blobstorage/pdisk/blobstorage_pdisk_blockdevice_async.cpp b/ydb/core/blobstorage/pdisk/blobstorage_pdisk_blockdevice_async.cpp index ef212c88fc..34c20999b7 100644 --- a/ydb/core/blobstorage/pdisk/blobstorage_pdisk_blockdevice_async.cpp +++ b/ydb/core/blobstorage/pdisk/blobstorage_pdisk_blockdevice_async.cpp @@ -1024,7 +1024,7 @@ protected: TrimThread->Schedule(op); } - bool GetIsTrimEnabled() override { + bool GetIsTrimEnabled() override { return IsTrimEnabled; } diff --git a/ydb/core/blobstorage/pdisk/blobstorage_pdisk_requestimpl.h b/ydb/core/blobstorage/pdisk/blobstorage_pdisk_requestimpl.h index 4cbe79e247..61c0996e08 100644 --- a/ydb/core/blobstorage/pdisk/blobstorage_pdisk_requestimpl.h +++ b/ydb/core/blobstorage/pdisk/blobstorage_pdisk_requestimpl.h @@ -377,7 +377,7 @@ public: Cost = drive.SeekTimeNs() + drive.TimeForSizeNs((ui64)RemainingSize, ChunkIdx, TDriveModel::OP_TYPE_READ); } - bool TryStealSlack(ui64& slackNs, const TDriveModel &drive, ui64 appendBlockSize, bool adhesion) override { + bool TryStealSlack(ui64& slackNs, const TDriveModel &drive, ui64 appendBlockSize, bool adhesion) override { Y_UNUSED(appendBlockSize); Y_UNUSED(adhesion); // Calculate how many bytes can we read within given slack (with single seek) SlackSize = (ui32)drive.SizeForTimeNs(slackNs > drive.SeekTimeNs()? slackNs - drive.SeekTimeNs(): 0, @@ -493,7 +493,7 @@ public: return UnenqueuedSize == 0; } - bool TryStealSlack(ui64& slackNs, const TDriveModel &drive, ui64 appendBlockSize, bool adhesion) override { + bool TryStealSlack(ui64& slackNs, const TDriveModel &drive, ui64 appendBlockSize, bool adhesion) override { // Calculate how many bytes can we write within given slack (with single seek) // TODO[serxa]: use write speed? but there is no write speed in drive model! SlackSize = (ui32)drive.SizeForTimeNs(slackNs > drive.SeekTimeNs()? slackNs - drive.SeekTimeNs(): 0, @@ -562,7 +562,7 @@ public: Cost = drive.TrimTimeForSizeNs(Size); } - bool TryStealSlack(ui64& slackNs, const TDriveModel &drive, ui64 appendBlockSize, bool adhesion) override { + bool TryStealSlack(ui64& slackNs, const TDriveModel &drive, ui64 appendBlockSize, bool adhesion) override { Y_UNUSED(drive); Y_UNUSED(appendBlockSize); Y_UNUSED(adhesion); if (slackNs > Cost) { slackNs -= Cost; diff --git a/ydb/core/blobstorage/vdisk/scrub/scrub_actor_impl.h b/ydb/core/blobstorage/vdisk/scrub/scrub_actor_impl.h index ad5d95606b..7af6d264f6 100644 --- a/ydb/core/blobstorage/vdisk/scrub/scrub_actor_impl.h +++ b/ydb/core/blobstorage/vdisk/scrub/scrub_actor_impl.h @@ -87,7 +87,7 @@ namespace NKikimr { public: TScrubCoroImpl(TScrubContext::TPtr scrubCtx, NKikimrVDiskData::TScrubEntrypoint scrubEntrypoint, ui64 scrubEntrypointLsn); - void ProcessUnexpectedEvent(TAutoPtr<IEventHandle> ev) override; + void ProcessUnexpectedEvent(TAutoPtr<IEventHandle> ev) override; void Handle(NMon::TEvHttpInfo::TPtr ev); void ForwardToBlobRecoveryActor(TAutoPtr<IEventHandle> ev); diff --git a/ydb/core/driver_lib/cli_utils/cli_cmds_cms.cpp b/ydb/core/driver_lib/cli_utils/cli_cmds_cms.cpp index d7d129a5e0..8d8e54af65 100644 --- a/ydb/core/driver_lib/cli_utils/cli_cmds_cms.cpp +++ b/ydb/core/driver_lib/cli_utils/cli_cmds_cms.cpp @@ -111,7 +111,7 @@ public: *rec.AddHosts() = host; } - void PrintOkResponse(const NKikimrClient::TCmsResponse &response) override + void PrintOkResponse(const NKikimrClient::TCmsResponse &response) override { auto &state = response.GetClusterStateResponse().GetState(); @@ -1138,7 +1138,7 @@ public: req.MutableLogFilter()->SetOffset(Offset); } - void PrintOkResponse(const NKikimrClient::TCmsResponse &response) override + void PrintOkResponse(const NKikimrClient::TCmsResponse &response) override { if (!response.GetGetLogTailResponse().LogRecordsSize()) Cout << "<empty>" << Endl; diff --git a/ydb/core/driver_lib/cli_utils/cli_cmds_console.cpp b/ydb/core/driver_lib/cli_utils/cli_cmds_console.cpp index 718b65578f..0497d4ea8f 100644 --- a/ydb/core/driver_lib/cli_utils/cli_cmds_console.cpp +++ b/ydb/core/driver_lib/cli_utils/cli_cmds_console.cpp @@ -206,7 +206,7 @@ public: Request.MutableConfigureRequest()->SetFillAffectedConfigs(true); } - virtual void PrintResponse(const NKikimrClient::TConsoleResponse &response) override + virtual void PrintResponse(const NKikimrClient::TConsoleResponse &response) override { if (response.GetStatus().GetCode() != Ydb::StatusIds::SUCCESS) { Cout << "ERROR: " << response.GetStatus().GetCode() @@ -296,7 +296,7 @@ public: rec.MutableNode()->SetHost(Host); } - virtual void PrintResponse(const NKikimrClient::TConsoleResponse &response) override + virtual void PrintResponse(const NKikimrClient::TConsoleResponse &response) override { if (response.GetStatus().GetCode() != Ydb::StatusIds::SUCCESS) { Cout << "ERROR: " << response.GetStatus().GetCode() diff --git a/ydb/core/formats/clickhouse_block.cpp b/ydb/core/formats/clickhouse_block.cpp index dc7fafabd6..0fd77f5fda 100644 --- a/ydb/core/formats/clickhouse_block.cpp +++ b/ydb/core/formats/clickhouse_block.cpp @@ -574,7 +574,7 @@ public: size_t Bytes() const override; private: - std::unique_ptr<IBlockBuilder> Clone() const override; + std::unique_ptr<IBlockBuilder> Clone() const override; private: const TDataTypeRegistryPtr DataTypeRegistry; diff --git a/ydb/core/grpc_services/base/base.h b/ydb/core/grpc_services/base/base.h index 5562a3994f..44b25c4a5f 100644 --- a/ydb/core/grpc_services/base/base.h +++ b/ydb/core/grpc_services/base/base.h @@ -446,7 +446,7 @@ public: return {}; } - void SetRlPath(TMaybe<NRpcService::TRlPath>&&) override {} + void SetRlPath(TMaybe<NRpcService::TRlPath>&&) override {} TMaybe<NRpcService::TRlPath> GetRlPath() const override { return Nothing(); @@ -508,7 +508,7 @@ public: return TInstant::Max(); } - void SetRespHook(TRespHook&&) override { /* do nothing */} + void SetRespHook(TRespHook&&) override { /* do nothing */} TRateLimiterMode GetRlMode() const override { return TRateLimiterMode::Off; @@ -670,7 +670,7 @@ public: return GetPeerMetaValues(NGrpc::GRPC_USER_AGENT_HEADER); } - const TMaybe<TString> GetPeerMetaValues(const TString& key) const override { + const TMaybe<TString> GetPeerMetaValues(const TString& key) const override { return ToMaybe(Ctx_->GetPeerMetaValues(key)); } @@ -678,7 +678,7 @@ public: NGRpcService::RefreshToken(token, GetDatabaseName().GetOrElse(""), ctx, id); } - void SetRespHook(TRespHook&&) override { + void SetRespHook(TRespHook&&) override { /* cannot add hook to bidirect streaming */ Y_FAIL("Unimplemented"); } @@ -694,68 +694,68 @@ private: TMaybe<NRpcService::TRlPath> RlPath_; }; -template <typename TDerived> -class TGrpcResponseSenderImpl : public IRequestOpCtx { -public: - void SendOperation(const Ydb::Operations::Operation& operation) override { - auto self = Derived(); - auto resp = self->CreateResponseMessage(); - resp->mutable_operation()->CopyFrom(operation); - self->Ctx_->Reply(resp, operation.status()); - } - - void SendResult(Ydb::StatusIds::StatusCode status, - const google::protobuf::RepeatedPtrField<TYdbIssueMessageType>& message) override - { - auto self = Derived(); - auto resp = self->CreateResponseMessage(); - auto deferred = resp->mutable_operation(); - deferred->set_ready(true); - deferred->set_status(status); - deferred->mutable_issues()->MergeFrom(message); - if (self->CostInfo) { - deferred->mutable_cost_info()->Swap(self->CostInfo); - } - self->Reply(resp, status); - } - - void SendResult(const google::protobuf::Message& result, - Ydb::StatusIds::StatusCode status, - const google::protobuf::RepeatedPtrField<TYdbIssueMessageType>& message) override - { - auto self = Derived(); - auto resp = self->CreateResponseMessage(); - auto deferred = resp->mutable_operation(); - deferred->set_ready(true); - deferred->set_status(status); - deferred->mutable_issues()->MergeFrom(message); - if (self->CostInfo) { - deferred->mutable_cost_info()->Swap(self->CostInfo); - } - auto data = deferred->mutable_result(); - data->PackFrom(result); - self->Reply(resp, status); - } - - void SendResult(const google::protobuf::Message& result, Ydb::StatusIds::StatusCode status) override { - auto self = Derived(); - auto resp = self->CreateResponseMessage(); - auto deferred = resp->mutable_operation(); - deferred->set_ready(true); - deferred->set_status(status); - if (self->CostInfo) { - deferred->mutable_cost_info()->Swap(self->CostInfo); - } - NYql::IssuesToMessage(self->IssueManager.GetIssues(), deferred->mutable_issues()); - auto data = deferred->mutable_result(); - data->PackFrom(result); - self->Reply(resp, status); - } - -private: - TDerived* Derived() noexcept { return static_cast<TDerived*>(this); } -}; - +template <typename TDerived> +class TGrpcResponseSenderImpl : public IRequestOpCtx { +public: + void SendOperation(const Ydb::Operations::Operation& operation) override { + auto self = Derived(); + auto resp = self->CreateResponseMessage(); + resp->mutable_operation()->CopyFrom(operation); + self->Ctx_->Reply(resp, operation.status()); + } + + void SendResult(Ydb::StatusIds::StatusCode status, + const google::protobuf::RepeatedPtrField<TYdbIssueMessageType>& message) override + { + auto self = Derived(); + auto resp = self->CreateResponseMessage(); + auto deferred = resp->mutable_operation(); + deferred->set_ready(true); + deferred->set_status(status); + deferred->mutable_issues()->MergeFrom(message); + if (self->CostInfo) { + deferred->mutable_cost_info()->Swap(self->CostInfo); + } + self->Reply(resp, status); + } + + void SendResult(const google::protobuf::Message& result, + Ydb::StatusIds::StatusCode status, + const google::protobuf::RepeatedPtrField<TYdbIssueMessageType>& message) override + { + auto self = Derived(); + auto resp = self->CreateResponseMessage(); + auto deferred = resp->mutable_operation(); + deferred->set_ready(true); + deferred->set_status(status); + deferred->mutable_issues()->MergeFrom(message); + if (self->CostInfo) { + deferred->mutable_cost_info()->Swap(self->CostInfo); + } + auto data = deferred->mutable_result(); + data->PackFrom(result); + self->Reply(resp, status); + } + + void SendResult(const google::protobuf::Message& result, Ydb::StatusIds::StatusCode status) override { + auto self = Derived(); + auto resp = self->CreateResponseMessage(); + auto deferred = resp->mutable_operation(); + deferred->set_ready(true); + deferred->set_status(status); + if (self->CostInfo) { + deferred->mutable_cost_info()->Swap(self->CostInfo); + } + NYql::IssuesToMessage(self->IssueManager.GetIssues(), deferred->mutable_issues()); + auto data = deferred->mutable_result(); + data->PackFrom(result); + self->Reply(resp, status); + } + +private: + TDerived* Derived() noexcept { return static_cast<TDerived*>(this); } +}; + class TEvProxyRuntimeEvent : public IRequestProxyCtx , public TEventLocal<TEvProxyRuntimeEvent, TRpcServices::EvGrpcRuntimeRequest> @@ -787,15 +787,15 @@ public: template<ui32 TRpcId, typename TReq, typename TResp, bool IsOperation, typename TDerived> class TGRpcRequestWrapperImpl : - public std::conditional_t<IsOperation, - TGrpcResponseSenderImpl<TGRpcRequestWrapperImpl<TRpcId, TReq, TResp, IsOperation, TDerived>>, - IRequestNoOpCtx>, + public std::conditional_t<IsOperation, + TGrpcResponseSenderImpl<TGRpcRequestWrapperImpl<TRpcId, TReq, TResp, IsOperation, TDerived>>, + IRequestNoOpCtx>, public std::conditional_t<TRpcId == TRpcServices::EvGrpcRuntimeRequest, TEvProxyRuntimeEvent, TEvProxyLegacyEvent<TRpcId, TDerived>> { friend class TProtoResponseHelper; - friend class TGrpcResponseSenderImpl<TGRpcRequestWrapperImpl<TRpcId, TReq, TResp, IsOperation, TDerived>>; + friend class TGrpcResponseSenderImpl<TGRpcRequestWrapperImpl<TRpcId, TReq, TResp, IsOperation, TDerived>>; public: using TRequest = TReq; using TResponse = TResp; @@ -879,7 +879,7 @@ public: Reply(resp, status); } - TString GetPeerName() const override { + TString GetPeerName() const override { return Ctx_->GetPeer(); } @@ -898,7 +898,7 @@ public: return GetProtoRequest(this); } - TMaybe<TString> GetTraceId() const override { + TMaybe<TString> GetTraceId() const override { return GetPeerMetaValues(NYdb::YDB_TRACE_ID_HEADER); } @@ -910,7 +910,7 @@ public: return Ctx_->Deadline(); } - const TMaybe<TString> GetRequestType() const override { + const TMaybe<TString> GetRequestType() const override { return GetPeerMetaValues(NYdb::YDB_REQUEST_TYPE_HEADER); } @@ -932,7 +932,7 @@ public: Ctx_->Reply(&data, status); } - void SetCostInfo(float consumed_units) override { + void SetCostInfo(float consumed_units) override { CostInfo = google::protobuf::Arena::CreateMessage<Ydb::CostInfo>(GetArena()); CostInfo->set_consumed_units(consumed_units); } diff --git a/ydb/core/grpc_services/local_rpc/local_rpc.h b/ydb/core/grpc_services/local_rpc/local_rpc.h index ec333a8498..23c3b6c803 100644 --- a/ydb/core/grpc_services/local_rpc/local_rpc.h +++ b/ydb/core/grpc_services/local_rpc/local_rpc.h @@ -98,7 +98,7 @@ public: } void SendResult(Ydb::StatusIds::StatusCode status, - const google::protobuf::RepeatedPtrField<NGRpcService::TYdbIssueMessageType>& message) override + const google::protobuf::RepeatedPtrField<NGRpcService::TYdbIssueMessageType>& message) override { TResp resp; auto deferred = resp.mutable_operation(); @@ -111,7 +111,7 @@ public: CbWrapper(resp); } - void SendOperation(const Ydb::Operations::Operation& operation) override { + void SendOperation(const Ydb::Operations::Operation& operation) override { TResp resp; resp.mutable_operation()->CopyFrom(operation); CbWrapper(resp); @@ -157,7 +157,7 @@ public: return Nothing(); } - void SetCostInfo(float consumed_units) override { + void SetCostInfo(float consumed_units) override { CostInfo = std::make_unique<Ydb::CostInfo>(); CostInfo->set_consumed_units(consumed_units); } diff --git a/ydb/core/kesus/tablet/quoter_resource_tree_ut.cpp b/ydb/core/kesus/tablet/quoter_resource_tree_ut.cpp index b64fa63c83..b280b4b29b 100644 --- a/ydb/core/kesus/tablet/quoter_resource_tree_ut.cpp +++ b/ydb/core/kesus/tablet/quoter_resource_tree_ut.cpp @@ -86,9 +86,9 @@ public: } } - MOCK_METHOD(void, OnSend, (ui64 resourceId, double amount, const NKikimrKesus::TStreamingQuoterResource* props), ()); - MOCK_METHOD(void, OnNotFound, (ui64 resourceId), ()); - MOCK_METHOD(void, OnSessionExpired, (ui64 resourceId), ()); + MOCK_METHOD(void, OnSend, (ui64 resourceId, double amount, const NKikimrKesus::TStreamingQuoterResource* props), ()); + MOCK_METHOD(void, OnNotFound, (ui64 resourceId), ()); + MOCK_METHOD(void, OnSessionExpired, (ui64 resourceId), ()); const ui64 ResourceId; THashSet<ui64> SessionClosed; diff --git a/ydb/core/kesus/tablet/tx_quoter_resource_add.cpp b/ydb/core/kesus/tablet/tx_quoter_resource_add.cpp index 65e94994dd..fa5755eb6e 100644 --- a/ydb/core/kesus/tablet/tx_quoter_resource_add.cpp +++ b/ydb/core/kesus/tablet/tx_quoter_resource_add.cpp @@ -29,7 +29,7 @@ struct TKesusTablet::TTxQuoterResourceAdd : public TTxBase { Reply = MakeHolder<TEvKesus::TEvAddQuoterResourceResult>(result); } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { LOG_DEBUG_S(ctx, NKikimrServices::KESUS_TABLET, "[" << Self->TabletID() << "] TTxQuoterResourceAdd::Execute (sender=" << Sender << ", cookie=" << Cookie << ", path=\"" << Record.GetResource().GetResourcePath() diff --git a/ydb/core/kesus/tablet/tx_quoter_resource_delete.cpp b/ydb/core/kesus/tablet/tx_quoter_resource_delete.cpp index 313e1a739c..33048ba705 100644 --- a/ydb/core/kesus/tablet/tx_quoter_resource_delete.cpp +++ b/ydb/core/kesus/tablet/tx_quoter_resource_delete.cpp @@ -26,7 +26,7 @@ struct TKesusTablet::TTxQuoterResourceDelete : public TTxBase { Reply = MakeHolder<TEvKesus::TEvDeleteQuoterResourceResult>(result); } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { LOG_DEBUG_S(ctx, NKikimrServices::KESUS_TABLET, "[" << Self->TabletID() << "] TTxQuoterResourceDelete::Execute (sender=" << Sender << ", cookie=" << Cookie << ", id=" << Record.GetResourceId() << ", path=\"" << Record.GetResourcePath() << "\")"); diff --git a/ydb/core/kesus/tablet/tx_quoter_resource_update.cpp b/ydb/core/kesus/tablet/tx_quoter_resource_update.cpp index ce8341f4b3..7189612061 100644 --- a/ydb/core/kesus/tablet/tx_quoter_resource_update.cpp +++ b/ydb/core/kesus/tablet/tx_quoter_resource_update.cpp @@ -27,7 +27,7 @@ struct TKesusTablet::TTxQuoterResourceUpdate : public TTxBase { Reply = MakeHolder<TEvKesus::TEvUpdateQuoterResourceResult>(result); } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { LOG_DEBUG_S(ctx, NKikimrServices::KESUS_TABLET, "[" << Self->TabletID() << "] TTxQuoterResourceUpdate::Execute (sender=" << Sender << ", cookie=" << Cookie << ", id=" << Record.GetResource().GetResourceId() << ", path=\"" << Record.GetResource().GetResourcePath() diff --git a/ydb/core/kesus/tablet/tx_semaphore_acquire.cpp b/ydb/core/kesus/tablet/tx_semaphore_acquire.cpp index 15ac7623e8..996dca18bf 100644 --- a/ydb/core/kesus/tablet/tx_semaphore_acquire.cpp +++ b/ydb/core/kesus/tablet/tx_semaphore_acquire.cpp @@ -257,7 +257,7 @@ struct TKesusTablet::TTxSemaphoreAcquire : public TTxBase { return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { LOG_DEBUG_S(ctx, NKikimrServices::KESUS_TABLET, "[" << Self->TabletID() << "] TTxSemaphoreAcquire::Complete (sender=" << Sender << ", cookie=" << Cookie << ")"); diff --git a/ydb/core/kesus/tablet/tx_semaphore_create.cpp b/ydb/core/kesus/tablet/tx_semaphore_create.cpp index 9a505f3e21..100cf550b3 100644 --- a/ydb/core/kesus/tablet/tx_semaphore_create.cpp +++ b/ydb/core/kesus/tablet/tx_semaphore_create.cpp @@ -25,7 +25,7 @@ struct TKesusTablet::TTxSemaphoreCreate : public TTxBase { Reply.Reset(new TEvKesus::TEvCreateSemaphoreResult(Record.GetProxyGeneration())); } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { LOG_DEBUG_S(ctx, NKikimrServices::KESUS_TABLET, "[" << Self->TabletID() << "] TTxSemaphoreCreate::Execute (sender=" << Sender << ", cookie=" << Cookie << ", name=" << Record.GetName().Quote() diff --git a/ydb/core/kesus/tablet/tx_semaphore_delete.cpp b/ydb/core/kesus/tablet/tx_semaphore_delete.cpp index 1feda5e3b3..bdd94a6511 100644 --- a/ydb/core/kesus/tablet/tx_semaphore_delete.cpp +++ b/ydb/core/kesus/tablet/tx_semaphore_delete.cpp @@ -89,7 +89,7 @@ struct TKesusTablet::TTxSemaphoreDelete : public TTxBase { return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { LOG_DEBUG_S(ctx, NKikimrServices::KESUS_TABLET, "[" << Self->TabletID() << "] TTxSemaphoreDelete::Complete (sender=" << Sender << ", cookie=" << Cookie << ")"); diff --git a/ydb/core/kesus/tablet/tx_semaphore_timeout.cpp b/ydb/core/kesus/tablet/tx_semaphore_timeout.cpp index 4cf843bf94..83d1ed0567 100644 --- a/ydb/core/kesus/tablet/tx_semaphore_timeout.cpp +++ b/ydb/core/kesus/tablet/tx_semaphore_timeout.cpp @@ -24,7 +24,7 @@ struct TKesusTablet::TTxSemaphoreTimeout : public TTxBase { TTxType GetTxType() const override { return TXTYPE_SEMAPHORE_TIMEOUT; } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { LOG_DEBUG_S(ctx, NKikimrServices::KESUS_TABLET, "[" << Self->TabletID() << "] TTxSemaphoreTimeout::Execute (session=" << SessionId << ", semaphore=" << SemaphoreId << ")"); diff --git a/ydb/core/kqp/kqp_ic_gateway.cpp b/ydb/core/kqp/kqp_ic_gateway.cpp index 5e183d9ae4..47489a9bd5 100644 --- a/ydb/core/kqp/kqp_ic_gateway.cpp +++ b/ydb/core/kqp/kqp_ic_gateway.cpp @@ -1024,7 +1024,7 @@ public: } } - TVector<TString> GetCollectedSchemeData() override { + TVector<TString> GetCollectedSchemeData() override { return MetadataLoader->GetCollectedSchemeData(); } @@ -1214,7 +1214,7 @@ public: } } - TFuture<TGenericResult> AlterTable(Ydb::Table::AlterTableRequest&& req, const TString& cluster) override { + TFuture<TGenericResult> AlterTable(Ydb::Table::AlterTableRequest&& req, const TString& cluster) override { try { if (!CheckCluster(cluster)) { return InvalidCluster<TGenericResult>(cluster); diff --git a/ydb/core/kqp/provider/yql_kikimr_datasource.cpp b/ydb/core/kqp/provider/yql_kikimr_datasource.cpp index 6f2b5103f1..65ef7eb932 100644 --- a/ydb/core/kqp/provider/yql_kikimr_datasource.cpp +++ b/ydb/core/kqp/provider/yql_kikimr_datasource.cpp @@ -391,7 +391,7 @@ public: return false; } - bool IsPersistent(const TExprNode& node) override { + bool IsPersistent(const TExprNode& node) override { if (node.IsCallable(ReadName)) { return node.Child(1)->Child(0)->Content() == KikimrProviderName; } diff --git a/ydb/core/mind/hive/tx__adopt_tablet.cpp b/ydb/core/mind/hive/tx__adopt_tablet.cpp index ee18884cb6..45203af0d1 100644 --- a/ydb/core/mind/hive/tx__adopt_tablet.cpp +++ b/ydb/core/mind/hive/tx__adopt_tablet.cpp @@ -36,7 +36,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_ADOPT_TABLET; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { BLOG_D("THive::TTxAdoptTablet::Execute"); NIceDb::TNiceDb db(txc.DB); @@ -100,7 +100,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxAdoptTablet::Complete TabletId: " << TabletId << " Status: " << NKikimrProto::EReplyStatus_Name(Status) << " Explain: " << Explain); diff --git a/ydb/core/mind/hive/tx__block_storage_result.cpp b/ydb/core/mind/hive/tx__block_storage_result.cpp index cc5e6ddf66..28315ec93b 100644 --- a/ydb/core/mind/hive/tx__block_storage_result.cpp +++ b/ydb/core/mind/hive/tx__block_storage_result.cpp @@ -16,7 +16,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_BLOCK_STORAGE_RESULT; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { TEvTabletBase::TEvBlockBlobStorageResult* msg = Result->Get(); BLOG_D("THive::TTxBlockStorageResult::Execute(" << TabletId << " " << NKikimrProto::EReplyStatus_Name(msg->Status) << ")"); TLeaderTabletInfo* tablet = Self->FindTabletEvenInDeleting(TabletId); @@ -35,7 +35,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { TEvTabletBase::TEvBlockBlobStorageResult* msg = Result->Get(); BLOG_D("THive::TTxBlockStorageResult::Complete(" << TabletId << " " << NKikimrProto::EReplyStatus_Name(msg->Status) << ")"); TLeaderTabletInfo* tablet = Self->FindTabletEvenInDeleting(TabletId); diff --git a/ydb/core/mind/hive/tx__create_tablet.cpp b/ydb/core/mind/hive/tx__create_tablet.cpp index 46161e7f26..f3b27bfd9a 100644 --- a/ydb/core/mind/hive/tx__create_tablet.cpp +++ b/ydb/core/mind/hive/tx__create_tablet.cpp @@ -153,7 +153,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_CREATE_TABLET; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { BLOG_D("THive::TTxCreateTablet::Execute"); State = ETabletState::Unknown; ErrorReason = NKikimrHive::ERROR_REASON_UNKNOWN; @@ -460,7 +460,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { if (Status != NKikimrProto::UNKNOWN) { BLOG_D("THive::TTxCreateTablet::Complete TabletId: " << TabletId << " Status: " << NKikimrProto::EReplyStatus_Name(Status) << " State: " << ETabletStateName(State)); diff --git a/ydb/core/mind/hive/tx__cut_tablet_history.cpp b/ydb/core/mind/hive/tx__cut_tablet_history.cpp index ee0d67097a..9bf4c94b98 100644 --- a/ydb/core/mind/hive/tx__cut_tablet_history.cpp +++ b/ydb/core/mind/hive/tx__cut_tablet_history.cpp @@ -14,7 +14,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_CUT_TABLET_HISTORY; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { TEvHive::TEvCutTabletHistory* msg = Event->Get(); auto tabletId = msg->Record.GetTabletID(); BLOG_D("THive::TTxCutTabletHistory::Execute(" << tabletId << ")"); @@ -38,7 +38,7 @@ public: return true; } - void Complete(const TActorContext&) override {} + void Complete(const TActorContext&) override {} }; ITransaction* THive::CreateCutTabletHistory(TEvHive::TEvCutTabletHistory::TPtr& ev) { diff --git a/ydb/core/mind/hive/tx__delete_tablet.cpp b/ydb/core/mind/hive/tx__delete_tablet.cpp index f17d9d0402..6d481e695f 100644 --- a/ydb/core/mind/hive/tx__delete_tablet.cpp +++ b/ydb/core/mind/hive/tx__delete_tablet.cpp @@ -57,7 +57,7 @@ public: return deletedTablet; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { const NKikimrHive::TEvDeleteTablet& rec = Event->Get()->Record; NIceDb::TNiceDb db(txc.DB); OwnerId = rec.GetShardOwnerId(); @@ -102,7 +102,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxDeleteTablet::Complete(" << TabletIds << ")"); THolder<TEvHive::TEvDeleteTabletReply> response = MakeHolder<TEvHive::TEvDeleteTabletReply>(Status, Self->TabletID(), Event->Get()->Record.GetTxId_Deprecated(), OwnerId, LocalIdxs); if (ForwardRequest.HasHiveTabletId()) { @@ -165,7 +165,7 @@ public: return deletedTablet; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { const NKikimrHive::TEvDeleteOwnerTablets& rec = Event->Get()->Record; BLOG_D("THive::TEvDeleteOwnerTablets::Execute Owner: " << rec.GetOwner()); for (auto item : Self->OwnerToTablet) { @@ -194,7 +194,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TEvDeleteOwnerTablets::Complete(" << Event->Get()->Record.GetOwner() << "), " << ToDelete.size() << " tablet has been deleted"); Self->BlockedOwners.emplace(Event->Get()->Record.GetOwner()); ctx.Send(Event->Sender, new TEvHive::TEvDeleteOwnerTabletsReply(Status, Self->TabletID(), Event->Get()->Record.GetOwner(), Event->Get()->Record.GetTxId())); diff --git a/ydb/core/mind/hive/tx__delete_tablet_result.cpp b/ydb/core/mind/hive/tx__delete_tablet_result.cpp index 162018da91..bbe89acae4 100644 --- a/ydb/core/mind/hive/tx__delete_tablet_result.cpp +++ b/ydb/core/mind/hive/tx__delete_tablet_result.cpp @@ -20,7 +20,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_DELETE_TABLET_RESULT; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { TEvTabletBase::TEvDeleteTabletResult* msg = Result->Get(); BLOG_D("THive::TTxDeleteTabletResult::Execute(" << TabletId << " " << NKikimrProto::EReplyStatus_Name(msg->Status) << ")"); Tablet = Self->FindTabletEvenInDeleting(TabletId); @@ -52,7 +52,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { TEvTabletBase::TEvDeleteTabletResult* msg = Result->Get(); BLOG_D("THive::TTxDeleteTabletResult(" << TabletId << " " << NKikimrProto::EReplyStatus_Name(msg->Status) << ")::Complete"); Tablet = Self->FindTabletEvenInDeleting(TabletId); diff --git a/ydb/core/mind/hive/tx__disconnect_node.cpp b/ydb/core/mind/hive/tx__disconnect_node.cpp index 786a074d21..0969a6e3b9 100644 --- a/ydb/core/mind/hive/tx__disconnect_node.cpp +++ b/ydb/core/mind/hive/tx__disconnect_node.cpp @@ -16,7 +16,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_DISCONNECT_NODE; } - bool Execute(TTransactionContext&, const TActorContext&) override { + bool Execute(TTransactionContext&, const TActorContext&) override { BLOG_D("THive::TTxDisconnectNode()::Execute"); TNodeInfo* node = Self->FindNode(Event->NodeId); if (node != nullptr) { @@ -42,7 +42,7 @@ public: return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { BLOG_D("THive::TTxDisconnectNode()::Complete"); } }; diff --git a/ydb/core/mind/hive/tx__init_scheme.cpp b/ydb/core/mind/hive/tx__init_scheme.cpp index e02b72c5c0..b65451f94a 100644 --- a/ydb/core/mind/hive/tx__init_scheme.cpp +++ b/ydb/core/mind/hive/tx__init_scheme.cpp @@ -13,7 +13,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_INIT_SCHEME; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { BLOG_D("THive::TTxInitScheme::Execute"); NIceDb::TNiceDb(txc.DB).Materialize<Schema>(); if (!txc.DB.GetScheme().IsEmpty()) { @@ -92,7 +92,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxInitScheme::Complete"); const TActorId nameserviceId = GetNameserviceActorId(); ctx.Send(nameserviceId, new TEvInterconnect::TEvListNodes()); diff --git a/ydb/core/mind/hive/tx__load_everything.cpp b/ydb/core/mind/hive/tx__load_everything.cpp index 7864836003..e4c1cf1f51 100644 --- a/ydb/core/mind/hive/tx__load_everything.cpp +++ b/ydb/core/mind/hive/tx__load_everything.cpp @@ -12,7 +12,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_LOAD_EVERYTHING; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { BLOG_D("THive::TTxLoadEverything::Execute"); TAppData* appData = AppData(); @@ -617,7 +617,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxLoadEverything::Complete " << Self->DatabaseConfig.ShortDebugString()); i64 tabletsTotal = 0; for (auto it = Self->Tablets.begin(); it != Self->Tablets.end(); ++it) { diff --git a/ydb/core/mind/hive/tx__process_boot_queue.cpp b/ydb/core/mind/hive/tx__process_boot_queue.cpp index 9380c59e17..8ce6459862 100644 --- a/ydb/core/mind/hive/tx__process_boot_queue.cpp +++ b/ydb/core/mind/hive/tx__process_boot_queue.cpp @@ -12,13 +12,13 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_PROCESS_BOOT_QUEUE; } - bool Execute(TTransactionContext&, const TActorContext&) override { + bool Execute(TTransactionContext&, const TActorContext&) override { BLOG_D("THive::TTxProcessBootQueue()::Execute"); Self->RunProcessBootQueue(); return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { BLOG_D("THive::TTxProcessBootQueue()::Complete"); } }; diff --git a/ydb/core/mind/hive/tx__process_pending_operations.cpp b/ydb/core/mind/hive/tx__process_pending_operations.cpp index 70c0c54ccf..afaf7203d4 100644 --- a/ydb/core/mind/hive/tx__process_pending_operations.cpp +++ b/ydb/core/mind/hive/tx__process_pending_operations.cpp @@ -15,7 +15,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_PROCESS_PENDING_OPERATIONS; } - bool Execute(TTransactionContext&, const TActorContext&) override { + bool Execute(TTransactionContext&, const TActorContext&) override { BLOG_D("THive::TTxProcessPendingOperations()::Execute"); for (auto& [owner, pendingCreateTablet] : Self->PendingCreateTablets) { THolder<TEvHive::TEvCreateTablet> evCreateTablet(new TEvHive::TEvCreateTablet()); @@ -25,7 +25,7 @@ public: return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { BLOG_D("THive::TTxProcessPendingOperations()::Complete"); for (THolder<IEventHandle>& event : Events) { BLOG_D("THive::TTxProcessPendingOperations(): retry event " << event->Type); diff --git a/ydb/core/mind/hive/tx__reassign_groups.cpp b/ydb/core/mind/hive/tx__reassign_groups.cpp index 70c9de834a..ec9f4bfdd2 100644 --- a/ydb/core/mind/hive/tx__reassign_groups.cpp +++ b/ydb/core/mind/hive/tx__reassign_groups.cpp @@ -24,7 +24,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_REASSIGN_GROUPS; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { //SetTxType(NHive::TXTYPE_KILL_TABLET); TLeaderTabletInfo* tablet = Self->FindTablet(TabletId); if (tablet != nullptr) { @@ -53,7 +53,7 @@ public: return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { BLOG_D("THive::TTxReassignGroups(" << TabletId << ")::Complete"); if (InitiatedReassignTablet) { TLeaderTabletInfo* tablet = Self->FindTablet(TabletId); diff --git a/ydb/core/mind/hive/tx__release_tablets.cpp b/ydb/core/mind/hive/tx__release_tablets.cpp index bf7d7b699d..cdfd82ce06 100644 --- a/ydb/core/mind/hive/tx__release_tablets.cpp +++ b/ydb/core/mind/hive/tx__release_tablets.cpp @@ -18,7 +18,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_RELEASE_TABLETS; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { const NKikimrHive::TEvReleaseTablets& request(Request->Get()->Record); NKikimrHive::TEvReleaseTabletsReply& response(Response->Record); BLOG_D("THive::TTxReleaseTablets::Execute " << request); @@ -75,7 +75,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxReleaseTablets::Complete " << Request->Get()->Record); for (const auto& unlockedFromActor : UnlockedFromActor) { // Notify lock owner that lock has been lost diff --git a/ydb/core/mind/hive/tx__release_tablets_reply.cpp b/ydb/core/mind/hive/tx__release_tablets_reply.cpp index 6dea0a90a3..8589258f32 100644 --- a/ydb/core/mind/hive/tx__release_tablets_reply.cpp +++ b/ydb/core/mind/hive/tx__release_tablets_reply.cpp @@ -61,7 +61,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_RELEASE_TABLETS_REPLY; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { const NKikimrHive::TEvReleaseTabletsReply& request(Request->Get()->Record); BLOG_D("THive::TTxReleaseTabletsReply::Execute " << request); NIceDb::TNiceDb db(txc.DB); @@ -71,7 +71,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { const NKikimrHive::TEvReleaseTabletsReply& request(Request->Get()->Record); BLOG_D("THive::TTxReleaseTabletsReply::Complete"); diff --git a/ydb/core/mind/hive/tx__request_tablet_seq.cpp b/ydb/core/mind/hive/tx__request_tablet_seq.cpp index 07a2bda8b1..aa43f85ea4 100644 --- a/ydb/core/mind/hive/tx__request_tablet_seq.cpp +++ b/ydb/core/mind/hive/tx__request_tablet_seq.cpp @@ -19,7 +19,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_REQUEST_TABLET_SEQUENCE; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { BLOG_D("THive::TTxRequestTabletSequence()::Execute"); const auto& pbRecord(Event->Get()->Record); Size = pbRecord.GetSize(); @@ -52,7 +52,7 @@ public: return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { BLOG_D("THive::TTxRequestTabletSequence()::Complete"); if (Sequence == TSequencer::NO_SEQUENCE) { BLOG_CRIT("Could not allocate sequence of " << Size << " elements for " << Owner); diff --git a/ydb/core/mind/hive/tx__response_tablet_seq.cpp b/ydb/core/mind/hive/tx__response_tablet_seq.cpp index ef3b5a45fc..4c0e2a41e3 100644 --- a/ydb/core/mind/hive/tx__response_tablet_seq.cpp +++ b/ydb/core/mind/hive/tx__response_tablet_seq.cpp @@ -18,7 +18,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_RESPONSE_TABLET_SEQUENCE; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { BLOG_D("THive::TTxResponseTabletSequence()::Execute"); const auto& pbRecord(Event->Get()->Record); if (!pbRecord.HasOwner()) { @@ -53,7 +53,7 @@ public: return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { BLOG_D("THive::TTxResponseTabletSequence()::Complete"); if (!Sequence.Empty()) { Self->ProcessPendingOperations(); diff --git a/ydb/core/mind/hive/tx__restart_tablet.cpp b/ydb/core/mind/hive/tx__restart_tablet.cpp index 0dde88e173..3c070ed706 100644 --- a/ydb/core/mind/hive/tx__restart_tablet.cpp +++ b/ydb/core/mind/hive/tx__restart_tablet.cpp @@ -23,7 +23,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_RESTART_TABLET; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { TTabletInfo* tablet = Self->FindTablet(TabletId); if (tablet != nullptr) { if (PreferredNodeId != 0) { @@ -48,7 +48,7 @@ public: return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { BLOG_D("THive::TTxRestartTablet(" << TabletId << ")::Complete"); } }; diff --git a/ydb/core/mind/hive/tx__resume_tablet.cpp b/ydb/core/mind/hive/tx__resume_tablet.cpp index 52961bef46..a7252bff72 100644 --- a/ydb/core/mind/hive/tx__resume_tablet.cpp +++ b/ydb/core/mind/hive/tx__resume_tablet.cpp @@ -19,7 +19,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_RESUME_TABLET; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { BLOG_D("THive::TTxResumeTablet::Execute Tablet: " << TabletId); TLeaderTabletInfo* tablet = Self->FindTablet(TabletId); if (tablet != nullptr) { @@ -62,7 +62,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxResumeTablet::Complete TabletId: " << TabletId); if (Status != NKikimrProto::UNKNOWN) { ctx.Send(ActorToNotify, new TEvHive::TEvResumeTabletResult(Status, TabletId), 0, 0); diff --git a/ydb/core/mind/hive/tx__seize_tablets.cpp b/ydb/core/mind/hive/tx__seize_tablets.cpp index 553c7c9a7f..09a93c9656 100644 --- a/ydb/core/mind/hive/tx__seize_tablets.cpp +++ b/ydb/core/mind/hive/tx__seize_tablets.cpp @@ -36,7 +36,7 @@ public: } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { const NKikimrHive::TEvSeizeTablets& request(Request->Get()->Record); NKikimrHive::TEvSeizeTabletsReply& response(Response->Record); BLOG_D("THive::TTxSeizeTablets::Execute " << request); @@ -150,7 +150,7 @@ public: return true; } - void Complete(const TActorContext& txc) override { + void Complete(const TActorContext& txc) override { BLOG_D("THive::TTxSeizeTablets::Complete " << Request->Get()->Record); txc.Send(Request->Sender, Response.Release()); } diff --git a/ydb/core/mind/hive/tx__seize_tablets_reply.cpp b/ydb/core/mind/hive/tx__seize_tablets_reply.cpp index 752e80ebb3..6e6db7131b 100644 --- a/ydb/core/mind/hive/tx__seize_tablets_reply.cpp +++ b/ydb/core/mind/hive/tx__seize_tablets_reply.cpp @@ -16,7 +16,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_SEIZE_TABLETS_REPLY; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { const NKikimrHive::TEvSeizeTabletsReply& request(Request->Get()->Record); BLOG_D("THive::TTxSeizeTabletsReply::Execute"); NIceDb::TNiceDb db(txc.DB); @@ -150,7 +150,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxSeizeTabletsReply::Complete"); if (!TabletIds.empty()) { THolder<TEvHive::TEvReleaseTablets> request(new TEvHive::TEvReleaseTablets()); diff --git a/ydb/core/mind/hive/tx__start_tablet.cpp b/ydb/core/mind/hive/tx__start_tablet.cpp index 0347ab17b3..4cef3a0e06 100644 --- a/ydb/core/mind/hive/tx__start_tablet.cpp +++ b/ydb/core/mind/hive/tx__start_tablet.cpp @@ -22,7 +22,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_START_TABLET; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { BLOG_D("THive::TTxStartTablet::Execute Tablet " << TabletId); TTabletInfo* tablet = Self->FindTablet(TabletId); if (tablet != nullptr) { @@ -43,7 +43,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { TTabletInfo* tablet = Self->FindTablet(TabletId); if (tablet != nullptr) { if (tablet->LastNodeId != 0 && tablet->LastNodeId != Local.NodeId()) { diff --git a/ydb/core/mind/hive/tx__status.cpp b/ydb/core/mind/hive/tx__status.cpp index 7a93b8ea3b..e45fa5055a 100644 --- a/ydb/core/mind/hive/tx__status.cpp +++ b/ydb/core/mind/hive/tx__status.cpp @@ -44,7 +44,7 @@ public: return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { TNodeId nodeId = Local.NodeId(); BLOG_D("THive::TTxStatus(" << nodeId << ")::Complete"); TNodeInfo* node = Self->FindNode(nodeId); diff --git a/ydb/core/mind/hive/tx__stop_tablet.cpp b/ydb/core/mind/hive/tx__stop_tablet.cpp index b1ad3e122c..c05103b258 100644 --- a/ydb/core/mind/hive/tx__stop_tablet.cpp +++ b/ydb/core/mind/hive/tx__stop_tablet.cpp @@ -19,7 +19,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_STOP_TABLET; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { BLOG_D("THive::TTxStopTablet::Execute Tablet: " << TabletId); TLeaderTabletInfo* tablet = Self->FindTablet(TabletId); if (tablet != nullptr) { @@ -73,7 +73,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxStopTablet::Complete TabletId: " << TabletId); if (Status != NKikimrProto::UNKNOWN) { ctx.Send(ActorToNotify, new TEvHive::TEvStopTabletResult(Status, TabletId), 0, 0); diff --git a/ydb/core/mind/hive/tx__switch_drain.cpp b/ydb/core/mind/hive/tx__switch_drain.cpp index 9c59f098e1..1a09d87993 100644 --- a/ydb/core/mind/hive/tx__switch_drain.cpp +++ b/ydb/core/mind/hive/tx__switch_drain.cpp @@ -17,7 +17,7 @@ public: , Initiator(initiator) {} - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { BLOG_D("THive::TTxSwitchDrainOn::Execute Node: " << NodeId << " Persist: " << Settings.Persist << " KeepDown: " << Settings.KeepDown); NIceDb::TNiceDb db(txc.DB); @@ -49,7 +49,7 @@ public: return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { BLOG_D("THive::TTxSwitchDrainOn::Complete NodeId: " << NodeId << " Status: " << Status); if (Status != NKikimrProto::OK) { if (Initiator) { @@ -75,7 +75,7 @@ public: , Movements(movements) {} - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& txc, const TActorContext&) override { BLOG_D("THive::TTxSwitchDrainOff::Execute Node: " << NodeId); NIceDb::TNiceDb db(txc.DB); TNodeInfo* node = Self->FindNode(NodeId); @@ -94,7 +94,7 @@ public: return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { BLOG_D("THive::TTxSwitchDrainOff::Complete NodeId: " << NodeId << " Status: " << NKikimrProto::EReplyStatus_Name(Status) << " Movements: " << Movements); for (const TActorId& initiator : Initiators) { diff --git a/ydb/core/mind/hive/tx__sync_tablets.cpp b/ydb/core/mind/hive/tx__sync_tablets.cpp index 371287b8fa..29eb4cfba1 100644 --- a/ydb/core/mind/hive/tx__sync_tablets.cpp +++ b/ydb/core/mind/hive/tx__sync_tablets.cpp @@ -37,7 +37,7 @@ public: return false; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { BLOG_D("THive::TTxSyncTablets(" << Local << ")::Execute"); NIceDb::TNiceDb db(txc.DB); TNodeInfo& node = Self->GetNode(Local.NodeId()); @@ -111,7 +111,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxSyncTablets(" << Local << ")::Complete"); for (std::pair<TTabletId, TFollowerId> tabletId : TabletsToStop) { Self->Execute(Self->CreateRestartTablet(tabletId), ctx); diff --git a/ydb/core/mind/hive/tx__update_tablet_groups.cpp b/ydb/core/mind/hive/tx__update_tablet_groups.cpp index f8b23f0f83..2d9a11bc3b 100644 --- a/ydb/core/mind/hive/tx__update_tablet_groups.cpp +++ b/ydb/core/mind/hive/tx__update_tablet_groups.cpp @@ -27,7 +27,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_UPDATE_TABLET_GROUPS; } - bool Execute(TTransactionContext &txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext &txc, const TActorContext& ctx) override { TStringBuilder tabletBootState; TLeaderTabletInfo* tablet = Self->FindTablet(TabletId); @@ -249,7 +249,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { if (Ignored) { BLOG_NOTICE("THive::TTxUpdateTabletGroups{" << (ui64)this << "}(" << TabletId << ")::Complete" " - Ignored transaction"); diff --git a/ydb/core/mind/hive/tx__update_tablet_metrics.cpp b/ydb/core/mind/hive/tx__update_tablet_metrics.cpp index 67437fe0e4..7e6150ec9a 100644 --- a/ydb/core/mind/hive/tx__update_tablet_metrics.cpp +++ b/ydb/core/mind/hive/tx__update_tablet_metrics.cpp @@ -15,7 +15,7 @@ public: TTxType GetTxType() const override { return NHive::TXTYPE_UPDATE_TABLET_METRIC; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { TInstant now = TInstant::Now(); Reply = new TEvLocal::TEvTabletMetricsAck; auto& record = Event->Get()->Record; @@ -68,7 +68,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { ctx.Send(Event->Sender, Reply.Release()); Self->UpdateTabletMetricsInProgress--; } diff --git a/ydb/core/mind/hive/tx__update_tablet_status.cpp b/ydb/core/mind/hive/tx__update_tablet_status.cpp index 0e3bd50e22..7e682e857d 100644 --- a/ydb/core/mind/hive/tx__update_tablet_status.cpp +++ b/ydb/core/mind/hive/tx__update_tablet_status.cpp @@ -61,7 +61,7 @@ public: return str; } - bool Execute(TTransactionContext &txc, const TActorContext&) override { + bool Execute(TTransactionContext &txc, const TActorContext&) override { TTabletInfo* tablet = Self->FindTablet(TabletId, FollowerId); if (tablet != nullptr) { BLOG_D("THive::TTxUpdateTabletStatus::Execute for tablet " @@ -185,7 +185,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { BLOG_D("THive::TTxUpdateTabletStatus::Complete TabletId: " << TabletId << " Notifications: " << Notifications); Notifications.Send(ctx); TLeaderTabletInfo* tablet = Self->FindTablet(TabletId); diff --git a/ydb/core/quoter/ut_helpers.h b/ydb/core/quoter/ut_helpers.h index 891023c5f0..ea76fdc0ae 100644 --- a/ydb/core/quoter/ut_helpers.h +++ b/ydb/core/quoter/ut_helpers.h @@ -121,11 +121,11 @@ public: public: TTestTabletPipe(TTestTabletPipeFactory* parent); - MOCK_METHOD(void, OnStart, (), ()); - MOCK_METHOD(void, OnPoisonPill, (), ()); - MOCK_METHOD(void, OnSubscribeOnResources, (const NKikimrKesus::TEvSubscribeOnResources&, ui64 cookie), ()); - MOCK_METHOD(void, OnUpdateConsumptionState, (const NKikimrKesus::TEvUpdateConsumptionState&, ui64 cookie), ()); - MOCK_METHOD(void, OnResourcesAllocatedAck, (const NKikimrKesus::TEvResourcesAllocatedAck&, ui64 cookie), ()); + MOCK_METHOD(void, OnStart, (), ()); + MOCK_METHOD(void, OnPoisonPill, (), ()); + MOCK_METHOD(void, OnSubscribeOnResources, (const NKikimrKesus::TEvSubscribeOnResources&, ui64 cookie), ()); + MOCK_METHOD(void, OnUpdateConsumptionState, (const NKikimrKesus::TEvUpdateConsumptionState&, ui64 cookie), ()); + MOCK_METHOD(void, OnResourcesAllocatedAck, (const NKikimrKesus::TEvResourcesAllocatedAck&, ui64 cookie), ()); void SendNotConnected(); void SendConnected(); diff --git a/ydb/core/tablet_flat/flat_executor.h b/ydb/core/tablet_flat/flat_executor.h index 1b66829286..df08b3a338 100644 --- a/ydb/core/tablet_flat/flat_executor.h +++ b/ydb/core/tablet_flat/flat_executor.h @@ -561,7 +561,7 @@ class TExecutor NKikimrSchemeOp::ECompactionStrategy strategy); public: - void Describe(IOutputStream &out) const noexcept override + void Describe(IOutputStream &out) const noexcept override { out << (Stats->IsFollower ? "Follower" : "Leader") diff --git a/ydb/core/tablet_flat/flat_scan_actor.h b/ydb/core/tablet_flat/flat_scan_actor.h index ffbf025ca3..5cbf2797a0 100644 --- a/ydb/core/tablet_flat/flat_scan_actor.h +++ b/ydb/core/tablet_flat/flat_scan_actor.h @@ -70,7 +70,7 @@ namespace NOps { delete DetachScan(); } - void Describe(IOutputStream &out) const noexcept override + void Describe(IOutputStream &out) const noexcept override { out << "Scan{" << Serial << " on " << Snapshot->Table diff --git a/ydb/core/tablet_flat/test/libs/exec/logger.h b/ydb/core/tablet_flat/test/libs/exec/logger.h index 81050c79e7..471f00b844 100644 --- a/ydb/core/tablet_flat/test/libs/exec/logger.h +++ b/ydb/core/tablet_flat/test/libs/exec/logger.h @@ -86,7 +86,7 @@ namespace NFake { } - NUtil::TLogLn Log(ELnLev prio) const noexcept override + NUtil::TLogLn Log(ELnLev prio) const noexcept override { return { prio <= Level ? this : nullptr, prio }; } diff --git a/ydb/core/tablet_flat/ut/flat_test_db.cpp b/ydb/core/tablet_flat/ut/flat_test_db.cpp index a8cce6f8f9..b65757d4bb 100644 --- a/ydb/core/tablet_flat/ut/flat_test_db.cpp +++ b/ydb/core/tablet_flat/ut/flat_test_db.cpp @@ -131,23 +131,23 @@ public: return IsValid () ? EReady::Data : EReady::Gone; } - bool IsValid() override { + bool IsValid() override { return RowIt != RowEnd; } - bool IsRowDeleted() override { + bool IsRowDeleted() override { Y_ASSERT(IsValid()); return RowIt->second.IsDeleted; } - TDbTupleRef GetKey() override { + TDbTupleRef GetKey() override { if (!IsValid()) return TDbTupleRef(); return TDbTupleRef(&KeyTypes[0], &KeyCells[0], KeyCells.size()); } - TDbTupleRef GetValues() override { + TDbTupleRef GetValues() override { if (!IsValid()) return TDbTupleRef(); @@ -157,7 +157,7 @@ public: return TDbTupleRef(&ValueTypes[0], &ValueCells[0], ValueCells.size()); } - TCell GetValue(ui32 idx) override { + TCell GetValue(ui32 idx) override { if (!IsValid()) return TCell(); @@ -185,15 +185,15 @@ private: TAutoPtr<TScheme> Scheme; public: - void Init(const TScheme& scheme) override { + void Init(const TScheme& scheme) override { Scheme.Reset(new TScheme(scheme)); } - const TScheme& GetScheme() const override { + const TScheme& GetScheme() const override { return *Scheme; } - TString FinishTransaction(bool commit) override { + TString FinishTransaction(bool commit) override { if (commit) { TAutoPtr<TSchemeChanges> schemeDeltaRecs = SchemeChanges.Flush(); TSchemeModifier(*Scheme).Apply(*schemeDeltaRecs); @@ -268,9 +268,9 @@ public: TxChanges[root][fk] = fv; } - void Precharge(ui32 root, + void Precharge(ui32 root, TRawVals keyFrom, TRawVals keyTo, - TTagsRef tags, ui32 flags) override { + TTagsRef tags, ui32 flags) override { Y_UNUSED(root); Y_UNUSED(keyFrom); Y_UNUSED(keyTo); @@ -278,7 +278,7 @@ public: Y_UNUSED(flags); } - ITestIterator* Iterate(ui32 root, TRawVals key, TTagsRef tags, ELookup mode) noexcept override { + ITestIterator* Iterate(ui32 root, TRawVals key, TTagsRef tags, ELookup mode) noexcept override { if (!key) { return new TFakeDbIterator(GetScheme(), root, tags, Tables[root].begin(), Tables[root].end()); } diff --git a/ydb/core/tablet_flat/ut/flat_test_db.h b/ydb/core/tablet_flat/ut/flat_test_db.h index 258a6e9d14..ed0af81c68 100644 --- a/ydb/core/tablet_flat/ut/flat_test_db.h +++ b/ydb/core/tablet_flat/ut/flat_test_db.h @@ -67,23 +67,23 @@ public: return ready; } - bool IsValid() override { + bool IsValid() override { return Iter->Last() == EReady::Data; } - bool IsRowDeleted() override { + bool IsRowDeleted() override { return Iter->Row().GetRowState() == ERowOp::Erase; } - TDbTupleRef GetKey() override { + TDbTupleRef GetKey() override { return Iter->GetKey(); } - TDbTupleRef GetValues() override { + TDbTupleRef GetValues() override { return Iter->GetValues(); } - TCell GetValue(ui32 idx) override { + TCell GetValue(ui32 idx) override { return Iter->Row().Get(idx); } }; @@ -106,16 +106,16 @@ public: return Db; } - void Init(const TScheme& scheme) override { + void Init(const TScheme& scheme) override { Y_UNUSED(scheme); Y_VERIFY("Not supported by flat db wrapper"); } - const TScheme& GetScheme() const override { + const TScheme& GetScheme() const override { return Db->GetScheme(); } - TString FinishTransaction(bool commit) override { + TString FinishTransaction(bool commit) override { Y_UNUSED(commit); Y_VERIFY("Not supported by flat db wrapper"); return "42"; @@ -126,15 +126,15 @@ public: Db->Update(root, rop, key, ops); } - void Precharge(ui32 root, + void Precharge(ui32 root, TRawVals keyFrom, TRawVals keyTo, - TTagsRef tags, ui32 flags) override { + TTagsRef tags, ui32 flags) override { bool res = Db->Precharge(root, keyFrom, keyTo, tags, flags, -1, -1); if (!res) throw TIteratorNotReady(); } - ITestIterator* Iterate(ui32 root, TRawVals key, TTagsRef tags, ELookup mode) override { + ITestIterator* Iterate(ui32 root, TRawVals key, TTagsRef tags, ELookup mode) override { if (auto res = Db->Iterate(root, key, tags, mode)) return new TFlatDbIterator(res); throw TIteratorNotReady(); @@ -170,29 +170,29 @@ public: return one; } - bool IsValid() override { + bool IsValid() override { return It1->IsValid(); } - bool IsRowDeleted() override { + bool IsRowDeleted() override { return It2->IsRowDeleted(); } - TDbTupleRef GetKey() override { + TDbTupleRef GetKey() override { TDbTupleRef keyTuple1 = It1->GetKey(); TDbTupleRef keyTuple2 = It2->GetKey(); VerifyEqualTuples(keyTuple1, keyTuple2); return keyTuple1; } - TDbTupleRef GetValues() override { + TDbTupleRef GetValues() override { TDbTupleRef tuple1 = It1->GetValues(); TDbTupleRef tuple2 = It2->GetValues(); VerifyEqualTuples(tuple1, tuple2); return tuple1; } - TCell GetValue(ui32 idx) override { + TCell GetValue(ui32 idx) override { TCell c1 = It1->GetValue(idx); TCell c2 = It2->GetValue(idx); UNIT_ASSERT(c1.IsNull() == c2.IsNull()); @@ -224,12 +224,12 @@ public: , Db2(&db2) {} - void Init(const TScheme& scheme) override { + void Init(const TScheme& scheme) override { Db1->Init(scheme); Db2->Init(scheme); } - const TScheme& GetScheme() const override { + const TScheme& GetScheme() const override { return Db1->GetScheme(); } @@ -241,7 +241,7 @@ public: return Db2; } - TString FinishTransaction(bool commit) override { + TString FinishTransaction(bool commit) override { auto res = Db1->FinishTransaction(commit); Db2->FinishTransaction(commit); return res; @@ -252,14 +252,14 @@ public: Db2->Update(root, rop, key, ops); } - void Precharge(ui32 root, + void Precharge(ui32 root, TRawVals keyFrom, TRawVals keyTo, - TTagsRef tags, ui32 flags) override { + TTagsRef tags, ui32 flags) override { Db1->Precharge(root, keyFrom, keyTo, tags, flags); Db2->Precharge(root, keyFrom, keyTo, tags, flags); } - ITestIterator* Iterate(ui32 root, TRawVals key, TTagsRef tags, ELookup mode) override { + ITestIterator* Iterate(ui32 root, TRawVals key, TTagsRef tags, ELookup mode) override { return new TIteratorPair( Db1->Iterate(root, key, tags, mode), Db2->Iterate(root, key, tags, mode)); diff --git a/ydb/core/tablet_flat/util_fmt_logger.h b/ydb/core/tablet_flat/util_fmt_logger.h index 6ec40b3a3b..784e1795fd 100644 --- a/ydb/core/tablet_flat/util_fmt_logger.h +++ b/ydb/core/tablet_flat/util_fmt_logger.h @@ -26,7 +26,7 @@ namespace NUtil { } - TLogLn Log(ELnLev level_) const noexcept override + TLogLn Log(ELnLev level_) const noexcept override { const NActors::NLog::TLevel level{ ui32(level_) }; diff --git a/ydb/core/test_tablet/tx_init_scheme.cpp b/ydb/core/test_tablet/tx_init_scheme.cpp index dd702d3de2..665760c1f0 100644 --- a/ydb/core/test_tablet/tx_init_scheme.cpp +++ b/ydb/core/test_tablet/tx_init_scheme.cpp @@ -14,7 +14,7 @@ namespace NKikimr::NTestShard { return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { Self->Execute(Self->CreateTxLoadEverything(), ctx); } }; diff --git a/ydb/core/test_tablet/tx_initialize.cpp b/ydb/core/test_tablet/tx_initialize.cpp index 82d7d1e92a..70614cd3e9 100644 --- a/ydb/core/test_tablet/tx_initialize.cpp +++ b/ydb/core/test_tablet/tx_initialize.cpp @@ -32,7 +32,7 @@ namespace NKikimr::NTestShard { return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { ctx.Send(Sender, new TEvControlResponse, 0, Cookie); Self->Settings = Cmd; Self->StartActivities(); diff --git a/ydb/core/test_tablet/tx_load_everything.cpp b/ydb/core/test_tablet/tx_load_everything.cpp index 2968c9f455..b00a3dada1 100644 --- a/ydb/core/test_tablet/tx_load_everything.cpp +++ b/ydb/core/test_tablet/tx_load_everything.cpp @@ -28,7 +28,7 @@ namespace NKikimr::NTestShard { return true; } - void Complete(const TActorContext&) override { + void Complete(const TActorContext&) override { Self->OnLoadComplete(); } }; diff --git a/ydb/core/tracing/signal.h b/ydb/core/tracing/signal.h index 23f2175d04..7f317436e9 100644 --- a/ydb/core/tracing/signal.h +++ b/ydb/core/tracing/signal.h @@ -84,7 +84,7 @@ public: return PbSignal.SerializeToString(&str); } - EType GetType() const override { + EType GetType() const override { return TSignalType; } diff --git a/ydb/core/tx/datashard/datashard__kqp_scan.cpp b/ydb/core/tx/datashard/datashard__kqp_scan.cpp index 4cdd0ebf59..b6b6b7e337 100644 --- a/ydb/core/tx/datashard/datashard__kqp_scan.cpp +++ b/ydb/core/tx/datashard/datashard__kqp_scan.cpp @@ -295,7 +295,7 @@ private: return EScan::Feed; // sent by rows limit, can send one more batch } - EScan Exhausted() noexcept override { + EScan Exhausted() noexcept override { LOG_DEBUG_S(*TlsActivationContext, NKikimrServices::TX_DATASHARD, "Range " << CurrentRange << " of " << TableRanges.size() << " exhausted: try next one." << " table: " << TablePath diff --git a/ydb/core/tx/datashard/datashard__read_columns.cpp b/ydb/core/tx/datashard/datashard__read_columns.cpp index 2c500e7569..2b56a192d1 100644 --- a/ydb/core/tx/datashard/datashard__read_columns.cpp +++ b/ydb/core/tx/datashard/datashard__read_columns.cpp @@ -211,7 +211,7 @@ public: return ready; } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { Result = new TEvDataShard::TEvReadColumnsResponse(Self->TabletID()); bool useScan = Self->ReadColumnsScanEnabled; @@ -494,7 +494,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { if (Result) { ctx.Send(Ev->Sender, Result.Release()); } diff --git a/ydb/core/tx/datashard/datashard__s3.cpp b/ydb/core/tx/datashard/datashard__s3.cpp index 521390c96a..2f7a74bbab 100644 --- a/ydb/core/tx/datashard/datashard__s3.cpp +++ b/ydb/core/tx/datashard/datashard__s3.cpp @@ -27,7 +27,7 @@ public: TTxType GetTxType() const override { return TXTYPE_S3_LISTING; } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { ++RestartCount; if (!Result) { @@ -232,7 +232,7 @@ public: return iter->Last() != NTable::EReady::Page; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { LOG_DEBUG_S(ctx, NKikimrServices::TX_DATASHARD, Self->TabletID() << " S3 Listing: finished " << " status: " << Result->Record.GetStatus() << " description: \"" << Result->Record.GetErrorDescription() << "\"" diff --git a/ydb/core/tx/datashard/datashard__schema_changed.cpp b/ydb/core/tx/datashard/datashard__schema_changed.cpp index 703ebd2a66..3d6b2a31cb 100644 --- a/ydb/core/tx/datashard/datashard__schema_changed.cpp +++ b/ydb/core/tx/datashard/datashard__schema_changed.cpp @@ -15,7 +15,7 @@ public: TTxType GetTxType() const override { return TXTYPE_SCHEMA_CHANGED; } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { TxId = Ev->Get()->Record.GetTxId(); LOG_DEBUG_S(ctx, NKikimrServices::TX_DATASHARD, Self->TabletID() << " Got TEvSchemaChangedResult from SS at " @@ -26,7 +26,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { NTabletPipe::CloseAndForgetClient(Self->SelfId(), Self->SchemeShardPipe); Self->CheckStateChange(ctx); } diff --git a/ydb/core/tx/datashard/datashard__stats.cpp b/ydb/core/tx/datashard/datashard__stats.cpp index db6d40f0c9..129a14dca5 100644 --- a/ydb/core/tx/datashard/datashard__stats.cpp +++ b/ydb/core/tx/datashard/datashard__stats.cpp @@ -75,7 +75,7 @@ public: TTxType GetTxType() const override { return TXTYPE_GET_TABLE_STATS; } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { Y_UNUSED(ctx); ui64 tableId = Ev->Get()->Record.GetTableId(); @@ -139,7 +139,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { ctx.Send(Ev->Sender, Result.Release()); } @@ -235,7 +235,7 @@ public: TTxType GetTxType() const override { return TXTYPE_INITIATE_STATS_UPDATE; } - bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { + bool Execute(TTransactionContext& txc, const TActorContext& ctx) override { if (Self->State != TShardState::Ready) return true; @@ -337,7 +337,7 @@ public: return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { Y_UNUSED(ctx); } }; diff --git a/ydb/core/tx/datashard/read_table_scan.cpp b/ydb/core/tx/datashard/read_table_scan.cpp index 2b40a534e2..63e94fde96 100644 --- a/ydb/core/tx/datashard/read_table_scan.cpp +++ b/ydb/core/tx/datashard/read_table_scan.cpp @@ -322,7 +322,7 @@ public: } private: - void Die(const TActorContext &ctx) override + void Die(const TActorContext &ctx) override { ctx.Send(TActivationContext::InterconnectProxy(Sink.NodeId()), new TEvents::TEvUnsubscribe()); diff --git a/ydb/core/tx/schemeshard/schemeshard__clean_pathes.cpp b/ydb/core/tx/schemeshard/schemeshard__clean_pathes.cpp index 78d6b3c709..258699bba9 100644 --- a/ydb/core/tx/schemeshard/schemeshard__clean_pathes.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__clean_pathes.cpp @@ -148,7 +148,7 @@ struct TSchemeShard::TTxCleanDroppedPaths : public TTransactionBase<TSchemeShard return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { Y_VERIFY(Self->CleanDroppedPathsInFly); if (RemovedCount || SkippedCount) { @@ -233,7 +233,7 @@ struct TSchemeShard::TTxCleanDroppedSubDomains : public TTransactionBase<TScheme return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& ctx) override { Y_VERIFY(Self->CleanDroppedSubDomainsInFly); if (RemovedCount || SkippedCount) { diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_alter_cdc_stream.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_alter_cdc_stream.cpp index 2c7fa1f89f..d7027b570e 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_alter_cdc_stream.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_alter_cdc_stream.cpp @@ -12,7 +12,7 @@ namespace NSchemeShard { namespace { class TPropose: public TSubOperationState { - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "AlterCdcStream TPropose" << " opId# " << OperationId << " "; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_alter_fs.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_alter_fs.cpp index 97e38700b0..ee2a3fb3e5 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_alter_fs.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_alter_fs.cpp @@ -16,7 +16,7 @@ class TConfigureParts: public TSubOperationState { private: const TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterFileStore::TConfigureParts" << " operationId#" << OperationId; @@ -122,7 +122,7 @@ class TPropose: public TSubOperationState { private: const TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterFileStore::TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_alter_index.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_alter_index.cpp index 2e63633246..10688f0991 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_alter_index.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_alter_index.cpp @@ -11,7 +11,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterTableIndex TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_alter_kesus.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_alter_kesus.cpp index 414f7430a9..38e5f74777 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_alter_kesus.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_alter_kesus.cpp @@ -52,7 +52,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterKesus TConfigureParts" << " operationId#" << OperationId; @@ -150,7 +150,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterKesus TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_alter_olap_store.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_alter_olap_store.cpp index d8a460b6e3..7141c76ae7 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_alter_olap_store.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_alter_olap_store.cpp @@ -201,7 +201,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterOlapStore TConfigureParts" << " operationId#" << OperationId; @@ -335,7 +335,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterOlapStore TPropose" << " operationId#" << OperationId; @@ -430,7 +430,7 @@ private: TDeque<TPathId> TablesToUpdate; bool TablesInitialized = false; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterOlapStore TProposedWaitParts" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_alter_olap_table.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_alter_olap_table.cpp index 4a4a4bf1f5..2e89cad986 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_alter_olap_table.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_alter_olap_table.cpp @@ -121,7 +121,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterOlapTable TConfigureParts" << " operationId#" << OperationId; @@ -242,7 +242,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterOlapTable TPropose" << " operationId#" << OperationId; @@ -328,7 +328,7 @@ class TProposedWaitParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterOlapTable TProposedWaitParts" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_alter_solomon.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_alter_solomon.cpp index d0d21b7239..1c17ee6095 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_alter_solomon.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_alter_solomon.cpp @@ -14,7 +14,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterSolomon TConfigureParts" << ", operationId: " << OperationId; @@ -68,7 +68,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterSolomon TPropose" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_alter_table.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_alter_table.cpp index c1c3d43293..b6c0b6c8b2 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_alter_table.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_alter_table.cpp @@ -226,7 +226,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterTable TConfigureParts" << " operationId#" << OperationId; @@ -292,7 +292,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TAlterTable TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_backup_restore_common.h b/ydb/core/tx/schemeshard/schemeshard__operation_backup_restore_common.h index 2b5726c661..640f5f1356 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_backup_restore_common.h +++ b/ydb/core/tx/schemeshard/schemeshard__operation_backup_restore_common.h @@ -17,7 +17,7 @@ class TConfigurePart: public TSubOperationState { const TTxState::ETxType TxType; const TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << TKind::Name() << " TConfigurePart" << ", opId: " << OperationId; @@ -70,7 +70,7 @@ protected: const TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << TKind::Name() << " TProposedWaitParts" << ", opId: " << OperationId; @@ -288,7 +288,7 @@ class TAborting: public TProposedWaitParts<TKind> { using TProposedWaitParts<TKind>::OperationId; using TProposedWaitParts<TKind>::TxType; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << TKind::Name() << " TAborting" << ", opId: " << OperationId; @@ -366,7 +366,7 @@ class TPropose: public TSubOperationState { const TTxState::ETxType TxType; const TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << TKind::Name() << " TPropose" << ", opId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_common.h b/ydb/core/tx/schemeshard/schemeshard__operation_common.h index 8f4861e4ad..5a3da32cad 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_common.h +++ b/ydb/core/tx/schemeshard/schemeshard__operation_common.h @@ -33,7 +33,7 @@ class TProposedWaitParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NTableState::TProposedWaitParts" << " operationId# " << OperationId; @@ -129,7 +129,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NSubDomainState::TConfigureParts" << " operationId#" << OperationId; @@ -365,7 +365,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NSubDomainState::TPropose" << " operationId#" << OperationId; @@ -463,7 +463,7 @@ class TCreateParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateParts" << " operationId: " << OperationId; @@ -827,7 +827,7 @@ class TDone: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDone operationId#" << OperationId; } @@ -900,7 +900,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NPQState::TConfigureParts" << " operationId#" << OperationId; @@ -1107,7 +1107,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NPQState::TPropose" << " operationId#" << OperationId; @@ -1189,7 +1189,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NBSVState::TConfigureParts" << " operationId: " << OperationId; @@ -1316,7 +1316,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NBSVState::TPropose" << " operationId#" << OperationId; @@ -1401,7 +1401,7 @@ public: namespace NCdcStreamState { class TConfigurePartsAtTable: public TSubOperationState { - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NCdcStreamState::TConfigurePartsAtTable" << " operationId: " << OperationId; @@ -1487,7 +1487,7 @@ private: }; // TConfigurePartsAtTable class TProposeAtTable: public TSubOperationState { - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NCdcStreamState::TProposeAtTable" << " operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_cdc_stream.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_cdc_stream.cpp index dc89ed549c..01e4cd9df8 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_cdc_stream.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_cdc_stream.cpp @@ -15,7 +15,7 @@ namespace NSchemeShard { namespace { class TPropose: public TSubOperationState { - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "NewCdcStream TPropose" << " opId# " << OperationId << " "; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_fs.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_fs.cpp index e6378d21b1..6d908a55e8 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_fs.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_fs.cpp @@ -16,7 +16,7 @@ class TConfigureParts: public TSubOperationState { private: const TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateFileStore::TConfigureParts" << " operationId#" << OperationId; @@ -127,7 +127,7 @@ class TPropose: public TSubOperationState { private: const TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateFileStore::TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_index.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_index.cpp index 66e9266956..4713823eef 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_index.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_index.cpp @@ -11,7 +11,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateTableIndex TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_kesus.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_kesus.cpp index 2ea2c84ae0..c974b72c31 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_kesus.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_kesus.cpp @@ -75,7 +75,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateKesus TConfigureParts" << " operationId#" << OperationId; @@ -174,7 +174,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateKesus TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_olap_store.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_olap_store.cpp index 5db4fef54a..a3e6896b6f 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_olap_store.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_olap_store.cpp @@ -284,7 +284,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateOlapStore TConfigureParts" << " operationId#" << OperationId; @@ -363,7 +363,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateOlapStore TPropose" << " operationId#" << OperationId; @@ -451,7 +451,7 @@ class TProposedWaitParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateOlapStore TProposedWaitParts" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_olap_table.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_olap_table.cpp index adb768802a..09f556c655 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_olap_table.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_olap_table.cpp @@ -313,7 +313,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateOlapTable TConfigureParts" << " operationId#" << OperationId; @@ -433,7 +433,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateOlapTable TPropose" << " operationId#" << OperationId; @@ -521,7 +521,7 @@ class TProposedWaitParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateOlapTable TProposedWaitParts" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_rtmr.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_rtmr.cpp index 33c45c687e..648fcd3c4d 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_rtmr.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_rtmr.cpp @@ -59,7 +59,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateRTMR TConfigureParts" << " operationId#" << OperationId; @@ -106,7 +106,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateRTMR TPropose" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_sequence.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_sequence.cpp index 94551cd21a..3dbeecfb51 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_sequence.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_sequence.cpp @@ -14,7 +14,7 @@ class TConfigureParts : public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateSequence TConfigureParts" << " operationId#" << OperationId; @@ -164,7 +164,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateSequence TPropose" << " operationId#" << OperationId; @@ -391,7 +391,7 @@ public: if (!parentPath->IsTable()) { checks.DepthLimit(); } - + checks .PathsLimit() .DirChildrenLimit() diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_solomon.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_solomon.cpp index 5a5e575f87..a821169854 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_solomon.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_solomon.cpp @@ -90,7 +90,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateSolomon TConfigureParts" << ", operationId: " << OperationId; @@ -139,7 +139,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateSolomon TPropose" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_table.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_table.cpp index 52b8ece0c3..5004522529 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_table.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_table.cpp @@ -130,7 +130,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateTable TConfigureParts" << " operationId#" << OperationId; @@ -220,7 +220,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TCreateTable TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_bsv.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_bsv.cpp index 79f240db92..e6f0322026 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_bsv.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_bsv.cpp @@ -13,7 +13,7 @@ class TDeleteParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropBlockStoreVolume TDeleteParts" << ", operationId: " << OperationId; @@ -52,7 +52,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropBlockStoreVolume TPropose" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_cdc_stream.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_cdc_stream.cpp index 238b82a87f..9d02b90e0d 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_cdc_stream.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_cdc_stream.cpp @@ -12,7 +12,7 @@ namespace NSchemeShard { namespace { class TPropose: public TSubOperationState { - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "DropCdcStream TPropose" << " opId# " << OperationId << " "; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_extsubdomain.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_extsubdomain.cpp index 6e137c21ae..c33f76ca93 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_extsubdomain.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_extsubdomain.cpp @@ -13,7 +13,7 @@ class TDeletePrivateShards: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropExtSubdomain TDeletePrivateShards" << ", operationId: " << OperationId; @@ -50,7 +50,7 @@ class TDeleteExternalShards: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropExtSubdomain TDeleteExternalShards" << ", operationId: " << OperationId; @@ -138,7 +138,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropExtSubdomain TPropose" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_fs.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_fs.cpp index 000b41c97e..4ba51deb84 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_fs.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_fs.cpp @@ -16,7 +16,7 @@ class TDeleteParts: public TSubOperationState { private: const TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropFileStore::TDeleteParts" << ", operationId: " << OperationId; @@ -56,7 +56,7 @@ class TPropose: public TSubOperationState { private: const TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropFileStore::TPropose" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_index.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_index.cpp index c6ddf95771..a84868b77b 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_index.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_index.cpp @@ -17,7 +17,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropIndexAtMainTable TConfigureParts" << " operationId#" << OperationId; @@ -132,7 +132,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropIndexAtMainTable TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_indexed_table.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_indexed_table.cpp index 5ae39fb9b4..7064fabe1e 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_indexed_table.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_indexed_table.cpp @@ -56,7 +56,7 @@ private: TOperationId OperationId; TTxState::ETxState& NextState; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropTableIndex TPropose" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_kesus.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_kesus.cpp index 7d72448a64..ad42e96de5 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_kesus.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_kesus.cpp @@ -13,7 +13,7 @@ class TDeleteParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropKesus TDeleteParts" << ", operationId: " << OperationId; @@ -52,7 +52,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropKesus TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_olap_store.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_olap_store.cpp index eb0662c65e..ef1dafb905 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_olap_store.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_olap_store.cpp @@ -14,7 +14,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropOlapStore TDropParts" << " operationId#" << OperationId; @@ -53,7 +53,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropOlapStore TPropose" << " operationId#" << OperationId; @@ -135,7 +135,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropOlapStore TProposedWaitParts" << " operationId#" << OperationId; @@ -216,7 +216,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropOlapStore TProposedDeleteParts" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_olap_table.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_olap_table.cpp index bea2ba4278..02ca98d236 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_olap_table.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_olap_table.cpp @@ -14,7 +14,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropOlapTable TDropParts" << " operationId#" << OperationId; @@ -92,7 +92,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropOlapTable TPropose" << " operationId#" << OperationId; @@ -179,7 +179,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropOlapTable TProposedWaitParts" << " operationId#" << OperationId; @@ -260,7 +260,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropOlapTable TProposedDeleteParts" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_pq.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_pq.cpp index ddc4c6af76..c338b4c358 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_pq.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_pq.cpp @@ -13,7 +13,7 @@ class TDropParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropPQ TDropParts" << " operationId#" << OperationId; @@ -123,7 +123,7 @@ class TDeleteParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropPQ TProposedDeletePart" << ", operationId: " << OperationId; @@ -163,7 +163,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropPQ TPropose" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_sequence.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_sequence.cpp index 1959681a58..f9c8734073 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_sequence.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_sequence.cpp @@ -14,7 +14,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropSequence TDropParts" << " operationId#" << OperationId; @@ -130,7 +130,7 @@ private: TOperationId OperationId; private: - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropSequence TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_solomon.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_solomon.cpp index 07be8f7343..bdd9f953d4 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_solomon.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_solomon.cpp @@ -13,7 +13,7 @@ class TDeleteParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropSolomon TDeleteParts" << ", operationId: " << OperationId; @@ -50,7 +50,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropSolomon TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_subdomain.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_subdomain.cpp index d4fbe8e589..832fd1df70 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_subdomain.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_subdomain.cpp @@ -13,7 +13,7 @@ class TDeleteParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropSubdomain TDeleteParts" << " operationId#" << OperationId; @@ -50,7 +50,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropSubdomain TPropose" << " operationId#" << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_table.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_table.cpp index e70e0fa520..45730be409 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_table.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_table.cpp @@ -54,7 +54,7 @@ class TDropParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropTable TDropParts" << " operationId#" << OperationId; @@ -151,7 +151,7 @@ private: TOperationId OperationId; TTxState::ETxState& NextState; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropTable TPropose" << " operationId#" << OperationId; @@ -391,7 +391,7 @@ class TProposedDeletePart: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropTable TProposedDeletePart" << " operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_drop_unsafe.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_drop_unsafe.cpp index 096206b487..a1a9f2ccfd 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_drop_unsafe.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_drop_unsafe.cpp @@ -13,7 +13,7 @@ class TProposedDeletePart: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropForceUnsafe TProposedDeletePart" << ", operationId: " << OperationId; @@ -50,7 +50,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDropForceUnsafe TPropose" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_finalize_build_index.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_finalize_build_index.cpp index aa10388c24..fe4d116416 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_finalize_build_index.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_finalize_build_index.cpp @@ -15,7 +15,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TFinalizeBuildIndex TConfigureParts" << " operationId#" << OperationId; @@ -112,7 +112,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TFinalizeBuildIndex TPropose" << " operationId#" << OperationId; @@ -207,7 +207,7 @@ class TCreateTxShards: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TFinalizeBuildIndex TCreateTxShards" << " operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_initiate_build_index.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_initiate_build_index.cpp index 1e54d74e2c..f8d5ca96c6 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_initiate_build_index.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_initiate_build_index.cpp @@ -15,7 +15,7 @@ class TConfigureParts: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TInitializeBuildIndex TConfigureParts" << " operationId#" << OperationId; @@ -135,7 +135,7 @@ class TPropose: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TInitializeBuildIndex TPropose" << " operationId#" << OperationId; @@ -221,7 +221,7 @@ class TCreateTxShards: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TInitializeBuildIndex TCreateTxShards" << " operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_split_merge.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_split_merge.cpp index 4d14b05c22..645d7f37e1 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_split_merge.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_split_merge.cpp @@ -13,7 +13,7 @@ class TConfigureDestination: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TSplitMerge TConfigureDestination" << " operationId#" << OperationId; @@ -183,7 +183,7 @@ class TTranserData: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TSplitMerge TTranserData" << " operationId#" << OperationId; @@ -343,7 +343,7 @@ class TNotifySrc: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TSplitMerge TNotifySrc" << ", operationId: " << OperationId; diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_upgrade_subdomain.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_upgrade_subdomain.cpp index 27acf8cd1d..ad9c6808fc 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_upgrade_subdomain.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_upgrade_subdomain.cpp @@ -14,7 +14,7 @@ class TWait: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TWaiting" << " operationId: " << OperationId; @@ -85,7 +85,7 @@ private: TTabletId TenantSchemeShardId = InvalidTabletId; THashSet<TPathId> PathesInside; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TConfigure" << " operationId: " << OperationId; @@ -442,7 +442,7 @@ private: TOperationId OperationId; TTabletId TenantSchemeShardId = InvalidTabletId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TPublishTenantReadOnly" << " operationId: " << OperationId; @@ -514,7 +514,7 @@ private: TPathElement::TChildrenCont HidenChildren; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TPublishGlobal" << " operationId: " << OperationId; @@ -681,7 +681,7 @@ class TDeleteTenantSS: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDeleteTenantSS" << " operationId: " << OperationId; @@ -734,7 +734,7 @@ private: TTabletId TenantSchemeShardId = InvalidTabletId; TSet<TTabletId> DatashardsInside; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TRewriteOwner" << " operationId: " << OperationId; @@ -886,7 +886,7 @@ class TPublishTenant: public TSubOperationState { private: TOperationId OperationId; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TPublishTenant" << " operationId: " << OperationId; @@ -948,7 +948,7 @@ private: bool IsInited = false; - TString DebugHint() const override { + TString DebugHint() const override { return TStringBuilder() << "TDoneMigrateTree" << " operationId: " << OperationId; diff --git a/ydb/core/tx/tx_proxy/upload_rows.cpp b/ydb/core/tx/tx_proxy/upload_rows.cpp index 75bbe85682..3c4580a8a8 100644 --- a/ydb/core/tx/tx_proxy/upload_rows.cpp +++ b/ydb/core/tx/tx_proxy/upload_rows.cpp @@ -54,7 +54,7 @@ private: ctx.Send(Sender, ev); } - void RaiseIssue(const NYql::TIssue& issue) override { + void RaiseIssue(const NYql::TIssue& issue) override { Issues.AddIssue(issue); } diff --git a/ydb/core/util/testactorsys.cpp b/ydb/core/util/testactorsys.cpp index df89f22613..73d27bc9d9 100644 --- a/ydb/core/util/testactorsys.cpp +++ b/ydb/core/util/testactorsys.cpp @@ -83,7 +83,7 @@ public: return true; } - TAffinity* Affinity() const override { + TAffinity* Affinity() const override { Y_FAIL(); } }; diff --git a/ydb/core/viewer/browse_pq.h b/ydb/core/viewer/browse_pq.h index 2d329001be..3e3b32a21e 100644 --- a/ydb/core/viewer/browse_pq.h +++ b/ydb/core/viewer/browse_pq.h @@ -278,7 +278,7 @@ public: Become(&TThis::StateWork); } - void ReplyAndDie(const TActorContext &ctx) override = 0; + void ReplyAndDie(const TActorContext &ctx) override = 0; }; class TBrowseConsumers : public TBrowseCommon { diff --git a/ydb/library/yql/ast/yql_type_string.cpp b/ydb/library/yql/ast/yql_type_string.cpp index 723db63da0..af9af93259 100644 --- a/ydb/library/yql/ast/yql_type_string.cpp +++ b/ydb/library/yql/ast/yql_type_string.cpp @@ -1106,12 +1106,12 @@ public: } private: - void Visit(const TUnitExprType& type) final { + void Visit(const TUnitExprType& type) final { Y_UNUSED(type); Out_ << TStringBuf("Unit"); } - void Visit(const TMultiExprType& type) final { + void Visit(const TMultiExprType& type) final { Out_ << TStringBuf("Multi<"); const auto& items = type.GetItems(); for (ui32 i = 0; i < items.size(); ++i) { @@ -1123,7 +1123,7 @@ private: Out_ << '>'; } - void Visit(const TTupleExprType& type) final { + void Visit(const TTupleExprType& type) final { Out_ << TStringBuf("Tuple<"); const auto& items = type.GetItems(); for (ui32 i = 0; i < items.size(); ++i) { @@ -1135,7 +1135,7 @@ private: Out_ << '>'; } - void Visit(const TStructExprType& type) final { + void Visit(const TStructExprType& type) final { Out_ << TStringBuf("Struct<"); const auto& items = type.GetItems(); for (ui32 i = 0; i < items.size(); ++i) { @@ -1147,43 +1147,43 @@ private: Out_ << '>'; } - void Visit(const TItemExprType& type) final { + void Visit(const TItemExprType& type) final { EscapeArbitraryAtom(type.GetName(), '\'', &Out_); Out_ << ':'; type.GetItemType()->Accept(*this); } - void Visit(const TListExprType& type) final { + void Visit(const TListExprType& type) final { Out_ << TStringBuf("List<"); type.GetItemType()->Accept(*this); Out_ << '>'; } - void Visit(const TStreamExprType& type) final { + void Visit(const TStreamExprType& type) final { Out_ << TStringBuf("Stream<"); type.GetItemType()->Accept(*this); Out_ << '>'; } - void Visit(const TFlowExprType& type) final { + void Visit(const TFlowExprType& type) final { Out_ << TStringBuf("Flow<"); type.GetItemType()->Accept(*this); Out_ << '>'; } - void Visit(const TDataExprType& type) final { + void Visit(const TDataExprType& type) final { Out_ << type.GetName(); if (const auto dataExprParamsType = dynamic_cast<const TDataExprParamsType*>(&type)) { Out_ << '(' << dataExprParamsType->GetParamOne() << ',' << dataExprParamsType->GetParamTwo() << ')'; } } - void Visit(const TWorldExprType& type) final { + void Visit(const TWorldExprType& type) final { Y_UNUSED(type); Out_ << TStringBuf("World"); } - void Visit(const TOptionalExprType& type) final { + void Visit(const TOptionalExprType& type) final { const TTypeAnnotationNode* itemType = type.GetItemType(); if (itemType->GetKind() == ETypeAnnotationKind::Callable) { Out_ << TStringBuf("Optional<"); @@ -1195,7 +1195,7 @@ private: } } - void Visit(const TCallableExprType& type) final { + void Visit(const TCallableExprType& type) final { const auto& args = type.GetArguments(); ui32 argsCount = type.GetArgumentsSize(); ui32 optArgsCount = @@ -1236,19 +1236,19 @@ private: Out_ << '>'; } - void Visit(const TResourceExprType& type) final { + void Visit(const TResourceExprType& type) final { Out_ << TStringBuf("Resource<"); EscapeArbitraryAtom(type.GetTag(), '\'', &Out_); Out_ << '>'; } - void Visit(const TTypeExprType& type) final { + void Visit(const TTypeExprType& type) final { Out_ << TStringBuf("Type<"); type.GetType()->Accept(*this); Out_ << '>'; } - void Visit(const TDictExprType& type) final { + void Visit(const TDictExprType& type) final { if (type.GetPayloadType()->GetKind() == ETypeAnnotationKind::Void) { Out_ << TStringBuf("Set<"); type.GetKeyType()->Accept(*this); @@ -1262,32 +1262,32 @@ private: } } - void Visit(const TVoidExprType& type) final { + void Visit(const TVoidExprType& type) final { Y_UNUSED(type); Out_ << TStringBuf("Void"); } - void Visit(const TNullExprType& type) final { + void Visit(const TNullExprType& type) final { Y_UNUSED(type); Out_ << TStringBuf("Null"); } - void Visit(const TEmptyListExprType& type) final { + void Visit(const TEmptyListExprType& type) final { Y_UNUSED(type); Out_ << TStringBuf("EmptyList"); } - void Visit(const TEmptyDictExprType& type) final { + void Visit(const TEmptyDictExprType& type) final { Y_UNUSED(type); Out_ << TStringBuf("EmptyDict"); } - void Visit(const TGenericExprType& type) final { + void Visit(const TGenericExprType& type) final { Y_UNUSED(type); Out_ << TStringBuf("Generic"); } - void Visit(const TTaggedExprType& type) final { + void Visit(const TTaggedExprType& type) final { Out_ << TStringBuf("Tagged<"); type.GetBaseType()->Accept(*this); Out_ << ','; @@ -1295,7 +1295,7 @@ private: Out_ << '>'; } - void Visit(const TErrorExprType& type) final { + void Visit(const TErrorExprType& type) final { Out_ << TStringBuf("Error<"); auto pos = type.GetError().Position; EscapeArbitraryAtom(pos.File.empty() ? "<main>" : pos.File, '\'', &Out_); @@ -1308,7 +1308,7 @@ private: Out_ << '>'; } - void Visit(const TVariantExprType& type) final { + void Visit(const TVariantExprType& type) final { auto underlyingType = type.GetUnderlyingType(); if (underlyingType->GetKind() == ETypeAnnotationKind::Tuple) { Out_ << TStringBuf("Variant<"); diff --git a/ydb/library/yql/core/file_storage/file_storage.cpp b/ydb/library/yql/core/file_storage/file_storage.cpp index 4d659c28cc..631adbc688 100644 --- a/ydb/library/yql/core/file_storage/file_storage.cpp +++ b/ydb/library/yql/core/file_storage/file_storage.cpp @@ -65,7 +65,7 @@ public: Downloaders.push_back(std::move(downloader)); } - TFileLinkPtr PutFile(const TString& file, const TString& outFileName = {}) override { + TFileLinkPtr PutFile(const TString& file, const TString& outFileName = {}) override { YQL_LOG(INFO) << "PutFile to cache: " << file; const auto md5 = MD5::File(file); const TString storageFileName = md5 + ".file"; @@ -86,7 +86,7 @@ public: }); } - TFileLinkPtr PutFileStripped(const TString& file, const TString& originalMd5 = {}) override { + TFileLinkPtr PutFileStripped(const TString& file, const TString& originalMd5 = {}) override { YQL_LOG(INFO) << "PutFileStripped to cache: " << file; if (originalMd5.empty()) { YQL_LOG(WARN) << "Empty md5 for: " << file; @@ -127,7 +127,7 @@ public: return result; } - TFileLinkPtr PutInline(const TString& data) override { + TFileLinkPtr PutInline(const TString& data) override { const auto md5 = MD5::Calc(data); const TString storageFileName = md5 + ".file"; YQL_LOG(INFO) << "PutInline to cache. md5=" << md5; @@ -149,7 +149,7 @@ public: }); } - TFileLinkPtr PutUrl(const TString& urlStr, const TString& oauthToken) override { + TFileLinkPtr PutUrl(const TString& urlStr, const TString& oauthToken) override { try { TString convertedUrl; if (!Mapper.MapUrl(urlStr, convertedUrl)) { @@ -192,11 +192,11 @@ public: }, *MtpQueue); } - TFsPath GetRoot() const override { + TFsPath GetRoot() const override { return Storage.GetRoot(); } - TFsPath GetTemp() const override { + TFsPath GetTemp() const override { return Storage.GetTemp(); } diff --git a/ydb/library/yql/core/file_storage/sized_cache_ut.cpp b/ydb/library/yql/core/file_storage/sized_cache_ut.cpp index e891051ed5..b0e41e5c62 100644 --- a/ydb/library/yql/core/file_storage/sized_cache_ut.cpp +++ b/ydb/library/yql/core/file_storage/sized_cache_ut.cpp @@ -12,13 +12,13 @@ struct TTestCacheObj: public TSizedCache::ICacheObj { { } - TString GetName() override { + TString GetName() override { return Name; } - ui64 GetSize() override { + ui64 GetSize() override { return Size; } - void Dismiss() override { + void Dismiss() override { Dismissed = true; } diff --git a/ydb/library/yql/core/yql_graph_transformer.cpp b/ydb/library/yql/core/yql_graph_transformer.cpp index 55eba5e201..26193c4c40 100644 --- a/ydb/library/yql/core/yql_graph_transformer.cpp +++ b/ydb/library/yql/core/yql_graph_transformer.cpp @@ -83,7 +83,7 @@ public: return HandleStatus(status); } - TStatistics GetStatistics() const final { + TStatistics GetStatistics() const final { if (Statistics.Stages.empty()) { Statistics.Stages.resize(Stages.size()); } diff --git a/ydb/library/yql/core/yql_opt_window.cpp b/ydb/library/yql/core/yql_opt_window.cpp index a34ca3e421..5fc03d35d9 100644 --- a/ydb/library/yql/core/yql_opt_window.cpp +++ b/ydb/library/yql/core/yql_opt_window.cpp @@ -475,7 +475,7 @@ public: } // Lambda(row) -> AsTuple(output, state) - TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { return ctx.Builder(GetPos()) .Lambda() .Param("row") @@ -491,7 +491,7 @@ public: } // Lambda(row, state) -> AsTuple(output, state) - TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { return ctx.Builder(GetPos()) .Lambda() .Param("row") @@ -539,7 +539,7 @@ public: } // Lambda(row) -> AsTuple(output, state) - TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { Y_UNUSED(dataQueue); return ctx.Builder(GetPos()) .Lambda() @@ -553,7 +553,7 @@ public: } // Lambda(row, state) -> AsTuple(output, state) - TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { Y_UNUSED(dataQueue); return ctx.Builder(GetPos()) .Lambda() @@ -595,7 +595,7 @@ public: } // Lambda(row) -> AsTuple(output, state) - TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const final { + TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const final { Y_UNUSED(dataQueue); @@ -622,7 +622,7 @@ public: } // Lambda(row, state) -> AsTuple(output, state) - TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const final { + TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const final { Y_UNUSED(dataQueue); bool useAggrEquals = Ansi; @@ -722,7 +722,7 @@ public: { } - TExprNode::TPtr BuildRawInitLambda(TExprContext& ctx) const final { + TExprNode::TPtr BuildRawInitLambda(TExprContext& ctx) const final { auto one = BuildUint64(GetPos(), 1, ctx); return ctx.Builder(GetPos()) .Lambda() @@ -736,7 +736,7 @@ public: .Build(); } - TExprNode::TPtr BuildRawUpdateLambda(bool useAggrEquals, TExprContext& ctx) const final { + TExprNode::TPtr BuildRawUpdateLambda(bool useAggrEquals, TExprContext& ctx) const final { return ctx.Builder(GetPos()) .Lambda() .Param("key") @@ -773,7 +773,7 @@ public: .Build(); } - const TTypeAnnotationNode* GetStateType(const TTypeAnnotationNode* keyType, TExprContext& ctx) const final { + const TTypeAnnotationNode* GetStateType(const TTypeAnnotationNode* keyType, TExprContext& ctx) const final { return ctx.MakeType<TTupleExprType>(TTypeAnnotationNode::TListType{ ctx.MakeType<TDataExprType>(EDataSlot::Uint64), ctx.MakeType<TDataExprType>(EDataSlot::Uint64), @@ -789,7 +789,7 @@ public: { } - TExprNode::TPtr BuildRawInitLambda(TExprContext& ctx) const final { + TExprNode::TPtr BuildRawInitLambda(TExprContext& ctx) const final { return ctx.Builder(GetPos()) .Lambda() .Param("key") @@ -801,7 +801,7 @@ public: .Build(); } - TExprNode::TPtr BuildRawUpdateLambda(bool useAggrEquals, TExprContext& ctx) const final { + TExprNode::TPtr BuildRawUpdateLambda(bool useAggrEquals, TExprContext& ctx) const final { return ctx.Builder(GetPos()) .Lambda() .Param("key") @@ -832,7 +832,7 @@ public: .Build(); } - const TTypeAnnotationNode* GetStateType(const TTypeAnnotationNode* keyType, TExprContext& ctx) const final { + const TTypeAnnotationNode* GetStateType(const TTypeAnnotationNode* keyType, TExprContext& ctx) const final { return ctx.MakeType<TTupleExprType>(TTypeAnnotationNode::TListType{ ctx.MakeType<TDataExprType>(EDataSlot::Uint64), keyType @@ -886,19 +886,19 @@ public: } // Lambda(row) -> AsTuple(output, state) - TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { Y_UNUSED(dataQueue); return BuildInitLambdaForChain1Map(GetPos(), GetInitLambda(), GetCalculateLambda(), ctx); } // Lambda(row, state) -> AsTuple(output, state) - TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { Y_UNUSED(dataQueue); return BuildUpdateLambdaForChain1Map(GetPos(), GetUpdateLambda(), GetCalculateLambda(), ctx); } - TExprNode::TPtr ExtractLaggingOutput(const TExprNode::TPtr& lagQueue, - const TExprNode::TPtr& dependsOn, TExprContext& ctx) const override + TExprNode::TPtr ExtractLaggingOutput(const TExprNode::TPtr& lagQueue, + const TExprNode::TPtr& dependsOn, TExprContext& ctx) const override { if (!LaggingQueueIndex.Defined()) { return {}; @@ -934,7 +934,7 @@ public: } // Lambda(row) -> AsTuple(output, state) - TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { YQL_ENSURE(dataQueue); auto originalInit = GetInitLambda(); auto originalUpdate = GetUpdateLambda(); @@ -966,7 +966,7 @@ public: } // Lambda(row, state) -> AsTuple(output, state) - TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { YQL_ENSURE(dataQueue); auto originalInit = GetInitLambda(); auto originalUpdate = GetUpdateLambda(); @@ -1017,7 +1017,7 @@ public: // Lambda(row) -> AsTuple(output, state) // state == output - TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { auto originalInit = GetInitLambda(); auto originalUpdate = GetUpdateLambda(); auto calculate = GetCalculateLambda(); @@ -1048,7 +1048,7 @@ public: } // Lambda(row, state) -> AsTuple(output, state) - TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { Y_UNUSED(dataQueue); return ctx.Builder(GetPos()) .Lambda() @@ -1079,7 +1079,7 @@ public: } // Lambda(row) -> AsTuple(output, state) - TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { auto rowArg = ctx.NewArgument(GetPos(), "row"); auto body = ctx.Builder(GetPos()) .List() @@ -1092,7 +1092,7 @@ public: } // Lambda(row, state) -> AsTuple(output, state) - TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { auto rowArg = ctx.NewArgument(GetPos(), "row"); auto stateArg = ctx.NewArgument(GetPos(), "state"); auto body = ctx.Builder(GetPos()) @@ -1162,7 +1162,7 @@ public: } // Lambda(row) -> AsTuple(output, state) - TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildInitLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { Y_UNUSED(dataQueue); return ctx.Builder(GetPos()) .Lambda() @@ -1177,7 +1177,7 @@ public: } // Lambda(row, state) -> AsTuple(output, state) - TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { + TExprNode::TPtr BuildUpdateLambda(const TExprNode::TPtr& dataQueue, TExprContext& ctx) const override { Y_UNUSED(dataQueue); return ctx.Builder(GetPos()) .Lambda() diff --git a/ydb/library/yql/dq/runtime/dq_source.cpp b/ydb/library/yql/dq/runtime/dq_source.cpp index e8fd3633a7..b9e75a15e8 100644 --- a/ydb/library/yql/dq/runtime/dq_source.cpp +++ b/ydb/library/yql/dq/runtime/dq_source.cpp @@ -17,7 +17,7 @@ public: return InputIndex; } - void Push(NKikimr::NMiniKQL::TUnboxedValueVector&& batch, i64 space) override { + void Push(NKikimr::NMiniKQL::TUnboxedValueVector&& batch, i64 space) override { Y_VERIFY(!batch.empty() || !space); if (!batch.empty()) { AddBatch(std::move(batch), space); diff --git a/ydb/library/yql/minikql/codegen/codegen.cpp b/ydb/library/yql/minikql/codegen/codegen.cpp index b056d97bac..6e4096af22 100644 --- a/ydb/library/yql/minikql/codegen/codegen.cpp +++ b/ydb/library/yql/minikql/codegen/codegen.cpp @@ -336,7 +336,7 @@ public: Engine_->RegisterJITEventListener(this); } - void TogglePerfJITEventListener() override { + void TogglePerfJITEventListener() override { #ifdef __linux__ PerfListener_ = llvm::JITEventListener::createPerfJITEventListener(); Engine_->RegisterJITEventListener(PerfListener_); @@ -377,7 +377,7 @@ public: } } - void GetStats(TCodegenStats& stats) override { + void GetStats(TCodegenStats& stats) override { TCodegenStats ret; for (auto& func : Module_->functions()) { if (func.isDeclaration()) { diff --git a/ydb/library/yql/minikql/comp_nodes/ut/mkql_multihopping_ut.cpp b/ydb/library/yql/minikql/comp_nodes/ut/mkql_multihopping_ut.cpp index 34b939dcf9..719ba1f6ea 100644 --- a/ydb/library/yql/minikql/comp_nodes/ut/mkql_multihopping_ut.cpp +++ b/ydb/library/yql/minikql/comp_nodes/ut/mkql_multihopping_ut.cpp @@ -118,7 +118,7 @@ namespace { ui32 Index; std::function<void()> FetchCallback; - NUdf::EFetchStatus Fetch(NUdf::TUnboxedValue& result) final { + NUdf::EFetchStatus Fetch(NUdf::TUnboxedValue& result) final { FetchCallback(); if (Index >= Items.size()) { return NUdf::EFetchStatus::Finish; diff --git a/ydb/library/yql/minikql/computation/mkql_computation_node_graph_saveload_ut.cpp b/ydb/library/yql/minikql/computation/mkql_computation_node_graph_saveload_ut.cpp index 0a01499060..cc734e11d6 100644 --- a/ydb/library/yql/minikql/computation/mkql_computation_node_graph_saveload_ut.cpp +++ b/ydb/library/yql/minikql/computation/mkql_computation_node_graph_saveload_ut.cpp @@ -90,7 +90,7 @@ namespace { Y_UNUSED(state); } - NUdf::EFetchStatus Fetch(NUdf::TUnboxedValue& result) final { + NUdf::EFetchStatus Fetch(NUdf::TUnboxedValue& result) final { if (Index >= Items.size()) { return NUdf::EFetchStatus::Finish; } diff --git a/ydb/library/yql/minikql/computation/mkql_computation_node_impl.h b/ydb/library/yql/minikql/computation/mkql_computation_node_impl.h index 557b807ce4..0a63ca9d34 100644 --- a/ydb/library/yql/minikql/computation/mkql_computation_node_impl.h +++ b/ydb/library/yql/minikql/computation/mkql_computation_node_impl.h @@ -1007,13 +1007,13 @@ private: return nullptr; } - NUdf::EFetchStatus FetchBlock(NUdf::TUnboxedValue& result, ui32 rowsLimitHint) override { + NUdf::EFetchStatus FetchBlock(NUdf::TUnboxedValue& result, ui32 rowsLimitHint) override { Y_UNUSED(result); Y_UNUSED(rowsLimitHint); ThrowNotSupported(__func__); } - bool VisitBlocks(NUdf::TBlockCallback callback, void* context) override { + bool VisitBlocks(NUdf::TBlockCallback callback, void* context) override { Y_UNUSED(callback); Y_UNUSED(context); ThrowNotSupported(__func__); diff --git a/ydb/library/yql/minikql/computation/mkql_validate_ut.cpp b/ydb/library/yql/minikql/computation/mkql_validate_ut.cpp index 3a647266bc..ed2f12303a 100644 --- a/ydb/library/yql/minikql/computation/mkql_validate_ut.cpp +++ b/ydb/library/yql/minikql/computation/mkql_validate_ut.cpp @@ -56,7 +56,7 @@ namespace NUdf { ui32 Index; ui32 HolePos; - bool Next(NUdf::TUnboxedValue& value) final { + bool Next(NUdf::TUnboxedValue& value) final { if (++Index >= ListRef.size()) return false; value = Index == HolePos ? NUdf::TUnboxedValue(NUdf::TUnboxedValuePod(42)) : ToUnboxedValue(ListRef[Index]); @@ -215,11 +215,11 @@ namespace NImpl { ui32 HolePos; ui32 Index; - bool Skip() final { + bool Skip() final { return ++Index < Size; } - bool Next(NUdf::TUnboxedValue& value) final { + bool Next(NUdf::TUnboxedValue& value) final { if (!Skip()) return false; value = Index == HolePos ? NUdf::TUnboxedValuePod() : NUdf::TUnboxedValuePod(Index); @@ -325,18 +325,18 @@ namespace { PosPair HolePos; ui32 Index; - bool Skip() final { + bool Skip() final { return ++Index < DictData.size(); } - bool Next(NUdf::TUnboxedValue& key) final { + bool Next(NUdf::TUnboxedValue& key) final { if (!Skip()) return false; key = Index == HolePos.first ? NUdf::TUnboxedValuePod() : NUdf::TUnboxedValuePod(DictData[Index].first); return true; } - bool NextPair(NUdf::TUnboxedValue& key, NUdf::TUnboxedValue& payload) final { + bool NextPair(NUdf::TUnboxedValue& key, NUdf::TUnboxedValue& payload) final { if (!Next(key)) return false; payload = Index == HolePos.second ? NUdf::TUnboxedValue() : ToUnboxedValue(DictData[Index].second); diff --git a/ydb/library/yql/minikql/mkql_node_serialization.cpp b/ydb/library/yql/minikql/mkql_node_serialization.cpp index 553ffb7bb2..e314f38cd6 100644 --- a/ydb/library/yql/minikql/mkql_node_serialization.cpp +++ b/ydb/library/yql/minikql/mkql_node_serialization.cpp @@ -107,37 +107,37 @@ namespace { { } - void Visit(TTypeType& node) override { + void Visit(TTypeType& node) override { Y_UNUSED(node); Owner.Write(TypeMarker | (char)TType::EKind::Type); IsProcessed0 = true; } - void Visit(TVoidType& node) override { + void Visit(TVoidType& node) override { Y_UNUSED(node); Owner.Write(TypeMarker | (char)TType::EKind::Void); IsProcessed0 = true; } - void Visit(TNullType& node) override { + void Visit(TNullType& node) override { Y_UNUSED(node); Owner.Write(TypeMarker | (char)TType::EKind::Null); IsProcessed0 = true; } - void Visit(TEmptyListType& node) override { + void Visit(TEmptyListType& node) override { Y_UNUSED(node); Owner.Write(TypeMarker | (char)TType::EKind::EmptyList); IsProcessed0 = true; } - void Visit(TEmptyDictType& node) override { + void Visit(TEmptyDictType& node) override { Y_UNUSED(node); Owner.Write(TypeMarker | (char)TType::EKind::EmptyDict); IsProcessed0 = true; } - void Visit(TDataType& node) override { + void Visit(TDataType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -154,7 +154,7 @@ namespace { IsProcessed0 = false; } - void Visit(TStructType& node) override { + void Visit(TStructType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -171,7 +171,7 @@ namespace { IsProcessed0 = false; } - void Visit(TListType& node) override { + void Visit(TListType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -184,7 +184,7 @@ namespace { IsProcessed0 = false; } - void Visit(TStreamType& node) override { + void Visit(TStreamType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -197,7 +197,7 @@ namespace { IsProcessed0 = false; } - void Visit(TFlowType& node) override { + void Visit(TFlowType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -223,7 +223,7 @@ namespace { IsProcessed0 = false; } - void Visit(TTaggedType& node) override { + void Visit(TTaggedType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -236,7 +236,7 @@ namespace { IsProcessed0 = false; } - void Visit(TOptionalType& node) override { + void Visit(TOptionalType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -249,7 +249,7 @@ namespace { IsProcessed0 = false; } - void Visit(TDictType& node) override { + void Visit(TDictType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -264,7 +264,7 @@ namespace { IsProcessed0 = false; } - void Visit(TCallableType& node) override { + void Visit(TCallableType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -288,13 +288,13 @@ namespace { IsProcessed0 = false; } - void Visit(TAnyType& node) override { + void Visit(TAnyType& node) override { Y_UNUSED(node); Owner.Write(TypeMarker | (char)TType::EKind::Any); IsProcessed0 = true; } - void Visit(TTupleType& node) override { + void Visit(TTupleType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -311,7 +311,7 @@ namespace { IsProcessed0 = false; } - void Visit(TResourceType& node) override { + void Visit(TResourceType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -324,7 +324,7 @@ namespace { IsProcessed0 = false; } - void Visit(TVariantType& node) override { + void Visit(TVariantType& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -337,31 +337,31 @@ namespace { IsProcessed0 = false; } - void Visit(TVoid& node) override { + void Visit(TVoid& node) override { Y_UNUSED(node); Owner.Write((char)TType::EKind::Void); IsProcessed0 = true; } - void Visit(TNull& node) override { + void Visit(TNull& node) override { Y_UNUSED(node); Owner.Write((char)TType::EKind::Null); IsProcessed0 = true; } - void Visit(TEmptyList& node) override { + void Visit(TEmptyList& node) override { Y_UNUSED(node); Owner.Write((char)TType::EKind::EmptyList); IsProcessed0 = true; } - void Visit(TEmptyDict& node) override { + void Visit(TEmptyDict& node) override { Y_UNUSED(node); Owner.Write((char)TType::EKind::EmptyDict); IsProcessed0 = true; } - void Visit(TDataLiteral& node) override { + void Visit(TDataLiteral& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -374,7 +374,7 @@ namespace { IsProcessed0 = false; } - void Visit(TStructLiteral& node) override { + void Visit(TStructLiteral& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -393,7 +393,7 @@ namespace { IsProcessed0 = false; } - void Visit(TListLiteral& node) override { + void Visit(TListLiteral& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -413,7 +413,7 @@ namespace { IsProcessed0 = false; } - void Visit(TOptionalLiteral& node) override { + void Visit(TOptionalLiteral& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -434,7 +434,7 @@ namespace { IsProcessed0 = false; } - void Visit(TDictLiteral& node) override { + void Visit(TDictLiteral& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -454,7 +454,7 @@ namespace { IsProcessed0 = false; } - void Visit(TCallable& node) override { + void Visit(TCallable& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -480,7 +480,7 @@ namespace { IsProcessed0 = false; } - void Visit(TAny& node) override { + void Visit(TAny& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -499,7 +499,7 @@ namespace { IsProcessed0 = false; } - void Visit(TTupleLiteral& node) override { + void Visit(TTupleLiteral& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; @@ -518,7 +518,7 @@ namespace { IsProcessed0 = false; } - void Visit(TVariantLiteral& node) override { + void Visit(TVariantLiteral& node) override { if (node.GetCookie() != 0) { Owner.WriteReference(node); IsProcessed0 = true; diff --git a/ydb/library/yql/providers/clickhouse/provider/yql_clickhouse_dq_integration.cpp b/ydb/library/yql/providers/clickhouse/provider/yql_clickhouse_dq_integration.cpp index f62c455c50..a882da93a0 100644 --- a/ydb/library/yql/providers/clickhouse/provider/yql_clickhouse_dq_integration.cpp +++ b/ydb/library/yql/providers/clickhouse/provider/yql_clickhouse_dq_integration.cpp @@ -109,7 +109,7 @@ public: } } - void RegisterMkqlCompiler(NCommon::TMkqlCallableCompilerBase& compiler) override { + void RegisterMkqlCompiler(NCommon::TMkqlCallableCompilerBase& compiler) override { RegisterDqClickHouseMkqlCompilers(compiler, State_); } diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_formatcode.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_formatcode.cpp index 4a2f79a72f..c6ec91c0d5 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_formatcode.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_formatcode.cpp @@ -28,7 +28,7 @@ public: return MakeString(str); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { DependsOn(Code_); } @@ -57,7 +57,7 @@ public: return MakeString(str); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { DependsOn(Code_); } diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_formattype.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_formattype.cpp index b00e745ce1..777de21e1f 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_formattype.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_formattype.cpp @@ -21,7 +21,7 @@ public: return MakeString(NYql::FormatType(type)); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { DependsOn(Handle_); } diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_makecode.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_makecode.cpp index c04dcf3fab..7325d12ede 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_makecode.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_makecode.cpp @@ -140,7 +140,7 @@ public: return NUdf::TUnboxedValuePod(new TYqlCodeResource(exprCtxPtr, retNode)); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { for (auto arg : Args_) { this->DependsOn(arg); } diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_maketype.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_maketype.cpp index 3a4db023b8..fe3d3c626e 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_maketype.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_maketype.cpp @@ -310,7 +310,7 @@ public: return NUdf::TUnboxedValuePod(new TYqlTypeResource(exprCtxPtr, retType)); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { for (auto arg : Args_) { this->DependsOn(arg); } diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_parsetypehandle.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_parsetypehandle.cpp index 55a3fdd0db..8919e250a1 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_parsetypehandle.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_parsetypehandle.cpp @@ -52,7 +52,7 @@ public: return NUdf::TUnboxedValuePod(new TYqlTypeResource(exprCtxPtr, exprRoot->GetTypeAnn()->Cast<NYql::TTypeExprType>()->GetType())); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { DependsOn(Str_); } diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_reprcode.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_reprcode.cpp index 2217923a92..a89bdd976d 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_reprcode.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_reprcode.cpp @@ -29,7 +29,7 @@ public: return NUdf::TUnboxedValuePod(new TYqlCodeResource(exprCtxPtr, node)); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { DependsOn(Value_); } diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_serializetypehandle.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_serializetypehandle.cpp index e003d6d671..446b880812 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_serializetypehandle.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_serializetypehandle.cpp @@ -22,7 +22,7 @@ public: return MakeString(NYql::NCommon::WriteTypeToYson(type)); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { DependsOn(Handle_); } diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_splittype.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_splittype.cpp index fd99ef7dee..84415beae0 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_splittype.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_splittype.cpp @@ -188,7 +188,7 @@ public: } } - void RegisterDependencies() const override { + void RegisterDependencies() const override { this->DependsOn(Handle_); } diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_typehandle.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_typehandle.cpp index fd87837b4c..229c7ffd1c 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_typehandle.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_typehandle.cpp @@ -29,7 +29,7 @@ public: return NUdf::TUnboxedValuePod(new TYqlTypeResource(exprCtxPtr, type)); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { } private: diff --git a/ydb/library/yql/providers/common/comp_nodes/yql_typekind.cpp b/ydb/library/yql/providers/common/comp_nodes/yql_typekind.cpp index 2ec5c82d51..5270c1d039 100644 --- a/ydb/library/yql/providers/common/comp_nodes/yql_typekind.cpp +++ b/ydb/library/yql/providers/common/comp_nodes/yql_typekind.cpp @@ -20,7 +20,7 @@ public: return MakeString(ToString(type->GetKind())); } - void RegisterDependencies() const override { + void RegisterDependencies() const override { DependsOn(Handle_); } diff --git a/ydb/library/yql/providers/dq/task_runner/tasks_runner_local.cpp b/ydb/library/yql/providers/dq/task_runner/tasks_runner_local.cpp index c8f97ae159..ab8769f44e 100644 --- a/ydb/library/yql/providers/dq/task_runner/tasks_runner_local.cpp +++ b/ydb/library/yql/providers/dq/task_runner/tasks_runner_local.cpp @@ -84,7 +84,7 @@ public: { } [[nodiscard]] - NDqProto::TPopResponse Pop(NDqProto::TData& data, ui64 bytes) override { + NDqProto::TPopResponse Pop(NDqProto::TData& data, ui64 bytes) override { NDqProto::TPopResponse response; response.SetResult(Channel->Pop(data, bytes)); if (Channel->IsFinished()) { @@ -94,7 +94,7 @@ public: return response; } - bool IsFinished() const override { + bool IsFinished() const override { return Channel->IsFinished(); } diff --git a/ydb/library/yql/providers/dq/task_runner/tasks_runner_pipe.cpp b/ydb/library/yql/providers/dq/task_runner/tasks_runner_pipe.cpp index 32ebb28f20..cdcbd32ef5 100644 --- a/ydb/library/yql/providers/dq/task_runner/tasks_runner_pipe.cpp +++ b/ydb/library/yql/providers/dq/task_runner/tasks_runner_pipe.cpp @@ -646,7 +646,7 @@ public: ythrow yexception() << "unimplemented"; } - const TDqInputChannelStats* GetStats() const override { + const TDqInputChannelStats* GetStats() const override { try { NDqProto::TCommandHeader header; header.SetVersion(3); @@ -808,7 +808,7 @@ public: return InputIndex; } - const TDqSourceStats* GetStats() const override { + const TDqSourceStats* GetStats() const override { try { NDqProto::TCommandHeader header; header.SetVersion(4); @@ -881,7 +881,7 @@ public: { } [[nodiscard]] - NDqProto::TPopResponse Pop(NDqProto::TData& data, ui64) override { + NDqProto::TPopResponse Pop(NDqProto::TData& data, ui64) override { NDqProto::TCommandHeader header; header.SetVersion(1); header.SetCommand(NDqProto::TCommandHeader::POP); @@ -895,7 +895,7 @@ public: return response; } - bool IsFinished() const override { + bool IsFinished() const override { if (Finished) { return true; } @@ -1043,7 +1043,7 @@ public: return nullptr; } - const TDqOutputChannelStats* GetStats() const override { + const TDqOutputChannelStats* GetStats() const override { try { NDqProto::TCommandHeader header; header.SetVersion(3); @@ -1423,7 +1423,7 @@ public: } [[noreturn]] - void RaiseException() override { + void RaiseException() override { auto status = GetStatus(); TString message; message += "ExitCode: " + ToString(status.ExitCode) + "\n"; @@ -1431,11 +1431,11 @@ public: ythrow yexception() << message; } - IOutputStream& GetOutput() override { + IOutputStream& GetOutput() override { return Output; } - IInputStream& GetInput() override { + IInputStream& GetInput() override { return Input; } diff --git a/ydb/library/yql/providers/pq/async_io/dq_pq_read_actor.cpp b/ydb/library/yql/providers/pq/async_io/dq_pq_read_actor.cpp index 311f5153ac..e26956545e 100644 --- a/ydb/library/yql/providers/pq/async_io/dq_pq_read_actor.cpp +++ b/ydb/library/yql/providers/pq/async_io/dq_pq_read_actor.cpp @@ -189,7 +189,7 @@ public: } } - void CommitState(const NDqProto::TCheckpoint& checkpoint) override { + void CommitState(const NDqProto::TCheckpoint& checkpoint) override { const auto checkpointId = checkpoint.GetId(); while (!DeferredCommits.empty() && DeferredCommits.front().first <= checkpointId) { DeferredCommits.front().second.Commit(); @@ -197,7 +197,7 @@ public: } } - ui64 GetInputIndex() const override { + ui64 GetInputIndex() const override { return InputIndex; }; @@ -236,7 +236,7 @@ private: TActor<TDqPqReadActor>::PassAway(); } - i64 GetSourceData(NKikimr::NMiniKQL::TUnboxedValueVector& buffer, bool&, i64 freeSpace) override { + i64 GetSourceData(NKikimr::NMiniKQL::TUnboxedValueVector& buffer, bool&, i64 freeSpace) override { auto events = GetReadSession().GetEvents(false, TMaybe<size_t>(), static_cast<size_t>(Max<i64>(freeSpace, 0))); ui32 batchSize = 0; diff --git a/ydb/library/yql/providers/pq/gateway/native/yql_pq_gateway.cpp b/ydb/library/yql/providers/pq/gateway/native/yql_pq_gateway.cpp index 1ec32b58d8..bd89565050 100644 --- a/ydb/library/yql/providers/pq/gateway/native/yql_pq_gateway.cpp +++ b/ydb/library/yql/providers/pq/gateway/native/yql_pq_gateway.cpp @@ -19,12 +19,12 @@ public: NThreading::TFuture<void> OpenSession(const TString& sessionId, const TString& username) override; void CloseSession(const TString& sessionId) override; - NPq::NConfigurationManager::TAsyncDescribePathResult DescribePath( - const TString& sessionId, - const TString& cluster, - const TString& database, - const TString& path, - const TString& token) override; + NPq::NConfigurationManager::TAsyncDescribePathResult DescribePath( + const TString& sessionId, + const TString& cluster, + const TString& database, + const TString& path, + const TString& token) override; void UpdateClusterConfigs( const TString& clusterName, diff --git a/ydb/library/yql/sql/settings/translation_settings.cpp b/ydb/library/yql/sql/settings/translation_settings.cpp index 0aba3db748..e09fd43aaa 100644 --- a/ydb/library/yql/sql/settings/translation_settings.cpp +++ b/ydb/library/yql/sql/settings/translation_settings.cpp @@ -17,7 +17,7 @@ namespace { class TAlwaysDiallowPolicy : public ISqlFeaturePolicy { public: TAlwaysDiallowPolicy() = default; - bool Allow() const override { + bool Allow() const override { return false; } }; diff --git a/ydb/library/yql/sql/v0/builtin.cpp b/ydb/library/yql/sql/v0/builtin.cpp index ed19ead843..a0945f9d05 100644 --- a/ydb/library/yql/sql/v0/builtin.cpp +++ b/ydb/library/yql/sql/v0/builtin.cpp @@ -406,7 +406,7 @@ public: , Args(args) {} - TAstNode* Translate(TContext& ctx) const override { + TAstNode* Translate(TContext& ctx) const override { if (Args.size() != 1) { ctx.Error(Pos) << "Expected 1 argument in ParseType function"; return nullptr; @@ -1316,7 +1316,7 @@ public: return true; } - void DoUpdateState() const final { + void DoUpdateState() const final { State.Set(ENodeState::Const, false); } diff --git a/ydb/library/yql/sql/v0/list_builtin.h b/ydb/library/yql/sql/v0/list_builtin.h index 9e4be5b66e..9fc4f22ce6 100644 --- a/ydb/library/yql/sql/v0/list_builtin.h +++ b/ydb/library/yql/sql/v0/list_builtin.h @@ -24,7 +24,7 @@ public: , Args(args) {} - bool DoInit(TContext& ctx, ISource* src) override = 0; + bool DoInit(TContext& ctx, ISource* src) override = 0; TAstNode* Translate(TContext& ctx) const override; @@ -189,9 +189,9 @@ public: private: bool DoInit(TContext& ctx, ISource* src) override; - TNodePtr GetInitialState() override; + TNodePtr GetInitialState() override; - TNodePtr GetUpdateLambda() override; + TNodePtr GetUpdateLambda() override; }; class TListHasBuiltin final: public TListFoldBuiltin { @@ -205,7 +205,7 @@ public: return new TListHasBuiltin(Pos, CloneContainer(Args)); } private: - TNodePtr GetUpdateLambda() override; + TNodePtr GetUpdateLambda() override; void DoUpdateState() const override { bool isAggregated = true; diff --git a/ydb/library/yql/sql/v0/node.h b/ydb/library/yql/sql/v0/node.h index 6a991bfe05..4c7cfc273b 100644 --- a/ydb/library/yql/sql/v0/node.h +++ b/ydb/library/yql/sql/v0/node.h @@ -275,7 +275,7 @@ namespace NSQLTranslationV0 { TAstListNode(TPosition pos); virtual ~TAstListNode(); - TAstNode* Translate(TContext& ctx) const override; + TAstNode* Translate(TContext& ctx) const override; protected: explicit TAstListNode(const TAstListNode& node); @@ -552,11 +552,11 @@ namespace NSQLTranslationV0 { TColumnNode(TPosition pos, const TNodePtr& column, const TString& source); virtual ~TColumnNode(); - bool IsAsterisk() const override; + bool IsAsterisk() const override; virtual bool IsArtificial() const; - const TString* GetColumnName() const override; - const TString* GetSourceName() const override; - TAstNode* Translate(TContext& ctx) const override; + const TString* GetColumnName() const override; + const TString* GetSourceName() const override; + TAstNode* Translate(TContext& ctx) const override; void ResetColumn(const TString& column, const TString& source); void ResetColumn(const TNodePtr& column, const TString& source); @@ -669,7 +669,7 @@ namespace NSQLTranslationV0 { protected: IAggregation(TPosition pos, const TString& name, const TString& func, EAggregateMode mode); - TAstNode* Translate(TContext& ctx) const override; + TAstNode* Translate(TContext& ctx) const override; TString Name; const TString Func; diff --git a/ydb/library/yql/sql/v0/query.cpp b/ydb/library/yql/sql/v0/query.cpp index 917550f30e..7752b28b01 100644 --- a/ydb/library/yql/sql/v0/query.cpp +++ b/ydb/library/yql/sql/v0/query.cpp @@ -1128,7 +1128,7 @@ public: return true; } - TAstNode* Translate(TContext& ctx) const override { + TAstNode* Translate(TContext& ctx) const override { return Node->Translate(ctx); } diff --git a/ydb/library/yql/sql/v0/select.cpp b/ydb/library/yql/sql/v0/select.cpp index f719208b93..ef47023be1 100644 --- a/ydb/library/yql/sql/v0/select.cpp +++ b/ydb/library/yql/sql/v0/select.cpp @@ -1021,7 +1021,7 @@ public: return Source.Get(); } - TWriteSettings GetWriteSettings() const override { + TWriteSettings GetWriteSettings() const override { return Settings; } diff --git a/ydb/library/yql/sql/v1/builtin.cpp b/ydb/library/yql/sql/v1/builtin.cpp index 752139e80d..43ef1243f1 100644 --- a/ydb/library/yql/sql/v1/builtin.cpp +++ b/ydb/library/yql/sql/v1/builtin.cpp @@ -517,7 +517,7 @@ public: , Args(args) {} - TAstNode* Translate(TContext& ctx) const override { + TAstNode* Translate(TContext& ctx) const override { if (Args.size() != 1) { ctx.Error(Pos) << "Expected 1 argument in ParseType function"; return nullptr; @@ -1640,7 +1640,7 @@ public: return true; } - TAstNode* Translate(TContext& ctx) const override { + TAstNode* Translate(TContext& ctx) const override { Y_VERIFY_DEBUG(Node); return Node->Translate(ctx); } diff --git a/ydb/library/yql/sql/v1/list_builtin.h b/ydb/library/yql/sql/v1/list_builtin.h index f8d8702f5b..a8077b464a 100644 --- a/ydb/library/yql/sql/v1/list_builtin.h +++ b/ydb/library/yql/sql/v1/list_builtin.h @@ -24,7 +24,7 @@ public: , Args(args) {} - bool DoInit(TContext& ctx, ISource* src) override = 0; + bool DoInit(TContext& ctx, ISource* src) override = 0; TAstNode* Translate(TContext& ctx) const override; diff --git a/ydb/library/yql/sql/v1/node.h b/ydb/library/yql/sql/v1/node.h index 4b3dbe9851..de82b45a23 100644 --- a/ydb/library/yql/sql/v1/node.h +++ b/ydb/library/yql/sql/v1/node.h @@ -305,7 +305,7 @@ namespace NSQLTranslationV1 { TAstListNode(TPosition pos); virtual ~TAstListNode(); - TAstNode* Translate(TContext& ctx) const override; + TAstNode* Translate(TContext& ctx) const override; protected: explicit TAstListNode(const TAstListNode& node); @@ -401,7 +401,7 @@ namespace NSQLTranslationV1 { protected: void DoUpdateState() const override; bool DoInit(TContext& ctx, ISource* src) override; - TPtr WindowSpecFunc(const TNodePtr& type) const override; + TPtr WindowSpecFunc(const TNodePtr& type) const override; public: TWinAggrEmulation(TPosition pos, const TString& opName, i32 minArgs, i32 maxArgs, const TVector<TNodePtr>& args); protected: @@ -647,11 +647,11 @@ namespace NSQLTranslationV1 { TColumnNode(TPosition pos, const TNodePtr& column, const TString& source); virtual ~TColumnNode(); - bool IsAsterisk() const override; + bool IsAsterisk() const override; virtual bool IsArtificial() const; - const TString* GetColumnName() const override; - const TString* GetSourceName() const override; - TAstNode* Translate(TContext& ctx) const override; + const TString* GetColumnName() const override; + const TString* GetSourceName() const override; + TAstNode* Translate(TContext& ctx) const override; void ResetColumn(const TString& column, const TString& source); void ResetColumn(const TNodePtr& column, const TString& source); @@ -774,7 +774,7 @@ namespace NSQLTranslationV1 { protected: IAggregation(TPosition pos, const TString& name, const TString& func, EAggregateMode mode); - TAstNode* Translate(TContext& ctx) const override; + TAstNode* Translate(TContext& ctx) const override; TString Name; TString Func; @@ -1015,7 +1015,7 @@ namespace NSQLTranslationV1 { bool DoInit(TContext& ctx, ISource* src) override; - void DoUpdateState() const override; + void DoUpdateState() const override; TNodePtr DoClone() const final; TAstNode* Translate(TContext& ctx) const override; diff --git a/ydb/library/yql/sql/v1/query.cpp b/ydb/library/yql/sql/v1/query.cpp index 0e122e95bc..725356b9f5 100644 --- a/ydb/library/yql/sql/v1/query.cpp +++ b/ydb/library/yql/sql/v1/query.cpp @@ -1841,7 +1841,7 @@ public: return true; } - TAstNode* Translate(TContext& ctx) const final { + TAstNode* Translate(TContext& ctx) const final { return Node->Translate(ctx); } diff --git a/ydb/library/yql/udfs/common/set/set_udf.cpp b/ydb/library/yql/udfs/common/set/set_udf.cpp index 6ca6d5735e..f282c22842 100644 --- a/ydb/library/yql/udfs/common/set/set_udf.cpp +++ b/ydb/library/yql/udfs/common/set/set_udf.cpp @@ -187,14 +187,14 @@ TSetResource* GetSetResource(const TUnboxedValuePod& arg) { template <EDataSlot Slot> class TSetCreateData: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { return TUnboxedValuePod(new TSetResourceData<Slot>(args[0], args[1].Get<ui32>())); } }; class TSetCreate: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { return TUnboxedValuePod(new TSetResource(args[0], args[1].Get<ui32>(), Hash_, Equate_)); } @@ -212,7 +212,7 @@ private: template <EDataSlot Slot> class TSetAddValueData: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { auto resource = GetSetResourceData<Slot>(args[0]); resource->Get()->ResetChanged(); resource->Get()->AddValue(args[1]); @@ -222,7 +222,7 @@ private: class TSetAddValue: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { auto resource = GetSetResource(args[0]); resource->Get()->ResetChanged(); resource->Get()->AddValue(args[1]); @@ -233,7 +233,7 @@ private: template <EDataSlot Slot> class TSetWasChangedData: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { auto resource = GetSetResourceData<Slot>(args[0]); return TUnboxedValuePod(resource->Get()->Changed()); } @@ -241,7 +241,7 @@ private: class TSetWasChanged: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { auto resource = GetSetResource(args[0]); return TUnboxedValuePod(resource->Get()->Changed()); } @@ -250,14 +250,14 @@ private: template <EDataSlot Slot> class TSetSerializeData: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { return GetSetResourceData<Slot>(args[0])->Get()->Serialize(valueBuilder); } }; class TSetSerialize: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { return GetSetResource(args[0])->Get()->Serialize(valueBuilder); } }; @@ -265,14 +265,14 @@ private: template <EDataSlot Slot> class TSetDeserializeData: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { return TUnboxedValuePod(new TSetResourceData<Slot>(args[0])); } }; class TSetDeserialize: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { return TUnboxedValuePod(new TSetResource(args[0], Hash_, Equate_)); } @@ -290,7 +290,7 @@ private: template <EDataSlot Slot> class TSetMergeData: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { auto left = GetSetResourceData<Slot>(args[0]); auto right = GetSetResourceData<Slot>(args[1]); return TUnboxedValuePod(new TSetResourceData<Slot>(*left->Get(), *right->Get())); @@ -299,7 +299,7 @@ private: class TSetMerge: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { auto left = GetSetResource(args[0]); auto right = GetSetResource(args[1]); return TUnboxedValuePod(new TSetResource(*left->Get(), *right->Get(), Hash_, Equate_)); @@ -319,14 +319,14 @@ private: template <EDataSlot Slot> class TSetGetResultData: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { return GetSetResourceData<Slot>(args[0])->Get()->GetResult(valueBuilder); } }; class TSetGetResult: public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { return GetSetResource(args[0])->Get()->GetResult(valueBuilder); } }; diff --git a/ydb/library/yql/udfs/common/top/top_udf.cpp b/ydb/library/yql/udfs/common/top/top_udf.cpp index 4b879432ca..748ffe489b 100644 --- a/ydb/library/yql/udfs/common/top/top_udf.cpp +++ b/ydb/library/yql/udfs/common/top/top_udf.cpp @@ -514,7 +514,7 @@ public: template <EDataSlot Slot, bool HasKey, bool IsTop> class TTopSerializeData : public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { auto resource = GetTopResourceData<Slot, HasKey, IsTop>(args[0]); return resource->Get()->Serialize(valueBuilder); } @@ -523,7 +523,7 @@ private: template <bool HasKey, bool IsTop> class TTopSerialize : public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { auto resource = GetTopResource<HasKey, IsTop>(args[0]); return resource->Get()->Serialize(valueBuilder); } @@ -536,7 +536,7 @@ public: template <EDataSlot Slot, bool HasKey, bool IsTop> class TTopDeserializeData : public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { return TUnboxedValuePod(new TTopResourceData<Slot, HasKey, IsTop>(args[0])); } }; @@ -544,7 +544,7 @@ private: template <bool HasKey, bool IsTop> class TTopDeserialize : public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { return TUnboxedValuePod(new TTopResource<HasKey, IsTop>(args[0], Compare_)); } @@ -560,7 +560,7 @@ private: template <EDataSlot Slot, bool HasKey, bool IsTop> class TTopMergeData : public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { auto left = GetTopResourceData<Slot, HasKey, IsTop>(args[0]); auto right = GetTopResourceData<Slot, HasKey, IsTop>(args[1]); return TUnboxedValuePod(new TTopResourceData<Slot, HasKey, IsTop>(*left->Get(), *right->Get())); @@ -570,7 +570,7 @@ private: template <bool HasKey, bool IsTop> class TTopMerge : public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { auto left = GetTopResource<HasKey, IsTop>(args[0]); auto right = GetTopResource<HasKey, IsTop>(args[1]); return TUnboxedValuePod(new TTopResource<HasKey, IsTop>(*left->Get(), *right->Get(), Compare_)); @@ -588,7 +588,7 @@ private: template <EDataSlot Slot, bool HasKey, bool IsTop> class TTopGetResultData : public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { auto resource = GetTopResourceData<Slot, HasKey, IsTop>(args[0]); return resource->Get()->GetResult(valueBuilder); } @@ -597,7 +597,7 @@ private: template <bool HasKey, bool IsTop> class TTopGetResult : public TBoxedValue { private: - TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder* valueBuilder, const TUnboxedValuePod* args) const override { auto resource = GetTopResource<HasKey, IsTop>(args[0]); return resource->Get()->GetResult(valueBuilder); } diff --git a/ydb/library/yql/udfs/common/yson2/yson2_udf.cpp b/ydb/library/yql/udfs/common/yson2/yson2_udf.cpp index da2a330648..1278ec565c 100644 --- a/ydb/library/yql/udfs/common/yson2/yson2_udf.cpp +++ b/ydb/library/yql/udfs/common/yson2/yson2_udf.cpp @@ -53,7 +53,7 @@ TOpts ParseOptions(TUnboxedValuePod x) { } class TOptions : public TBoxedValue { - TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { + TUnboxedValue Run(const IValueBuilder*, const TUnboxedValuePod* args) const override { ui8 options = 0; if (args[0] && args[0].Get<bool>()) { @@ -175,7 +175,7 @@ private: return TUnboxedValuePod(new TIterator<true>(Original.GetKeysIterator(), ValueBuilder, Pos_)); } - TUnboxedValue GetPayloadsIterator() const override { + TUnboxedValue GetPayloadsIterator() const override { return TUnboxedValuePod(new TIterator<false>(Original.GetPayloadsIterator(), ValueBuilder, Pos_)); } diff --git a/ydb/library/yql/utils/fetch/fetch.cpp b/ydb/library/yql/utils/fetch/fetch.cpp index 5a4de5b8bd..100c88c385 100644 --- a/ydb/library/yql/utils/fetch/fetch.cpp +++ b/ydb/library/yql/utils/fetch/fetch.cpp @@ -81,15 +81,15 @@ public: HttpInput.Reset(new THttpInput(Ssl ? (IInputStream*)Ssl.Get() : (IInputStream*)SocketInput.Get())); } - THttpInput& GetStream() override { + THttpInput& GetStream() override { return *HttpInput; } - unsigned GetRetCode() override { + unsigned GetRetCode() override { return ParseHttpRetCode(HttpInput->FirstLine()); } - THttpURL GetRedirectURL(const THttpURL& baseUrl) override { + THttpURL GetRedirectURL(const THttpURL& baseUrl) override { for (auto i = HttpInput->Headers().Begin(); i != HttpInput->Headers().End(); ++i) { if (0 == TCiString::compare(i->Name(), TStringBuf("location"))) { THttpURL target = ParseURL(i->Value(), THttpURL::FeaturesAll | NUri::TFeature::FeatureConvertHostIDN); diff --git a/ydb/public/lib/idx_test/idx_test_stderr_progress_tracker.cpp b/ydb/public/lib/idx_test/idx_test_stderr_progress_tracker.cpp index d4b4a7d90c..42bb67ffb8 100644 --- a/ydb/public/lib/idx_test/idx_test_stderr_progress_tracker.cpp +++ b/ydb/public/lib/idx_test/idx_test_stderr_progress_tracker.cpp @@ -26,7 +26,7 @@ public: DoUpdate(pos, false); } - void Finish(const TString& freeMessage) override { + void Finish(const TString& freeMessage) override { if (LastUpdateValue_) { DoUpdate(LastUpdateValue_.GetRef(), true); Cerr << Endl; diff --git a/ydb/public/sdk/cpp/client/impl/ydb_internal/grpc_connections/grpc_connections.h b/ydb/public/sdk/cpp/client/impl/ydb_internal/grpc_connections/grpc_connections.h index 63b3a33d8f..bfc1b7ec38 100644 --- a/ydb/public/sdk/cpp/client/impl/ydb_internal/grpc_connections/grpc_connections.h +++ b/ydb/public/sdk/cpp/client/impl/ydb_internal/grpc_connections/grpc_connections.h @@ -63,7 +63,7 @@ public: const TMaybe<bool>& enableSsl, const TMaybe<std::shared_ptr<ICredentialsProviderFactory>>& credentialsProviderFactory ); - IQueueClientContextPtr CreateContext() override; + IQueueClientContextPtr CreateContext() override; bool TryCreateContext(IQueueClientContextPtr& context); void WaitIdle(); void Stop(bool wait = false); @@ -582,7 +582,7 @@ public: }, dbState, TStringType(), endpointPolicy); } - TAsyncListEndpointsResult GetEndpoints(TDbDriverStatePtr dbState) override; + TAsyncListEndpointsResult GetEndpoints(TDbDriverStatePtr dbState) override; TListEndpointsResult MutateDiscovery(TListEndpointsResult result, const TStringType& database); #ifndef YDB_GRPC_BYPASS_CHANNEL_POOL diff --git a/ydb/public/sdk/cpp/client/ydb_persqueue_core/ut/read_session_ut.cpp b/ydb/public/sdk/cpp/client/ydb_persqueue_core/ut/read_session_ut.cpp index bda391d2eb..9b2367e3f3 100644 --- a/ydb/public/sdk/cpp/client/ydb_persqueue_core/ut/read_session_ut.cpp +++ b/ydb/public/sdk/cpp/client/ydb_persqueue_core/ut/read_session_ut.cpp @@ -91,10 +91,10 @@ struct TMockProcessorFactory : public ISessionConnectionProcessorFactory<TReques OnCreateProcessor(++CreateCallsCount); } - MOCK_METHOD(void, ValidateConnectTimeout, (TDuration), ()); + MOCK_METHOD(void, ValidateConnectTimeout, (TDuration), ()); // Handler is called in CreateProcessor() method after parameter validation. - MOCK_METHOD(void, OnCreateProcessor, (size_t callNumber)); // 1-based + MOCK_METHOD(void, OnCreateProcessor, (size_t callNumber)); // 1-based // Actions to use in OnCreateProcessor handler: void CreateProcessor(typename IFactory::IProcessor::TPtr processor) { // Success. @@ -381,12 +381,12 @@ struct TMockReadSessionProcessor : public TMockProcessorFactory<Ydb::PersQueue:: } } - MOCK_METHOD(void, OnInitRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::InitRequest&), ()); - MOCK_METHOD(void, OnReadRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::Read&), ()); - MOCK_METHOD(void, OnStartReadRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::StartRead&), ()); - MOCK_METHOD(void, OnCommitRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::Commit&), ()); - MOCK_METHOD(void, OnReleasedRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::Released&), ()); - MOCK_METHOD(void, OnStatusRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::Status&), ()); + MOCK_METHOD(void, OnInitRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::InitRequest&), ()); + MOCK_METHOD(void, OnReadRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::Read&), ()); + MOCK_METHOD(void, OnStartReadRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::StartRead&), ()); + MOCK_METHOD(void, OnCommitRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::Commit&), ()); + MOCK_METHOD(void, OnReleasedRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::Released&), ()); + MOCK_METHOD(void, OnStatusRequest, (const Ydb::PersQueue::V1::MigrationStreamingReadClientMessage::Status&), ()); void Wait() { std::queue<std::future<void>> callbackFutures; @@ -451,7 +451,7 @@ public: using TMockProcessorFactory = ::TMockProcessorFactory<Ydb::PersQueue::V1::MigrationStreamingReadClientMessage, Ydb::PersQueue::V1::MigrationStreamingReadServerMessage>; struct TMockErrorHandler : public IErrorHandler { - MOCK_METHOD(void, AbortSession, (TSessionClosedEvent&& closeEvent), (override)); + MOCK_METHOD(void, AbortSession, (TSessionClosedEvent&& closeEvent), (override)); }; struct TFakeContext : public NGrpc::IQueueClientContext { diff --git a/ydb/services/ydb/ydb_stats_ut.cpp b/ydb/services/ydb/ydb_stats_ut.cpp index 3a5d935a46..b40e22fc42 100644 --- a/ydb/services/ydb/ydb_stats_ut.cpp +++ b/ydb/services/ydb/ydb_stats_ut.cpp @@ -62,7 +62,7 @@ public: void Close() override { } void OnStreamBegin() override { } - void OnStreamEnd() override { } + void OnStreamEnd() override { } void OnCommonTime(TInstant) override { } |