diff options
| author | a-romanov <Anton.Romanov@ydb.tech> | 2023-10-27 11:25:04 +0300 |
|---|---|---|
| committer | a-romanov <Anton.Romanov@ydb.tech> | 2023-10-27 11:54:41 +0300 |
| commit | b15f8132b6d2f5cde633d1207654042993d93bb8 (patch) | |
| tree | b84be084a7858f18565abad115dc54f523db8891 | |
| parent | 9f0d269f99492ad31a0882ded8db0547a5d92fad (diff) | |
| download | ydb-b15f8132b6d2f5cde633d1207654042993d93bb8.tar.gz | |
YQL-16757 Fix cleanup temporary key.
| -rw-r--r-- | ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp index a6a5723f63..4b000dd8df 100644 --- a/ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp +++ b/ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp @@ -350,7 +350,7 @@ public: if constexpr (WithoutRight) { this->GenFillLeftStruct(current.second, getters); - if (RightRequired) { + if constexpr (RightRequired) { BranchInst::Create(loop, step, none, block); } else { result->addIncoming(ConstantInt::get(resultType, i32(EFetchResult::One)), block); @@ -362,9 +362,7 @@ public: const auto cont = CallBoxedValueVirtualMethod<NUdf::TBoxedValueAccessor::EMethod::Contains>(Type::getInt1Ty(context), dict, ctx.Codegen, block, keysPtr); if constexpr (!IsTuple) { - if (this->IsUnusedInput(this->LeftKeyColumns.front())) { - ValueCleanup(GetValueRepresentation(this->DictType->GetKeyType()), keysPtr, ctx, block); - } + ValueCleanup(GetValueRepresentation(this->DictType->GetKeyType()), keysPtr, ctx, block); } result->addIncoming(ConstantInt::get(resultType, i32(EFetchResult::One)), block); @@ -392,9 +390,7 @@ public: const auto lookup = new LoadInst(valueType, lookupPtr, "lookup", block); if constexpr (!IsTuple) { - if (this->IsUnusedInput(this->LeftKeyColumns.front())) { - ValueCleanup(GetValueRepresentation(this->DictType->GetKeyType()), keysPtr, ctx, block); - } + ValueCleanup(GetValueRepresentation(this->DictType->GetKeyType()), keysPtr, ctx, block); } const auto ok = CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, lookup, zero, "ok", block); |