diff options
author | Vasily Gerasimov <UgnineSirdis@gmail.com> | 2022-05-13 23:02:25 +0300 |
---|---|---|
committer | Vasily Gerasimov <UgnineSirdis@gmail.com> | 2022-05-13 23:02:25 +0300 |
commit | ac5cd845fa20777156e7d9327cde4238032a7181 (patch) | |
tree | fb66c83d482e7726ef3980b385e3862af8fb5a0d | |
parent | 849d3f28890afca409377b63332546e74191e383 (diff) | |
download | ydb-ac5cd845fa20777156e7d9327cde4238032a7181.tar.gz |
YQ-1054 Small fixes in solomon write actor
More accurate data size
Small fixes
ref:e5eacf342177ea261bc77a021a7991ac87477cf7
-rw-r--r-- | ydb/library/yql/providers/solomon/async_io/dq_solomon_write_actor.cpp | 6 | ||||
-rw-r--r-- | ydb/library/yql/providers/solomon/async_io/metrics_encoder.cpp | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/ydb/library/yql/providers/solomon/async_io/dq_solomon_write_actor.cpp b/ydb/library/yql/providers/solomon/async_io/dq_solomon_write_actor.cpp index 584bfcd7be..62a849057a 100644 --- a/ydb/library/yql/providers/solomon/async_io/dq_solomon_write_actor.cpp +++ b/ydb/library/yql/providers/solomon/async_io/dq_solomon_write_actor.cpp @@ -351,10 +351,10 @@ private: HttpProxyId = Register(NHttp::CreateHttpProxy(NMonitoring::TMetricRegistry::SharedInstance())); } - const auto metricsToSend = std::get<TMetricsToSend>(variant); + const auto& metricsToSend = std::get<TMetricsToSend>(variant); const NHttp::THttpOutgoingRequestPtr httpRequest = BuildSolomonRequest(metricsToSend.Data); - const auto bodySize = httpRequest->Body.Size(); + const size_t bodySize = metricsToSend.Data.size(); const TActorId httpSenderId = Register(CreateHttpSenderActor(SelfId(), HttpProxyId)); Send(httpSenderId, new NHttp::TEvHttpProxy::TEvHttpOutgoingRequest(httpRequest), /*flags=*/0, Cookie); SINK_LOG_D("Sent " << metricsToSend.MetricsCount << " metrics with size of " << metricsToSend.Data.size() << " bytes to solomon"); @@ -417,7 +417,7 @@ private: } FreeSpace += ptr->second.BodySize; - if (ShouldNotifyNewFreeSpace) { + if (ShouldNotifyNewFreeSpace && FreeSpace > 0) { Callbacks->ResumeExecution(); ShouldNotifyNewFreeSpace = false; } diff --git a/ydb/library/yql/providers/solomon/async_io/metrics_encoder.cpp b/ydb/library/yql/providers/solomon/async_io/metrics_encoder.cpp index 80637642fb..0f1dd8f71d 100644 --- a/ydb/library/yql/providers/solomon/async_io/metrics_encoder.cpp +++ b/ydb/library/yql/providers/solomon/async_io/metrics_encoder.cpp @@ -124,7 +124,7 @@ ui64 TMetricsEncoder::Append(const NUdf::TUnboxedValue& value) SolomonEncoder->OnLabel("name", sensor.GetKey()); for (const auto& label : Scheme.GetLabels()) { const NUdf::TUnboxedValue& labelValue = value.GetElement(label.GetIndex()); - SolomonEncoder->OnLabel(label.GetKey(), TString(labelValue.AsStringRef())); + SolomonEncoder->OnLabel(label.GetKey(), TStringBuf(labelValue.AsStringRef())); } SolomonEncoder->OnLabelsEnd(); |