diff options
| author | Ilia Shakhov <pixcc@ydb.tech> | 2025-02-14 13:05:53 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-02-14 10:05:53 +0000 |
| commit | a27e92027534df6f49609bd1a1ed8f321eb779ce (patch) | |
| tree | d8f23ad8f0f9ac0b91cf446962b40b5baac746f7 | |
| parent | 4adb4e566b376e307ddb377bed51f2173330734b (diff) | |
| download | ydb-a27e92027534df6f49609bd1a1ed8f321eb779ce.tar.gz | |
Make dump commands read only (#14562)
| -rw-r--r-- | ydb/public/lib/ydb_cli/commands/ydb_admin.cpp | 2 | ||||
| -rw-r--r-- | ydb/public/lib/ydb_cli/commands/ydb_admin.h | 2 | ||||
| -rw-r--r-- | ydb/public/lib/ydb_cli/commands/ydb_cluster.cpp | 2 | ||||
| -rw-r--r-- | ydb/public/lib/ydb_cli/commands/ydb_cluster.h | 2 | ||||
| -rw-r--r-- | ydb/tests/functional/ydb_cli/test_ydb_backup.py | 1 |
5 files changed, 4 insertions, 5 deletions
diff --git a/ydb/public/lib/ydb_cli/commands/ydb_admin.cpp b/ydb/public/lib/ydb_cli/commands/ydb_admin.cpp index ad33a94349..0dfab05a11 100644 --- a/ydb/public/lib/ydb_cli/commands/ydb_admin.cpp +++ b/ydb/public/lib/ydb_cli/commands/ydb_admin.cpp @@ -35,7 +35,7 @@ public: }; TCommandDatabaseDump::TCommandDatabaseDump() - : TYdbCommand("dump", {}, "Dump database into local directory") + : TYdbReadOnlyCommand("dump", {}, "Dump database into local directory") {} void TCommandDatabaseDump::Config(TConfig& config) { diff --git a/ydb/public/lib/ydb_cli/commands/ydb_admin.h b/ydb/public/lib/ydb_cli/commands/ydb_admin.h index 0735dd39d2..ee02a853c8 100644 --- a/ydb/public/lib/ydb_cli/commands/ydb_admin.h +++ b/ydb/public/lib/ydb_cli/commands/ydb_admin.h @@ -12,7 +12,7 @@ protected: virtual void Config(TConfig& config) override; }; -class TCommandDatabaseDump : public TYdbCommand { +class TCommandDatabaseDump : public TYdbReadOnlyCommand { public: TCommandDatabaseDump(); void Config(TConfig& config) override; diff --git a/ydb/public/lib/ydb_cli/commands/ydb_cluster.cpp b/ydb/public/lib/ydb_cli/commands/ydb_cluster.cpp index 5520de753d..1e67ebc496 100644 --- a/ydb/public/lib/ydb_cli/commands/ydb_cluster.cpp +++ b/ydb/public/lib/ydb_cli/commands/ydb_cluster.cpp @@ -46,7 +46,7 @@ int TCommandClusterBootstrap::Run(TConfig& config) { } TCommandClusterDump::TCommandClusterDump() - : TYdbCommand("dump", {}, "Dump cluster into local directory") + : TYdbReadOnlyCommand("dump", {}, "Dump cluster into local directory") {} void TCommandClusterDump::Config(TConfig& config) { diff --git a/ydb/public/lib/ydb_cli/commands/ydb_cluster.h b/ydb/public/lib/ydb_cli/commands/ydb_cluster.h index 14376920a9..955e41a2a0 100644 --- a/ydb/public/lib/ydb_cli/commands/ydb_cluster.h +++ b/ydb/public/lib/ydb_cli/commands/ydb_cluster.h @@ -22,7 +22,7 @@ public: int Run(TConfig& config) override; }; -class TCommandClusterDump : public TYdbCommand { +class TCommandClusterDump : public TYdbReadOnlyCommand { public: TCommandClusterDump(); void Config(TConfig& config) override; diff --git a/ydb/tests/functional/ydb_cli/test_ydb_backup.py b/ydb/tests/functional/ydb_cli/test_ydb_backup.py index 301b9bd1be..be9147ea9e 100644 --- a/ydb/tests/functional/ydb_cli/test_ydb_backup.py +++ b/ydb/tests/functional/ydb_cli/test_ydb_backup.py @@ -1339,7 +1339,6 @@ class BaseTestClusterBackupInFiles(object): [ backup_bin(), "--verbose", - "--assume-yes", "--endpoint", "grpc://localhost:%d" % cls.cluster.nodes[1].grpc_port, ] + command |