diff options
| author | zverevgeny <[email protected]> | 2024-02-06 06:44:45 +0300 |
|---|---|---|
| committer | GitHub <[email protected]> | 2024-02-06 06:44:45 +0300 |
| commit | 9bf348b2c398b89da69a0f789cd4d836ca04c217 (patch) | |
| tree | f0c7eb79b9a6e0419a615426f4bc9bd2a6ce9355 | |
| parent | a7a2a17e1d45b5151915f601b6da92be841b8256 (diff) | |
YQL-17542 split stat (#1553)
3 files changed, 17 insertions, 7 deletions
diff --git a/ydb/library/yql/dq/actors/compute/dq_async_compute_actor.cpp b/ydb/library/yql/dq/actors/compute/dq_async_compute_actor.cpp index 2eda9ad5a45..f887aad5066 100644 --- a/ydb/library/yql/dq/actors/compute/dq_async_compute_actor.cpp +++ b/ydb/library/yql/dq/actors/compute/dq_async_compute_actor.cpp @@ -789,6 +789,11 @@ private: return TaskRunnerStats.Get(); } + const NYql::NDq::TDqMeteringStats* GetMeteringStats() override { + // TODO: support async CA + return nullptr; + } + template<typename TSecond> TVector<ui32> GetIds(const THashMap<ui64, TSecond>& collection) { TVector<ui32> ids; diff --git a/ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h b/ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h index e1054a5183d..c115a3ee4c7 100644 --- a/ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h +++ b/ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h @@ -1758,9 +1758,8 @@ private: } } - virtual const NYql::NDq::TTaskRunnerStatsBase* GetTaskRunnerStats() { - return TaskRunner ? TaskRunner->GetStats() : nullptr; - } + virtual const NYql::NDq::TTaskRunnerStatsBase* GetTaskRunnerStats() = 0; + virtual const NYql::NDq::TDqMeteringStats* GetMeteringStats() = 0; virtual const IDqAsyncOutputBuffer* GetSink(ui64, const TAsyncOutputInfoBase& sinkInfo) const { return sinkInfo.Buffer.Get(); @@ -1820,8 +1819,7 @@ public: for (auto& [inputIndex, sourceInfo] : SourcesMap) { if (auto* source = sourceInfo.AsyncInput) { - // TODO: support async CA - source->FillExtraStats(protoTask, last, TaskRunner ? TaskRunner->GetMeteringStats() : nullptr); + source->FillExtraStats(protoTask, last, GetMeteringStats()); } } FillTaskRunnerStats(Task.GetId(), Task.GetStageId(), *taskStats, protoTask, RuntimeSettings.GetCollectStatsLevel()); @@ -1926,8 +1924,7 @@ public: } if (auto* transform = transformInfo.AsyncInput) { - // TODO: support async CA - transform->FillExtraStats(protoTask, last, TaskRunner ? TaskRunner->GetMeteringStats() : 0); + transform->FillExtraStats(protoTask, last, GetMeteringStats()); } } diff --git a/ydb/library/yql/dq/actors/compute/dq_sync_compute_actor_base.h b/ydb/library/yql/dq/actors/compute/dq_sync_compute_actor_base.h index f999357be5d..e27605abfaf 100644 --- a/ydb/library/yql/dq/actors/compute/dq_sync_compute_actor_base.h +++ b/ydb/library/yql/dq/actors/compute/dq_sync_compute_actor_base.h @@ -123,6 +123,14 @@ protected: this->TaskRunner->GetRandomProvider() ); } + + const NYql::NDq::TTaskRunnerStatsBase* GetTaskRunnerStats() override { + return this->TaskRunner ? this->TaskRunner->GetStats() : nullptr; + } + + const NYql::NDq::TDqMeteringStats* GetMeteringStats() override { + return this->TaskRunner ? this->TaskRunner->GetMeteringStats() : nullptr; + } }; } //namespace NYql::NDq |
