summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsabdenovch <[email protected]>2025-09-10 23:18:19 +0300
committersabdenovch <[email protected]>2025-09-10 23:42:15 +0300
commit922003ece4579a034cc70774503977e67ee70e95 (patch)
tree114a1b7f7d713806527c5a7d2b44537c63e65cd8
parent14cd0df83fc8d216af876690c81d1ad8a7d6cd9a (diff)
YT-26156: Remove default statistics aggregation in select rows options
commit_hash:a0d11cc8f98b5a27d5b16c04b26c47711d283947
-rw-r--r--yt/yt/client/api/client_common.h2
-rw-r--r--yt/yt/client/api/rpc_proxy/client_base.cpp2
-rw-r--r--yt/yt/client/driver/table_commands.cpp2
3 files changed, 3 insertions, 3 deletions
diff --git a/yt/yt/client/api/client_common.h b/yt/yt/client/api/client_common.h
index a79eaac2d54..f949d0bc604 100644
--- a/yt/yt/client/api/client_common.h
+++ b/yt/yt/client/api/client_common.h
@@ -191,7 +191,7 @@ struct TSelectRowsOptions
//! Tune join row batch size.
std::optional<i64> MaxJoinBatchSize;
//! Determines the way statistics are aggregated across subqueries.
- NQueryClient::EStatisticsAggregation StatisticsAggregation = NQueryClient::EStatisticsAggregation::None;
+ std::optional<NQueryClient::EStatisticsAggregation> StatisticsAggregation;
//! Allow queries without any condition on key columns.
bool AllowFullScan = true;
//! Allow queries with join condition which implies foreign query with IN operator.
diff --git a/yt/yt/client/api/rpc_proxy/client_base.cpp b/yt/yt/client/api/rpc_proxy/client_base.cpp
index f5cb74ec6da..0db27f35de8 100644
--- a/yt/yt/client/api/rpc_proxy/client_base.cpp
+++ b/yt/yt/client/api/rpc_proxy/client_base.cpp
@@ -1113,7 +1113,7 @@ TFuture<TSelectRowsResult> TClientBase::SelectRows(
YT_OPTIONAL_SET_PROTO(req, use_lookup_cache, options.UseLookupCache);
req->set_expression_builder_version(options.ExpressionBuilderVersion);
req->set_use_order_by_in_join_subqueries(options.UseOrderByInJoinSubqueries);
- req->set_statistics_aggregation(ToProto(options.StatisticsAggregation));
+ YT_OPTIONAL_SET_PROTO(req, statistics_aggregation, options.StatisticsAggregation);
return req->Invoke().Apply(BIND([] (const TApiServiceProxy::TRspSelectRowsPtr& rsp) {
TSelectRowsResult result;
diff --git a/yt/yt/client/driver/table_commands.cpp b/yt/yt/client/driver/table_commands.cpp
index b0caa111544..f3937be86ea 100644
--- a/yt/yt/client/driver/table_commands.cpp
+++ b/yt/yt/client/driver/table_commands.cpp
@@ -960,7 +960,7 @@ void TSelectRowsCommand::Register(TRegistrar registrar)
})
.Optional(/*init*/ false);
- registrar.ParameterWithUniversalAccessor<EStatisticsAggregation>(
+ registrar.ParameterWithUniversalAccessor<std::optional<EStatisticsAggregation>>(
"statistics_aggregation",
[] (TThis* command) -> auto& {
return command->Options.StatisticsAggregation;