aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorpavook <pavook@yandex-team.com>2025-02-18 13:32:00 +0300
committerpavook <pavook@yandex-team.com>2025-02-18 14:56:02 +0300
commit8e5dc4835824a8639f0fed767f34a56187115232 (patch)
tree6d31da82801682b0daa0be4f24019c1f6f3be681
parent3f7bb4c26bcb890dc2217c24556422e39514f11f (diff)
downloadydb-8e5dc4835824a8639f0fed767f34a56187115232.tar.gz
Rename dummy signature classes to structs
- Class -> struct - Remove useless friends commit_hash:87aa0c648bf31795c35bac54d546df46611c8e1e
-rw-r--r--yt/yt/client/signature/generator.cpp6
-rw-r--r--yt/yt/client/signature/generator.h8
-rw-r--r--yt/yt/client/signature/public.h4
-rw-r--r--yt/yt/client/signature/signature.h12
-rw-r--r--yt/yt/client/signature/validator.cpp6
-rw-r--r--yt/yt/client/signature/validator.h3
6 files changed, 14 insertions, 25 deletions
diff --git a/yt/yt/client/signature/generator.cpp b/yt/yt/client/signature/generator.cpp
index 7a82cdd727..5687cd2b05 100644
--- a/yt/yt/client/signature/generator.cpp
+++ b/yt/yt/client/signature/generator.cpp
@@ -20,10 +20,9 @@ TSignaturePtr ISignatureGenerator::Sign(TYsonString data)
////////////////////////////////////////////////////////////////////////////////
-class TDummySignatureGenerator
+struct TDummySignatureGenerator
: public ISignatureGenerator
{
-public:
void Sign(const TSignaturePtr& signature) override
{
signature->Header_ = NYson::TYsonString("DummySignature"_sb);
@@ -37,10 +36,9 @@ ISignatureGeneratorPtr CreateDummySignatureGenerator()
////////////////////////////////////////////////////////////////////////////////
-class TAlwaysThrowingSignatureGenerator
+struct TAlwaysThrowingSignatureGenerator
: public ISignatureGenerator
{
-public:
void Sign(const TSignaturePtr& /*signature*/) override
{
THROW_ERROR_EXCEPTION("Signature generation is unsupported");
diff --git a/yt/yt/client/signature/generator.h b/yt/yt/client/signature/generator.h
index fe2f715272..6dc12eef9f 100644
--- a/yt/yt/client/signature/generator.h
+++ b/yt/yt/client/signature/generator.h
@@ -8,20 +8,14 @@ namespace NYT::NSignature {
////////////////////////////////////////////////////////////////////////////////
-class ISignatureGenerator
+struct ISignatureGenerator
: public TRefCounted
{
-public:
//! Fills out the Signature_ and Header_ fields in a given TSignature
//! based on its payload.
virtual void Sign(const TSignaturePtr& signature) = 0;
[[nodiscard]] TSignaturePtr Sign(NYson::TYsonString data);
-
-private:
- friend class TSignatureGenerator;
- friend class TDummySignatureGenerator;
- friend class TAlwaysThrowingSignatureGenerator;
};
DEFINE_REFCOUNTED_TYPE(ISignatureGenerator)
diff --git a/yt/yt/client/signature/public.h b/yt/yt/client/signature/public.h
index 845445d9e9..85a636fe49 100644
--- a/yt/yt/client/signature/public.h
+++ b/yt/yt/client/signature/public.h
@@ -10,8 +10,8 @@ DECLARE_REFCOUNTED_CLASS(TSignature)
///////////////////////////////////////////////////////////////////////////////
-DECLARE_REFCOUNTED_CLASS(ISignatureGenerator)
-DECLARE_REFCOUNTED_CLASS(ISignatureValidator)
+DECLARE_REFCOUNTED_STRUCT(ISignatureGenerator)
+DECLARE_REFCOUNTED_STRUCT(ISignatureValidator)
///////////////////////////////////////////////////////////////////////////////
diff --git a/yt/yt/client/signature/signature.h b/yt/yt/client/signature/signature.h
index 08882f2375..ea74bb8192 100644
--- a/yt/yt/client/signature/signature.h
+++ b/yt/yt/client/signature/signature.h
@@ -27,15 +27,15 @@ private:
NYson::TYsonString Payload_;
std::vector<std::byte> Signature_;
- friend class ISignatureGenerator;
+ friend struct ISignatureGenerator;
+ friend struct TDummySignatureGenerator;
+ friend struct TAlwaysThrowingSignatureGenerator;
friend class TSignatureGenerator;
- friend class TDummySignatureGenerator;
- friend class TAlwaysThrowingSignatureGenerator;
- friend class ISignatureValidator;
+ friend struct ISignatureValidator;
+ friend struct TDummySignatureValidator;
+ friend struct TAlwaysThrowingSignatureValidator;
friend class TSignatureValidator;
- friend class TDummySignatureValidator;
- friend class TAlwaysThrowingSignatureValidator;
friend void Serialize(const TSignature& signature, NYson::IYsonConsumer* consumer);
friend void Deserialize(TSignature& signature, NYTree::INodePtr node);
diff --git a/yt/yt/client/signature/validator.cpp b/yt/yt/client/signature/validator.cpp
index 156630f135..aebc42d488 100644
--- a/yt/yt/client/signature/validator.cpp
+++ b/yt/yt/client/signature/validator.cpp
@@ -8,10 +8,9 @@ namespace NYT::NSignature {
////////////////////////////////////////////////////////////////////////////////
-class TDummySignatureValidator
+struct TDummySignatureValidator
: public ISignatureValidator
{
-public:
TFuture<bool> Validate(const TSignaturePtr& signature) override
{
YT_VERIFY(signature->Header_.ToString() == "DummySignature");
@@ -26,10 +25,9 @@ ISignatureValidatorPtr CreateDummySignatureValidator()
////////////////////////////////////////////////////////////////////////////////
-class TAlwaysThrowingSignatureValidator
+struct TAlwaysThrowingSignatureValidator
: public ISignatureValidator
{
-public:
TFuture<bool> Validate(const TSignaturePtr& /*signature*/) override
{
THROW_ERROR_EXCEPTION("Signature validation is unsupported");
diff --git a/yt/yt/client/signature/validator.h b/yt/yt/client/signature/validator.h
index f1215e7d0c..94425001d3 100644
--- a/yt/yt/client/signature/validator.h
+++ b/yt/yt/client/signature/validator.h
@@ -10,10 +10,9 @@ namespace NYT::NSignature {
////////////////////////////////////////////////////////////////////////////////
-class ISignatureValidator
+struct ISignatureValidator
: public TRefCounted
{
-public:
virtual TFuture<bool> Validate(const TSignaturePtr& signature) = 0;
};