aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIvan <5627721+abyss7@users.noreply.github.com>2024-07-15 15:29:47 +0300
committerGitHub <noreply@github.com>2024-07-15 15:29:47 +0300
commit85d44959f34d0a1140b4314312977b33ec7d0a2e (patch)
tree4a0b6179fff13ccd58acc8a17e1bc93e33dde62e
parent47b767b1f9a1f1c16775ccf4409f978f866abacd (diff)
downloadydb-85d44959f34d0a1140b4314312977b33ec7d0a2e.tar.gz
[KIKIMR-21472] Output the final AST in explain query (#6487)
-rw-r--r--ydb/core/kqp/host/kqp_explain_prepared.cpp2
-rw-r--r--ydb/core/kqp/ut/olap/helpers/aggregation.h10
-rw-r--r--ydb/core/kqp/ut/olap/kqp_olap_ut.cpp6
3 files changed, 7 insertions, 11 deletions
diff --git a/ydb/core/kqp/host/kqp_explain_prepared.cpp b/ydb/core/kqp/host/kqp_explain_prepared.cpp
index 91ee362da0f..f76ce851140 100644
--- a/ydb/core/kqp/host/kqp_explain_prepared.cpp
+++ b/ydb/core/kqp/host/kqp_explain_prepared.cpp
@@ -66,7 +66,7 @@ public:
PhyQuerySetTxPlans(query, TKqpPhysicalQuery(TransformCtx->ExplainTransformerInput), std::move(TxResults),
ctx, Cluster, TransformCtx->Tables, TransformCtx->Config, TypeCtx, OptimizeCtx);
- query.SetQueryAst(KqpExprToPrettyString(*TransformCtx->ExplainTransformerInput, ctx));
+ query.SetQueryAst(KqpExprToPrettyString(*input, ctx));
TransformCtx->ExplainTransformerInput = nullptr;
return TStatus::Ok;
diff --git a/ydb/core/kqp/ut/olap/helpers/aggregation.h b/ydb/core/kqp/ut/olap/helpers/aggregation.h
index e83dcb32fd8..de9ab275fa7 100644
--- a/ydb/core/kqp/ut/olap/helpers/aggregation.h
+++ b/ydb/core/kqp/ut/olap/helpers/aggregation.h
@@ -81,12 +81,7 @@ private:
bool UseLlvm = true;
public:
void FillExpectedAggregationGroupByPlanOptions() {
-#if SSA_RUNTIME_VERSION >= 2U
- // AddExpectedPlanOptions("TKqpOlapAgg");
AddExpectedPlanOptions("WideCombiner");
-#else
- AddExpectedPlanOptions("CombineCore");
-#endif
}
TString GetFixedQuery() const {
TStringBuilder queryFixed;
@@ -177,7 +172,8 @@ void CheckPlanForAggregatePushdown(
const TString& query,
TClient& client,
const std::vector<std::string>& expectedPlanNodes,
- const std::string& readNodeType) {
+ const std::string& readNodeType)
+{
auto res = StreamExplainQuery(query, client);
UNIT_ASSERT_C(res.IsSuccess(), res.GetIssues().ToString());
@@ -242,4 +238,4 @@ void WriteTestDataForTableWithNulls(TKikimrRunner& kikimr, TString testTable);
void TestTableWithNulls(const std::vector<TAggregationTestCase>& cases, const bool genericQuery = false);
-} \ No newline at end of file
+}
diff --git a/ydb/core/kqp/ut/olap/kqp_olap_ut.cpp b/ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
index c54957614c1..3295ee8e104 100644
--- a/ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
+++ b/ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
@@ -2485,7 +2485,7 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
UNIT_ASSERT_C(result.GetStatus() == NYdb::EStatus::SUCCESS, result.GetIssues().ToString());
auto client = kikimr.GetQueryClient();
- {
+ {
auto prepareResult = client.ExecuteQuery(R"(
REPLACE INTO `/Root/ColumnShard` (a, b, c) VALUES
(1u, 1, 5),
@@ -2515,7 +2515,7 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
UNIT_ASSERT_C(plan.QueryStats->Getquery_ast().Contains("return (FromFlow (NarrowMap (WideFromBlocks"), plan.QueryStats->Getquery_ast());
break;
case NKikimrConfig::TTableServiceConfig_EBlockChannelsMode_BLOCK_CHANNELS_AUTO:
- UNIT_ASSERT_C(plan.QueryStats->Getquery_ast().Contains("return (FromFlow (ExpandMap (NarrowMap (WideFromBlocks"), plan.QueryStats->Getquery_ast());
+ UNIT_ASSERT_C(plan.QueryStats->Getquery_ast().Contains("return (FromFlow (WideFromBlocks"), plan.QueryStats->Getquery_ast());
break;
case NKikimrConfig::TTableServiceConfig_EBlockChannelsMode_BLOCK_CHANNELS_FORCE:
UNIT_ASSERT_C(plan.QueryStats->Getquery_ast().Contains("return (FromFlow (WideMap"), plan.QueryStats->Getquery_ast());
@@ -2523,7 +2523,7 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
}
}
- {
+ {
auto it = client.StreamExecuteQuery(R"(
SELECT
b, COUNT(*), SUM(a)