IGNIETFERRO-1969 Prepare to enable -Wrange-loop-construct

ref:7ff485b6411661e85a41dfabacdfa7665f5971e0

9 files changed, 38 insertions, 38 deletions

diff --git a/ydb/core/mind/bscontroller/config_fit_pdisks.cpp b/ydb/core/mind/bscontroller/config_fit_pdisks.cpp
index 53269e1dce..9690895321 100644
--- a/ydb/core/mind/bscontroller/config_fit_pdisks.cpp
+++ b/ydb/core/mind/bscontroller/config_fit_pdisks.cpp
@@ -255,7 +255,7 @@ namespace NKikimr {
         }
 
         void TBlobStorageController::FitPDisksForNode(TConfigState& state, ui32 nodeId, const std::vector<TSerial>& serials) {
-            for (TString serial : serials) {
+            for (const auto& serial : serials) {
                 if (const TDriveSerialInfo *driveInfo = state.DrivesSerials.Find(serial)) {
                     switch (driveInfo->LifeStage) {
                         case NKikimrBlobStorage::TDriveLifeStage::NOT_SEEN:
diff --git a/ydb/core/tx/columnshard/blob_manager.cpp b/ydb/core/tx/columnshard/blob_manager.cpp
index bf958b428a..991300843e 100644
--- a/ydb/core/tx/columnshard/blob_manager.cpp
+++ b/ydb/core/tx/columnshard/blob_manager.cpp
@@ -165,7 +165,7 @@ bool TBlobManager::LoadState(IBlobManagerDb& db) {
 
     // Build the list of steps that cannot be garbage collected before Keep flag is set on the blobs
     THashSet<TGenStep> genStepsWithBlobsToKeep;
-    for (const auto unifiedBlobId : blobsToKeep) {
+    for (const auto& unifiedBlobId : blobsToKeep) {
         Y_VERIFY(unifiedBlobId.IsDsBlob(), "Not a DS blob id in Keep table: %s", unifiedBlobId.ToStringNew().c_str());
 
         TLogoBlobID blobId = unifiedBlobId.GetLogoBlobId();
@@ -179,7 +179,7 @@ bool TBlobManager::LoadState(IBlobManagerDb& db) {
         BlobsToKeep.insert(blobId);
     }
 
-    for (const auto unifiedBlobId : blobsToDelete) {
+    for (const auto& unifiedBlobId : blobsToDelete) {
         if (unifiedBlobId.IsSmallBlob()) {
             SmallBlobsToDelete.insert(unifiedBlobId);
         } else if (unifiedBlobId.IsDsBlob()) {
diff --git a/ydb/core/tx/datashard/datashard_ut_erase_rows.cpp b/ydb/core/tx/datashard/datashard_ut_erase_rows.cpp
index 09dc2d8bf0..dcafb2e92f 100644
--- a/ydb/core/tx/datashard/datashard_ut_erase_rows.cpp
+++ b/ydb/core/tx/datashard/datashard_ut_erase_rows.cpp
@@ -281,7 +281,7 @@ void ConditionalEraseRows(
                 index.SetPathId(indexId.PathId.LocalPathId);
                 index.SetSchemaVersion(indexId.SchemaVersion);
 
-                for (const auto [indexColumnId, mainColumnId] : columnIds) {
+                for (const auto& [indexColumnId, mainColumnId] : columnIds) {
                     auto& keyMap = *index.MutableKeyMap()->Add();
                     keyMap.SetIndexColumnId(indexColumnId);
                     keyMap.SetMainColumnId(mainColumnId);
@@ -1714,7 +1714,7 @@ tkey = 100, key = 4
             auto ev = server->GetRuntime()->GrabEdgeEventRethrow<TEvResponse>(sender);
             UNIT_ASSERT_VALUES_EQUAL(ev->Get()->Record.GetStatus(), TEvResponse::ProtoRecordType::OK);
 
-            for (const auto index : opts.Indexes_) {
+            for (const auto& index : opts.Indexes_) {
                 do {
                     auto content = ReadShardedTable(server, Sprintf("/Root/%s/%s/indexImplTable", table, index.Name.c_str()));
 
diff --git a/ydb/library/binary_json/ut/container_ut.cpp b/ydb/library/binary_json/ut/container_ut.cpp
index b726079817..402076480d 100644
--- a/ydb/library/binary_json/ut/container_ut.cpp
+++ b/ydb/library/binary_json/ut/container_ut.cpp
@@ -34,7 +34,7 @@ public:
             {R"({"key": 1, "another": null})", EContainerType::Object},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.first);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
@@ -51,7 +51,7 @@ public:
             {R"({"key": true, "another_key": 2.34})", 2},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.first);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
@@ -77,7 +77,7 @@ public:
             {R"([1, {}, [], true, false, "string", null])", 6, "null"},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.Json);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
@@ -99,7 +99,7 @@ public:
             {R"([1, {}, [], true, false, "string", null])", {"1", "{}", "[]", "true", "false", "\"string\"", "null"}},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.Json);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
@@ -144,7 +144,7 @@ public:
             {R"({"one": 1, "two": 2, "three": 3, "four": 4})", "four", {"4"}},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.Json);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
@@ -185,7 +185,7 @@ public:
             }},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.Json);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
@@ -199,7 +199,7 @@ public:
 
             UNIT_ASSERT_VALUES_EQUAL(testCase.Result.size(), result.size());
 
-            for (const auto it : testCase.Result) {
+            for (const auto& it : testCase.Result) {
                 UNIT_ASSERT(result.contains(it.first));
                 UNIT_ASSERT_VALUES_EQUAL(result.at(it.first), it.second);
             }
diff --git a/ydb/library/binary_json/ut/entry_ut.cpp b/ydb/library/binary_json/ut/entry_ut.cpp
index c89534e97b..d9099b0f9f 100644
--- a/ydb/library/binary_json/ut/entry_ut.cpp
+++ b/ydb/library/binary_json/ut/entry_ut.cpp
@@ -32,7 +32,7 @@ public:
             {R"([{"key": 1, "another": null}])", EEntryType::Container},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.first);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
@@ -49,7 +49,7 @@ public:
             {R"([{"abc": 123, "def": 456}])", R"({"abc":123,"def":456})"},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.first);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
@@ -66,7 +66,7 @@ public:
             {R"(["string", "another", "string"])", "string"},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.first);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
@@ -85,7 +85,7 @@ public:
             {"[1.5, 2, 3, 1.5]", 1.5},
         };
 
-        for (const auto testCase : testCases) {
+        for (const auto& testCase : testCases) {
             const auto binaryJson = *SerializeToBinaryJson(testCase.first);
             const auto reader = TBinaryJsonReader::Make(binaryJson);
             const auto container = reader->GetRootCursor();
diff --git a/ydb/library/yql/minikql/comp_nodes/ut/mkql_wide_combine_ut.cpp b/ydb/library/yql/minikql/comp_nodes/ut/mkql_wide_combine_ut.cpp
index 1f566e6412..9a985d4d52 100644
--- a/ydb/library/yql/minikql/comp_nodes/ut/mkql_wide_combine_ut.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/ut/mkql_wide_combine_ut.cpp
@@ -329,7 +329,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
 
         double positive = 0.0, negative = 0.0;
         const auto t = TInstant::Now();
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             (sample.second > 0.0 ? positive : negative) += sample.second;
         }
         const auto cppTime = TInstant::Now() - t;
@@ -375,7 +375,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
 
         double pSum = 0.0, nSum = 0.0, pMax = 0.0, nMax = -1000.0, pMin = 1000.0, nMin = 0.0;
         const auto t = TInstant::Now();
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             if (sample.second > 0.0) {
                 pSum += sample.second;
                 pMax = std::max(pMax, sample.second);
@@ -442,7 +442,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
 
         std::unordered_map<i8, double> expects(201);
         const auto t = TInstant::Now();
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             expects.emplace(sample.first, 0.0).first->second += sample.second;
         }
         const auto cppTime = TInstant::Now() - t;
@@ -471,7 +471,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
         const auto graph = setup.BuildGraph(pgmReturn, {list});
         NUdf::TUnboxedValue* items = nullptr;
         graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(I8Samples.size(), items));
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             NUdf::TUnboxedValue* pair = nullptr;
             *items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
             pair[0] = NUdf::TUnboxedValuePod(sample.first);
@@ -500,7 +500,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
 
         std::unordered_map<i8, std::array<double, 3U>> expects(201);
         const auto t = TInstant::Now();
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             auto& item = expects.emplace(sample.first, std::array<double, 3U>{0.0, std::numeric_limits<double>::max(), std::numeric_limits<double>::min()}).first->second;
             std::get<0U>(item) += sample.second;
             std::get<1U>(item) = std::min(std::get<1U>(item), sample.second);
@@ -532,7 +532,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
         const auto graph = setup.BuildGraph(pgmReturn, {list});
         NUdf::TUnboxedValue* items = nullptr;
         graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(I8Samples.size(), items));
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             NUdf::TUnboxedValue* pair = nullptr;
             *items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
             pair[0] = NUdf::TUnboxedValuePod(sample.first);
@@ -564,7 +564,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
 
         std::unordered_map<std::string, double> expects(201);
         const auto t = TInstant::Now();
-        for (const auto sample : stringI8Samples) {
+        for (const auto& sample : stringI8Samples) {
             expects.emplace(sample.first, 0.0).first->second += sample.second;
         }
         const auto cppTime = TInstant::Now() - t;
@@ -1170,7 +1170,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
 
         double positive = 0.0, negative = 0.0;
         const auto t = TInstant::Now();
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             (sample.second > 0.0 ? positive : negative) += sample.second;
         }
         const auto cppTime = TInstant::Now() - t;
@@ -1216,7 +1216,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
 
         double pSum = 0.0, nSum = 0.0, pMax = 0.0, nMax = -1000.0, pMin = 1000.0, nMin = 0.0;
         const auto t = TInstant::Now();
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             if (sample.second > 0.0) {
                 pSum += sample.second;
                 pMax = std::max(pMax, sample.second);
@@ -1283,7 +1283,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
 
         std::unordered_map<i8, double> expects(201);
         const auto t = TInstant::Now();
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             expects.emplace(sample.first, 0.0).first->second += sample.second;
         }
         const auto cppTime = TInstant::Now() - t;
@@ -1312,7 +1312,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
         const auto graph = setup.BuildGraph(pgmReturn, {list});
         NUdf::TUnboxedValue* items = nullptr;
         graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(I8Samples.size(), items));
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             NUdf::TUnboxedValue* pair = nullptr;
             *items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
             pair[0] = NUdf::TUnboxedValuePod(sample.first);
@@ -1341,7 +1341,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
 
         std::unordered_map<i8, std::array<double, 3U>> expects(201);
         const auto t = TInstant::Now();
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             auto& item = expects.emplace(sample.first, std::array<double, 3U>{0.0, std::numeric_limits<double>::max(), std::numeric_limits<double>::min()}).first->second;
             std::get<0U>(item) += sample.second;
             std::get<1U>(item) = std::min(std::get<1U>(item), sample.second);
@@ -1373,7 +1373,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
         const auto graph = setup.BuildGraph(pgmReturn, {list});
         NUdf::TUnboxedValue* items = nullptr;
         graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(I8Samples.size(), items));
-        for (const auto sample : I8Samples) {
+        for (const auto& sample : I8Samples) {
             NUdf::TUnboxedValue* pair = nullptr;
             *items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
             pair[0] = NUdf::TUnboxedValuePod(sample.first);
diff --git a/ydb/library/yql/sql/v1/sql_ut.cpp b/ydb/library/yql/sql/v1/sql_ut.cpp
index b8b9e542c0..f3f39ca564 100644
--- a/ydb/library/yql/sql/v1/sql_ut.cpp
+++ b/ydb/library/yql/sql/v1/sql_ut.cpp
@@ -3757,9 +3757,9 @@ Y_UNIT_TEST_SUITE(JsonQuery) {
             {"EMPTY OBJECT", "'EmptyObject"},
         };
 
-        for (const auto wrap : wrapCases) {
-            for (const auto onError : handlerCases) {
-                for (const auto onEmpty : handlerCases) {
+        for (const auto& wrap : wrapCases) {
+            for (const auto& onError : handlerCases) {
+                for (const auto& onEmpty : handlerCases) {
                     TStringBuilder query;
                     query << R"($json = CAST(@@{"key": [123]}@@ as Json);
                     SELECT JSON_QUERY($json, "strict $.key" )" << wrap.first;
diff --git a/ydb/library/yql/udfs/common/url_base/lib/url_query.cpp b/ydb/library/yql/udfs/common/url_base/lib/url_query.cpp
index 6bbe3b8969..f78d5d738c 100644
--- a/ydb/library/yql/udfs/common/url_base/lib/url_query.cpp
+++ b/ydb/library/yql/udfs/common/url_base/lib/url_query.cpp
@@ -80,7 +80,7 @@ namespace NUrlUdf {
                                           const TUnboxedValuePod* args) const {
         const auto pairs = RunImpl(args);
         std::vector<TUnboxedValue> ret;
-        for (const auto nvPair : pairs) {
+        for (const auto& nvPair : pairs) {
             TUnboxedValue* pair = nullptr;
             auto item = valueBuilder->NewArray(2U, pair);
             pair[0] = valueBuilder->NewString(nvPair.first);
@@ -110,7 +110,7 @@ namespace NUrlUdf {
                                           const TUnboxedValuePod* args) const {
         const auto pairs = RunImpl(args);
         auto ret = valueBuilder->NewDict(DictType_, TDictFlags::Hashed | TDictFlags::Multi);
-        for (const auto nvPair : pairs) {
+        for (const auto& nvPair : pairs) {
             ret->Add(valueBuilder->NewString(nvPair.first),
                      valueBuilder->NewString(nvPair.second));
         }
diff --git a/ydb/public/lib/idx_test/idx_test_loader.cpp b/ydb/public/lib/idx_test/idx_test_loader.cpp
index 5e6b856b8f..001b081734 100644
--- a/ydb/public/lib/idx_test/idx_test_loader.cpp
+++ b/ydb/public/lib/idx_test/idx_test_loader.cpp
@@ -328,7 +328,7 @@ private:
 
             TVector<NYdb::TValue> values;
             TVector<TString> paramNames;
-            for (const auto col : p.second) {
+            for (const auto& col : p.second) {
                 const auto val = ::NIdxTest::CreateValue(col.first, *this);
 
                 checked.insert({col.first.Name, val});
@@ -488,7 +488,7 @@ public:
 
         TVector<NYdb::TValue> values;
         TVector<TString> paramNames;
-        for (const auto col : program.second) {
+        for (const auto& col : program.second) {
             values.push_back(::NIdxTest::CreateOptionalValue(col.first, *this));
             paramNames.push_back(col.second);
         }
@@ -570,7 +570,7 @@ private:
 
             TVector<NYdb::TValue> val;
             TVector<TString> parNames;
-            for (const auto col : p.second) {
+            for (const auto& col : p.second) {
                 val.push_back(rsParser.GetValue(col.first.Name));
                 auto vp = TValueParser(val.back());
                 vp.OpenOptional();
@@ -728,7 +728,7 @@ public:
 
         TVector<NYdb::TValue> values;
         TVector<TString> paramNames;
-        for (const auto col : program.second) {
+        for (const auto& col : program.second) {
             values.push_back(::NIdxTest::CreateOptionalValue(col.first, *this));
             paramNames.push_back(col.second);
         }