aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormdartemenko <mdartemenko@yandex-team.com>2022-08-22 12:05:55 +0300
committermdartemenko <mdartemenko@yandex-team.com>2022-08-22 12:05:55 +0300
commit80386d4cd0c19b3d6930768677e46f2d25536bcc (patch)
treece7d33bf031d07d8fb14658228a39ae50b0a5504
parent34a4f487c8a1ffe58fc9cf16cc577e24852b5955 (diff)
downloadydb-80386d4cd0c19b3d6930768677e46f2d25536bcc.tar.gz
Add KQP Scan Executer coverage
-rw-r--r--ydb/core/kqp/common/kqp_lwtrace_probes.h10
-rw-r--r--ydb/core/kqp/executer/kqp_scan_executer.cpp4
2 files changed, 8 insertions, 6 deletions
diff --git a/ydb/core/kqp/common/kqp_lwtrace_probes.h b/ydb/core/kqp/common/kqp_lwtrace_probes.h
index bc257ff1bf..16c80c9843 100644
--- a/ydb/core/kqp/common/kqp_lwtrace_probes.h
+++ b/ydb/core/kqp/common/kqp_lwtrace_probes.h
@@ -89,13 +89,13 @@ struct TQueryAction {
PROBE(KqpDataExecuterFinalize, GROUPS("KQP"), \
TYPES(ui64, ui64, ui64, ui64), \
NAMES("TxId", "lastCompletedShard", "ResultRows", "resultSize")) \
- PROBE(KqpDataExecuterReplyErrorAndDie, GROUPS("KQP"), \
+ PROBE(KqpScanExecuterStartExecute, GROUPS("KQP"), \
TYPES(ui64), \
NAMES("TxId")) \
- PROBE(KqpScanExecutorReplyErrorAndDie, GROUPS("KQP"), \
- TYPES(ui64), \
- NAMES("TxId")) \
- PROBE(KqpScanExecutorFinalize, GROUPS("KQP"), \
+ PROBE(KqpScanExecuterStartTasksAndTxs, GROUPS("KQP"), \
+ TYPES(ui64, ui64, ui64), \
+ NAMES("TxId", "tasksSize", "scansSize")) \
+ PROBE(KqpScanExecuterFinalize, GROUPS("KQP"), \
TYPES(ui64, ui64, TString, ui64), \
NAMES("TxId", "lastCompletedTask", "lastCompletedComputeActor", "ResultsSize")) \
PROBE(KqpLiteralExecuterReplyErrorAndDie, GROUPS("KQP"), \
diff --git a/ydb/core/kqp/executer/kqp_scan_executer.cpp b/ydb/core/kqp/executer/kqp_scan_executer.cpp
index 8a9d1ae957..9b7de40a8c 100644
--- a/ydb/core/kqp/executer/kqp_scan_executer.cpp
+++ b/ydb/core/kqp/executer/kqp_scan_executer.cpp
@@ -631,6 +631,7 @@ private:
}
void Execute() {
+ LWTRACK(KqpScanExecuterStartExecute, ResponseEv->Orbit, TxId);
auto& funcRegistry = *AppData()->FunctionRegistry;
NMiniKQL::TScopedAlloc alloc(TAlignedPagePoolCounters(), funcRegistry.SupportsSizedAllocators());
NMiniKQL::TTypeEnvironment typeEnv(alloc);
@@ -822,6 +823,7 @@ private:
}
void ExecuteScanTx(TVector<NYql::NDqProto::TDqTask>&& computeTasks, THashMap<ui64, TVector<NYql::NDqProto::TDqTask>>&& scanTasks) {
+ LWTRACK(KqpScanExecuterStartTasksAndTxs, ResponseEv->Orbit, TxId, computeTasks.size(), scanTasks.size());
LOG_D("Execute scan tx, computeTasks: " << computeTasks.size() << ", scanTasks: " << scanTasks.size());
for (const auto& [_, tasks]: scanTasks) {
for (const auto& task : tasks) {
@@ -873,7 +875,7 @@ private:
}
}
- LWTRACK(KqpScanExecutorFinalize, ResponseEv->Orbit, TxId, LastTaskId, LastComputeActorId, Results.size());
+ LWTRACK(KqpScanExecuterFinalize, ResponseEv->Orbit, TxId, LastTaskId, LastComputeActorId, Results.size());
LOG_D("Sending response to: " << Target);
Send(Target, ResponseEv.release());