diff options
| author | ivanmorozov <ivanmorozov@yandex-team.com> | 2023-07-26 18:07:19 +0300 |
|---|---|---|
| committer | ivanmorozov <ivanmorozov@yandex-team.com> | 2023-07-26 18:07:19 +0300 |
| commit | 7cc9580d8881325b06b56736e0e9aec36edfbddc (patch) | |
| tree | 8254718dd591c1a9ddfa96a7a2cef3c055ba68e4 | |
| parent | 74f9db80058e8292af239e50237370199ad2664e (diff) | |
| download | ydb-7cc9580d8881325b06b56736e0e9aec36edfbddc.tar.gz | |
add logging
| -rw-r--r-- | ydb/core/tx/columnshard/columnshard__scan.cpp | 4 | ||||
| -rw-r--r-- | ydb/core/tx/columnshard/engines/predicate/filter.cpp | 1 |
2 files changed, 4 insertions, 1 deletions
diff --git a/ydb/core/tx/columnshard/columnshard__scan.cpp b/ydb/core/tx/columnshard/columnshard__scan.cpp index 055835a161..d0a330c832 100644 --- a/ydb/core/tx/columnshard/columnshard__scan.cpp +++ b/ydb/core/tx/columnshard/columnshard__scan.cpp @@ -917,6 +917,7 @@ bool TTxScan::Execute(TTransactionContext& txc, const TActorContext& ctx) { for (auto& range: record.GetRanges()) { if (!FillPredicatesFromRange(read, range, ydbKey, Self->TabletID(), isIndexStats ? nullptr : &Self->TablesManager.GetIndexInfo())) { + ErrorDescription = "cannot fill predicates from range"; ReadMetadataRanges.clear(); return true; } @@ -924,6 +925,7 @@ bool TTxScan::Execute(TTransactionContext& txc, const TActorContext& ctx) { { auto newRange = CreateReadMetadata(read, isIndexStats, record.GetReverse(), itemsLimit); if (!newRange) { + ErrorDescription = "cannot create new range"; ReadMetadataRanges.clear(); return true; } @@ -974,7 +976,7 @@ void TTxScan::Complete(const TActorContext& ctx) { std::vector<NOlap::TReadMetadata::TConstPtr> rMetadataRanges; if (ReadMetadataRanges.empty()) { - LOG_S_DEBUG("TTxScan failed " + LOG_S_ERROR("TTxScan failed " << " txId: " << txId << " scanId: " << scanId << " gen: " << scanGen diff --git a/ydb/core/tx/columnshard/engines/predicate/filter.cpp b/ydb/core/tx/columnshard/engines/predicate/filter.cpp index 89bcdb2bb3..dbd1f61c0d 100644 --- a/ydb/core/tx/columnshard/engines/predicate/filter.cpp +++ b/ydb/core/tx/columnshard/engines/predicate/filter.cpp @@ -21,6 +21,7 @@ bool TPKRangesFilter::Add(std::shared_ptr<NOlap::TPredicate> f, std::shared_ptr< auto fromContainer = TPredicateContainer::BuildPredicateFrom(f, indexInfo); auto toContainer = TPredicateContainer::BuildPredicateTo(t, indexInfo); if (!fromContainer || !toContainer) { + AFL_ERROR(NKikimrServices::TX_COLUMNSHARD_SCAN)("event", "add_range_filter")("problem", "incorrect from/to containers")("from", !!fromContainer)("to", !!toContainer); return false; } if (SortedRanges.size() && !FakeRanges) { |