aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbabenko <babenko@yandex-team.com>2024-09-24 09:19:23 +0300
committerbabenko <babenko@yandex-team.com>2024-09-24 09:28:50 +0300
commit79f4eaeba6c32e55f7bb8ccd3b63415214bb7bd9 (patch)
treeb72a902e5c11b2c49caa98ccd5e9f041df3ec5b9
parent7b52d3a3ff9ea0bda3fb19634cdfb3a3ac6a52e2 (diff)
downloadydb-79f4eaeba6c32e55f7bb8ccd3b63415214bb7bd9.tar.gz
Fix UB in MakeWellKnownId
commit_hash:fbe7f38577500dd3efd682cc7b125ef99c5e3e1a
-rw-r--r--yt/yt/client/object_client/helpers-inl.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/yt/yt/client/object_client/helpers-inl.h b/yt/yt/client/object_client/helpers-inl.h
index 1aaa08b251..9d487edb19 100644
--- a/yt/yt/client/object_client/helpers-inl.h
+++ b/yt/yt/client/object_client/helpers-inl.h
@@ -123,14 +123,14 @@ inline TObjectId MakeSequoiaId(
inline TObjectId MakeWellKnownId(
EObjectType type,
TCellTag cellTag,
- ui64 counter /*= 0xffffffffffffffff*/)
+ ui64 counter)
{
YT_VERIFY(counter & WellKnownCounterMask);
return MakeId(
type,
cellTag,
counter,
- static_cast<ui32>(cellTag.Underlying() * 901517) ^ 0x140a8383);
+ static_cast<ui32>(static_cast<ui32>(cellTag.Underlying()) * 901517ULL ^ 0x140a8383ULL));
}
inline TObjectId MakeSchemaObjectId(