diff options
author | savnik <savnik@yandex-team.com> | 2023-08-24 08:45:57 +0300 |
---|---|---|
committer | savnik <savnik@yandex-team.com> | 2023-08-24 08:57:54 +0300 |
commit | 610e07b26011b26c73c60bf74b6ce63bb8fc73bc (patch) | |
tree | 63a35759b38ff883489bfc4e4a0a6642ed50447a | |
parent | 7526247f720278ccf551886eae7394d98eaf325e (diff) | |
download | ydb-610e07b26011b26c73c60bf74b6ce63bb8fc73bc.tar.gz |
Fix kafka auth in test
-rw-r--r-- | ydb/core/kafka_proxy/actors/kafka_sasl_auth_actor.cpp | 4 | ||||
-rw-r--r-- | ydb/core/kafka_proxy/ut/ut_protocol.cpp | 24 |
2 files changed, 19 insertions, 9 deletions
diff --git a/ydb/core/kafka_proxy/actors/kafka_sasl_auth_actor.cpp b/ydb/core/kafka_proxy/actors/kafka_sasl_auth_actor.cpp index 66227d2584..0ef26fed5f 100644 --- a/ydb/core/kafka_proxy/actors/kafka_sasl_auth_actor.cpp +++ b/ydb/core/kafka_proxy/actors/kafka_sasl_auth_actor.cpp @@ -61,7 +61,7 @@ void TKafkaSaslAuthActor::Handle(NKikimr::TEvTicketParser::TEvAuthorizeTicketRes Die(ctx); } -void TKafkaSaslAuthActor::Handle(TEvPrivate::TEvTokenReady::TPtr& ev, const NActors::TActorContext&) { +void TKafkaSaslAuthActor::Handle(TEvPrivate::TEvTokenReady::TPtr& ev, const NActors::TActorContext& /*ctx*/) { Send(NKikimr::MakeTicketParserID(), new NKikimr::TEvTicketParser::TEvAuthorizeTicket({ .Database = ev->Get()->Database, .Ticket = ev->Get()->LoginResult.token(), @@ -133,7 +133,7 @@ void TKafkaSaslAuthActor::SendLoginRequest(TKafkaSaslAuthActor::TAuthData authDa auto tokenReadyEvent = std::make_unique<TEvPrivate::TEvTokenReady>(); response.operation().result().UnpackTo(&(tokenReadyEvent->LoginResult)); tokenReadyEvent->Database = authData.Database; - actorSystem->Send(selfId, tokenReadyEvent.release()); + actorSystem->Schedule(TDuration::Seconds(1), new IEventHandle(selfId, selfId, tokenReadyEvent.release())); // FIXME(savnik): replace Schedule to Send } else { auto authFailedEvent = std::make_unique<TEvPrivate::TEvAuthFailed>(); if (response.operation().issues_size() > 0) { diff --git a/ydb/core/kafka_proxy/ut/ut_protocol.cpp b/ydb/core/kafka_proxy/ut/ut_protocol.cpp index 8b6df0c716..4d4c5724e9 100644 --- a/ydb/core/kafka_proxy/ut/ut_protocol.cpp +++ b/ydb/core/kafka_proxy/ut/ut_protocol.cpp @@ -62,9 +62,11 @@ public: TTestServer() { TPortManager portManager; - Port = 9090; // portManager.GetTcpPort(); + Port = portManager.GetTcpPort(); NKikimrConfig::TAppConfig appConfig; + appConfig.MutableAuthConfig()->SetUseLoginProvider(true); + appConfig.MutableAuthConfig()->SetUseBlackBox(false); appConfig.MutablePQConfig()->SetTopicsAreFirstClassCitizen(true); appConfig.MutablePQConfig()->SetEnabled(true); // NOTE(shmel1k@): KIKIMR-14221 @@ -114,7 +116,15 @@ public: if (secure) { appConfig.MutablePQConfig()->SetRequireCredentialsInNewProtocol(true); } - KikimrServer = std::make_unique<TKikimr>(std::move(appConfig)); + KikimrServer = std::unique_ptr<TKikimr>(new TKikimr( + std::move(appConfig), + {}, + {}, + false, + nullptr, + nullptr, + 0) + ); KikimrServer->GetRuntime()->SetLogPriority(NKikimrServices::KAFKA_PROXY, NActors::NLog::PRI_DEBUG); ui16 grpc = KikimrServer->GetPort(); @@ -145,8 +155,8 @@ public: {"cloud_id", DEFAULT_CLOUD_ID}, {"database_id", "root"}})); - //auto status = client.CreateUser("/Root", "ouruser", "ourUserPassword"); - //UNIT_ASSERT_VALUES_EQUAL(status, NMsgBusProxy::MSTATUS_OK); + auto status = client.CreateUser("/Root", "ouruser", "ourUserPassword"); + UNIT_ASSERT_VALUES_EQUAL(status, NMsgBusProxy::MSTATUS_OK); } public: @@ -271,7 +281,7 @@ Y_UNIT_TEST_SUITE(KafkaProtocol) { { Cerr << ">>>>> SaslAuthenticateRequestData"; - char authBytes[] = "ignored\0ourUser@/Root\0ourUserPassword"; + char authBytes[] = "ignored\0ouruser@/Root\0ourUserPassword"; TRequestHeaderData header; header.RequestApiKey = NKafka::EApiKey::SASL_AUTHENTICATE; @@ -286,9 +296,9 @@ Y_UNIT_TEST_SUITE(KafkaProtocol) { auto response = Read(si, &header); Y_UNUSED(response); - //auto* msg = dynamic_cast<TSaslAuthenticateResponseData*>(response.get()); + auto* msg = dynamic_cast<TSaslAuthenticateResponseData*>(response.get()); - //UNIT_ASSERT_VALUES_EQUAL(msg->ErrorCode, static_cast<TKafkaInt16>(EKafkaErrors::NONE_ERROR)); + UNIT_ASSERT_VALUES_EQUAL(msg->ErrorCode, static_cast<TKafkaInt16>(EKafkaErrors::NONE_ERROR)); } } }
\ No newline at end of file |