diff options
| author | Aleksey Myasnikov <asmyasnikov@ydb.tech> | 2024-11-20 03:26:58 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-20 03:26:58 +0300 |
| commit | 5b45c7497248b94d579ecaf8c43cdb997e1e66c0 (patch) | |
| tree | c5f83e834ba82d773adb7401673f9da1d8397106 | |
| parent | fef9bc2801129afea020f8aa69e2ce2733ce78aa (diff) | |
| download | ydb-5b45c7497248b94d579ecaf8c43cdb997e1e66c0.tar.gz | |
Added enable_antlr4_parser feature flag (#11764)
| -rw-r--r-- | ydb/core/kqp/host/kqp_host.cpp | 2 | ||||
| -rw-r--r-- | ydb/core/kqp/provider/yql_kikimr_settings.cpp | 1 | ||||
| -rw-r--r-- | ydb/core/kqp/provider/yql_kikimr_settings.h | 1 | ||||
| -rw-r--r-- | ydb/core/protos/feature_flags.proto | 1 | ||||
| -rw-r--r-- | ydb/core/testlib/basics/feature_flags.h | 1 |
5 files changed, 5 insertions, 1 deletions
diff --git a/ydb/core/kqp/host/kqp_host.cpp b/ydb/core/kqp/host/kqp_host.cpp index 68e0b17b74..4055755b9f 100644 --- a/ydb/core/kqp/host/kqp_host.cpp +++ b/ydb/core/kqp/host/kqp_host.cpp @@ -1295,7 +1295,7 @@ private: .SetQueryParameters(query.ParameterTypes) .SetApplicationName(ApplicationName) .SetIsEnablePgSyntax(SessionCtx->Config().FeatureFlags.GetEnablePgSyntax()) - .SetIsEnableAntlr4Parser(SessionCtx->Config().EnableAntlr4Parser); + .SetIsEnableAntlr4Parser(SessionCtx->Config().FeatureFlags.GetEnableAntlr4Parser() || SessionCtx->Config().EnableAntlr4Parser); NSQLTranslation::TTranslationSettings effectiveSettings; auto astRes = ParseQuery( query.Text, diff --git a/ydb/core/kqp/provider/yql_kikimr_settings.cpp b/ydb/core/kqp/provider/yql_kikimr_settings.cpp index 4598d36f0b..e720d06977 100644 --- a/ydb/core/kqp/provider/yql_kikimr_settings.cpp +++ b/ydb/core/kqp/provider/yql_kikimr_settings.cpp @@ -59,6 +59,7 @@ TKikimrConfiguration::TKikimrConfiguration() { REGISTER_SETTING(*this, _KqpSlowLogNoticeThresholdMs); REGISTER_SETTING(*this, _KqpSlowLogTraceThresholdMs); REGISTER_SETTING(*this, _KqpYqlSyntaxVersion); + REGISTER_SETTING(*this, _KqpYqlAntlr4Parser); REGISTER_SETTING(*this, _KqpAllowUnsafeCommit); REGISTER_SETTING(*this, _KqpMaxComputeActors); REGISTER_SETTING(*this, _KqpEnableSpilling); diff --git a/ydb/core/kqp/provider/yql_kikimr_settings.h b/ydb/core/kqp/provider/yql_kikimr_settings.h index 3eaeffa987..85c5a88295 100644 --- a/ydb/core/kqp/provider/yql_kikimr_settings.h +++ b/ydb/core/kqp/provider/yql_kikimr_settings.h @@ -34,6 +34,7 @@ struct TKikimrSettings { NCommon::TConfSetting<ui32, false> _KqpSlowLogNoticeThresholdMs; NCommon::TConfSetting<ui32, false> _KqpSlowLogTraceThresholdMs; NCommon::TConfSetting<ui32, false> _KqpYqlSyntaxVersion; + NCommon::TConfSetting<bool, false> _KqpYqlAntlr4Parser; NCommon::TConfSetting<bool, false> _KqpAllowUnsafeCommit; NCommon::TConfSetting<ui32, false> _KqpMaxComputeActors; NCommon::TConfSetting<bool, false> _KqpEnableSpilling; diff --git a/ydb/core/protos/feature_flags.proto b/ydb/core/protos/feature_flags.proto index 13a2c2908f..ba5e0b87a6 100644 --- a/ydb/core/protos/feature_flags.proto +++ b/ydb/core/protos/feature_flags.proto @@ -176,4 +176,5 @@ message TFeatureFlags { optional bool EnableTopicAutopartitioningForReplication = 151 [default = false]; optional bool EnableDriveSerialsDiscovery = 152 [default = false]; optional bool EnableSeparateDiskSpaceQuotas = 153 [default = false]; + optional bool EnableAntlr4Parser = 154 [default = false]; } diff --git a/ydb/core/testlib/basics/feature_flags.h b/ydb/core/testlib/basics/feature_flags.h index 0d2509d2e8..2d499e1ce9 100644 --- a/ydb/core/testlib/basics/feature_flags.h +++ b/ydb/core/testlib/basics/feature_flags.h @@ -65,6 +65,7 @@ public: FEATURE_FLAG_SETTER(EnableBackupService) FEATURE_FLAG_SETTER(EnableGranularTimecast) FEATURE_FLAG_SETTER(EnablePgSyntax) + FEATURE_FLAG_SETTER(EnableAntlr4Parser) FEATURE_FLAG_SETTER(EnableTieringInColumnShard) FEATURE_FLAG_SETTER(EnableMetadataObjectsOnServerless) FEATURE_FLAG_SETTER(EnableOlapCompression) |