diff options
author | Maxim Yurchuk <maxim-yurchuk@ydb.tech> | 2024-08-02 11:04:37 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-02 11:04:37 +0300 |
commit | 4c6a56a4b9408e3cf99d9c5257c68a03d4ae6456 (patch) | |
tree | e645b0069268d3a71ce082cdee1aaf1380805158 | |
parent | 32f9fe752f1fbe0e011493fc5405e5a0652356ce (diff) | |
download | ydb-4c6a56a4b9408e3cf99d9c5257c68a03d4ae6456.tar.gz |
Transitional flag FIX_UNUSED_PARAMETR_PLS=1 (devtools request) (#7330)
23 files changed, 30 insertions, 29 deletions
diff --git a/build/internal/ya.conf b/build/internal/ya.conf index ddc81877de..02bd04e89d 100644 --- a/build/internal/ya.conf +++ b/build/internal/ya.conf @@ -22,3 +22,5 @@ USE_ICONV = "static" USE_IDN = "static" APPLE_SDK_LOCAL = "yes" CFLAGS = "-fno-omit-frame-pointer" +# TODO: uncomment after warnings fix +# FIX_UNUSED_PARAMETR_PLS = "1" # 31 jul 2024. Transitional flag for protobuf fix, DTCC-2275
\ No newline at end of file diff --git a/ydb/core/blobstorage/nodewarden/node_warden_pdisk.cpp b/ydb/core/blobstorage/nodewarden/node_warden_pdisk.cpp index e68c9ae7bb..50cbf37247 100644 --- a/ydb/core/blobstorage/nodewarden/node_warden_pdisk.cpp +++ b/ydb/core/blobstorage/nodewarden/node_warden_pdisk.cpp @@ -485,7 +485,7 @@ namespace NKikimr::NStorage { Become(&TThis::StateFunc, TDuration::Seconds(10), new TEvents::TEvWakeup); } - void Handle(TEvents::TEvUndelivered::TPtr ev) { + void Handle(TEvents::TEvUndelivered::TPtr /*ev*/) { // send this event again, this may be a race with PDisk destruction TActivationContext::Send(OriginalEv.release()); PassAway(); diff --git a/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl_metadata.cpp b/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl_metadata.cpp index 4d7e62cd63..735de1629d 100644 --- a/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl_metadata.cpp +++ b/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl_metadata.cpp @@ -70,7 +70,7 @@ namespace NKikimr::NPDisk { Release(actorSystem); } - void Release(TActorSystem *actorSystem) override { + void Release(TActorSystem * /*actorSystem*/) override { delete this; } }; @@ -231,7 +231,7 @@ namespace NKikimr::NPDisk { bool CanHandleResult() const override { return true; } - void Exec(TActorSystem *actorSystem) override { + void Exec(TActorSystem * /*actorSystem*/) override { LOG_DEBUG_S(*PDisk->ActorSystem, NKikimrServices::BS_PDISK, "PDiskId# " << PDisk->PDiskId << " TCompletionWriteUnformattedMetadata::Exec" << " Result# " << Result diff --git a/ydb/core/config/tools/protobuf_plugin/main.cpp b/ydb/core/config/tools/protobuf_plugin/main.cpp index a77cc65548..4ad888d4d0 100644 --- a/ydb/core/config/tools/protobuf_plugin/main.cpp +++ b/ydb/core/config/tools/protobuf_plugin/main.cpp @@ -44,8 +44,7 @@ private: return name; } - TString ConstructFullFieldPath(const TDeque<const FieldDescriptor*>& fieldPath, const FieldDescriptor* field) const { - + TString ConstructFullFieldPath(const TDeque<const FieldDescriptor*>& fieldPath, const FieldDescriptor* /*field*/) const { TVector<TString> path; path.push_back(""); for (size_t i = 1; i < fieldPath.size(); ++i) { diff --git a/ydb/core/formats/arrow/accessor/composite/accessor.h b/ydb/core/formats/arrow/accessor/composite/accessor.h index 9c981b008d..9b253b265e 100644 --- a/ydb/core/formats/arrow/accessor/composite/accessor.h +++ b/ydb/core/formats/arrow/accessor/composite/accessor.h @@ -21,7 +21,7 @@ protected: return {}; } - virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 index) const override { + virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 /*index*/) const override { AFL_VERIFY(false)("problem", "cannot use method"); return nullptr; } diff --git a/ydb/core/formats/arrow/accessor/composite_serial/accessor.h b/ydb/core/formats/arrow/accessor/composite_serial/accessor.h index 0152b5a94c..976e8cb91c 100644 --- a/ydb/core/formats/arrow/accessor/composite_serial/accessor.h +++ b/ydb/core/formats/arrow/accessor/composite_serial/accessor.h @@ -60,7 +60,7 @@ protected: return {}; } - virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 index) const override { + virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 /*index*/) const override { AFL_VERIFY(false)("problem", "cannot use method"); return nullptr; } diff --git a/ydb/core/formats/arrow/accessor/plain/accessor.h b/ydb/core/formats/arrow/accessor/plain/accessor.h index 0911d844cd..323073dc07 100644 --- a/ydb/core/formats/arrow/accessor/plain/accessor.h +++ b/ydb/core/formats/arrow/accessor/plain/accessor.h @@ -12,7 +12,7 @@ private: protected: virtual std::optional<ui64> DoGetRawSize() const override; - virtual TLocalDataAddress DoGetLocalData(const std::optional<TCommonChunkAddress>& /*chunkCurrent*/, const ui64 position) const override { + virtual TLocalDataAddress DoGetLocalData(const std::optional<TCommonChunkAddress>& /*chunkCurrent*/, const ui64 /*position*/) const override { return TLocalDataAddress(Array, 0, 0); } virtual std::shared_ptr<arrow::ChunkedArray> DoGetChunkedArray() const override { diff --git a/ydb/core/formats/arrow/accessor/sparsed/accessor.h b/ydb/core/formats/arrow/accessor/sparsed/accessor.h index 6c8fbe7c07..e3476d9195 100644 --- a/ydb/core/formats/arrow/accessor/sparsed/accessor.h +++ b/ydb/core/formats/arrow/accessor/sparsed/accessor.h @@ -115,7 +115,7 @@ protected: return bytes; } - TSparsedArray(std::vector<TSparsedArrayChunk>&& data, const std::shared_ptr<arrow::Scalar>& defaultValue, + TSparsedArray(std::vector<TSparsedArrayChunk>&& data, const std::shared_ptr<arrow::Scalar>& /*defaultValue*/, const std::shared_ptr<arrow::DataType>& type, const ui32 recordsCount) : TBase(recordsCount, EType::SparsedArray, type) , Records(std::move(data)) { diff --git a/ydb/core/formats/arrow/accessor/sparsed/constructor.cpp b/ydb/core/formats/arrow/accessor/sparsed/constructor.cpp index 379f6473f8..e3f45cd753 100644 --- a/ydb/core/formats/arrow/accessor/sparsed/constructor.cpp +++ b/ydb/core/formats/arrow/accessor/sparsed/constructor.cpp @@ -27,7 +27,7 @@ NKikimrArrowAccessorProto::TConstructor TConstructor::DoSerializeToProto() const return result; } -bool TConstructor::DoDeserializeFromProto(const NKikimrArrowAccessorProto::TConstructor& proto) { +bool TConstructor::DoDeserializeFromProto(const NKikimrArrowAccessorProto::TConstructor& /*proto*/) { return true; } diff --git a/ydb/core/formats/arrow/reader/position.h b/ydb/core/formats/arrow/reader/position.h index 37580cd3a7..ef5c0990eb 100644 --- a/ydb/core/formats/arrow/reader/position.h +++ b/ydb/core/formats/arrow/reader/position.h @@ -97,7 +97,7 @@ public: return PositionAddress[colIdx].GetAddress().GetLocalIndex(pos); } - std::shared_ptr<TSortableScanData> BuildCopy(const ui64 position) const { + std::shared_ptr<TSortableScanData> BuildCopy(const ui64 /*position*/) const { return std::make_shared<TSortableScanData>(*this); } diff --git a/ydb/core/grpc_services/rpc_alter_table.cpp b/ydb/core/grpc_services/rpc_alter_table.cpp index a33a030fc9..799157a0b1 100644 --- a/ydb/core/grpc_services/rpc_alter_table.cpp +++ b/ydb/core/grpc_services/rpc_alter_table.cpp @@ -228,7 +228,7 @@ private: Send(schemeCache, ev); } - void Navigate(const TTableId& pathId, const TActorContext& ctx) { + void Navigate(const TTableId& pathId, const TActorContext& /*ctx*/) { DatabaseName = Request_->GetDatabaseName() .GetOrElse(DatabaseFromDomain(AppData())); diff --git a/ydb/core/persqueue/read_balancer__balancing.cpp b/ydb/core/persqueue/read_balancer__balancing.cpp index d533cc1f80..1eb8361074 100644 --- a/ydb/core/persqueue/read_balancer__balancing.cpp +++ b/ydb/core/persqueue/read_balancer__balancing.cpp @@ -1827,7 +1827,7 @@ void TBalancer::Handle(TEvPQ::TEvBalanceConsumer::TPtr& ev, const TActorContext& } } -void TBalancer::Handle(TEvPersQueue::TEvStatusResponse::TPtr& ev, const TActorContext& ctx) { +void TBalancer::Handle(TEvPersQueue::TEvStatusResponse::TPtr& ev, const TActorContext& /*ctx*/) { const auto& record = ev->Get()->Record; for (const auto& partResult : record.GetPartResult()) { for (const auto& consumerResult : partResult.GetConsumerResult()) { diff --git a/ydb/core/statistics/aggregator/tx_ack_timeout.cpp b/ydb/core/statistics/aggregator/tx_ack_timeout.cpp index 6afa1bd86a..d83ce5b10d 100644 --- a/ydb/core/statistics/aggregator/tx_ack_timeout.cpp +++ b/ydb/core/statistics/aggregator/tx_ack_timeout.cpp @@ -9,7 +9,7 @@ struct TStatisticsAggregator::TTxAckTimeout : public TTxBase { TTxType GetTxType() const override { return TXTYPE_ACK_TIMEOUT; } - bool Execute(TTransactionContext& txc, const TActorContext&) override { + bool Execute(TTransactionContext& /*txc*/, const TActorContext&) override { SA_LOG_D("[" << Self->TabletID() << "] TTxAckTimeout::Execute"); return true; } diff --git a/ydb/core/statistics/aggregator/tx_analyze_table.cpp b/ydb/core/statistics/aggregator/tx_analyze_table.cpp index 4fc965ac61..e27bc5d578 100644 --- a/ydb/core/statistics/aggregator/tx_analyze_table.cpp +++ b/ydb/core/statistics/aggregator/tx_analyze_table.cpp @@ -50,7 +50,7 @@ struct TStatisticsAggregator::TTxAnalyzeTable : public TTxBase { return true; } - void Complete(const TActorContext& ctx) override { + void Complete(const TActorContext& /*ctx*/) override { SA_LOG_D("[" << Self->TabletID() << "] TTxAnalyzeTable::Complete"); } }; diff --git a/ydb/core/statistics/aggregator/ut/ut_traverse_columnshard.cpp b/ydb/core/statistics/aggregator/ut/ut_traverse_columnshard.cpp index fe7da8cf14..d46e892733 100644 --- a/ydb/core/statistics/aggregator/ut/ut_traverse_columnshard.cpp +++ b/ydb/core/statistics/aggregator/ut/ut_traverse_columnshard.cpp @@ -55,7 +55,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) { auto sender = runtime.AllocateEdgeActor(); int observerCount = 0; auto observer = runtime.AddObserver<TEvTxProxySchemeCache::TEvResolveKeySetResult>( - [&](TEvTxProxySchemeCache::TEvResolveKeySetResult::TPtr& ev) + [&](TEvTxProxySchemeCache::TEvResolveKeySetResult::TPtr& /*ev*/) { if (observerCount++ == 2) { RebootTablet(runtime, saTabletId, sender); @@ -89,7 +89,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) { auto sender = runtime.AllocateEdgeActor(); bool observerFirstExec = true; auto observer = runtime.AddObserver<TEvHive::TEvRequestTabletDistribution>( - [&](TEvHive::TEvRequestTabletDistribution::TPtr& ev) + [&](TEvHive::TEvRequestTabletDistribution::TPtr& /*ev*/) { if (observerFirstExec) { observerFirstExec = false; @@ -124,7 +124,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) { auto sender = runtime.AllocateEdgeActor(); bool observerFirstExec = true; auto observer = runtime.AddObserver<TEvStatistics::TEvAggregateStatistics>( - [&](TEvStatistics::TEvAggregateStatistics::TPtr& ev) + [&](TEvStatistics::TEvAggregateStatistics::TPtr& /*ev*/) { if (observerFirstExec) { observerFirstExec = false; @@ -159,7 +159,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) { auto sender = runtime.AllocateEdgeActor(); bool observerFirstExec = true; auto observer = runtime.AddObserver<TEvStatistics::TEvAggregateStatisticsResponse>( - [&](TEvStatistics::TEvAggregateStatisticsResponse::TPtr& ev) + [&](TEvStatistics::TEvAggregateStatisticsResponse::TPtr& /*ev*/) { if (observerFirstExec) { observerFirstExec = false; @@ -194,7 +194,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) { auto sender = runtime.AllocateEdgeActor(); int observerCount = 0; auto observer = runtime.AddObserver<TEvStatistics::TEvStatisticsRequest>( - [&](TEvStatistics::TEvStatisticsRequest::TPtr& ev) + [&](TEvStatistics::TEvStatisticsRequest::TPtr& /*ev*/) { if (observerCount++ == 5) { RebootTablet(runtime, saTabletId, sender); diff --git a/ydb/core/tx/columnshard/engines/changes/indexation.cpp b/ydb/core/tx/columnshard/engines/changes/indexation.cpp index a59798ff9f..1e0ffca320 100644 --- a/ydb/core/tx/columnshard/engines/changes/indexation.cpp +++ b/ydb/core/tx/columnshard/engines/changes/indexation.cpp @@ -51,7 +51,7 @@ private: YDB_READONLY_DEF(std::shared_ptr<NArrow::TGeneralContainer>, Batch); public: - TBatchInfo(const std::shared_ptr<NArrow::TGeneralContainer>& batch, const NEvWrite::EModificationType modificationType) + TBatchInfo(const std::shared_ptr<NArrow::TGeneralContainer>& batch, const NEvWrite::EModificationType /*modificationType*/) : Batch(batch) { } }; diff --git a/ydb/core/tx/columnshard/engines/scheme/abstract/index_info.h b/ydb/core/tx/columnshard/engines/scheme/abstract/index_info.h index e54bcd80b2..496a7533d4 100644 --- a/ydb/core/tx/columnshard/engines/scheme/abstract/index_info.h +++ b/ydb/core/tx/columnshard/engines/scheme/abstract/index_info.h @@ -165,7 +165,7 @@ public: fieldId == (ui32)ESpecialColumn::DELETE_FLAG; } - static bool IsNullableVerified(const ui32 fieldId) { + static bool IsNullableVerified(const ui32 /*fieldId*/) { return false; } diff --git a/ydb/core/tx/datashard/build_index.cpp b/ydb/core/tx/datashard/build_index.cpp index 70e1bd1567..e8b2e8ff5b 100644 --- a/ydb/core/tx/datashard/build_index.cpp +++ b/ydb/core/tx/datashard/build_index.cpp @@ -283,7 +283,7 @@ protected: } template <typename TAddRow> - EScan FeedImpl(TArrayRef<const TCell> key, const TRow& row, TAddRow&& addRow) noexcept { + EScan FeedImpl(TArrayRef<const TCell> key, const TRow& /*row*/, TAddRow&& addRow) noexcept { LOG_T("Feed key " << DebugPrintPoint(KeyTypes, key, *AppData()->TypeRegistry) << " " << Debug()); addRow(); @@ -440,7 +440,7 @@ private: } } - void HandleWakeup(const NActors::TActorContext& ctx) { + void HandleWakeup(const NActors::TActorContext& /*ctx*/) { LOG_D("Retry upload " << Debug()); if (!WriteBuf.IsEmpty()) { diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_apply_build_index.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_apply_build_index.cpp index e7ac9c79cc..65473da7a2 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_apply_build_index.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_apply_build_index.cpp @@ -28,7 +28,7 @@ ISubOperation::TPtr FinalizeIndexImplTable(TOperationContext& context, const TPa return CreateFinalizeBuildIndexImplTable(partId, transaction); } -ISubOperation::TPtr DropIndexImplTable(TOperationContext& context, const TPath& index, const TOperationId& nextId, const TOperationId& partId, const TString& name, const TPathId& pathId) { +ISubOperation::TPtr DropIndexImplTable(TOperationContext& /*context*/, const TPath& index, const TOperationId& nextId, const TOperationId& partId, const TString& name, const TPathId& pathId) { TPath implTable = index.Child(name); Y_ABORT_UNLESS(implTable->PathId == pathId); Y_ABORT_UNLESS(implTable.LeafName() == name); diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_restore_incremental_backup.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_restore_incremental_backup.cpp index b9c69cea34..0cb5378b49 100644 --- a/ydb/core/tx/schemeshard/schemeshard__operation_create_restore_incremental_backup.cpp +++ b/ydb/core/tx/schemeshard/schemeshard__operation_create_restore_incremental_backup.cpp @@ -16,7 +16,7 @@ const char* IB_RESTORE_CDC_STREAM_NAME = "__ib_restore_stream"; namespace NKikimr::NSchemeShard { -void DoCreateLock(const TOperationId opId, const TPath& workingDirPath, const TPath& tablePath, bool allowIndexImplLock, +void DoCreateLock(const TOperationId opId, const TPath& workingDirPath, const TPath& tablePath, bool /*allowIndexImplLock*/, TVector<ISubOperation::TPtr>& result) { auto outTx = TransactionTemplate(workingDirPath.PathString(), diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp index 850853669c..34e5dfa3a4 100644 --- a/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp +++ b/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp @@ -132,7 +132,7 @@ struct TCombinerNodes { } } - void ConsumeRawData(TComputationContext& ctx, NUdf::TUnboxedValue* keys, NUdf::TUnboxedValue** from, NUdf::TUnboxedValue* to) const { + void ConsumeRawData(TComputationContext& /*ctx*/, NUdf::TUnboxedValue* keys, NUdf::TUnboxedValue** from, NUdf::TUnboxedValue* to) const { std::fill_n(keys, KeyResultNodes.size(), NUdf::TUnboxedValuePod()); for (ui32 i = 0U; i < ItemNodes.size(); ++i) { if (from[i] && IsInputItemNodeUsed(i)) { diff --git a/ydb/library/yql/providers/yt/lib/res_pull/res_or_pull.cpp b/ydb/library/yql/providers/yt/lib/res_pull/res_or_pull.cpp index 6bac7ef94e..9dcf7dffcd 100644 --- a/ydb/library/yql/providers/yt/lib/res_pull/res_or_pull.cpp +++ b/ydb/library/yql/providers/yt/lib/res_pull/res_or_pull.cpp @@ -185,7 +185,7 @@ void TSkiffExecuteResOrPull::WriteValue(const NUdf::TUnboxedValue& value, TType* } } -bool TSkiffExecuteResOrPull::WriteNext(TMkqlIOCache& specsCache, const NYT::TNode& rec, ui32 tableIndex) { +bool TSkiffExecuteResOrPull::WriteNext(TMkqlIOCache& specsCache, const NYT::TNode& rec, ui32 /*tableIndex*/) { if (!HasCapacity()) { Truncated = true; return false; diff --git a/ydb/library/yql/sql/v1/select.cpp b/ydb/library/yql/sql/v1/select.cpp index 9545bb7c17..5ddedbac22 100644 --- a/ydb/library/yql/sql/v1/select.cpp +++ b/ydb/library/yql/sql/v1/select.cpp @@ -287,7 +287,7 @@ public: return ISource::DoInit(ctx, src); } - TNodePtr Build(TContext& ctx) final { + TNodePtr Build(TContext& /*ctx*/) final { auto nodeAst = AstNode(Node); if (WrapToList) { nodeAst = Y("ToList", nodeAst); |