summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPavel Velikhov <[email protected]>2024-08-19 16:28:21 +0300
committerGitHub <[email protected]>2024-08-19 13:28:21 +0000
commit4b5d232d21769a6dc74f8edf4b343fe2c41c1b24 (patch)
treeb91521375918a7f23878d2263d340cc0b13d0320
parentdff29e8a84dc5a66b6975a0d5b2b58021878bf8d (diff)
Fixed a subtle bug in removing aliases (#8003)
-rw-r--r--ydb/library/yql/dq/opt/dq_opt_join_hypergraph.h4
-rw-r--r--ydb/library/yql/dq/opt/dq_opt_stat.cpp2
-rw-r--r--ydb/library/yql/providers/dq/planner/execution_planner.cpp2
3 files changed, 4 insertions, 4 deletions
diff --git a/ydb/library/yql/dq/opt/dq_opt_join_hypergraph.h b/ydb/library/yql/dq/opt/dq_opt_join_hypergraph.h
index 2b2861461b1..e75f9edd9e5 100644
--- a/ydb/library/yql/dq/opt/dq_opt_join_hypergraph.h
+++ b/ydb/library/yql/dq/opt/dq_opt_join_hypergraph.h
@@ -67,11 +67,11 @@ public:
auto leftKey = left.AttributeName;
auto rightKey = right.AttributeName;
- if (auto idx = leftKey.find_last_of('.') != TString::npos) {
+ if (auto idx = leftKey.find_last_of('.'); idx != TString::npos) {
leftKey = leftKey.substr(idx+1);
}
- if (auto idx = rightKey.find_last_of('.') != TString::npos) {
+ if (auto idx = rightKey.find_last_of('.'); idx != TString::npos) {
rightKey = rightKey.substr(idx+1);
}
diff --git a/ydb/library/yql/dq/opt/dq_opt_stat.cpp b/ydb/library/yql/dq/opt/dq_opt_stat.cpp
index b4fb45f8e66..6fbce2cbe90 100644
--- a/ydb/library/yql/dq/opt/dq_opt_stat.cpp
+++ b/ydb/library/yql/dq/opt/dq_opt_stat.cpp
@@ -24,7 +24,7 @@ namespace {
TString RemoveAliases(TString attributeName) {
- if (auto idx = attributeName.find_last_of('.') != TString::npos) {
+ if (auto idx = attributeName.find_last_of('.'); idx != TString::npos) {
return attributeName.substr(idx+1);
}
return attributeName;
diff --git a/ydb/library/yql/providers/dq/planner/execution_planner.cpp b/ydb/library/yql/providers/dq/planner/execution_planner.cpp
index fb7b4e7094f..793ab143295 100644
--- a/ydb/library/yql/providers/dq/planner/execution_planner.cpp
+++ b/ydb/library/yql/providers/dq/planner/execution_planner.cpp
@@ -42,7 +42,7 @@ using namespace Yql::DqsProto;
namespace {
TString RemoveAliases(TString attributeName) {
- if (auto idx = attributeName.find_last_of('.') != TString::npos) {
+ if (auto idx = attributeName.find_last_of('.'); idx != TString::npos) {
return attributeName.substr(idx+1);
}
return attributeName;