diff options
| author | aneporada <aneporada@ydb.tech> | 2023-11-15 13:00:41 +0300 |
|---|---|---|
| committer | aneporada <aneporada@ydb.tech> | 2023-11-15 13:30:20 +0300 |
| commit | 4a094130b0e5a17d21c5d2b7ce77ff62cdfe217d (patch) | |
| tree | 8d625b887941f724ddfa56c6edfbf4455202babf | |
| parent | b2b16a876692fc6cd9acf4cd69ae27ac7e3e78f5 (diff) | |
| download | ydb-4a094130b0e5a17d21c5d2b7ce77ff62cdfe217d.tar.gz | |
Decrease default block size from 1MB to 240KB to improve block channel performance
240KB allocations works better with tcmalloc's 256KB page size
| -rw-r--r-- | ydb/library/yql/minikql/comp_nodes/ut/mkql_blocks_ut.cpp | 2 | ||||
| -rw-r--r-- | ydb/library/yql/minikql/mkql_type_builder.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/ydb/library/yql/minikql/comp_nodes/ut/mkql_blocks_ut.cpp b/ydb/library/yql/minikql/comp_nodes/ut/mkql_blocks_ut.cpp index 1b206c5a28..ca4bb2e546 100644 --- a/ydb/library/yql/minikql/comp_nodes/ut/mkql_blocks_ut.cpp +++ b/ydb/library/yql/minikql/comp_nodes/ut/mkql_blocks_ut.cpp @@ -746,7 +746,7 @@ Y_UNIT_TEST(Udf) { UNIT_ASSERT_VALUES_EQUAL(topology->Items[0].Inputs, expectedInputs1); arrow::compute::ExecContext execContext; - const size_t blockSize = 100000; + const size_t blockSize = 10000; std::vector<arrow::Datum> datums(topology->InputArgsCount + topology->Items.size()); { arrow::Int32Builder builder1(execContext.memory_pool()); diff --git a/ydb/library/yql/minikql/mkql_type_builder.h b/ydb/library/yql/minikql/mkql_type_builder.h index 175507632e..503d96cee8 100644 --- a/ydb/library/yql/minikql/mkql_type_builder.h +++ b/ydb/library/yql/minikql/mkql_type_builder.h @@ -19,7 +19,7 @@ public: NUdf::IBlockItemHasher::TPtr MakeHasher(NUdf::TType* type) const final; }; -constexpr size_t MaxBlockSizeInBytes = 1_MB; +constexpr size_t MaxBlockSizeInBytes = 240_KB; static_assert(MaxBlockSizeInBytes < (size_t)std::numeric_limits<i32>::max()); // maximum size of block item in bytes |