Add exception on duplicate keys during protobuf map serialization/deserialization

commit_hash:73552810ad9072ebfd5a1d2c67f58aadd78d0cca

1 files changed, 11 insertions, 2 deletions

diff --git a/yt/yt/core/misc/protobuf_helpers-inl.h b/yt/yt/core/misc/protobuf_helpers-inl.h
index 1d3ce8afd5d..dc73588308f 100644
--- a/yt/yt/core/misc/protobuf_helpers-inl.h
+++ b/yt/yt/core/misc/protobuf_helpers-inl.h
@@ -486,7 +486,12 @@ void ToProto(
 {
     serializedMap->clear();
     for (const auto& [key, value] : originalMap) {
-        serializedMap->insert(std::pair(ToProto<TSerializedKey>(key), ToProto<TSerializedValue>(value)));
+        auto [_, inserted] = serializedMap->insert(std::pair(ToProto<TSerializedKey>(key), ToProto<TSerializedValue>(value)));
+        if (!inserted) {
+            THROW_ERROR_EXCEPTION("Found duplicate key during protobuf map serialization")
+                << TErrorAttribute("key", key)
+                << TErrorAttribute("serialized_key", ToProto<TSerializedKey>(key));
+        }
     }
 }
 
@@ -533,7 +538,11 @@ void FromProto(
 {
     originalMap->clear();
     for (const auto& [serializedKey, serializedValue] : serializedMap) {
-        EmplaceOrCrash(*originalMap, FromProto<TKey>(serializedKey), FromProto<TValue>(serializedValue));
+        auto [_, inserted] = originalMap->emplace(FromProto<TKey>(serializedKey), FromProto<TValue>(serializedValue));
+        if (!inserted) {
+            THROW_ERROR_EXCEPTION("Found duplicate key during protobuf map deserialization")
+                << TErrorAttribute("key", FromProto<TKey>(serializedKey));
+        }
     }
 }