diff options
| author | zverevgeny <zverevgeny@ydb.tech> | 2024-01-22 20:02:37 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-22 20:02:37 +0300 |
| commit | 34c493d4f797f3a6c0a04d5c8a1e82b936a20a16 (patch) | |
| tree | e12edf4ff104c261b8f352e8ae192c5cf46f721a | |
| parent | 2a760a1cd41e5554516c503dccb1070e88ce0a8f (diff) | |
| download | ydb-34c493d4f797f3a6c0a04d5c8a1e82b936a20a16.tar.gz | |
YQL-17542 remove function with confusing name CreateKqpTaskRunner (#1183)
| -rw-r--r-- | ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp | 2 | ||||
| -rw-r--r-- | ydb/core/kqp/executer_actor/kqp_literal_executer.cpp | 2 | ||||
| -rw-r--r-- | ydb/core/kqp/runtime/kqp_tasks_runner.cpp | 8 | ||||
| -rw-r--r-- | ydb/core/kqp/runtime/kqp_tasks_runner.h | 3 |
4 files changed, 3 insertions, 12 deletions
diff --git a/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp b/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp index 709d19bd55b..c60a029b7dc 100644 --- a/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp +++ b/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp @@ -219,7 +219,7 @@ void TKqpScanComputeActor::DoBootstrap() { }; } - auto taskRunner = CreateKqpTaskRunner(execCtx, settings, logger); + auto taskRunner = MakeDqTaskRunner(execCtx, settings, logger); TBase::SetTaskRunner(taskRunner); auto wakeup = [this] { ContinueExecute(); }; diff --git a/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp b/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp index 2bab488f0d9..5156ed69e9d 100644 --- a/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp +++ b/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp @@ -218,7 +218,7 @@ public: << message); }; - auto taskRunner = CreateKqpTaskRunner(context, settings, log); + auto taskRunner = MakeDqTaskRunner(context, settings, log); TaskRunners.emplace_back(taskRunner); auto taskSettings = NDq::TDqTaskSettings(&protoTask); diff --git a/ydb/core/kqp/runtime/kqp_tasks_runner.cpp b/ydb/core/kqp/runtime/kqp_tasks_runner.cpp index a7f6a7edbab..ce0f9fc211a 100644 --- a/ydb/core/kqp/runtime/kqp_tasks_runner.cpp +++ b/ydb/core/kqp/runtime/kqp_tasks_runner.cpp @@ -68,12 +68,6 @@ IDqOutputConsumer::TPtr KqpBuildOutputConsumer(const NDqProto::TTaskOutput& outp } } -TIntrusivePtr<IDqTaskRunner> CreateKqpTaskRunner(const TDqTaskRunnerContext& execCtx, - const TDqTaskRunnerSettings& settings, const TLogFunc& logFunc) -{ - return MakeDqTaskRunner(execCtx, settings, logFunc); -} - TKqpTasksRunner::TKqpTasksRunner(google::protobuf::RepeatedPtrField<NDqProto::TDqTask>&& tasks, const TDqTaskRunnerContext& execCtx, const TDqTaskRunnerSettings& settings, const TLogFunc& logFunc) @@ -92,7 +86,7 @@ TKqpTasksRunner::TKqpTasksRunner(google::protobuf::RepeatedPtrField<NDqProto::TD try { for (auto&& task : tasks) { ui64 taskId = task.GetId(); - auto runner = CreateKqpTaskRunner(execCtx, settings, logFunc); + auto runner = MakeDqTaskRunner(execCtx, settings, logFunc); if (auto* stats = runner->GetStats()) { Stats.emplace(taskId, stats); } diff --git a/ydb/core/kqp/runtime/kqp_tasks_runner.h b/ydb/core/kqp/runtime/kqp_tasks_runner.h index d9be8de4807..9835aeb4b23 100644 --- a/ydb/core/kqp/runtime/kqp_tasks_runner.h +++ b/ydb/core/kqp/runtime/kqp_tasks_runner.h @@ -12,9 +12,6 @@ NYql::NDq::IDqOutputConsumer::TPtr KqpBuildOutputConsumer(const NYql::NDqProto:: const NKikimr::NMiniKQL::THolderFactory& holderFactory, TVector<NYql::NDq::IDqOutput::TPtr>&& outputs); -TIntrusivePtr<NYql::NDq::IDqTaskRunner> CreateKqpTaskRunner(const NYql::NDq::TDqTaskRunnerContext& execCtx, - const NYql::NDq::TDqTaskRunnerSettings& settings, const NYql::NDq::TLogFunc& logFunc); - class TKqpTasksRunner : public TSimpleRefCount<TKqpTasksRunner>, private TNonCopyable { public: |